[Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue May 10 09:44:33 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669

Marc Véron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51353|0                           |1
        is obsolete|                            |

--- Comment #26 from Marc Véron <veron at veron.ch> ---
Created attachment 51374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51374&action=edit
Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron
toolbar

This patch moves all the code into an include which can be accessed from the
'Add a new message' link or the patron toolbar.

EDIT: Ensuring modal opens on all pages
EDIT2: Once the form has been submitted the page will redirect to where you
submitted the form from.
EDIT3: Fixing indentation of member-add-message.inc
       Ensuring messages save on every page
       Fill branch
       Ensure predefined notes appear
       Form redirects to where it was submitted from, or just the circulation
page.
EDIT4: Removing the new include file and moving it all into the modal in the
toolbar
EDIT5: Removing swp file and unnecessary code duplication by utilising plugins
EDIT6: Batch checkout fixes
EDIT7: Ensure you do not get JS error from Comment 24 (Batch checkout syspref
must be turned on)

To test:
1) Go to a patron circ page (circ/circulation.pl?borrowernumber=X)
2) Click 'Add a new message' under Messages
3) Confirm this brings up the modal to add a message. Confirm clicking Save
saves your message. If it is an OPAC message (for the user), confirm it shows
as expected on the OPAC.
4) Click Cancel. Confirm this closes the modal.
5) Click 'Add message' button in toolbar. Complete steps 3 and 4.
6) Confirm the modal opens from all other pages with the members toolbar.
Confirm predefined notes shows.
        circ/circulation.pl
        members/moremember.pl
        members/routing-lists.pl
        members/statistics.pl
        members/boraccount.pl
        members/pay.pl
        members/maninvoice.pl
        members/mancredit.pl
        members/readingrec.pl
        members/notices.pl
        members/member-flags.pl
        members/member-password.pl
        members/paycollect.pl
        members/files.pl
        turn on BatchCheckouts syspref and put in appropriate patron category
        circ/circulation.pl?borrowernumber=X&batch=1
7) Confirm that the page redirects to where you submitted the form from once
you have submitted it.
8) Go to Check Out tab and confirm your message saved (or OPAC, wherever you
saved it)

Sponsored-by: Catalyst IT

Followed test plan, works as expected. (Re-tested for comment #24)
Signed-off-by: Marc Véron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list