[Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue May 10 11:38:00 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #15 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jonathan Druart from comment #14)
> Created attachment 51335 [details] [review]
> Bug 16088: Use Koha::Cache to cache the language

This new version looks a bit half-baked: you define new subroutine
set_in_L1_cache_only(), but it's not used anywhere, instead you are using
set_in_cache() / get_from_cache() so language code gets propagated to L2, if L2
== memcached this will have some "interesting" side effects.

Under plack, there still will be one unnecessary L1 flush - that's way better
than hundreds of unnecessary flushes, but that one extra flush is probably
avoidable as well.

IMO it would be better to have separate L1 memory-only cache for goals like
that (implemented in different package, or separate hash + a set of subroutines
to deal with it in Koha::Cache). Storing things that we don't want to propagate
to L2 in the same hash (%L1_cache) will make further improvements (both Bug
16140 and Bug 16166 for example) much more complicated. I suggested to
implement such a cache in a new package because having subroutines like
get_from_separate_L1_memory_only_cache() in Koha::Cache may look kind of silly
;).

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list