[Koha-bugs] [Bug 16431] Marc subfield structure should be cached using Koha::Cache

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue May 10 16:12:44 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51139|0                           |1
        is obsolete|                            |

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 51380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51380&action=edit
Bug 16431: Use Koha::Cache to cache marc subfield structure

The marc subfield structure is currently cached using a global variable
of C4::Context. The infos are retrieved every time a new context is
created.
This patch suggests to use Koha::Cache instead.

To achieve this goal, a new subroutine is created
C4::Biblio::GetMarcSubfieldStructure, it will be called from code which
needs to get the marc subfield structure. GetMarcFromKohaField,
GetMarcSubfieldStructureFromKohaField, TransformKohaToMarc and
_get_inverted_marc_field_map are modified accordingly and the cache is cleared
when the table is updated (from the 3 pl scripts modified by this patch).

The caching done in C4::Context (marcfromkohafield) is removed.

Test plan:
Play with the marc subfield structure (in the administration module),
then add and edit records and make sure everything went fine.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Everything works as expected on my functional tests. I'm really happy to see
the
patch introduces relevant tests for previously untested functions.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list