[Koha-bugs] [Bug 16489] ES code incorrectly refers to Moose
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue May 10 17:39:45 CEST 2016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489
Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #51381|0 |1
is obsolete| |
--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 51388
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51388&action=edit
Bug 16489: ES code incorrectly refers to Moose
Probably a leftover from the original SolR code, there are unused references to
Moose in the new Elasticsearch code.
To test:
- Run:
$ git grep Moose
=> FAIL: There are unneeded references to Moose:
Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role;
Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role;
- Apply the patch
- Run:
$ git grep Moose
=> SUCCESS: No references to Moose
- Run:
$ prove t/Search* t/db_dependent/Search*
=> SUCCESS: Tests pass
- Sign off
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list