[Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed May 11 11:46:28 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088

--- Comment #18 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
That part of the code

  if ( $cgi and not $cgi->param('language') ) {
      my $cached = $memory_cache->get_from_cache($cache_key);

still doesn't look quite right IMO; getlanguage() is almost never called with
$cgi parameter, and the cached value will be hardly ever used.

Shoudn't it be something like that instead:

  unless ($cgi && $cgi->param('language')) {

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list