[Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed May 11 14:12:14 CEST 2016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088
--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jacek Ablewicz from comment #22)
> Looks good, tests good and works really good - now there is only one
> CGI->new() call! Aparently get_template_and_user(), which usually triggers
> the 1st getlanguage() call is doing it properly with $cgi parameter included.
>
> Not sure if cache clean in setlanguagecookie() is strictly necessary, but
> it's not harming performance in any way, and this sub is used also in
> installer, better to be on the safe side.
What I thought too, I did not manage to know if it was useful but preferred to
keep it.
> Koha::Cache::set_in_L1_cache_only() may need some kind of unit test, if it's
> intended to stay there.
Erk, of course it is not intended, I have amended the patch using
git reset HEAD~1 Koha/Cache.pm
git checkout Koha/Cache.pm
git commit --amend
Nothing more
> In t/Cache.t
>
> skip "Cache not enabled", 33
> unless ( $cache->is_cache_active() && defined $cache );
>
> number of tests to skip is out of sync, but it was out of sync before this
> patch as well.
I will submit a patch for that
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list