[Koha-bugs] [Bug 16518] opac-addbybiblionumber is not plack safe

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16518

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51483|0                           |1
        is obsolete|                            |

--- Comment #2 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51513&action=edit
[SIGNED-OFF] Bug 16518: Fix Plack variable scoping problem in
opac-addbybiblionumber.pl

The script opac/opac-addbybiblionumber.pl is not plack safe because the
variable @biblios is declared with our and is not assigned to an empty
array (so not reset).

The issue:
When trying to add items to a list (virtualshelf), the biblionumbers are
added to the @biblios variable and the list is not reset between each
run.

Test plan:
Check from records from the result list and add them
to a list.
Cancel or save and re-add them (or others) to a list (same or
different).
=> Without this patch, the list of records will never stop growing, the
previous items added are still listed when adding new ones.
=> With this patch, the behavior is the one expected.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.