[Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This works fine, but the markup needs to be restructured:

<a href="[% IF ( budget_period_id)
%]/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=[% budget_period_id %][%
ELSE %]/cgi-bin/koha/admin/aqbudgetperiods.pl[% END %]"
class="cancel">Cancel</a>

I thought that this would have triggered a warning by the QA tools because of
coding guideline 'HTML1:'

https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML

It's more verbose, but you have to do it this way:

[% IF ( budget_period_id) %]
    <a href="/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=[%
budget_period_id %]" class="cancel">Cancel</a>
[% ELSE %]
    <a href="/cgi-bin/koha/admin/aqbudgetperiods.pl" class="cancel">Cancel</a>
[% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.