[Koha-bugs] [Bug 16441] C4::Letters::getletter is not plack safe

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51218|0                           |1
        is obsolete|                            |

--- Comment #2 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 51703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51703&action=edit
[SIGNED-OFF] Bug 16441: Do not use a package variable to cache
C4::Letters::getletter

C4::Letters::getletter use a package variable (%letter) to cache letter
returned by the subroutine.
I have not found any direct issues caused by that but it is safer to
remove it.
It won't be a big deal to hit the DBMS to get a valid letter when
needed.

No test plan here, just confirm that the changes make sense.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.