[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon May 23 06:21:44 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #17 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #11)
> [1] Although your changes in SimpleSearch are very small, it would probably
> help if you would add a test case in t/db_dependent/Search.t. (It seems to
> fail some tests currently, separate from your patch.)

I've reviewed Matcher.pm and Search.pm, an I don't think it would be possible
to add a test case. The functions aren't atomic enough. The altered behaviour
is internal to the functions and thus I don't see any way to automatically test
it.

Changing status back to Signed Off. 

Happy to discuss further or implement changes where necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list