[Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon May 23 08:53:34 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Srdjan Jankovic from comment #3)
> There's something odd with that t/db_dependent/Plugins.t. 
...
> and I'm getting
> not ok 18 - Koha::Plugins::GetPlugins functions correctly
> #   Failed test 'Koha::Plugins::GetPlugins functions correctly'
> #   at t/db_dependent/Plugins.t line 46.
> #          got: 'Example Kitchen-Sink Plugin'
> #     expected: 'Test Plugin'

Srdjan,
I made the same change and it seems to work with me.
But actually this test is based on the assumption that GetPlugins always finds
the Test Plugin first. Which could very well not be the case.
Since there can be a lot of plugins present, the test should only verify if the
Test Plugin is in the array.
Also note that the array is not sorted by the routine, so this should have been
taken in account too.
Adding a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list