[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to David Cook from comment #16)
> When I run "prove t/db_dependent/Search.t", it says that all tests are
> successful, although there are lots of warnings generated.
Between April 15 and May 23 some things may have changed :)

> > [2] The source_normalizer or norms just lead me to two FIXMEs:
> > # FIXME normalize, substr
> > # FIXME - default normalizer
> These FIXME messages pre-date my patch. 
True. But that is obviously not my point. Although Matcher.pm has some code
around norms and normalizer, actually it is just uncompleted functionality. The
code just calls a simple _normalized routine. The "references to normalization
subroutines (under C4::Normalize) to be applied to the source string" are not
used and do not exist.

> I'm open to removing _normalize() from the matching completely. Honestly, I
> figured that the community would be against it, so I created a way of opting
> out of the default _normalize(). That way default system behaviour doesn't
> change, while some people will know how to deactivate it.
I am not suggesting to remove it.
As noted above, I would be hesitant to make certain changes in uncompleted
functionality. 

> > [3] I have some doubts about this new condition:
> >     if ($QParser && $matchpoint->{'index'} !~ m/\w,\w/) {
> > Somehow you managed to bump in another unfinished area here too :) 
> > I would rather leave the condition as it was. In the QParser branch you
> > could choose to ignore/remove the second specifier word with a similar regex.
> It's not really a new condition. If you look at C4::Search::SimpleSearch,
> you'll see that it's already there:
Good point. Leave it there.

> Can the QA team indicate how to proceed? 
Could you (slightly) adjust the way to skip the normalize call for the URLs,
that does not suggest that the norms functionality is present while we do not
even have C4::Normalizer?
Maybe Jonathan wants to jump in too and add comments?

-- 
You are receiving this mail because:
You are watching all bug changes.