[Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with Plack

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed May 25 10:53:00 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #18 from Jesse Weaver <jweaver at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #15)
> I have to admit I am a bit lost with all the apache config files, but should
> not we move the RequestHeader add X-Koha-SetEnv lines to
> apache-shared-[intranet|opac]-plack.conf files?

I'm inclined to agree; at first I was thinking to have an example of the new
syntax in the configuration files, but given that this should be wrapped in an
<IfModule>, it should be moved there.

(In reply to Jonathan Druart from comment #16)
> In C4::Context->preference, the lc $var has been moved after the
> OVERRIDE_SYSPREF_* check, I don't think it's expected.

This is in tune with the documentation and how this feature has been
historically used; see
http://manual.koha-community.org/3.22/en/administration.html#globalsysprefs .

(In reply to Jonathan Druart from comment #17)
> 108     # We also add the MEMCACHED_ settings to the actual environment, to
> make sure any early
> 109     # initialization of Koha::Cache correctly sets up a memcached
> connection.
> 110     foreach my $special_var ( qw( MEMCACHED_SERVERS MEMCACHED_NAMESPACE
> ) ) {
> 111         $ENV{$special_var} = $setenvs{$special_var} if defined
> $setenvs{$special_var};
> 112     }
> 
> Jesse, could you explain in which cases this is useful?

C4::Auth, in my testing, loads up some system preferences early on that cause
Koha::Cache to be initialized before the Plack environment is copied to %ENV
(presumably by the Plack CGI wrapper?).

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list