[Koha-bugs] [Bug 15541] Prevent normalization during matching/import process

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon May 30 01:37:34 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

--- Comment #19 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #18)
> Could you (slightly) adjust the way to skip the normalize call for the URLs,
> that does not suggest that the norms functionality is present while we do
> not even have C4::Normalizer?

I'm not sure that I understand your question...

Regardless of whether or not you provide a value for "Normalization rule" on
/cgi-bin/koha/admin/matching-rules.pl, the default _normalize() function will
run.

While the matchpoint_component_norms.norm_routine isn't currently used in the
code, I add some code that does use it for the sole purpose of detecting a
"none" or "raw" normalization (ie no normalization).

Are you saying that you don't want me to add that code because it suggests to
people that adding a value there (besides "none" or "raw") will have an effect?

I could a checkbox on the UI that says "Skip normalization rule" or something
like that, but it would fulfil the same purpose of adding a "none" norm_routine
in the database.

Sorry, but I'm still not sure what you're asking, Marcel. Honestly, there
should probably be no normalization at this step. I would remove the
"Normalization rule" from the code, but it affects too many existing systems.
The patch I have here is the lightest change while also providing the desired
functionality. I'm not sure what else a person could do to skip the
normalization in a way that is backwards compatible.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list