[Koha-bugs] [Bug 15630] Make Edifact module pluggable

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630

--- Comment #13 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 49788
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49788
Bug 15630 - Make Edifact module pluggable

Review of attachment 49788:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15630&attachment=49788)
-----------------------------------------------------------------

::: Koha/Plugins.pm
@@ +20,4 @@
>  use Modern::Perl;
>  
>  use Module::Load::Conditional qw(can_load);
> +use Module::Pluggable search_path => ['Koha::Plugin'], except => qr/::Edifact(|::Line|::Message|::Order|::Segment|::Transport)$/;

This seems suboptimal... since any plugin with additional packages would need
an exception.

Wouldn't it make more sense to use "only" to only find plugins like
^Koha::Plugin::Com::CompanyName::PluginName$.

I suppose it might be too late for that now as there's any number of plugins
that can be allowed so perhaps one does have to only use exceptions from now
on... 

I'm thinking of making a plugin, but I'll probably just use a different
namespace like Local::PluginName::Submodules...

-- 
You are receiving this mail because:
You are watching all bug changes.