From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 07:07:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 06:07:24 +0000
Subject: [Koha-bugs] [Bug 17521] Step 3 of patron modification editor not
checking age limits
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17521
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |josef.moravec at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 08:55:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 07:55:30 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 08:55:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 07:55:33 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
--- Comment #34 from Josef Moravec ---
Created attachment 57012
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57012&action=edit
Bug 8612: QA followup - Make export button split button, unify button labels
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 08:55:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 07:55:51 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
--- Comment #35 from Josef Moravec ---
Created attachment 57013
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57013&action=edit
Bug 8612: Add tests for GetBasketAsCSV
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 09:01:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 08:01:53 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
--- Comment #36 from Josef Moravec ---
(In reply to Katrin Fischer from comment #33)
> Did a quick code review:
>
> 1) Could we make this a split button maybe (like the one in cataloguing for
> z39.50 import)? (no blocker)
Good point, I've done it
>
> 2) The button itself is labelled differently on a closed basket and an open
> basket. Should be the same label for both. I'd suggest something in the
> middle between both versions "Export as CSV"?
Fixed
>
> 2) Please provide tests for changes to GetBasketAsCSV.
Test added
As have little experiences with writing test, feel free to point me to the
right direction if it's not written as it should be. Thanks
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 10:05:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 09:05:38 +0000
Subject: [Koha-bugs] [Bug 17366] create patron list, software error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17366
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |INVALID
--- Comment #3 from Jonathan Druart ---
Closing, please reopen if it persists.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 10:53:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 09:53:21 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
of birth from checkout and patron quick searches
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874
--- Comment #48 from Jonathan Druart ---
(In reply to Tom?s Cohen Arazi from comment #47)
> Created attachment 57009 [details] [review]
> Bug 14874: (followup) Fix typo introduced in sysprefs.sql
>
> Signed-off-by: Tomas Cohen Arazi
I have just added a check to the QA script:
commit b8479e5189f992c62a828fd88e1a7cc2e1206835
Lines should not terminate by semicolons in sysprefs.sql
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 11:00:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 10:00:24 +0000
Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Status|Signed Off |Failed QA
--- Comment #9 from Jonathan Druart ---
I think this patch must be rewritten following what has been done in bug 17428
for Cities.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 11:25:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 10:25:21 +0000
Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497
--- Comment #10 from Benjamin Rokseth ---
Yup.
Perhaps even CRUD? or is that overkill?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 11:26:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 10:26:12 +0000
Subject: [Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC
framework don' t work correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527
--- Comment #1 from Jonathan Druart ---
Created attachment 57014
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57014&action=edit
Bug 17527: Hide hidden fields for XSLT blocks
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 11:27:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 10:27:40 +0000
Subject: [Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC
framework don' t work correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c
| |ommunity.org
Version|3.22 |unspecified
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org,
| |tomascohen at gmail.com
Status|NEW |In Discussion
Depends on| |11592
--- Comment #2 from Jonathan Druart ---
Here is a patch for discussion.
Tomas, could you confirm this is the way to go? Why don't we have a lower level
subroutine/method to retrieve a filtered record?
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
[Bug 11592] opac detail scripts do not respect MARC tag visibility
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 11:27:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 10:27:40 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
visibility
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |17527
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527
[Bug 17527] 245 $h Medium - hidden settings in MARC framework don't work
correctly
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 11:28:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 10:28:08 +0000
Subject: [Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC
framework don' t work correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527
--- Comment #3 from Jonathan Druart ---
(In reply to Elaine Bradtke from comment #0)
> This applies to 3.22 and 16.05? (MARC 21)
Do you mean it worked before 3.22?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 11:46:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 10:46:16 +0000
Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497
--- Comment #11 from Jonathan Druart ---
(In reply to Benjamin Rokseth from comment #10)
> Yup.
>
> Perhaps even CRUD? or is that overkill?
That seems overkill to me, but not so hard to implement.
It may make sense to be consistent and supply CRUD for such object.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 11:49:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 10:49:05 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch patron during
circulation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|new feature |enhancement
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 11:50:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 10:50:28 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch patron during
circulation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55953|1 |0
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 11:52:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 10:52:21 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch patron during
circulation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55953|0 |1
is obsolete| |
--- Comment #13 from Jonathan Druart ---
Created attachment 57015
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57015&action=edit
Bug 15752 - Automatically switch patron during circulation
With this syspref enabled scanning a patron barcode into the item
barcode field during circulation will redirect you to the patron's
circulation page.
This allows circulation with only a barcode scanner.
Testing:
- Enable the AutoSwitchPatron syspref
- Navigate to a patron's check out screen
- Enter a patron barcode into the "Enter item barcode" field
Result
- Browser should be redirected to the entered patron
Signed-off-by: Joel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:08:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:08:25 +0000
Subject: [Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC
framework don' t work correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527
Irma Birchall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |irma at calyx.net.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:15:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:15:42 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch patron during
circulation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752
--- Comment #14 from Jonathan Druart ---
Should not we add a message box if the switch happened?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:18:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:18:52 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch patron during
circulation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #15 from Jonathan Druart ---
>From the Koha log file:
circulation.pl: CGI::param called in list context from package main line 83,
this can lead to vulnerabilities. See the warning in "Fetching the value or
values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.,
referer: http://pro.kohadev.vm/cgi-bin/koha/circ/circulation-home.pl
circulation.pl: Odd number of elements in anonymous hash at
/home/vagrant/kohaclone/circ/circulation.pl line 83., referer:
http://pro.kohadev.vm/cgi-bin/koha/circ/circulation-home.pl
The search should only be done if the barcode field has been filled.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:21:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:21:26 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56729|0 |1
is obsolete| |
--- Comment #37 from Josef Moravec ---
Created attachment 57016
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57016&action=edit
Bug 16239: Update Bootstrap to 3.3.7
Customization tool used.
Javascript modules:
alert
button
dropdown
modal
tooltip
popover
tab
affix
collapse
transition
CSS modules:
type
code
grid
tables
forms
buttons
responsive-utilities
button-groups
input-groups
navs
navbar
breadcrumbs
pagination
pager
labels
badges
thumbnails
alerts
progress-bars
media
list-group
panels
responsive-embed
close
component-animations
dropdowns
tooltip
popovers
modals
Test plan:
1) Apply the patch
2) Try to go through interface to find problems, inconsistencies, etc.
3) Read the diff
Migration guide for bootstrap: http://getbootstrap.com/migration/
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:21:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:21:35 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56730|0 |1
is obsolete| |
--- Comment #38 from Josef Moravec ---
Created attachment 57017
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57017&action=edit
Bug 16239: Update templates
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:21:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:21:43 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
--- Comment #37 from Jonathan Druart ---
Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 8612 - System preference to
have custom fields in export csv basket
Using index info to reconstruct a base tree...
M acqui/basket.pl
M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
Auto-merging acqui/basket.pl
CONFLICT (content): Merge conflict in acqui/basket.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:21:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:21:44 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56731|0 |1
is obsolete| |
--- Comment #39 from Josef Moravec ---
Created attachment 57018
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57018&action=edit
Bug 16239: Update css files
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:21:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:21:51 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56732|0 |1
is obsolete| |
--- Comment #40 from Josef Moravec ---
Created attachment 57019
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57019&action=edit
Bug 16239: Update javascript files
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:22:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:22:01 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239
--- Comment #41 from Josef Moravec ---
Created attachment 57020
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57020&action=edit
Bug 16239: Adapt new housebound module template to Bootstrap 3
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:22:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:22:08 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239
--- Comment #42 from Josef Moravec ---
Created attachment 57021
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57021&action=edit
Bug 16239: Polishing things
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:22:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:22:13 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239
--- Comment #43 from Josef Moravec ---
Created attachment 57022
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57022&action=edit
Bug 16239: Rebased on master on 2016-11-01, commit 6001765
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:28:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:28:15 +0000
Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
suggestions ( using an Ajax-request)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #18 from Jonathan Druart ---
Does it make sense to add the autofill.js to opac-bottom.js when it's only used
once (in opac-suggestions.tt)?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:30:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:30:19 +0000
Subject: [Koha-bugs] [Bug 17518] Displayed language name for Czech is wrong
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17518
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:30:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:30:23 +0000
Subject: [Koha-bugs] [Bug 17518] Displayed language name for Czech is wrong
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17518
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56971|0 |1
is obsolete| |
--- Comment #7 from Jonathan Druart ---
Created attachment 57023
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57023&action=edit
Bug 17518: Displayed language name for Czech is wrong
It's "Ce?tina" and should be "?e?tina"
Test plan:
1) apply the patch
1.1) update database
2) install Czech translation for Koha
3) note the language name in language switcher (in staff client and
opac) is right: "?e?tina"
Signed-off-by: radiuscz
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:43:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:43:43 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:43:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:43:45 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56222|0 |1
is obsolete| |
--- Comment #38 from Josef Moravec ---
Created attachment 57024
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57024&action=edit
Bug 8612 - System preference to have custom fields in export csv basket
This patch allows the user use a CSV export profile to create the fields to
export the basket as CSV in a basket page.
To test:
1) Apply the patch;
2) Create a CSV export profile - type sql - Home ? Tools ? CSV export profiles
ex:
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) Create a new basket and add an order to the basket
4) Validate: the text "Select CSV profile:" and a dropdown in the basket view
5) In the new dropdown, select the CSV export profile created
6) Validate the CSV file.
7) Do the same validation with a closed basket.
a) close the basket
b) View the basket
c) validate that there is a dropdown
d) test it with an export
Signed-off-by: Josef Moravec
Works as expected for me
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:43:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:43:52 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56223|0 |1
is obsolete| |
--- Comment #39 from Josef Moravec ---
Created attachment 57025
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57025&action=edit
Bug 8612 - Cleans basket.tt by using TT blocks
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:43:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:43:59 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56224|0 |1
is obsolete| |
--- Comment #40 from Josef Moravec ---
Created attachment 57026
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57026&action=edit
Bug 8612 - Clean basket.pl getting rid of subroutines with sql query and use
GetBasketAsCSV instead
GetBasketAsCSV now has a new argument the profile_csv_id, when this param is
defined, it loads the profile_content, searches the value of the predefined
fields and assembles the data to create the output of the csv file.
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:44:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:44:24 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56225|0 |1
is obsolete| |
--- Comment #41 from Josef Moravec ---
Created attachment 57027
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57027&action=edit
Bug 8612 - Followup - use Koha::CsvProfile[s] module (see bug 15451)
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:44:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:44:29 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #57012|0 |1
is obsolete| |
--- Comment #42 from Josef Moravec ---
Created attachment 57028
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57028&action=edit
Bug 8612: QA followup - Make export button split button, unify button labels
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:44:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:44:34 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #57013|0 |1
is obsolete| |
--- Comment #43 from Josef Moravec ---
Created attachment 57029
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57029&action=edit
Bug 8612: Add tests for GetBasketAsCSV
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 12:45:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 11:45:05 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
--- Comment #44 from Josef Moravec ---
Sorry, rebased on master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 13:47:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 12:47:50 +0000
Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |dependency
Status|Signed Off |Patch doesn't apply
--- Comment #10 from Tom?s Cohen Arazi ---
Please rebase. I'd say this one depends only on Mirko's answer about packaging
Data::Session.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 13:48:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 12:48:08 +0000
Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mirko at abunchofthings.net
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 14:36:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 13:36:49 +0000
Subject: [Koha-bugs] [Bug 17528] New: Holds to pull: check button Solved by
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17528
Bug ID: 17528
Summary: Holds to pull: check button Solved by
Change sponsored?: ---
Product: Koha
Version: 16.05
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: black23 at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Hello,
we really like "Holds to Pull" in Koha. We miss function that bring possibility
to set hold as solved. In our case it means that we need often to create
transport order and give some signt to others that case is solved. So new
column with checkbox "Solved by" name_of_staff and date, time would be nice.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 14:37:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 13:37:41 +0000
Subject: [Koha-bugs] [Bug 17528] Holds to pull: check button Solved by
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17528
Mike changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |black23 at gmail.com,
| |josef.moravec at gmail.com,
| |rbit at rbit.cz
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 14:42:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 13:42:01 +0000
Subject: [Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC
framework don' t work correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Severity|normal |enhancement
--- Comment #4 from Katrin Fischer ---
To my knowledge it never worked for the XSLT/normal views, the hidden values
only take effect on the MARC views. There is a patch from Mark that might add
this feature in 16.11:
Bug 15870 - Add Filter for MARC to respect visibility settings
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 14:42:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 13:42:37 +0000
Subject: [Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC
framework don' t work correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527
--- Comment #5 from Katrin Fischer ---
Ah sorry, 16.05!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 14:52:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 13:52:13 +0000
Subject: [Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC
framework don' t work correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527
--- Comment #6 from Katrin Fischer ---
Hm got curious about this one, that's what happens for me:
If I uncheck the visibility for 245$h for the OPAC it works for me immediately
on the OPAC detail view, but not in the result list. It's still visible there
after reindexing too.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 14:55:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 13:55:35 +0000
Subject: [Koha-bugs] [Bug 17529] New: Add a --with-records option to
populate_db.pl
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
Bug ID: 17529
Summary: Add a --with-records option to populate_db.pl
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.druart at bugs.koha-community.org
Reporter: jonathan.druart at bugs.koha-community.org
QA Contact: testopia at bugs.koha-community.org
Depends on: 10337
This option will insert data into biblio, biblioitems, items and auth_header
tables \o/
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337
[Bug 10337] Add a script to insert all sample data automatically
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 14:55:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 13:55:35 +0000
Subject: [Koha-bugs] [Bug 10337] Add a script to insert all sample data
automatically
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |17529
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
[Bug 17529] Add a --with-records option to populate_db.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 14:58:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 13:58:07 +0000
Subject: [Koha-bugs] [Bug 17529] Add a --with-records option to
populate_db.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:00:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:00:51 +0000
Subject: [Koha-bugs] [Bug 17530] New: Don't show 'article request' link when
no article requests are permitted
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530
Bug ID: 17530
Summary: Don't show 'article request' link when no article
requests are permitted
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
Don't show the article request link on records where there is no article
request possible.
At the moment the article request link shows on all records, no matter if the
circulation conditions allow for an article request or not.
We should not show the link when an article request is in general not possible.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:01:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:01:22 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in
Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |17530
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530
[Bug 17530] Don't show 'article request' link when no article requests are
permitted
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:01:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:01:22 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
article requests are permitted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |14610
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610
[Bug 14610] Add ability to place article requests in Koha
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:09:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:09:26 +0000
Subject: [Koha-bugs] [Bug 17531] New: Search categories for itemtypes broken
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17531
Bug ID: 17531
Summary: Search categories for itemtypes broken
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
The feature introduced with bug 10937 appears to be broken on current master.
You can add a search category and the display on the advanced search page is
correct, but the search won't return any results.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:12:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:12:04 +0000
Subject: [Koha-bugs] [Bug 17528] Holds to pull: check button Solved by
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17528
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #1 from Katrin Fischer ---
Once the hold is waiting or in transport it should no longer show on the list -
can you explain what happens for you with a test plan a bit more?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:15:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:15:08 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals
after defined loan period
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Add a circ rule to limit |Add a circ rule to not
|the auto renewals given a |allow auto-renewals after
|delay |defined loan period
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:16:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:16:15 +0000
Subject: [Koha-bugs] [Bug 17528] Holds to pull: check button Solved by
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17528
--- Comment #2 from Owen Leonard ---
(In reply to Katrin Fischer from comment #1)
> Once the hold is waiting or in transport it should no longer show on the
> list
Does this bug refer instead to the holds queue report (circ/view_holdsqueue.pl)
? Since that one is generated periodically I can see how marking something as
"solved" would be useful.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:18:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:18:05 +0000
Subject: [Koha-bugs] [Bug 17529] Add a --with-records option to
populate_db.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
--- Comment #1 from Jonathan Druart ---
Created attachment 57030
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57030&action=edit
Bug 17529: Add a --with-records option to populate_db.pl
It's so frustrating to have to insert data manually to test with a fresh
install. This patch adds the data from the marc21 sandbox and let
populate_db.pl inserts them
Test plan:
DROP DATABASE koha_kohadev;
perl misc/devel/populate_db.pl --with-records -v
Enjoy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:28:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:28:34 +0000
Subject: [Koha-bugs] [Bug 17517] "your summary" page in OPAC is broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17517
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|ASSIGNED |RESOLVED
--- Comment #2 from Katrin Fischer ---
*** This bug has been marked as a duplicate of bug 17522 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:28:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:28:34 +0000
Subject: [Koha-bugs] [Bug 17522] opac-user.pl gives error of
OpacRenewalAllowed is enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17522
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #2 from Katrin Fischer ---
*** Bug 17517 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:28:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:28:35 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals
after defined loan period
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
Bug 15581 depends on bug 17517, which changed state.
Bug 17517 Summary: "your summary" page in OPAC is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17517
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |DUPLICATE
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:30:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:30:25 +0000
Subject: [Koha-bugs] [Bug 17522] opac-user.pl gives error of
OpacRenewalAllowed is enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17522
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #3 from Katrin Fischer ---
I think the patch is not correct:
[% IF ( canrenew && !userdebarred && OpacRenewalAllowed && !(
borrower.is_expired && Koha.Preference('BlockExpiredPatronOpacActions') ) ) %]
will only check the preference, but this works differently. The preference is
only the default, that can be overwritten by patron category.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:30:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:30:39 +0000
Subject: [Koha-bugs] [Bug 17522] opac-user.pl gives error of
OpacRenewalAllowed is enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17522
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|critical |blocker
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:33:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:33:48 +0000
Subject: [Koha-bugs] [Bug 17529] Add a --with-records option to
populate_db.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #57030|0 |1
is obsolete| |
--- Comment #2 from Jonathan Druart ---
Created attachment 57031
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57031&action=edit
Bug 17529: Add a --with-records option to populate_db.pl
It's so frustrating to have to insert data manually to test with a fresh
install. This patch adds the data from the marc21 sandbox and let
populate_db.pl inserts them
Test plan:
DROP DATABASE koha_kohadev;
perl misc/devel/populate_db.pl --with-records -v
Enjoy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:36:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:36:18 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals
after defined loan period
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
--- Comment #48 from Katrin Fischer ---
This works alright, but my concern is the message we display to the user in the
OPAC:
Automatic renewal (2 of 3 renewals remaining)
My suggestion would be to show a message about renewals being impossible and
remove the (2 of 3 renewals remaining) both in staff and the OPAC.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:49:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:49:28 +0000
Subject: [Koha-bugs] [Bug 17529] Add a --with-records option to
populate_db.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
--- Comment #3 from Josef Moravec ---
Created attachment 57032
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57032&action=edit
[SIGNED-OFF] Bug 17529: Add a --with-records option to populate_db.pl
It's so frustrating to have to insert data manually to test with a fresh
install. This patch adds the data from the marc21 sandbox and let
populate_db.pl inserts them
Test plan:
DROP DATABASE koha_kohadev;
perl misc/devel/populate_db.pl --with-records -v
Enjoy
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:49:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:49:33 +0000
Subject: [Koha-bugs] [Bug 17529] Add a --with-records option to
populate_db.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
--- Comment #4 from Josef Moravec ---
Created attachment 57033
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57033&action=edit
[SIGNED-OFF] Bug 17529: Follow-up - add with records to list of options in
usage
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:52:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:52:58 +0000
Subject: [Koha-bugs] [Bug 17529] Add a --with-records option to
populate_db.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |josef.moravec at gmail.com
Attachment #57032|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:53:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:53:25 +0000
Subject: [Koha-bugs] [Bug 17529] Add a --with-records option to
populate_db.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #57033|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:54:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:54:51 +0000
Subject: [Koha-bugs] [Bug 17529] Add a --with-records option to
populate_db.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
--- Comment #5 from Josef Moravec ---
I was too fast and signed off the older (now obsoleted) patch, I'll do it
again...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:56:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:56:55 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals
after defined loan period
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
--- Comment #49 from Katrin Fischer ---
Created attachment 57034
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57034&action=edit
[PASSED QA] Bug 15581: Add a circ rule to limit the auto renewals given a delay
This patch adds a new circulation rule (no_auto_renewal_after) to block/allow
auto renewals after a given delay.
For instance, if the issue date is 10 days before today, and
no_auto_renewal_after is set to 10, tomorrow the issue won't be auto
renewed.
Test plan:
0/ Execute the update DB entry
Note: You will have to manually change data in your DB, make sure you
have access to the sql cli.
1/ Define a rule with no_auto_renewal_after (10 for instance) and
norenewalbefore (5 for instance).
(This new rule will behave the same as norenewalbefore: the unit depends
on the lengthunit value).
The automatic renewals will be done from 5 to 10 days ahead.
2/ Modify the issues.issuedate, to simulate a checkout in the past:
UPDATE issues
SET issuedate = "yyyy-mm-dd hh:mm:ss"
WHERE itemnumber = YOUR_ITEMNUMBER;
with issuedate = 2 days before for instance
3/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has not been renewed (too soon)
4/ Repeat step 2 with a due date set as 11 days before
5/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has not been renewed (too late)
6/ Repeat step 2 with a due date set as 7 days before
7/ Execute the automatic renewals cronjob script
(misc/cronjobs/automatic_renewals.pl)
Confirm that the issue has been renewed (issues.renewals has been
incremented and date_due has been updated according your circ rules).
Sponsored-by: University of the Arts London
Signed-off-by: Jonathan Field
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:57:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:57:00 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals
after defined loan period
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
--- Comment #50 from Katrin Fischer ---
Created attachment 57035
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57035&action=edit
[PASSED QA] Bug 15581: Display the latest auto renew date possible when
renewing manually
If an issue marked as auto_renew is renewed manually, we want to display
the latest auto renew date possible.
Test plan:
1/ Define circ rules as in the previous patch.
2/ Check a item out, mark it as an auto renewal
3/ Back date the issuedate and make sure it will be too late to renew it
4/ Use the Circulation > renew page (circ/renew.pl) to manually renew
this issue.
You should get a warning "You barcode has been scheduled for automatic renewal
and cannot be renewed anymore since DATE."
If the pref AllowRenewalLimitOverride is set, you will be allowed to
renew it anyway.
Sponsored-by: University of the Arts London
Signed-off-by: Jonathan Field
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:57:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:57:05 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals
after defined loan period
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
--- Comment #51 from Katrin Fischer ---
Created attachment 57036
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57036&action=edit
[PASSED QA] Bug 15581: Display the generic "schedule for auto renew" message on
the checkouts table
Signed-off-by: Jonathan Field
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:57:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:57:09 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals
after defined loan period
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
--- Comment #52 from Katrin Fischer ---
Created attachment 57037
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57037&action=edit
[PASSED QA] Bug 15581: Change wording for auto too late
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:57:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:57:14 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals
after defined loan period
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
--- Comment #53 from Katrin Fischer ---
Created attachment 57038
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57038&action=edit
Bug 15581: Follow-up - suggested change to the OPAC message
Instead of showing "Automatic renewal" to the user, this
changes it to show "No longer renewable" when the
automatic renewal won't happen any longer because of the
days the item has already been checked out.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:58:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:58:02 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals
after defined loan period
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:58:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:58:05 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals
after defined loan period
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56961|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:58:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:58:09 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals
after defined loan period
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56962|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:58:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:58:15 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals
after defined loan period
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56982|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 15:58:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 14:58:12 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals
after defined loan period
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56963|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:00:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:00:00 +0000
Subject: [Koha-bugs] [Bug 15581] Add a circ rule to not allow auto-renewals
after defined loan period
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581
--- Comment #54 from Katrin Fischer ---
Last patch is a suggestion - I think it's better than to indicate that renewals
will still happen, but might need rephrasing. I was not sure how much
information to give to the patron about the reasoning, so I kept it general.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:17:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:17:46 +0000
Subject: [Koha-bugs] [Bug 17529] Add a --with-records option to
populate_db.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #57031|0 |1
is obsolete| |
--- Comment #6 from Josef Moravec ---
Created attachment 57039
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57039&action=edit
[SIGNED-OFF] Bug 17529: Add a --with-records option to populate_db.pl
It's so frustrating to have to insert data manually to test with a fresh
install. This patch adds the data from the marc21 sandbox and let
populate_db.pl inserts them
Test plan:
DROP DATABASE koha_kohadev;
perl misc/devel/populate_db.pl --with-records -v
Enjoy
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:18:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:18:30 +0000
Subject: [Koha-bugs] [Bug 17529] Add a --with-records option to
populate_db.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:18:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:18:33 +0000
Subject: [Koha-bugs] [Bug 17529] Add a --with-records option to
populate_db.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
--- Comment #7 from Josef Moravec ---
Created attachment 57040
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57040&action=edit
Bug 17529: Follow-up - add --with-records to list of options in usage
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:30:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:30:01 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
if set to ' editable in OPAC'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56924|0 |1
is obsolete| |
--- Comment #29 from Tom?s Cohen Arazi ---
Created attachment 57041
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57041&action=edit
Bug 13757: Make patron attributes editable in the OPAC (1/2)
This patch adds an opac_editable property of borrower attribute types
that can be set in the interface.
Test plan:
1. Repeat the following with a new and existing borrower attribute
type:
2. Verify that "Editable in OPAC" can only be checked if "Display in
OPAC" is checked.
3. Verify that this new property is correctly saved.
Signed-off-by: Aleisha
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:30:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:30:09 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
if set to ' editable in OPAC'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56925|0 |1
is obsolete| |
--- Comment #30 from Tom?s Cohen Arazi ---
Created attachment 57042
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57042&action=edit
Bug 13757: Make patron attributes editable in the OPAC (2/2)
This patch makes attributes marked as OPAC-editable editable from the
OPAC.
NOTE: This needs to be extended to work with the modifications system,
and thus only works for new patrons.
Test plan:
1) Create attributes that cover the spectrum of possible attribute
types; repeatable, unique, dropdown, etc.
2) Verify that all of these attributes are correctly validated and
saved.
Aleisha's update: Fixed a merge conflict and a warn "Argument "" isn't numeric
in numeric gt (>) at
/usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
line 336."
Signed-off-by: Aleisha
Sorry forgot to run updatedatabase.pl!
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:30:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:30:29 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
if set to ' editable in OPAC'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56926|0 |1
is obsolete| |
--- Comment #31 from Tom?s Cohen Arazi ---
Created attachment 57043
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57043&action=edit
Bug 13757: (followup) fix creation of patron attributes
Signed-off-by: Aleisha
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:30:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:30:37 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
if set to ' editable in OPAC'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56927|0 |1
is obsolete| |
--- Comment #32 from Tom?s Cohen Arazi ---
Created attachment 57044
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57044&action=edit
Bug 13757: (QA followup) fix QA issues, add small niceties
Remove debug warns, and hide patron attributes in the OPAC if
PatronSelfRegistrationVerifyByEmail is enabled (as this enhancement
currently does not work with Koha::Borrower::Modifications).
Also, slightly improve appearance of attributes with passwords.
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:30:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:30:45 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
if set to ' editable in OPAC'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56928|0 |1
is obsolete| |
--- Comment #33 from Tom?s Cohen Arazi ---
Created attachment 57045
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57045&action=edit
Bug 13757: (followup) Rebase against master
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:30:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:30:54 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
if set to ' editable in OPAC'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56929|0 |1
is obsolete| |
--- Comment #34 from Tom?s Cohen Arazi ---
Created attachment 57046
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57046&action=edit
Bug 13757: DBIC update
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:32:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:32:05 +0000
Subject: [Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #21 from Katrin Fischer ---
This works for me nicely, until I activate Plack.
Testing in a kohadevbox, started testing without Plack, test plan worked.
Then I started Plack:
sudo koha-plack --enable kohadev
sudo service apache2 restart
sudo koha-plack --start kohadev
About page:
Servers: undefined| Namespace: koha | Status: unknown | Effective caching
method: Cache::Memory
I tried restarting memcached:
sudo service memcached restart
No change - is this to be expected?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:43:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:43:01 +0000
Subject: [Koha-bugs] [Bug 17522] opac-user.pl gives error of
OpacRenewalAllowed is enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17522
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56999|0 |1
is obsolete| |
--- Comment #4 from Kyle M Hall ---
Created attachment 57047
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57047&action=edit
Bug 17522 - opac-user.pl gives error of OpacRenewalAllowed is enabled
If OpacRenewalAllowed is enabled, the following error message is
displayed:
Template process failed: undef error - The method is_expired is not
covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121.
Test Plan:
1) Check out an item for a patron
2) Enable OpacRenewalAllowed
3) Log in as that patron, go to opac-user.pl
4) Note the error
5) Apply this patch
6) Reload opac-user.pl
7) Page should now load!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:42:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:42:59 +0000
Subject: [Koha-bugs] [Bug 17522] opac-user.pl gives error of
OpacRenewalAllowed is enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17522
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:44:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:44:07 +0000
Subject: [Koha-bugs] [Bug 17522] opac-user.pl gives error of
OpacRenewalAllowed is enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17522
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #57047|0 |1
is obsolete| |
--- Comment #5 from Kyle M Hall ---
Created attachment 57048
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57048&action=edit
Bug 17522 - opac-user.pl gives error of OpacRenewalAllowed is enabled
If OpacRenewalAllowed is enabled, the following error message is
displayed:
Template process failed: undef error - The method is_expired is not
covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121.
Test Plan:
1) Check out an item for a patron
2) Enable OpacRenewalAllowed
3) Log in as that patron, go to opac-user.pl
4) Note the error
5) Apply this patch
6) Reload opac-user.pl
7) Page should now load!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:47:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:47:40 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:49:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:49:35 +0000
Subject: [Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261
--- Comment #22 from Jonathan Druart ---
Everything looks ok for me.
Without memcached and plack configured/set:
Servers: undefined| Namespace: koha | Status: unknown | Effective caching
method: Cache::Memory
% Edit $KOHA_CONF and add memcached_servers
% sudo service memcached start
Servers: localhost:11211 | Namespace: koha | Status: running.
% sudo koha-plack --enable kohadev
% sudo koha-plack --start kohadev
% sudo service apache2 restart
Servers: localhost:11211 | Namespace: koha | Status: running.
% sudo service memcached stop
Servers: localhost:11211 | Namespace: koha | Status: not running. Remember
memcached needs to be started before Plack.
% sudo service memcached start
Servers: localhost:11211 | Namespace: koha | Status: not running. Remember
memcached needs to be started before Plack.
% sudo koha-plack --restart kohadev
Servers: localhost:11211 | Namespace: koha | Status: running.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:57:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:57:54 +0000
Subject: [Koha-bugs] [Bug 17532] New: koha-shell does not propagate the
error code
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532
Bug ID: 17532
Summary: koha-shell does not propagate the error code
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.druart at bugs.koha-community.org
Reporter: jonathan.druart at bugs.koha-community.org
QA Contact: testopia at bugs.koha-community.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 16:58:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 15:58:20 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
code
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|koha-shell does not |koha-shell -c does not
|propagate the error code |propagate the error code
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:03:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:03:54 +0000
Subject: [Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC
framework don' t work correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527
--- Comment #7 from M. Tompsett ---
Comment on attachment 57014
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57014
Bug 17527: Hide hidden fields for XSLT blocks
Review of attachment 57014:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17527&attachment=57014)
-----------------------------------------------------------------
::: C4/Search.pm
@@ +2222,4 @@
> # XSLT processing of some stuff
> # we fetched the sysprefs already before the loop through all retrieved record!
> if (!$scan && $xslfile) {
> + $oldbiblio->{XSLTResultsRecord} = XSLTParse4Display($oldbiblio->{biblionumber}, $marcrecord, $xslsyspref, 1, \@hiddenitems, $sysxml, $xslfile, $lang, $interface);
It's the simplest change, but I really dislike that many parameters.
::: C4/XSLT.pm
@@ +255,1 @@
> my $itemsxml = buildKohaItemsNamespace($biblionumber, $hidden_items);
Technically, 952 visibility could be checked/unchecked accordingly, so there
might be something necessary here.
::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ +347,4 @@
> [% IF ( unknownbiblionumber ) %]
> Unknown record
> [% ELSE %]
> +/ Details for [% title |html %] [% FOREACH subtitl IN subtitle %] [% subtitl.subfield | html %][% END %]
What reason is there for adding this slash?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:07:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:07:02 +0000
Subject: [Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC
framework don' t work correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
--- Comment #8 from M. Tompsett ---
(In reply to Katrin Fischer from comment #4)
> To my knowledge it never worked for the XSLT/normal views, the hidden values
> only take effect on the MARC views.
That is my understanding too. And it looks like Jonathan has adapted the filter
for use against the XSLT views. I'm thinking this patch might be the way
forward for XSLT currently. Though, see my comment about items in comment #7.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:07:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:07:44 +0000
Subject: [Koha-bugs] [Bug 17533] New: Syncing private to public list or
adding more specific permissions?
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17533
Bug ID: 17533
Summary: Syncing private to public list or adding more specific
permissions?
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Lists
Assignee: gmcharlt at gmail.com
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
I now have two lists: private list A (shared between some users), and public
list B. A local custom cron job daily syncs changes from A to B.
What I would like, is: Let this group of users that now share A, have
permissions to add/delete entries from public list B (but no one else).
The current permission strategy on public lists is all or nothing, but not just
a group of selected users.
What would be the best way to go to achieve this goal?
What about giving staff users the right to add/delete entries from public
lists? In my specific case the editors include a normal user ;)
Redesign the whole permissions thing on lists? Aarg.
Add a sync lists option?
What do you think?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:09:21 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:09:21 +0000
Subject: [Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC
framework don' t work correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527
--- Comment #9 from M. Tompsett ---
Also, templates. The template files are using parameters passed directly which
may have grabbed the unfiltered values. I'd like to see a refactor of
templates, but that is not necessary to solve this problem.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:12:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:12:07 +0000
Subject: [Koha-bugs] [Bug 17533] Syncing private to public list or adding
more specific permissions?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17533
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #1 from Katrin Fischer ---
I think a permission 'Manage entries on public lists' would work - it would fit
with the already existing permission to delete public lists.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:17:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:17:04 +0000
Subject: [Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261
--- Comment #23 from Katrin Fischer ---
Created attachment 57049
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57049&action=edit
[PASSED QA] Bug 17261: Add memcached configuration info to about.pl
This patch adds a row in the About > System information tab, showing
the current configuration for memcached.
To test:
- Apply this patch, have memcached configured for the current instance (this is
the
default in kohadevbox)
- Make sure you have the memcached server running:
$ sudo service memcached start
- Open the about page in the browser
=> SUCCESS: You get something like:
Memcached: Servers: 127.0.0.1:11211 | Namespace: koha_kohadev | Status:
running
- Stop the memcached server:
$ sudo service memcached stop
- Reload the about page
=> SUCCESS: You get something like
Memcached: Servers: 127.0.0.1:11211 | Namespace: koha_kohadev | Status:
not running
- Set both MEMCACHED_* variables in the apache config for intranet the empty
string:
$ sudo vim /etc/apache2/sites-enabled/kohadev.conf
..
SetEnv MEMCACHED_SERVERS ""
#"127.0.0.1:11211"
SetEnv MEMCACHED_NAMESPACE ""
#"koha_kohadev"
..
- Restart apache:
$ sudo service apache2 restart
- Reload the about page
=> SUCCESS: You get something like:
Memcached: Servers: undefined| Namespace: undefined | Status: unknown
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Nick Clemens
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:17:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:17:06 +0000
Subject: [Koha-bugs] [Bug 17534] New: Press a button and get a fresh DB
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17534
Bug ID: 17534
Summary: Press a button and get a fresh DB
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.druart at bugs.koha-community.org
Reporter: jonathan.druart at bugs.koha-community.org
QA Contact: testopia at bugs.koha-community.org
Depends on: 17529
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
[Bug 17529] Add a --with-records option to populate_db.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:17:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:17:06 +0000
Subject: [Koha-bugs] [Bug 17529] Add a --with-records option to
populate_db.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17529
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |17534
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17534
[Bug 17534] Press a button and get a fresh DB
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:17:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:17:08 +0000
Subject: [Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261
--- Comment #24 from Katrin Fischer ---
Created attachment 57050
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57050&action=edit
[PASSED QA] Bug 17261: (followup) Rebase against 17189 and 11921
This patch adjusts the original one so it works on top of 17189
and 11921. It adds an 'Effective caching method' text which can
be useful, when memcached is not available.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:17:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:17:12 +0000
Subject: [Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261
--- Comment #25 from Katrin Fischer ---
Created attachment 57051
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57051&action=edit
[PASSED QA] Bug 17261: The default memcached namespace is "koha"
If no namespace is defined in ENV or the config, "koha" is used as the
default memcached namespace (See Koha::Cache->new)
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:17:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:17:16 +0000
Subject: [Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261
--- Comment #26 from Katrin Fischer ---
Created attachment 57052
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57052&action=edit
[PASSED QA] Bug 17261: Memcached may not longer be running
If plack is started with memcached, memcached will be considered as
running, even if it has been stopped (or crashed).
This case should be highlighted on the about page.
Note that I am not sure about the consequences of this specific case!
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:17:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:17:19 +0000
Subject: [Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261
--- Comment #27 from Katrin Fischer ---
Created attachment 57053
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57053&action=edit
[PASSED QA] Bug 17261: (followup) Mention the need to start memcached before
plack
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:18:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:18:24 +0000
Subject: [Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:18:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:18:27 +0000
Subject: [Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55536|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:18:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:18:29 +0000
Subject: [Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55537|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:18:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:18:32 +0000
Subject: [Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55538|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:18:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:18:34 +0000
Subject: [Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55542|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:18:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:18:37 +0000
Subject: [Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55535|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:19:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:19:33 +0000
Subject: [Koha-bugs] [Bug 17534] Press a button and get a fresh DB
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17534
--- Comment #1 from Jonathan Druart ---
Created attachment 57054
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57054&action=edit
Bug 17534: Add script to execute everything needed to get a fresh DB
Not sure it will be pushed, but at least it's shared.
It will populate the DB (with records), create a superlibrarian user and
rebuild zebra
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:20:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:20:34 +0000
Subject: [Koha-bugs] [Bug 17534] Press a button and get a fresh DB
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17534
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |In Discussion
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:23:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:23:07 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
code
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532
--- Comment #1 from Jonathan Druart ---
Created attachment 57055
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57055&action=edit
Bug 17532: Make koha-shell -c propagate the error code
When you execute a command using koha-shell -c, you would like to get
the error code of the command you executed.
It seems that koha-shell does not do that.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:23:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:23:14 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
of birth from checkout and patron quick searches
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874
--- Comment #49 from Kyle M Hall ---
Followup pushed to master, thanks Tomas!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:23:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:23:39 +0000
Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error
code
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |INVALID
Status|ASSIGNED |RESOLVED
--- Comment #2 from Jonathan Druart ---
Not sure about this, in my last tests it worked as expected.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:26:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:26:25 +0000
Subject: [Koha-bugs] [Bug 2901] Unable to hide RLIN subfields in a framework
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2901
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |WONTFIX
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:26:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:26:44 +0000
Subject: [Koha-bugs] [Bug 17534] Press a button and get a fresh DB
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17534
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |josef.moravec at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 17:31:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 16:31:17 +0000
Subject: [Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC
framework don' t work correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527
--- Comment #10 from Jonathan Druart ---
(In reply to M. Tompsett from comment #7)
> Comment on attachment 57014 [details] [review]
> Bug 17527: Hide hidden fields for XSLT blocks
>
> Review of attachment 57014 [details] [review]:
> -----------------------------------------------------------------
>
> ::: C4/Search.pm
> @@ +2222,4 @@
> > # XSLT processing of some stuff
> > # we fetched the sysprefs already before the loop through all retrieved record!
> > if (!$scan && $xslfile) {
> > + $oldbiblio->{XSLTResultsRecord} = XSLTParse4Display($oldbiblio->{biblionumber}, $marcrecord, $xslsyspref, 1, \@hiddenitems, $sysxml, $xslfile, $lang, $interface);
>
> It's the simplest change, but I really dislike that many parameters.
Me too, that's why I spend half of my time refactoring legacy code.
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
> @@ +347,4 @@
> > [% IF ( unknownbiblionumber ) %]
> > Unknown record
> > [% ELSE %]
> > +/ Details for [% title |html %] [% FOREACH subtitl IN subtitle %] [% subtitl.subfield | html %][% END %]
>
> What reason is there for adding this slash?
Just a typo maybe?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 18:00:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 17:00:49 +0000
Subject: [Koha-bugs] [Bug 14614] Multiple URLs (856) in cart/list email are
broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14614
Marjorie Barry-Vila changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marjorie.barry-vila at ccsr.qc
| |.ca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 18:04:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 17:04:46 +0000
Subject: [Koha-bugs] [Bug 17533] Syncing private to public list or adding
more specific permissions?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17533
--- Comment #2 from Marcel de Rooy ---
(In reply to Katrin Fischer from comment #1)
> I think a permission 'Manage entries on public lists' would work - it would
> fit with the already existing permission to delete public lists.
Sounds good. Maybe that is the easiest solution. Will not cover all scenarios,
but would be enough for my use case.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 19:47:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 18:47:15 +0000
Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133
Christopher Brannon changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cbrannon at cdalibrary.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 20:05:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 19:05:12 +0000
Subject: [Koha-bugs] [Bug 17274] Add info about which memcached config is
used to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 20:05:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 19:05:16 +0000
Subject: [Koha-bugs] [Bug 17274] Add info about which memcached config is
used to about.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55479|0 |1
is obsolete| |
--- Comment #8 from Katrin Fischer ---
Created attachment 57056
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57056&action=edit
[PASSED QA] Bug 17274: Display the place where the memcached is picked
The memcached config can be read from ENV or koha-conf.xml
In order to remove any ambiguity, let's inform the user which config is
used.
Test plan:
1/ Define the memcached config in ENV and $KOHA_CONF
=> Go on about page, you should get a warning
2/ Define the memcached config in ENV and not in $KOHA_CONF
=> Go on about page, you should get a warning
3/ Do not defined the memcached config in ENV or $KOHA_CONF
=> Go on about page, you should get a warning
4/ Define the memcached config in $KOHA_CONF and not in ENV
=> Go on about page, you should not get a warning, this is the expected
config
Followed test plan, works as expected.
Signed-off-by: Marc
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 23:14:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 22:14:50 +0000
Subject: [Koha-bugs] [Bug 16852] Remove C4::Members::GetBorrowerCategorycode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 23:14:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 22:14:54 +0000
Subject: [Koha-bugs] [Bug 16852] Remove C4::Members::GetBorrowerCategorycode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56388|0 |1
is obsolete| |
--- Comment #6 from Katrin Fischer ---
Created attachment 57057
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57057&action=edit
[PASSED QA] Bug 16852: Remove GetBorrowerCategorycode
And use Koha::Patron->categorycode instead
Test plan:
- Restrict a patron attribute to a patron category
- Use the batch patron modification tool to update a patron of this
category
You should not see the the patron attribute
Signed-off-by: Claire Gravely
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 23:31:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 22:31:52 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Status|Signed Off |Failed QA
--- Comment #25 from Katrin Fischer ---
I like this! I have found some small issues in testing tho:
- When you change the library in the pull down it jumps back to "Select a
library" instead if staying at the library you selected. This way you can't be
sure which library's news you are looking at.
- Same for when you are logged in - I'd think it would be nice to show that it
preselected your home library's news for you.
- The 'system-wide only' option doesn't work correctly - it still displays the
news for the home library of the patron as well.
- OpacNewsBranchSelect - we are trying to not use "Branch", could we change
this to OpacNewsLibrarySelect instead?
- I think you don't need the ==1 here, just checking the pref is true will work
too: [% IF Koha.Preference( 'OpacNewsBranchSelect' ) == 1 %] (just a note)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Nov 1 23:53:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 22:53:36 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #45 from Katrin Fischer ---
I really like the new split button! Tests pass.
Sorry, but noticed this now for the first time:
When you have a CSV profile defined for your late issues export, it will also
show up as export option for the CSV export in acquisitions. I think this could
get confusing as both will require different fields from the database.
I'd really like a way to indicate what the CSV profile is to be used for. I am
hesitating to pass this as is, as I think it will be harder to do this later
on. Once the libraries have added profiles for both, there will be no way to
assign them automatically to the correct module. If we do it now, we can safely
assume that all SQL profiles are used for exporting late issues. Hope that
makes sense?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 00:02:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 23:02:59 +0000
Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting
reminder notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #9 from Katrin Fischer ---
I love the amount of documentation for this script!
I didn't get to test this yet, but while reading through it I wondered:
There is a lot of work done in order to allow exporting in different formats. I
was wondering if it might be better to leave the job of creating a printable
version to gather_print_notices.pl working towards a more unified workflow for
all the printed letters.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 00:14:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2016 23:14:03 +0000
Subject: [Koha-bugs] [Bug 17481] Cas Logout: bug 11048 has been incorrectly
merged
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Status|NEW |Needs Signoff
--- Comment #2 from Katrin Fischer ---
Should this be 'Needs Signoff' or something else to get RMs attention?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 04:16:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 03:16:34 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 04:16:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 03:16:37 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56107|0 |1
is obsolete| |
Attachment #56108|0 |1
is obsolete| |
Attachment #56109|0 |1
is obsolete| |
--- Comment #26 from Liz Rea ---
Created attachment 57058
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57058&action=edit
Bug 14764: OPAC news selector - Add syspref
Adds the new system preference to the pref and SQL files.
Bug 14764: OPAC news selector - Atomic update SQL
Adds an SQL file to perform the database upgrade.
Bug 14764: OPAC news selector - Template tags
Test plan:
1) Add more than one library, at least two in total is needed. Make note of
which is your current user's home branch.
2) Go to Tools -> News and add one global ("All") news item and one specific
for each branch.
3) Apply the patches.
4) Perform database upgrades when you log in.
5) Go to OPAC main, it should work as before: Showing global news as well as
the news for your home branch once logged in.
6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to yes.
7) Go to OPAC main, you should see the global news item plus any items for your
home branch for the current user if logged in.
8) Above the news, you will see a dropdown that lists the branches. Select one,
and click "Change library."
9) You should now see global news and the news for the selected branch,
regardless of whether logged in or not.
Sponsored-By: Halland County Library
Fixes QA comments:
* Keep the current selected branch selected
* Change OPACNewsBranchSelect -> OPACNewsLibrarySelect
* fix 'all libraries' view for logged in user - note that I've gotten rid of
"system wide news" in favour of "all libraries." It's terminology, whatever you
think is best.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 04:17:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 03:17:25 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #57058|0 |1
is obsolete| |
--- Comment #27 from Liz Rea ---
Created attachment 57059
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57059&action=edit
Bug 14764: OPAC news selector
Adds the new system preference to the pref and SQL files.
Bug 14764: OPAC news selector - Atomic update SQL
Adds an SQL file to perform the database upgrade.
Bug 14764: OPAC news selector - Template tags
Test plan:
1) Add more than one library, at least two in total is needed. Make note of
which is your current user's home branch.
2) Go to Tools -> News and add one global ("All") news item and one specific
for each branch.
3) Apply the patches.
4) Perform database upgrades when you log in.
5) Go to OPAC main, it should work as before: Showing global news as well as
the news for your home branch once logged in.
6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to yes.
7) Go to OPAC main, you should see the global news item plus any items for your
home branch for the current user if logged in.
8) Above the news, you will see a dropdown that lists the branches. Select one,
and click "Change library."
9) You should now see global news and the news for the selected branch,
regardless of whether logged in or not.
Sponsored-By: Halland County Library
Fixes QA comments:
* Keep the current selected branch selected
* Change OPACNewsBranchSelect -> OPACNewsLibrarySelect
* fix 'all libraries' view for logged in user - note that I've gotten rid of
"system wide news" in favour of "all libraries." It's terminology, whatever you
think is best.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 04:19:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 03:19:20 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #57059|0 |1
is obsolete| |
--- Comment #28 from Liz Rea ---
Created attachment 57060
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57060&action=edit
Bug 14764: OPAC news selector
Adds the new system preference to the pref and SQL files.
Bug 14764: OPAC news selector - Atomic update SQL
Adds an SQL file to perform the database upgrade.
Bug 14764: OPAC news selector - Template tags
Test plan:
1) Add more than one library, at least two in total is needed. Make note of
which is your current user's home branch.
2) Go to Tools -> News and add one global ("All") news item and one specific
for each branch.
3) Apply the patches.
4) Perform database upgrades when you log in.
5) Go to OPAC main, it should work as before: Showing global news as well as
the news for your home branch once logged in.
6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to yes.
7) Go to OPAC main, you should see the global news item plus any items for your
home branch for the current user if logged in.
8) Above the news, you will see a dropdown that lists the branches. Select one,
and click "Change library."
9) You should now see global news and the news for the selected branch,
regardless of whether logged in or not.
Sponsored-By: Halland County Library
Fixes QA comments:
* Keep the current selected branch selected
* Change OPACNewsBranchSelect -> OPACNewsLibrarySelect
* fix 'all libraries' view for logged in user - note that I've gotten rid of
"system wide news" in favour of "all libraries." It's terminology, whatever you
think is best.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 04:22:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 03:22:06 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764
--- Comment #29 from Liz Rea ---
Created attachment 57061
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57061&action=edit
Bug 14764 - Fix missed OPACNewsBrancSelect
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 04:27:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 03:27:26 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #57060|0 |1
is obsolete| |
Attachment #57061|0 |1
is obsolete| |
--- Comment #30 from Liz Rea ---
Created attachment 57062
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57062&action=edit
Bug 14764: OPAC news selector
Test plan:
1) Add more than one library, at least two in total is needed. Make note of
which is your current user's home branch.
2) Go to Tools -> News and add one global ("All") news item and one specific
for each branch.
3) Apply the patches.
4) Perform database upgrades when you log in.
5) Go to OPAC main, it should work as before: Showing global news as well as
the news for your home branch once logged in.
6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to yes.
7) Go to OPAC main, you should see the global news item plus any items for your
home branch for the current user if logged in.
8) Above the news, you will see a dropdown that lists the branches. Select one,
and click "Change library."
9) You should now see global news and the news for the selected branch,
regardless of whether logged in or not.
Sponsored-By: Halland County Library
Fixes QA comments:
* Keep the current selected branch selected
* Change OPACNewsBranchSelect -> OPACNewsLibrarySelect
* fix 'all libraries' view for logged in user - note that I've gotten rid of
"system wide news" in favour of "all libraries." It's terminology, whatever you
think is best.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 04:31:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 03:31:08 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #57062|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 04:35:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 03:35:15 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764
--- Comment #31 from Liz Rea ---
Created attachment 57063
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57063&action=edit
Bug 14764: OPAC news selector
Test plan:
1) Add more than one library, at least two in total is needed. Make note of
which is your current user's home branch.
2) Go to Tools -> News and add one global ("All") news item and one specific
for each branch.
3) Apply the patches.
4) Perform database upgrades when you log in.
5) Go to OPAC main, it should work as before: Showing global news as well as
the news for your home branch once logged in.
6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to yes.
7) Go to OPAC main, you should see the global news item plus any items for your
home branch for the current user if logged in.
8) Above the news, you will see a dropdown that lists the branches. Select one,
and click "Change library."
9) You should now see global news and the news for the selected branch,
regardless of whether logged in or not.
Sponsored-By: Halland County Library
Fixes QA comments:
* Keep the current selected branch selected
* Change OPACNewsBranchSelect -> OPACNewsLibrarySelect
* fix 'all libraries' view for logged in user - note that I've gotten rid of
"system wide news" in favour of "all libraries." It's terminology, whatever you
think is best.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 07:37:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 06:37:38 +0000
Subject: [Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with
ExportCircHistory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
CC| |josef.moravec at gmail.com
--- Comment #6 from Josef Moravec ---
I'd like to sign-off, but patch doesn't ap?lied cleanly...
Also, I like the ability to select from all available profiles, but I think it
should offer only 'marc' type of profile, because with 'sql' type exporting of
checkouts doesn't work...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 08:14:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 07:14:53 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #32 from Katrin Fischer ---
Hi Liz,
thx for your work (while I slept :) ) I have retested this morning, but not
sure if it's working quite right yet:
1) The "Change library" link next to the pull down does nothing when I click on
it. Do we need it? The pull down still reloads automatically.
2) For "All libraries" I think I'd expect to see all news from all branches,
but it just shows the system wide news instead. I am not sure how to solve this
unless we do some changes to the news system itself. What we can do now is
"system wide and your own branch if you are logged in" which doesn't really
explain well as an option - maybe we should just remove it?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 08:17:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 07:17:45 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764
--- Comment #33 from Katrin Fischer ---
Ah ok, "All libraries" is not showing me the news of my own library when logged
in - sorry about that. I think I'd keep it as 'system-wide' news then, to match
what is written for the RSS feed too.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 08:35:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 07:35:40 +0000
Subject: [Koha-bugs] [Bug 17528] Holds to pull: check button Solved by
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17528
--- Comment #3 from Mike ---
Hello Katrin,
I agree with you generally. But some libraries have braches and stores. In
these cases is process different. Let me expain it on example:
- borrower hold to pull title from external store without staff
- somebody from staff at main bulding create request for driver
- hold is still on list but without any sign that request is already done
- if staff members rotate very often do same work because dont know that
request is done, so we need some paper solution or help from Koha
I agree that can be option function for some libraries.
Mike
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 09:58:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 08:58:38 +0000
Subject: [Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with
ExportCircHistory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 09:58:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 08:58:41 +0000
Subject: [Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with
ExportCircHistory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #50257|0 |1
is obsolete| |
--- Comment #7 from Jonathan Druart ---
Created attachment 57064
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57064&action=edit
Bug 15498: Let the user choose the CSV profile to export circ history
The way the export options are displayed at the bottom of the checkouts table
was not consistent.
Prior to this patch set, they are display if ExportRemoveFields or
ExportWithCsvProfile is set.
It does not make any sense, the user could want to export the checkouts in
iso2709 format without having to define a csv profile and fill the pref.
Moreover the behavior of this pref did not match its description: it's used as
a default CSV profile when exporting records from the export tools or the
command line.
This patch set adds a new pref ExportCircHistory and remove
ExportWithCsvProfile. The new pref is set if ExportWithCsvProfile or
ExportRemoveFields were set.
A new dropdown list with the CSV profile list will be displayed in the
export area, at the bottom of the checkouts table.
Note that now --csv_profile_id is mandatory for the export command line
(misc/export_records.pl) if the export format is csv.
Test plan:
0/ Do not execute the DB entry
1/ Clear both ExportWithCsvProfile and ExportRemoveFields prefs
2/ Execute the DB entry
3/ ExportCircHistory should not be set and the export options should not
be displayed at the bottom of the checkouts table.
4/ Remove the pref
DELETE FROM systempreferences WHERE variable='ExportCircHistory';
and reinsert the previous one, with a value:
INSERT INTO systempreferences (variable, value) VALUES
('ExportWithCsvProfile', 'something');
Execute the DB entry again
=> The now pref should be now set
5/ Export some checkouts using the CSV entry
6/ Note that the export tool and commandline script still work using the
csv format. You have to provide a --csv_profile_id option to make it
work.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 09:58:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 08:58:45 +0000
Subject: [Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with
ExportCircHistory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #50258|0 |1
is obsolete| |
--- Comment #8 from Jonathan Druart ---
Created attachment 57065
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57065&action=edit
Bug 15498: Add ExportCircHistory and remove ExportWithCsvProfile
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 09:58:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 08:58:51 +0000
Subject: [Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with
ExportCircHistory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498
--- Comment #9 from Jonathan Druart ---
Created attachment 57066
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57066&action=edit
Bug 15498: Do not display sql csv profiles
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 09:59:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 08:59:30 +0000
Subject: [Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with
ExportCircHistory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498
--- Comment #10 from Jonathan Druart ---
(In reply to Josef Moravec from comment #6)
> I'd like to sign-off, but patch doesn't ap?lied cleanly...
>
> Also, I like the ability to select from all available profiles, but I think
> it should offer only 'marc' type of profile, because with 'sql' type
> exporting of checkouts doesn't work...
Indeed, done.
Thanks for testing Josef!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 10:02:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 09:02:38 +0000
Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 10:02:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 09:02:42 +0000
Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56572|0 |1
is obsolete| |
--- Comment #11 from Jonathan Druart ---
Created attachment 57067
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57067&action=edit
Bug 17427: Replace CGI::Session with Data::Session
CGI::Session is not maintained for ages and seems quite buggy.
It would be the culprit of random logout problems.
Another issue is the following crazy code in CGI::Session::Driver::DBI
sub DESTROY {
my $self = shift;
unless ( defined $self->{Handle} && $self->{Handle} -> ping ) {
$self->set_error(__PACKAGE__ . '::DESTROY(). Database handle has gone
away');
return;
}
unless ( $self->{Handle}->{AutoCommit} ) {
$self->{Handle}->commit;
}
if ( $self->{_disconnect} ) {
$self->{Handle}->disconnect;
}
}
If AutoCommit is off, it will commit anyway...
It causes some tests to fail (api) if SessionStorage is set to MySQL
Note that PostgreSQL is not supported yet so no need to implement it.
Test plan:
0/ The dependencies are not packaged for debian so far, so install it
via cpan
1/ Test the 3 different values for SessionStorage
2/ Using different browsers (or sessions) login into Koha with different
users. Naviguate => you should not be logged out
3/ Set SessionStorage to Memcached, stop memcached make sure that it
defaults to file.
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 10:04:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 09:04:05 +0000
Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #12 from Jonathan Druart ---
I do not recommend to push this patch into the next stable release (at least
not at the beginning).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 10:22:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 09:22:47 +0000
Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 10:22:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 09:22:50 +0000
Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707
--- Comment #6 from Jonathan Druart ---
Created attachment 57068
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57068&action=edit
Bug 1707: Do not return more than 100 patrons matching the attributes search
As you can feel, this patch is not perfect as we are hardcodind the
number of results to return.
But this number should be correct in the most cases.
Test plan:
With a large number of patrons, using attributes, you can search for
something very generic, like '%'.
Without this patch, the MySQL server could be overloaded because of the
generated query (built from borrowernumbers).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 10:23:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 09:23:05 +0000
Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c
| |ommunity.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 10:27:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 09:27:56 +0000
Subject: [Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with
ExportCircHistory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498
--- Comment #11 from Josef Moravec ---
Jonathan, everything works perfectly, I have just small doubt about UI - the
purpose of 2nd select is not 100% obvious from my point of view...
could you try to
Merge these to select into one like this?
- ISO2709 with items
- ISO2709 without
- CSV - profile1
- CSV - profile2
- ...
OR
Show/hide the second select dynamically based on actually selected format in
first select?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 10:28:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 09:28:34 +0000
Subject: [Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with
ExportCircHistory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |8612
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
[Bug 8612] CSV export profile to have custom fields in export csv basket
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 10:28:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 09:28:34 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
export csv basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |15498
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498
[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 10:36:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 09:36:45 +0000
Subject: [Koha-bugs] [Bug 14435] Recover feature to store and access results
of a report
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |17535
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535
[Bug 17535] Regression: Search for reports by keyword
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 10:36:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 09:36:45 +0000
Subject: [Koha-bugs] [Bug 17535] New: Regression: Search for reports by
keyword
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535
Bug ID: 17535
Summary: Regression: Search for reports by keyword
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: normal
Priority: P5 - low
Component: Reports
Assignee: jonathan.druart at bugs.koha-community.org
Reporter: jonathan.druart at bugs.koha-community.org
QA Contact: testopia at bugs.koha-community.org
Depends on: 14435
Introduced by bug 14435
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435
[Bug 14435] Recover feature to store and access results of a report
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 10:37:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 09:37:17 +0000
Subject: [Koha-bugs] [Bug 17535] Regression: Search for reports by keywords
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Regression: Search for |Regression: Search for
|reports by keyword |reports by keywords
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 10:39:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 09:39:46 +0000
Subject: [Koha-bugs] [Bug 17535] Regression: Search for reports by keywords
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Nov 2 10:39:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2016 09:39:49 +0000
Subject: [Koha-bugs] [Bug 17535] Regression: Search for reports by keywords
In-Reply-To: