[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #36 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Katrin Fischer from comment #33)
> Did a quick code review:
> 
> 1) Could we make this a split button maybe (like the one in cataloguing for
> z39.50 import)? (no blocker)

Good point, I've done it

> 
> 2) The button itself is labelled differently on a closed basket and an open
> basket. Should be the same label for both. I'd suggest something in the
> middle between both versions "Export as CSV"?

Fixed

> 
> 2) Please provide tests for changes to GetBasketAsCSV.

Test added

As have little experiences with writing test, feel free to point me to the
right direction if it's not written as it should be. Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.