[Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC framework don' t work correctly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527

--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 57014
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57014
Bug 17527: Hide hidden fields for XSLT blocks

Review of attachment 57014:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17527&attachment=57014)
-----------------------------------------------------------------

::: C4/Search.pm
@@ +2222,4 @@
>          # XSLT processing of some stuff
>          # we fetched the sysprefs already before the loop through all retrieved record!
>          if (!$scan && $xslfile) {
> +            $oldbiblio->{XSLTResultsRecord} = XSLTParse4Display($oldbiblio->{biblionumber}, $marcrecord, $xslsyspref, 1, \@hiddenitems, $sysxml, $xslfile, $lang, $interface);

It's the simplest change, but I really dislike that many parameters.

::: C4/XSLT.pm
@@ +255,1 @@
>      my $itemsxml  = buildKohaItemsNamespace($biblionumber, $hidden_items);

Technically, 952 visibility could be checked/unchecked accordingly, so there
might be something necessary here.

::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ +347,4 @@
>    [% IF ( unknownbiblionumber ) %]
>      Unknown record
>    [% ELSE %]
> +/    Details for <i>[% title |html %]  [% FOREACH subtitl IN subtitle %] [% subtitl.subfield | html %][% END %]</i>

What reason is there for adding this slash?

-- 
You are receiving this mail because:
You are watching all bug changes.