[Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC framework don' t work correctly

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Nov 1 17:31:17 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to M. Tompsett from comment #7)
> Comment on attachment 57014 [details] [review]
> Bug 17527: Hide hidden fields for XSLT blocks
> 
> Review of attachment 57014 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Search.pm
> @@ +2222,4 @@
> >          # XSLT processing of some stuff
> >          # we fetched the sysprefs already before the loop through all retrieved record!
> >          if (!$scan && $xslfile) {
> > +            $oldbiblio->{XSLTResultsRecord} = XSLTParse4Display($oldbiblio->{biblionumber}, $marcrecord, $xslsyspref, 1, \@hiddenitems, $sysxml, $xslfile, $lang, $interface);
> 
> It's the simplest change, but I really dislike that many parameters.

Me too, that's why I spend half of my time refactoring legacy code.

> ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
> @@ +347,4 @@
> >    [% IF ( unknownbiblionumber ) %]
> >      Unknown record
> >    [% ELSE %]
> > +/    Details for <i>[% title |html %]  [% FOREACH subtitl IN subtitle %] [% subtitl.subfield | html %][% END %]</i>
> 
> What reason is there for adding this slash?

Just a typo maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list