[Koha-bugs] [Bug 17431] Fix failing test t/db_dependent/api/v1/holds.t

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Nov 8 10:39:46 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17431

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm generally not a big fan of bare 'use' statements for this exact reason. 
It's generally good practice to state which routines your wanting to import..
an order change like this feels like a sub is getting redefined silently and so
it's likely stuff will just start randomly failing again further down the line.

Could we work out where the actual issue lies and either specify the imports so
we're clear about exactly which routine from where we're testing or rename the
routine to be unique across the codebase to remove ambiguity?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list