[Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726

--- Comment #12 from Josef Moravec <josef.moravec at gmail.com> ---
Thanks for rebasing!

I started to test and here are first comments

When receiving shipment (script parcel.pl) I got this error:
"The method listinct is not covered by tests!"

In tests:
t/db_dependent/Bookseller.t fails with Can't locate object method "new" via
package "Koha::Acquisition::Bookseller::Contact" (perhaps you forgot to load
"Koha::Acquisition::Bookseller::Contact"?) at t/db_dependent/Bookseller.t line
686.

t/db_dependent/Contract.t fails with Can't locate object method "new" via
package "Koha::Acquisition::Bookseller" (perhaps you forgot to load
"Koha::Acquisition::Bookseller"?) at t/db_dependent/Contract.t line 42.

t/db_dependent/Letters.t fails with 
"my" variable $bookseller masks earlier declaration in same scope at
t/db_dependent/Letters.t line 418.
and
Can't locate object method "new" via package
"Koha::Acquisition::Bookseller::Contact" (perhaps you forgot to load
"Koha::Acquisition::Bookseller::Contact"?) at t/db_dependent/Letters.t line
379.

All other Acquisition test are passing - I am testing on top of 17562, 17563
and 17564

I tried all related (I hope) tests, and in ui I tested Vendor, Contracts,
Baskets adding to order, and so on... I will continue after the error in
parcel.pl will be fixed, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.