[Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Nov 8 22:32:48 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

--- Comment #22 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 57354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57354&action=edit
[SIGNED-OFF] Bug 17008: Test to compare Swagger property types against column
data types

This patch adds a test that iterates through each definition-object in Swagger
and compares their properties' data types to corresponding Koha-object's
column's
data type by using Koha::Util::Swagger::column_type_to_swagger_type().

This test will also check if the column is nullable and will complain
unless property has also "null" defined in its type.

To test:
1. Run t/db_dependent/api/v1/swagger/definitions.t
2. Observe that tests pass (if not, open a Bug to fix issues)
3. Modify api/v1/swagger/definitions/patron.json cardnumber to be type
"integer".
4. Run the test again.
5. Observe that test fails and will complain about incorrect data type.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list