[Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Josef Moravec from comment #1)
> Created attachment 57120 [details] [review]
> Bug 16914: Insert end of line in CSV export of item search in translated
> templates
> 
> Test plan:
> 0) Do not apply the patch
> 1) Install any translation
> 2) Go to item search and choose Output to be CSV
> 3) Search for at least 2 items in result set, open CSV in text editor
>     -> in english, everything is ok
>     -> in other languages are all data on one line
> 4) Apply the patch
> 5) Repeat steps 2 and 3, CSV should look OK either in english and other
> languages

Nice try but this does not correct the bug.
It only works because when you change the "en" file itemsearch_item.csv.inc, it
will not be translated.
I've tryed to add translation update and install after 4) and the bug is still
there.

I think problem comes from the empty_line.inc :
wc -l koha-tmpl/intranet-tmpl/prog/en/includes/empty_line.inc
0 koha-tmpl/intranet-tmpl/prog/en/includes/empty_line.inc
It is really empty, it should contain a line feed.

-- 
You are receiving this mail because:
You are watching all bug changes.