[Koha-bugs] [Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250

--- Comment #20 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jonathan Druart from comment #18)

> Why do you think ->search_by_koha_field is the guilty? It seems only called
> one from searchResults (for a search)

In my test it (and the following ->count / ->next) got called 3 times per each
item in the search results (100 results = w/ 198 items total):

<http://koha-ms.biblos.pk.edu.pl/local/temp/nytprof.41_100_results/C4-Items-pm-1355-line.html#1304>

<http://koha-ms.biblos.pk.edu.pl/local/temp/nytprof.41_100_results/Koha-AuthorisedValues-pm-1165-line.html#85>

(this particular profile is from master @ wheezy, but I measured it in master @
jessie manually, and it does not seem to be much different speed-wise, despite
the newer and more optimised version of DBIx::Class in jessie).

But it is probably config dependent - I profiled this search with all XSLT*
sysprefs enabled (i.e. set to 'default'). I'm wondering if the AV descriptions
fetched in GetItemsInfo() are even used for anything (for the search results
page).. I think they are used in biblio details display (but I'm not entirely
sure about that either), maybe this code can be removed, or called only when
really necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.