[Koha-bugs] [Bug 14224] patron notes about item shown at check in

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Nov 25 00:08:20 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

--- Comment #13 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
(In reply to Jonathan Druart from comment #11)
> Hi Aleisha,
> The getter and setter subroutines (GetIssue, SetIssueNote, SendIssueNote,
> GetPatronNote) should not be added to C4 but use Koha::Issue[s] instead. Let
> me know if you need help to do so.
> And you won't have to provide new tests ;)
> Ideally the svc script should not be added, but you should use the REST API
> instead. However the routes for checkins do not exist yet.

Hi Jonathan,

My latest patch moves those subroutines into Koha::Issue. Are you sure we don't
need tests?
I think we'll leave the svc stuff in the checkins file for now while the routes
for checkins do not exist. 

I will now be working on the fallback form for browsers without JS.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list