[Koha-bugs] [Bug 17676] Default COLLATE for marc_subfield_structure is not set

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17676

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Passed QA. Seems to fix the issue mentioned.
Still some concerns.

> Indeed we want to keep tagsubfield a utf8_bin (to allow lowercase and uppercase of the same letter for subfields).
Could you provide an example where we want to do that? Is that MARC conform?
And if so(!), why would you need utf8_bin to do so? You can still insert them,
only finding the right a or A would be harder.
It seems to me that we should remove this strange exception, and make sure that
all tagsubfields are saved lowercase. Should not be too hard.
Can MARC::Record handle subfields a and A btw?
But this discussion should be on a new report.

> if ( $table[1] !~ /COLLATE=utf8_unicode_ci/ and $table[1] !~ /COLLATE=utf8mb4_unicode_ci/ ) { #catches utf8mb4 collated tables
This is only 99,9% safe (as you are probably aware of).
If you find one column in unicode_ci, the table might still be something else
(theoretically). Perhaps someone added a custom column with collation?
Since you only change the default here, why not always do it? Replacing X with
X will not be a problem..

-- 
You are receiving this mail because:
You are watching all bug changes.