[Koha-bugs] [Bug 17679] C4::Circulation - Remove unused GetItemIssues

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |josef.moravec at gmail.com

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
I totally agree with removing this part of code.

Just few comments:

qa tool is saying this:

 FAIL   catalogue/issuehistory.pl
   FAIL   valid
                "my" variable $biblio masks earlier declaration in same scope



also in the copied part of issuhistory.pl, line 53:

my $total  = scalar @$issues;

but $total is not used and the number of issues is passed to template by this
lines:

$template->param(
    total        => scalar @$issues,
...

-- 
You are receiving this mail because:
You are watching all bug changes.