[Koha-bugs] [Bug 17676] Default COLLATE for marc_subfield_structure is not set

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sat Nov 26 14:50:43 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17676

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #11)
> QA Comment:
> Passed QA. Seems to fix the issue mentioned.
> Still some concerns.
> 
> > Indeed we want to keep tagsubfield a utf8_bin (to allow lowercase and uppercase of the same letter for subfields).
> Could you provide an example where we want to do that? Is that MARC conform?
> And if so(!), why would you need utf8_bin to do so? You can still insert
> them, only finding the right a or A would be harder.
> It seems to me that we should remove this strange exception, and make sure
> that all tagsubfields are saved lowercase. Should not be too hard.
> Can MARC::Record handle subfields a and A btw?
> But this discussion should be on a new report.
> 
> > if ( $table[1] !~ /COLLATE=utf8_unicode_ci/ and $table[1] !~ /COLLATE=utf8mb4_unicode_ci/ ) { #catches utf8mb4 collated tables
> This is only 99,9% safe (as you are probably aware of).
> If you find one column in unicode_ci, the table might still be something
> else (theoretically). Perhaps someone added a custom column with collation?
> Since you only change the default here, why not always do it? Replacing X
> with X will not be a problem..

It's not strictly MARC conform, but we use this a lot and I have talked to
others using it as well. Take the 952 field as the example - all subfield codes
are taken. Using upper case letters works fantastically now and allows you to
store and index data that we got no other sensible spot for. We got it all
working perfectly, why break this feature without need?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list