[Koha-bugs] [Bug 17696] New: Two missing periods in opac-suggestions.tt

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696

            Bug ID: 17696
           Summary: Two missing periods in opac-suggestions.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: ephetteplace at cca.edu
        QA Contact: testopia at bugs.koha-community.org

Around line 38 of the template file a sentence is missing a period:

<p>Please fill out this form to make a purchase suggestion. You will receive an
email when the library processes your suggestion</p>

In an attempt to make this patch more worthwhile, I went looking for other
typos in the template and found another missing period around line 259 in the
conditional text that appears if the user has more pending suggestions than the
MaxOpenSuggestions setting allows:

<p class="TooManySuggestionsText">You have reached your limit of suggestions
you can place at this time.</br>Once the library has processed those
suggestions you will be able to place more</p>

Testing plan:

- configure MaxOpenSuggestions with a low limit (e.g. 1)
- visit opac-suggestions.pl?op=add, login if necessary
- note that the period is missing from the second sentence of the leading
paragraph under the "Enter a new purchase suggestion" heading
- continue to submit suggestions until you've reached the MaxOpenSuggestions
limit
- observe the missing period in the "TooManySuggestionsText" paragraph
- apply patch
- revisit opac-suggestions.pl?op=add
- note that the period is now present in the second sentence of the leading
paragraph under the "Enter a new purchase suggestion" heading
- note that the period is also present at the end of the
"TooManySuggestionsText" paragraph

Patch coming shortly.

-- 
You are receiving this mail because:
You are watching all bug changes.