[Koha-bugs] [Bug 17164] Software error when enrolment fee or reserve fee are too high (Patron categories)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17164

Mika <mikasmith at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56915|0                           |1
        is obsolete|                            |

--- Comment #3 from Mika <mikasmith at catalyst.net.nz> ---
Created attachment 57815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57815&action=edit
Bug 17164: Lower maximum digits of enrolmentfee and reservefee in categories

If the values are too high, Patron Categories page will crash with:

Software error: Template process failed: undef error - round() overflow. Try
smaller precision or use Math::BigFloat at
/home/vagrant/kohaclone/Koha/Number/Price.pm line 44.

This is likely caused by test builder setting random huge numbers when creating
categories.

I found out that 19 digits is the maximum that can be handled. Surely it is
enough for both enrolmentfee and reservefee. This patch lowers the maximum
number of significant digits in order to avoid this crash.

To test:
1. Set category enrolmentfee with a high value, like
3862694923528880000000.0000
2. Go to cgi-bin/koha/admin/categories.pl
3. Observe Software error
4. Apply patch and run updatedatabase.pl
5. Reload the page
6. Observe that software error is gone

Signed-off-by: Mika Smith <mikasmith at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.