From bugzilla-daemon at bugs.koha-community.org Sat Oct 1 03:49:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Oct 2016 01:49:17 +0000 Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 07:01:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 05:01:03 +0000 Subject: [Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a potential security issue when running from git In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 --- Comment #16 from Chris Cormack --- It will achieve part of the goal, it still leaves the base dir messy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 07:36:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 05:36:51 +0000 Subject: [Koha-bugs] [Bug 17384] Categories do not display in patron editing form if they have only one category assigned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 07:36:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 05:36:55 +0000 Subject: [Koha-bugs] [Bug 17384] Categories do not display in patron editing form if they have only one category assigned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55962|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 55966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55966&action=edit Bug 17384 - Categories do not display in patron editing form if they have only one category assigned To reproduce: - Go to Home > Administration > Patron categories - Make sure that you have only one category for a category type. Examples: Only one category "Staff" for category type "Staff" or Only one category "Library" for category type "Org." - Edit a patron or create a new patron - Verify that categories of examples above do not show up in category drop down - Go back to Home > Administration > Patron categories and add categories to both category types - Edit or create a new patron. Veryfy that categories show up in dropdown. To test: - Apply patch - Make sure you have a category type with only one category assigned (e.g. category taype Staff with category Staff) - Edit a patron or create a new patron. Verify that the category shows up in categroy drop down. - Additional test: Verify that template param 'catcode' from removed line is not used in template memberentrygen.tt Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 17:28:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 15:28:07 +0000 Subject: [Koha-bugs] [Bug 14745] RDA: RDA Registry metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14745 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 17:30:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 15:30:29 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 17:35:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 15:35:50 +0000 Subject: [Koha-bugs] [Bug 14519] Send courtesy notices when sys pref EnhancedMessagingPreferences is OFF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14519 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12528 --- Comment #10 from Marc V?ron --- (In reply to Zeno Tajoli from comment #9) > (In reply to Katrin Fischer from comment #8) > > Hm, maybe the solution then would be Bug 9254 - New option to block patrons > > from changing messaging preferences in OPAC? > > Yes 9354 could be a good answer for my requests. Hi Zeno, Bug 9254 is marked as duplicate of: Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC (Pushed to master) Does 12528 resolve your request? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 17:35:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 15:35:50 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14519 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 17:37:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 15:37:37 +0000 Subject: [Koha-bugs] [Bug 10994] Allow use of branch/ kohaAdmin e-mail address for sending claim notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #11 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 17:40:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 15:40:49 +0000 Subject: [Koha-bugs] [Bug 14519] Send courtesy notices when sys pref EnhancedMessagingPreferences is OFF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14519 --- Comment #11 from Zeno Tajoli --- Hi, in fact yes 12528 resolve my request. I close the bug. Bye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 17:41:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 15:41:52 +0000 Subject: [Koha-bugs] [Bug 14519] Send courtesy notices when sys pref EnhancedMessagingPreferences is OFF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14519 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 17:43:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 15:43:04 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 17:46:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 15:46:16 +0000 Subject: [Koha-bugs] [Bug 12594] Get rid of z3950random In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12594 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 18:12:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 16:12:59 +0000 Subject: [Koha-bugs] [Bug 2426] Management Permissions Deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 18:16:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 16:16:03 +0000 Subject: [Koha-bugs] [Bug 2237] Use primary email address as Koha login account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2237 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 18:27:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 16:27:21 +0000 Subject: [Koha-bugs] [Bug 6779] Don't allow patron renewal x days before expiry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6779 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Related to syspref 'ReturnBeforeExpiry' : [Require / Don't require] patrons to return books before their accounts expire (by restricting due dates to before the patron's expiration date). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 18:32:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 16:32:16 +0000 Subject: [Koha-bugs] [Bug 6879] Actual price should show correctly on order line and basket summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #13 from Marc V?ron --- Is this bug still valid? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 2 18:46:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Oct 2016 16:46:22 +0000 Subject: [Koha-bugs] [Bug 7811] borrowers.borrowernumber should be a foreign key for 8 tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7811 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:38:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 07:38:53 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch patron during circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |chad at pennmanor.net |ity.org | --- Comment #7 from Jonathan Druart --- I'd like to get feedback from others to know if it is a good behaviour to implement before fixing it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:41:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 07:41:30 +0000 Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911 --- Comment #40 from Jonathan Druart --- (In reply to Kyle M Hall from comment #39) > (In reply to Jonathan Druart from comment #38) > > (In reply to Kyle M Hall from comment #37) > > > Created attachment 55447 [details] [review] [review] [review] > > > Bug 16911 [QA Followup] - No need to 'use C4::Members' > > > > > > For some reason, this is causing t/db_dependent/Circulation.t to fail if > > > run independently. > > > > > > Signed-off-by: Kyle M Hall > > > > I do not understand this patch, the subroutine AddEnrolmentFeeIfNeeded from > > C4::Members is called from Koha::Patron. It would make sense to use it. > > Do the unit tests fail for you without that patch? If not, maybe it's a > quirk of my environment. Because the call to AddEnrolmentFeeIfNeeded is > fully qualified, the 'use' is not needed, and would be unnecessary overhead > ( though incredibly minimal ). > > If the tests pass for you without that patch, I'd be happy to revert that > specific commit. No, the tests don't pass, but I don't understand why they do with this patch. I am suspecting there is bug hidden somewhere else :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:45:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 07:45:30 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch patron during circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- I think this could speed up things at the desk, but I have one worry: What happens when there is an overlap between item barcodes and patron cardnumbers? Maybe we should show a warning message in that case, asking if the number was one or the other before proceeding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:48:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 07:48:14 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch patron during circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #9 from Katrin Fischer --- Hm, if this is to avoid using the mouse to switch to the check-in field - have you seen that there are keyboard shortcuts for this too? From the circulation start page help: - jump to the catalog search with Alt+Q - jump to the checkout with Alt+U (this will not work for Mac user) - jump to the checkin with Alt+R -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:48:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 07:48:36 +0000 Subject: [Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #11 from Jonathan Druart --- (In reply to Mirko Tietgen from comment #10) > This patch was reverted from the 16.05.04.01 package by request because it > would break instances running Plack. I will skip it for 3.22.11 too. Please > sort this out until next release, either by a followup that fixes the > problem or by reverting it officially from stable and oldstable. Could you detail what is "the problem"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:52:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 07:52:23 +0000 Subject: [Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #12 from Josef Moravec --- I think the problem is described in bug 17342 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:52:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 07:52:52 +0000 Subject: [Koha-bugs] [Bug 17342] Plack does not work after upgrading to 3.22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17342 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17262 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:52:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 07:52:52 +0000 Subject: [Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17342 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 09:58:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 07:58:03 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch patron during circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #10 from Marc V?ron --- (In reply to Katrin Fischer from comment #8) > I think this could speed up things at the desk, but I have one worry: What > happens when there is an overlap between item barcodes and patron > cardnumbers? > > Maybe we should show a warning message in that case, asking if the number > was one or the other before proceeding. I think in the case of overlapping barcodes the feature should be turned off anyway, as the explanation for syspref AutoSwitchPatron says: "This should not be enabled if you have overlapping patron and book barcodes." If in the future a library with overlapping barcodes wants to have this feature, they can ask for or provide an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:02:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 08:02:57 +0000 Subject: [Koha-bugs] [Bug 17342] Plack does not work after upgrading to 3.22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- (In reply to Josef Moravec from comment #2) > In master the memcache configuration is set in koha-conf file, so I think > for stable versions we could adapt this quick fix. > > See bug 11921 Do you have a good idea for the fix? I really do not like the patch from bug 17262 actually. It won't work if the first virtualhost (from the apache config file) does not have a memcached config defined but the second has. It won't work either if the 2 are configured but are different. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:05:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 08:05:56 +0000 Subject: [Koha-bugs] [Bug 17342] Plack does not work after upgrading to 3.22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17342 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > (In reply to Josef Moravec from comment #2) > > In master the memcache configuration is set in koha-conf file, so I think > > for stable versions we could adapt this quick fix. > > > > See bug 11921 > > Do you have a good idea for the fix? > I really do not like the patch from bug 17262 actually. It won't work if the > first virtualhost (from the apache config file) does not have a memcached > config defined but the second has. It won't work either if the 2 are > configured but are different. I think we don't have a solution for these 2 cases actually and we will have to assume it will not happen (or not taken into account). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:09:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 08:09:31 +0000 Subject: [Koha-bugs] [Bug 17342] Plack does not work after upgrading to 3.22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:09:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 08:09:34 +0000 Subject: [Koha-bugs] [Bug 17342] Plack does not work after upgrading to 3.22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17342 --- Comment #5 from Jonathan Druart --- Created attachment 55967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55967&action=edit Bug 17342: (bug 17262 follow-up) fix the way to retrieve memcached config from apache The problem is that the memcached configuration variables are extracted from the apache configuration file incorrectly so you get '"127.0.0.1:11211"' including double quotes as the servers parameter to memcached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:10:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 08:10:38 +0000 Subject: [Koha-bugs] [Bug 17342] Plack does not work after upgrading to 3.22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |andreas.jonsson at kreablo.se CC| |frederic at tamil.fr, | |mirko at abunchofthings.net, | |tomascohen at gmail.com Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:43:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 08:43:30 +0000 Subject: [Koha-bugs] [Bug 17387] Add an undelete feature for items/biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:46:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 08:46:12 +0000 Subject: [Koha-bugs] [Bug 17383] Build debian package failed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17383 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #2 from Josef Moravec --- Did you try to update pbuilder environment? See https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:46:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 08:46:19 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 --- Comment #16 from Magnus Enger --- (In reply to Jonathan Druart from comment #15) > So, Magnus maybe? :) I will have a look in Marseille, if noone beats me to it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:48:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 08:48:39 +0000 Subject: [Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #13 from Mirko Tietgen --- (In reply to Jonathan Druart from comment #11) > Could you detail what is "the problem"? Tom?s said there is a circular dependency IIRC, and asked me to remove it from 16.05.04. Which I did and uploaded a new 16.05.04.01 while I was travelling, I had no time to look into the actual problem. He should be able to explain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 10:56:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 08:56:12 +0000 Subject: [Koha-bugs] [Bug 17342] Plack does not work after upgrading to 3.22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17342 --- Comment #6 from Mirko Tietgen --- The fast fix is to disable memcached and wait for the real fix. I already built two package versions for 16.05.04 because of this. I am not doing another before this has been resolved properly. For the time being, comment out memcached in your config while I am on vacation. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 11:17:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 09:17:13 +0000 Subject: [Koha-bugs] [Bug 17369] Enhance the Reports button on mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17369 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 11:45:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 09:45:41 +0000 Subject: [Koha-bugs] [Bug 17278] Limit to available items returns 0 results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17278 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Severity|minor |major Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 11:51:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 09:51:38 +0000 Subject: [Koha-bugs] [Bug 17278] Limit to available items returns 0 results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17278 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 11:51:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 09:51:41 +0000 Subject: [Koha-bugs] [Bug 17278] Limit to available items returns 0 results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17278 --- Comment #6 from Jonathan Druart --- Created attachment 55968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55968&action=edit Bug 17278: Use available limit when requesting zebra when ccl query is used When a ccl query is used, the buildQuery subroutine does not handle the available limit (not an index). This available limit is handle later in the subroutine. This affect the author links on the detail page for instance (an=xx). A much better solution would be to keep an 'available' zebra index up-to-date. Test plan: (OPAC or staff interface, it does not matter) - Launch a search, click on a result and then on an author link to launch another query (an:xx) - Limit to available items without the 'facet' => Without this patch you won't get any results => With this patch applied you should get relevant result (regarding the known bugs 16970, 13715, 13658, 5463, etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 11:55:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 09:55:19 +0000 Subject: [Koha-bugs] [Bug 14627] GetAuthorisedValueByCode does not handle undef intelligently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14627 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #10 from Jonathan Druart --- This subroutine is going to be removed by bug 17252 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:00:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 10:00:36 +0000 Subject: [Koha-bugs] [Bug 17324] branchcode is NULL in letter triggers red upgrade message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:28:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 10:28:49 +0000 Subject: [Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260 --- Comment #3 from Jonathan Druart --- (In reply to M. Tompsett from comment #2) > Comment on attachment 55263 [details] [review] > Bug 17260 - updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN > columns > > Review of attachment 55263 [details] [review]: > ----------------------------------------------------------------- > > ::: installer/data/mysql/updatedatabase.pl > @@ +12280,4 @@ > > `id` int(11) NOT NULL AUTO_INCREMENT, > > `name` varchar(255) NOT NULL COMMENT 'the name of the field as it will be stored in the search engine', > > `label` varchar(255) NOT NULL COMMENT 'the human readable name of the field, for display', > > + `type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum') NOT NULL COMMENT 'what type of data this holds, relevant when storing it in the search engine', > > I'm not sure how to test for this. I do not have MySQL5.7 but: mysql> insert into search_field(name, label, type)values('name', 'label', ''); Query OK, 1 row affected, 1 warning (0.01 sec) mysql> show warnings; +---------+------+-------------------------------------------+ | Level | Code | Message | +---------+------+-------------------------------------------+ | Warning | 1265 | Data truncated for column 'type' at row 1 | +---------+------+-------------------------------------------+ 1 row in set (0.00 sec) And given https://dev.mysql.com/doc/refman/5.7/en/constraint-enum.html: "For a column defined as ENUM('a','b','c'), values such as '', 'd', or 'ax' are invalid and are rejected." I guess MySQL5.7 will raise an error instead of a warning. ENUM should be avoided, but that would be for another bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:34:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 10:34:45 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 12:38:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 10:38:54 +0000 Subject: [Koha-bugs] [Bug 17376] rebuild_zebra.pl in daemon mode no database access kills the process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17376 Claudio changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:03:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:03:53 +0000 Subject: [Koha-bugs] [Bug 17278] Limit to available items returns 0 results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17278 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Fr?d?ric Demians --- Thanks Jonathan. It's almost there. But there is still something wrong. With your patch, after limiting by availability, if you click on 'Show all items' to remove the limitation, it isn't removed. As you implement it, the limitation is in the CCL query, and so the current code don't remove what you've added to the query: and ( ( allrecords,AlwaysMatches:'' not onloan,AlwaysMatches:'') and (lost,st-numeric=0) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:10:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:10:00 +0000 Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55956|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 55970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55970&action=edit Bug 17317 ILSDI - Getavailability method with id_type=bib implementation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:10:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:10:05 +0000 Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 --- Comment #9 from Jonathan Druart --- Created attachment 55971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55971&action=edit Bug 17317: Perfomance Improvement - Use of GetItemnumbersForBiblio instead of GetItemsByBiblioitemnumber (thx Jonathan Druart) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:10:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:10:58 +0000 Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Needs Signoff --- Comment #10 from Jonathan Druart --- I have just reuploaded the patches (correctly formatted). I'd like to get another signoff on these 2 patches, the structure of the XML has changed (and seems to make more sense). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:11:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:11:28 +0000 Subject: [Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #14 from Fr?d?ric Demians --- It's either not clear to me whether this patch has to be removed from 16.05 or completed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:11:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:11:30 +0000 Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|paul.poulain at biblibre.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:20:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:20:26 +0000 Subject: [Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262 --- Comment #15 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #14) > It's either not clear to me whether this patch has to be removed from 16.05 > or completed. It would be better to fix it, see bug 17342 for a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:29:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:29:05 +0000 Subject: [Koha-bugs] [Bug 17278] Limit to available items returns 0 results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17278 --- Comment #8 from Jonathan Druart --- Created attachment 55972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55972&action=edit Bug 17278: Fix "show all items" link Then we need to remove the "available" part from the query. They are really awkward patches... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:29:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:29:27 +0000 Subject: [Koha-bugs] [Bug 17278] Limit to available items returns 0 results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17278 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:31:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:31:45 +0000 Subject: [Koha-bugs] [Bug 17278] Limit to available items returns 0 results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17278 --- Comment #9 from Jonathan Druart --- Note that I do not plan to provide follow-up if these patches break things (like facets, links, etc.) when this will get pushed. I will ask for a revert instead. I think it would be better to turn off the "available" feature by default as it does not work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:37:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:37:06 +0000 Subject: [Koha-bugs] [Bug 17384] Categories do not display in patron editing form if they have only one category assigned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:37:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:37:09 +0000 Subject: [Koha-bugs] [Bug 17384] Categories do not display in patron editing form if they have only one category assigned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55966|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 55973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55973&action=edit Bug 17384 - Categories do not display in patron editing form if they have only one category assigned To reproduce: - Go to Home > Administration > Patron categories - Make sure that you have only one category for a category type. Examples: Only one category "Staff" for category type "Staff" or Only one category "Library" for category type "Org." - Edit a patron or create a new patron - Verify that categories of examples above do not show up in category drop down - Go back to Home > Administration > Patron categories and add categories to both category types - Edit or create a new patron. Veryfy that categories show up in dropdown. To test: - Apply patch - Make sure you have a category type with only one category assigned (e.g. category taype Staff with category Staff) - Edit a patron or create a new patron. Verify that the category shows up in categroy drop down. - Additional test: Verify that template param 'catcode' from removed line is not used in template memberentrygen.tt Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:38:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:38:44 +0000 Subject: [Koha-bugs] [Bug 17384] Categories do not display in patron editing form if they have only one category assigned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Caused by: commit cae4b980607be083e5e0fb163c4949c73d6347db Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType Really weird line, I guess it's a leftover debug line I put to understand this part of code. Thanks for fixing it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:38:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:38:52 +0000 Subject: [Koha-bugs] [Bug 17384] Categories do not display in patron editing form if they have only one category assigned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:38:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:38:52 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17384 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 [Bug 17384] Categories do not display in patron editing form if they have only one category assigned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:41:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:41:44 +0000 Subject: [Koha-bugs] [Bug 16535] Add the date on which the suggestion was managed on Purchase suggestions tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- I think it would be better to add this info to its own column to allow sort on it, don't you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:44:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:44:21 +0000 Subject: [Koha-bugs] [Bug 16535] Add the date on which the suggestion was managed on Purchase suggestions tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > I think it would be better to add this info to its own column to allow sort > on it, don't you think? Hum not sure actually, it's how it's displayed on the suggestion list page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:49:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:49:22 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart --- Nick, the parenthesis are displayed even if there are no holds on the record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:55:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:55:40 +0000 Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6782 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart --- I have revived by 6782 yesterday and it would fix this bug. Could someone confirm? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:55:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:55:40 +0000 Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17215 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 13:57:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 11:57:30 +0000 Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 --- Comment #13 from Jonathan Druart --- QAers: See (potential) answers of bug 17215 comment 11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 14:04:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 12:04:21 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- These patches do not apply cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 14:12:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 12:12:02 +0000 Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 --- Comment #12 from Lee Jamison --- If I may add my thoughts, 6782's scope is specific to autoMemberNum in regards to the patron creation form. However, 17215 bypasses the patron creation form altogether when Auth_with_ldap.pm triggers. Also, when reviewing the Diff of each bug's latest patch both bugs apply completely different changes. 17215 ONLY modifies C4::Auth_with_ldap while 6782 modifies C4::Members, memberentrygen.tt, and memberentry.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 14:42:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 12:42:41 +0000 Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 --- Comment #13 from Jonathan Druart --- The patch from bug 6782 moves the autoMemberNum check to the AddMember subroutine. That means that the cardnumber will be auto-generated at this point. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 14:44:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 12:44:14 +0000 Subject: [Koha-bugs] [Bug 16535] Add the date on which the suggestion was managed on Purchase suggestions tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 --- Comment #5 from Marc V?ron --- (In reply to Jonathan Druart from comment #4) > (In reply to Jonathan Druart from comment #3) > > I think it would be better to add this info to its own column to allow sort > > on it, don't you think? > > Hum not sure actually, it's how it's displayed on the suggestion list page. The way the patch displays the date is fine for me. A date colum would be fine as well, but if we add a date column, we should do the same on the suggestion list page to have the same look & feel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 14:48:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 12:48:45 +0000 Subject: [Koha-bugs] [Bug 16535] Add the date on which the suggestion was managed on Purchase suggestions tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 --- Comment #6 from Owen Leonard --- I think the addition of a new column for the date would be a good change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:03:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 13:03:11 +0000 Subject: [Koha-bugs] [Bug 17388] New: Suggestion detail page marks suggestion as rejected and accepted Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17388 Bug ID: 17388 Summary: Suggestion detail page marks suggestion as rejected and accepted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org To reproduce: - Create a suggestion - In suggestions management, mark it ("accidentally") as accepted. - Then change status, e.g. to rejected - Display the suggestion's detail page Result: Weird information on detail page, suggestion appears as rejected and as accepted. See screeshot. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:08:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 13:08:00 +0000 Subject: [Koha-bugs] [Bug 17388] Suggestion detail page marks suggestion as rejected and accepted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17388 --- Comment #1 from Marc V?ron --- Created attachment 55974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55974&action=edit Screenshot: Rejected suggestion displays as accepted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:19:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 13:19:01 +0000 Subject: [Koha-bugs] [Bug 16535] Add the date on which the suggestion was managed on Purchase suggestions tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 --- Comment #7 from Jonathan Druart --- If we want to stick with this patch, we should fix the following bug: If the date does not exist, the cell contains: "name - " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 15:57:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 13:57:01 +0000 Subject: [Koha-bugs] [Bug 16535] Add the date on which the suggestion was managed on Purchase suggestions tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 --- Comment #8 from Marc V?ron --- (In reply to Jonathan Druart from comment #7) > If we want to stick with this patch, we should fix the following bug: > If the date does not exist, the cell contains: "name - " Can that ever happen? I had to delete the date directly in mysql to test this case (setting the date to '' and to NULL). If there is no date, the column displays nothing (with and without patch). On /suggestion/suggestion.pl, the column shows ' - ' (no name, no date, only the -) But if somebody adds a date column, I'll be happy to sign off :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:14:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:14:09 +0000 Subject: [Koha-bugs] [Bug 17389] New: Exporting framework always export the default framework Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 Bug ID: 17389 Summary: Exporting framework always export the default framework Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: System Administration Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:14:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:14:26 +0000 Subject: [Koha-bugs] [Bug 17389] Exporting framework always export the default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 --- Comment #1 from Jonathan Druart --- From: commit 705097f938ba9334c21b3e6f006bd7c9ba38763c Bug 16035: MARC default bibliographic framework Export fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:14:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:14:34 +0000 Subject: [Koha-bugs] [Bug 17389] Exporting framework always export the default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16035 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035 [Bug 16035] MARC framework Export misbehaving -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:14:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:14:34 +0000 Subject: [Koha-bugs] [Bug 16035] MARC framework Export misbehaving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 [Bug 17389] Exporting framework always export the default framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:15:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:15:26 +0000 Subject: [Koha-bugs] [Bug 16035] MARC framework Export misbehaving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- > 6) Confirm export still works for other frameworks That did not work, see bug 17389 for a fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:16:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:16:46 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Patch doesn't apply --- Comment #14 from Marc V?ron --- Wanted to test, but patch does not apply, sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:17:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:17:33 +0000 Subject: [Koha-bugs] [Bug 17389] Exporting framework always export the default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:17:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:17:35 +0000 Subject: [Koha-bugs] [Bug 17389] Exporting framework always export the default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 --- Comment #2 from Jonathan Druart --- Created attachment 55975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55975&action=edit Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks Trivial patch, no need to explain anything :) Test plan: Export default framework Export other frameworks => The frameworkcode column should contain the framework code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:18:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:18:10 +0000 Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:23:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:23:44 +0000 Subject: [Koha-bugs] [Bug 7039] Link to existing record from result list in acquisition search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7039 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55476|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 55976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55976&action=edit Bug 7039 - Link to existing record from result list in acquisition search In the Staff client -> Acquisitions, when creating orders from existing records the result list should link to the existing records so that it's possible to check for existing items. This patch adds that functionality. Test plan: 1) In the Staff client, go to Acquisitions and try to add an order from existing records. 2) Observe that the titles in the Summary column are not hyperlinks. 3) Apply the patch. 4) Repeat step 1), and confirm that the titles are now links pointing to each biblio's details page. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:24:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:24:02 +0000 Subject: [Koha-bugs] [Bug 7039] Link to existing record from result list in acquisition search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7039 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:25:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:25:30 +0000 Subject: [Koha-bugs] [Bug 17389] Exporting framework always export the default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 --- Comment #3 from Jonathan Druart --- Created attachment 55977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55977&action=edit Bug 17389: Clear logs Logs are full of: Use of uninitialized value in substitution (s///) at C4/ImportExportFramework.pm line 282. Use of uninitialized value in concatenation (.) or string at C4/ImportExportFramework.pm line 283. Some field are NULL in DB, we need to init the value to an empty string to avoid these warnings. Note: This fix is not related to the original bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:32:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:32:00 +0000 Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #19 from Jonathan Druart --- Kyle, what are you testing on t/db_dependent/Koha/Account.t? it seems that it is already covered by the tests on t/db_dependent/Accounts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:32:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:32:42 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields , or based on the koha biblio level itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:57:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:57:21 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55245|0 |1 is obsolete| | --- Comment #70 from Marc V?ron --- Created attachment 55978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55978&action=edit Bug 13371: Add filters on the supplier list view This patch adds the ability to filter the basket list depending on its creator name, basketgroup name, dates (creation, close), etc. It also adds a new link to filter on opened baskets only and the ability to switch to a simple view if the complete view is to complex Test plan: Go on the supplier list view (acqui/booksellers.pl) and confirm that the view is more ergonomic and the filters permit to the librarians to find a basket more easily than before. Signed-off-by: Paola Rossi Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 16:58:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 14:58:12 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:23:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:23:24 +0000 Subject: [Koha-bugs] [Bug 7676] Barcode Prefixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7676 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:24:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:24:42 +0000 Subject: [Koha-bugs] [Bug 6018] Batch modifitcation of items Enchancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #13 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:26:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:26:21 +0000 Subject: [Koha-bugs] [Bug 9373] show FA (fast add) bibs on the main cataloging page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9373 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #7 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:27:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:27:04 +0000 Subject: [Koha-bugs] [Bug 2960] Cyrillic Z39-50 servers (bad encoding results) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2960 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:28:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:28:17 +0000 Subject: [Koha-bugs] [Bug 17383] Build debian package failed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17383 martin.stastny at teamlibrary.cz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from martin.stastny at teamlibrary.cz --- That was the problem - I skipped some pbuilder setup steps. Thanks for helping. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:28:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:28:53 +0000 Subject: [Koha-bugs] [Bug 8088] Png-images of covers lost transparency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8088 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:29:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:29:57 +0000 Subject: [Koha-bugs] [Bug 6619] pressing enter when hold found at checkin causes issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6619 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:31:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:31:41 +0000 Subject: [Koha-bugs] [Bug 17390] New: Add REST API endpoint for Authorised Values Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 Bug ID: 17390 Summary: Add REST API endpoint for Authorised Values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be good and useful to at least be able to get the list of authorised values from Koha. The ability to create, update and delete could come later. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:31:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:31:45 +0000 Subject: [Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:33:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:33:33 +0000 Subject: [Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 --- Comment #1 from Kyle M Hall --- Created attachment 55979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55979&action=edit Bug 17390 - Add REST API endpoint for Authorised Values It would be good and useful to at least be able to get the list of authorised values from Koha. The ability to create, update and delete could come later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:33:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:33:41 +0000 Subject: [Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 --- Comment #2 from Kyle M Hall --- Created attachment 55980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55980&action=edit Bug 17390 - Update swagger.min.json -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:34:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:34:33 +0000 Subject: [Koha-bugs] [Bug 10471] Global search input box and button geometry not always consistent ( browsers, translations) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10471 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:35:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:35:49 +0000 Subject: [Koha-bugs] [Bug 6129] ISSN url param for serialssolutions.com In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #19 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:36:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:36:05 +0000 Subject: [Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Jonathan is about to move this to the Koha namespace - we should try to get those patches in first, I think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:38:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:38:22 +0000 Subject: [Koha-bugs] [Bug 7032] can select multiple layouts to edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:39:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:39:40 +0000 Subject: [Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #13 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:42:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:42:25 +0000 Subject: [Koha-bugs] [Bug 11409] ungrouped baskets are not being displayed when creating a new basket group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11409 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #7 from Marc V?ron --- Still valid? Are basket groups really used? See http://lists.katipo.co.nz/public/koha/2013-September/037276.html from comment #6 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:43:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:43:56 +0000 Subject: [Koha-bugs] [Bug 10043] Clear notforloan on receipt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10043 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #8 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 17:46:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 15:46:22 +0000 Subject: [Koha-bugs] [Bug 7901] Add batch delete borrowers script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7901 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #9 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:02:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:02:22 +0000 Subject: [Koha-bugs] [Bug 7867] Staff and OPAC areas lack consistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2237 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:02:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:02:22 +0000 Subject: [Koha-bugs] [Bug 2237] Use primary email address as Koha login account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2237 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7867 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:05:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:05:01 +0000 Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:06:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:06:55 +0000 Subject: [Koha-bugs] [Bug 12359] hidepatronname doesn't hide on the holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12359 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #4 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:10:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:10:04 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #15 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:10:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:10:55 +0000 Subject: [Koha-bugs] [Bug 4527] Item details don't respect newlines in details data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4527 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #9 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:15:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:15:08 +0000 Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:16:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:16:25 +0000 Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55970|0 |1 is obsolete| | --- Comment #11 from H?ctor Eduardo Castro Avalos --- Created attachment 55981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55981&action=edit [SIGNED-OFF]Bug 17317: ILSDI: Getavailability method with id_type=bib implementation To test this patch you should try to send a query to you opac formatted this way : http://[your-opac-domain-name]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[biblionumber]&id_type=bib You should get availability status for all the items of the matched bibliographic record. Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:16:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:16:34 +0000 Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55971|0 |1 is obsolete| | --- Comment #12 from H?ctor Eduardo Castro Avalos --- Created attachment 55982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55982&action=edit [SIGNED-OFF]Bug 17317: Perfomance Improvement - Use of GetItemnumbersForBiblio instead of GetItemsByBiblioitemnumber (thx Jonathan Druart) Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:16:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:16:53 +0000 Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:17:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:17:37 +0000 Subject: [Koha-bugs] [Bug 12628] reports/cat_issues_top.pl incorrect checkout range query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12628 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:17:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:17:46 +0000 Subject: [Koha-bugs] [Bug 17391] New: ReturnpathDefault missing from syspref.sql Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17391 Bug ID: 17391 Summary: ReturnpathDefault missing from syspref.sql Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com ReturnpathDefault and possibly others are missing from sysprefs.sql. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:17:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:17:52 +0000 Subject: [Koha-bugs] [Bug 17391] ReturnpathDefault missing from syspref.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17391 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:17:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:17:58 +0000 Subject: [Koha-bugs] [Bug 10188] Top Most-circulated items doesn't count current loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10188 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12628 CC| |veron at veron.ch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12628 [Bug 12628] reports/cat_issues_top.pl incorrect checkout range query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:17:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:17:58 +0000 Subject: [Koha-bugs] [Bug 12628] reports/cat_issues_top.pl incorrect checkout range query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12628 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10188 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10188 [Bug 10188] Top Most-circulated items doesn't count current loans -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:21:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:21:05 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:28:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:28:55 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:47:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:47:18 +0000 Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:47:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:47:18 +0000 Subject: [Koha-bugs] [Bug 11063] Add circulation message's patron when checkin items ( returns.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11063 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17101 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 18:51:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 16:51:50 +0000 Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #27 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:01:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 17:01:55 +0000 Subject: [Koha-bugs] [Bug 17389] Exporting framework always export the default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55975|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 55983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55983&action=edit [SIGNED-OFF]Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks Trivial patch, no need to explain anything :) Test plan: Export default framework Export other frameworks => The frameworkcode column should contain the framework code Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:02:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 17:02:06 +0000 Subject: [Koha-bugs] [Bug 17389] Exporting framework always export the default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55977|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 55984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55984&action=edit [SIGNED-OFF]Bug 17389: Clear logs Logs are full of: Use of uninitialized value in substitution (s///) at C4/ImportExportFramework.pm line 282. Use of uninitialized value in concatenation (.) or string at C4/ImportExportFramework.pm line 283. Some field are NULL in DB, we need to init the value to an empty string to avoid these warnings. Note: This fix is not related to the original bug Signed-off-by: Hector Castro Warnings avoided -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:02:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 17:02:23 +0000 Subject: [Koha-bugs] [Bug 17389] Exporting framework always export the default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17389 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 19:16:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 17:16:57 +0000 Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:54:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 18:54:44 +0000 Subject: [Koha-bugs] [Bug 17392] New: opac/svc/overdrive_proxy is not plack safe Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 Bug ID: 17392 Summary: opac/svc/overdrive_proxy is not plack safe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When running under plack the parameters in the url passed to overdrive are separated by semi-colons as opposed to ampersands example, dumping $query->query_string from /opac/svc/overdrive_proxy under plack we have: 'q=howard%20wigglebottom;limit=1;offset=0' If the page is excluded from plack we get: 'q=howard%20wigglebottom&limit=1&offset=0' You can test in a rest client, the first will return spurious results, searches in opac will report one number of hits, clicking the link for results will return none or a different number of hits from overdrive Tried removing the qw(-oldstyle-urls) from the script but it had no effect, though without that when excluded from plack things also don't work This is verified under master and 3.22 under plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 20:55:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 18:55:28 +0000 Subject: [Koha-bugs] [Bug 17392] opac/svc/overdrive_proxy is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |nick at bywatersolutions.com, | |srdjan at catalyst.net.nz, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:07:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 19:07:59 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #37 from Bouzid --- Created attachment 55985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55985&action=edit Bug12532 - delete useless code and many change for preference EnableRedirectGuaranteeEmail messages affected: ODUE, HOLD, DUE, PREDUE, CHECKIN, CHECKOUT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:09:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 19:09:09 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:29:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 19:29:41 +0000 Subject: [Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55923|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 55986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55986&action=edit [SIGNED-OFF]Bug 17375: Prevent internal software error when searching patron with invalid birth date To reproduce: - Go to Home > Patron - Expand patron search (click on + at the left of the search button) - In drop down 'Search fields', select 'Date of birth' - Enter a valid date (e.g. 11.02.1995 if syspref 'dateformat' is set to dmydot) Result: Search works OK - Enter an invalid date, e.g. 11.02 or abcd... Result: Internal server error - Do a patron search with many results - Use filter on results screen, select 'Date of birth' as search field and enter an invalid date to search (e.g. 'a') Result: Endless message 'Processing' To test: - Apply patch - Repeat steps above - In both cases, you should get "No results" Signed-off-by: Hector Castro Both cases works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:30:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 19:30:04 +0000 Subject: [Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:55:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 19:55:23 +0000 Subject: [Koha-bugs] [Bug 17386] Add opac notes for patron to self checkout screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17386 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55963|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 55987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55987&action=edit [SIGNED-OFF]Bug 17386: Add opac notes for patron to self checkout screen Display patron messages from OPAC summary page on SCO screen as well. To test: - Make sure you have patrons with and without OPAC note and OPAC messages - Log in to OPAC and go to patrons 'your summary' page to display note and messages - Apply patch - Refresh patrons detail page. Verify that it looks the same as before - Go to SCO - Log in as such patron - Verify that note and messages appear the same as on OPAC summary page Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 21:55:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 19:55:34 +0000 Subject: [Koha-bugs] [Bug 17386] Add opac notes for patron to self checkout screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17386 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 22:35:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 20:35:03 +0000 Subject: [Koha-bugs] [Bug 9373] show FA (fast add) bibs on the main cataloging page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9373 --- Comment #8 from Liz Rea --- A cataloguing dashboard would still be neat. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 22:36:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 20:36:58 +0000 Subject: [Koha-bugs] [Bug 6619] pressing enter when hold found at checkin causes issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6619 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:28:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:28:27 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54088|0 |1 is obsolete| | --- Comment #125 from H?ctor Eduardo Castro Avalos --- Created attachment 55988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55988&action=edit [PASSED QA] Bug 6934: New report Cash Register Statistics This patch creates a new report that outputs cash register stats for a specific period. Changes: koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc - Added cash register report link koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt - new file koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt - Added cash register report link reports/cash-register_stats.pl - new file Testing: I Apply the patch 0) Go to reports home page (Home ? Reports); 1) Validate link << Cash Register >> under Statistics wizards; 2) Click link; 3) Validate page with three fieldsets; 4) Chose a date interval, a transaction type, a library and an output; 5) Validade the result. Signed-off-by: Nicole Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:28:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:28:39 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54089|0 |1 is obsolete| | --- Comment #126 from H?ctor Eduardo Castro Avalos --- Created attachment 55989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55989&action=edit [PASSED QA] Bug 6934: Fix code in CashRegisterStats (dataTables pagination, more accurate descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils) I cleaned up the code according to comment #23. I got rid of DHTMLcalendar_dateformat, beacause it wasn't use in cash_register_stats.tt. C4::Dates is deprecated, Koha::DateUtils is now used. Some column names are changed and the pagination for the dataTables is fixed. Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:28:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:28:52 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54090|0 |1 is obsolete| | --- Comment #127 from H?ctor Eduardo Castro Avalos --- Created attachment 55990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55990&action=edit [PASSED QA] Bug 6934: New features, note added to transaction information, total caculated for negative types of transaction To be more specific, the column note from accountlines is now displayed in the table of the transactions. The grand total is now calculated for neagtive types like Credit or Payment and isn't counted for Write off types. Credit (return item) 'CR' has been added to drop down of transaction type Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:29:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:29:12 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54091|0 |1 is obsolete| | --- Comment #128 from H?ctor Eduardo Castro Avalos --- Created attachment 55991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55991&action=edit [PASSED QA] Bug 6934: QA Follow-up Tried to address every single thing that QA mentioned : 1)Removed isNull function 2)Changed datepicker properly 3)We have to fill in two dates not to be flooded with old entries if we don't want to. 4)The first two fieldsets are now in one bigger field set 5)Removed the use of $fullreportname variable 6)Removed the use of dt_from_string when it already recieved a DT. 7)Removed comments starting with "###" in cash_register_stats.pl 8)Used Text::CSV::Encoded to generate the CSV file (used guided_reports.pl as an example) 9)I am not sure if using C4::Reports::Guided is the right choice here. I instead used the same column names as the one recieved by the query in cash_register_stats because this report uses columns from 5 different tables in addition of using both firstname and surname twice. For the ninth point, I would like to know more about C4::Reports::Guided if you still think using it would be a better solution. Thank you! Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:29:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:29:27 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54092|0 |1 is obsolete| | --- Comment #129 from H?ctor Eduardo Castro Avalos --- Created attachment 55992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55992&action=edit [PASSED QA] Bug 6934: Fixed Calendar and removed used of unexisting and unused C4::Budgets getCurrency Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:29:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:29:44 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54093|0 |1 is obsolete| | --- Comment #130 from H?ctor Eduardo Castro Avalos --- Created attachment 55993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55993&action=edit [PASSED QA] Bug 6934: second fix to calendars Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:30:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:30:03 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54094|0 |1 is obsolete| | --- Comment #131 from H?ctor Eduardo Castro Avalos --- Created attachment 55994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55994&action=edit [PASSED QA] Bug 6934: fixed encoding issue Signed-off-by: Hector Castro Encoding issue fixed Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:30:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:30:21 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54095|0 |1 is obsolete| | --- Comment #132 from H?ctor Eduardo Castro Avalos --- Created attachment 55995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55995&action=edit [PASSED QA] Bug 6934: QA follow-up - fixed tabs - fixed capitalization on reports start page Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:30:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:30:35 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54096|0 |1 is obsolete| | --- Comment #133 from H?ctor Eduardo Castro Avalos --- Created attachment 55996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55996&action=edit [PASSED QA] Bug 6934: fix problem when export it open in LibreOffice - show values of itype and use TT plugin Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:30:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:30:51 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54097|0 |1 is obsolete| | --- Comment #134 from H?ctor Eduardo Castro Avalos --- Created attachment 55997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55997&action=edit [PASSED QA] Bug 6934: Make CSV header column translatable and add total amounts in csv file Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:31:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:31:09 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54098|0 |1 is obsolete| | --- Comment #135 from H?ctor Eduardo Castro Avalos --- Created attachment 55998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55998&action=edit [PASSED QA] Bug 6934: Fix the href for datables in link rel stylesheet Fix the new path for 'datatables.css' Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:31:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:31:26 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54099|0 |1 is obsolete| | --- Comment #136 from H?ctor Eduardo Castro Avalos --- Created attachment 55999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55999&action=edit [PASSED QA] Bug 6934: fix errors pointed out by the QA script Also fix forbidden patterns in koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:31:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:31:43 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54100|0 |1 is obsolete| | --- Comment #137 from H?ctor Eduardo Castro Avalos --- Created attachment 56000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56000&action=edit [PASSED QA] Bug 6934: rename active transaction with All payments to the library and grouping in it the relevant account types 'Pay' 'C' rename Patron carnumber on Patron card number fix src databales.js Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:32:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:32:15 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55939|0 |1 is obsolete| | --- Comment #138 from H?ctor Eduardo Castro Avalos --- Created attachment 56001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56001&action=edit [SIGNED-OFF]Bug 6934 - Fix problem C4::Branch::GetBranchesLoop not exist Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 3 23:33:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Oct 2016 21:33:40 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #139 from H?ctor Eduardo Castro Avalos --- Rebase all patches to avoid merge conflicts and signed-off last patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 05:07:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 03:07:57 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 05:08:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 03:08:01 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #8 from Aleisha Amohia --- Created attachment 56002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56002&action=edit Bug 14715: Fixing merge conflicts etc. To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 05:38:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 03:38:39 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42003|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia --- Created attachment 56003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56003&action=edit Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 05:38:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 03:38:47 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42742|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia --- Created attachment 56004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56004&action=edit Bug 14715: syspref for results per page options Remove the "all" option. Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of results per page including [OPAC]numSearchResults. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 05:38:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 03:38:53 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42743|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia --- Created attachment 56005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56005&action=edit Bug 14715: database updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 05:40:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 03:40:11 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Attachment #56002|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 05:40:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 03:40:51 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #12 from Aleisha Amohia --- These patches should now apply cleanly and are ready for testing. To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 08:11:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 06:11:07 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 --- Comment #16 from Martin Renvoize --- We have a series of public libraries that are still keen on this.. so I think it's still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 08:26:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 06:26:13 +0000 Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 --- Comment #28 from Martin Renvoize --- I reckon lets kill it off Marc, I got not reply two years ago on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 09:24:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 07:24:21 +0000 Subject: [Koha-bugs] [Bug 17393] New: selfreg - Patron' s info are not correctly inserted if contain non-Latin characters Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17393 Bug ID: 17393 Summary: selfreg - Patron's info are not correctly inserted if contain non-Latin characters Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org If you fill the patron self reg with non-latin characters, they will be encoded with HTML entities (é) This bug leads to generate a userid with weird behaviors: ? => eacute ? => x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 09:32:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 07:32:47 +0000 Subject: [Koha-bugs] [Bug 17393] selfreg - Patron' s info are not correctly inserted if contain non-Latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17393 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 09:37:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 07:37:58 +0000 Subject: [Koha-bugs] [Bug 17393] selfreg - Patron' s info are not correctly inserted if contain non-Latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17393 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 09:38:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 07:38:01 +0000 Subject: [Koha-bugs] [Bug 17393] selfreg - Patron' s info are not correctly inserted if contain non-Latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17393 --- Comment #1 from Jonathan Druart --- Created attachment 56006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56006&action=edit Bug 17393: Fix non-Latin chars handling in self reg If you fill the patron self reg with non-latin characters, they will be encoded with HTML entities (é) This bug leads to generate a userid with weird behaviors: ? => eacute ? => x Test plan: 0/ Do not apply the patch 1/ Set up the Self reg feature 2/ fill surname, fistname with something like "Micha? pou???" 3/ Save 4/ See the bad encoding/replacement on the screen and look at the data The accentued chars are replaced with their html representation and the non-Latin chars with a 'x' in the DB 5/ Apply this patch 6/ Repeat steps 2, 3 7/ Everything should be ok 8/ Try to make sure this HTML::Entities escape was not useful: fill surname with "surname " Save and look at the data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 09:44:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 07:44:16 +0000 Subject: [Koha-bugs] [Bug 7177] memoize more function calls to speed up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7177 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|ASSIGNED |RESOLVED --- Comment #9 from Jonathan Druart --- This is now invalid, we must use Koha::Cache instead to correctly cache our stuffs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 09:44:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 07:44:17 +0000 Subject: [Koha-bugs] [Bug 7119] general code-cleaning, tidy/whitespace omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7119 Bug 7119 depends on bug 7177, which changed state. Bug 7177 Summary: memoize more function calls to speed up Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7177 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 09:48:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 07:48:29 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #38 from Marc V?ron --- Wanted to test on current master, but first patch does not apply, sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 09:58:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 07:58:25 +0000 Subject: [Koha-bugs] [Bug 16535] Add the date on which the suggestion was managed on Purchase suggestions tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #9 from Jonathan Druart --- I have plenty of them and the check exist in suggestion.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 10:03:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 08:03:44 +0000 Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #29 from Marc V?ron --- Set to RESOLVED WONTFIX because there is no activity since 2013. Feel free to reactivate if necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 10:13:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 08:13:39 +0000 Subject: [Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #14 from Jonathan Druart --- (In reply to Marc V?ron from comment #13) > Still valid? Yes, the way to go is to use the TT plugin added by bug 12844. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 10:14:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 08:14:10 +0000 Subject: [Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12844 --- Comment #15 from Jonathan Druart --- (In reply to Jonathan Druart from comment #11) > Created attachment 21267 [details] [review] > [ALT] Bug 9410: Draft: TT Plugin for formatting prices, etc. This is now in, see bug 12844. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 10:14:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 08:14:10 +0000 Subject: [Koha-bugs] [Bug 12844] Introduce a centralized way to display prices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9410 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 10:16:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 08:16:45 +0000 Subject: [Koha-bugs] [Bug 17393] selfreg - Patron' s info are not correctly inserted if contain non-Latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17393 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56006|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 56007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56007&action=edit Bug 17393: Fix non-Latin chars handling in self reg If you fill the patron self reg with non-latin characters, they will be encoded with HTML entities (é) This bug leads to generate a userid with weird behaviors: ? => eacute ? => x Test plan: 0/ Do not apply the patch 1/ Set up the Self reg feature 2/ fill surname, fistname with something like "Micha? pou???" 3/ Save 4/ See the bad encoding/replacement on the screen and look at the data The accentued chars are replaced with their html representation and the non-Latin chars with a 'x' in the DB 5/ Apply this patch 6/ Repeat steps 2, 3 7/ Everything should be ok 8/ Try to make sure this HTML::Entities escape was not useful: fill surname with "surname " Save and look at the data Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 10:18:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 08:18:28 +0000 Subject: [Koha-bugs] [Bug 17393] selfreg - Patron' s info are not correctly inserted if contain non-Latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17393 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 10:50:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 08:50:58 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #18 from Jonathan Druart --- Jacek, sorry this has ran out of my radar. I do not really undertand how this could be (really) useful, the syspref cache is populated when Koha needs a pref value for the first time, then the prefs are picked from the cache. This patch will only improve the first hits and it will be insignificant compared to the whole pages load. I may missed something here, could you please elaborate a bit more? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 10:53:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 08:53:13 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #19 from Jonathan Druart --- Ok I think I got it: you want to serialise all prefs into the same structure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:26:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 09:26:02 +0000 Subject: [Koha-bugs] [Bug 17358] Authorised values: COU>COUNTRY | LAN>LANG In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17358 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55838|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 56008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56008&action=edit Bug 17358: Rename COU with COUNTRY and LAN with LANG Some installer files use COU and LAN instead of COUNTRY and LANG. To uniformise these AVs, it would be good to use the same code. Note that I do not think we should update existing installations Carefully compared code. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:26:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 09:26:14 +0000 Subject: [Koha-bugs] [Bug 17358] Authorised values: COU>COUNTRY | LAN>LANG In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17358 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:34:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 09:34:31 +0000 Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53656|0 |1 is obsolete| | --- Comment #15 from Marc V?ron --- Created attachment 56009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56009&action=edit Bug 16965: Add Koha::Objects->search_related In order to search on relations, we need this new method. Test plan: Confirm that the changes in Objects.t make sense and that the tests pass. Tested all 3 patches together, followed test plan, result OK Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:35:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 09:35:31 +0000 Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53673|0 |1 is obsolete| | --- Comment #16 from Marc V?ron --- Created attachment 56010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56010&action=edit Bug 16965: search_related returns an instanciated Koha::Objects-based object Koha::Objects->search_related should return a Koha::Objects-based object. This search_related method should follow the same rules as the search method, i.e. take into account what the caller want (scalar or list). The problem here is that we do not know (in Koha::Objects) what is the kind of objects we want to instanciate. To know it, this patch adds a get_object_class, it will return the class of the object and the resultset Koha::Object-based object. The drawback of this method is that we will have to keep it up-to-date every time we add a new Koha::Object class. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:36:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 09:36:44 +0000 Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53777|0 |1 is obsolete| | --- Comment #17 from Marc V?ron --- Created attachment 56011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56011&action=edit Bug 16965: [Follow-up] Adjust get_object_class In many cases it should be possible to derive the Koha::Objects class name from the DBIx result class name in a trivial manner. If not, the DBIx result class should have a class method called koha_objects_class providing that non-trivial name, such as Libraries for Branch. Note: We are only interested in the plural form here (Koha::Objects). Test plan: Run t/db_dependent/Koha/Objects.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:37:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 09:37:23 +0000 Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:45:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 09:45:13 +0000 Subject: [Koha-bugs] [Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron at veron.ch --- Comment #7 from Marc V?ron --- Wanted to test, but patch does not apply, sorry. fatal: sha1 information is lacking or useless (C4/Circulation.pm). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:46:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 09:46:34 +0000 Subject: [Koha-bugs] [Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Marc V?ron --- Sorry, missed dependency... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:53:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 09:53:32 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45535|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 56012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56012&action=edit Bug 15341: Retrieve all sysprefs at once C4::Context->preference generates a call to Koha::Config::SysPrefs->find for all different sysprefs we are searching for. It seems to be a performance killer and be better to retrieve them all together and then cache them all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:54:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 09:54:42 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #21 from Jonathan Druart --- (In reply to Jonathan Druart from comment #20) > Created attachment 56012 [details] [review] > Bug 15341: Retrieve all sysprefs at once Jacek, did you have something like that in mind? This patch is not graceful and will need to be improved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:57:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 09:57:06 +0000 Subject: [Koha-bugs] [Bug 16769] Koha::Cache->set_in_cache calls need to be standardised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:57:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 09:57:08 +0000 Subject: [Koha-bugs] [Bug 16769] Koha::Cache->set_in_cache calls need to be standardised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53751|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 56013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56013&action=edit Bug 16769: Uniformise calls to Koha::Cache->set_in_cache >From the POD of Koha::Cache->set_in_cache: # This is a bit of a hack to support the old API in case things still use it Let's remove this hack and update old calls. Test plan: Look at the results of git grep set_in_cache and confirm that there are no more version of the old call (without hashref as third param) Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:57:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 09:57:12 +0000 Subject: [Koha-bugs] [Bug 16769] Koha::Cache->set_in_cache calls need to be standardised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53752|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 56014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56014&action=edit Bug 16769: [QA Follow-up] Still found an occurrence Script svc/report did contain one old-style call. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 11:57:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 09:57:18 +0000 Subject: [Koha-bugs] [Bug 16769] Koha::Cache->set_in_cache calls need to be standardised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53753|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 56015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56015&action=edit Bug 16769: [QA Follow-up] Remove unsupported deepcopy parameter Routine C4/Koha/GetAuthorisedValues adds deepcopy => 1 to the options of set_in_cache. This makes no sense (anymore?). Is not supported or passed further. So better remove it. Test plan: Run t/db_dependent/Koha.t (with Test::Deep available to minimize confusion) Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:16:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:16:23 +0000 Subject: [Koha-bugs] [Bug 17392] opac/svc/overdrive_proxy is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 --- Comment #1 from Jonathan Druart --- Created attachment 56016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56016&action=edit Bug 17392: Make svc/overdrive_proxy plack safe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:17:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:17:26 +0000 Subject: [Koha-bugs] [Bug 17392] opac/svc/overdrive_proxy is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 --- Comment #2 from Jonathan Druart --- Just a try, I am not able to test the whole workflow. Please test and adapt if needed. I think that the problem comes from the fact that the CGI->new method is overwritten from the psgi file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:18:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:18:23 +0000 Subject: [Koha-bugs] [Bug 17392] opac/svc/overdrive_proxy is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > Just a try, I am not able to test the whole workflow. > Please test and adapt if needed. > I think that the problem comes from the fact that the CGI->new method is > overwritten from the psgi file. And so the -oldstyle_urls pragma is not taken into account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:19:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:19:14 +0000 Subject: [Koha-bugs] [Bug 3758] Automatic Exchange Rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3758 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:19:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:19:26 +0000 Subject: [Koha-bugs] [Bug 4202] Improve international currency and exchange support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4202 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:23:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:23:40 +0000 Subject: [Koha-bugs] [Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55580|0 |1 is obsolete| | --- Comment #9 from Marc V?ron --- Created attachment 56017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56017&action=edit Bug 17250 - Koha::AuthorisedValues - Remove GetAuthValCode The subroutine C4::Koha::GetAuthValCode returned the authorised value category for a given kohafield. This can be acchieve easily using a new Koha::AuthorisedValues->search_by_koha_field method which will mimic search_by_marc_field. Test plan: Confirm that the description is correctly displayed on the following pages: - detail and moredetail of a bibliographic page (itemlost, damaged, materials) - Set AcqCreateItem=ordering and receiving items. The description for notforloan, restricted, location, ccode, etc. field should be displayed. - Items search form - On the checkout list from the circulation.pl and returns.pl pages, the description for "materials" should be displayed Note that GetKohaAuthorisedValuesMapping is going to be removed on bug 17251. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:24:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:24:01 +0000 Subject: [Koha-bugs] [Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:30:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:30:17 +0000 Subject: [Koha-bugs] [Bug 4042] Public OPAC search can fall prey to web crawlers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #3 from Bob Birchall --- (In reply to Pablo AB from comment #2) > As told here > http://koha.1045719.n5.nabble.com/Help-100-CPU-utilization-running-Koha- > tp5809357.html > we could just put a robots.txt like this on /usr/share/koha/opac/htdocs: > > User-agent: * > Disallow:/cgi-bin/koha/opac-search.pl > Disallow:/cgi-bin/koha/opac-export.pl > Disallow:/cgi-bin/koha/opac-showmarc.pl > Disallow:/cgi-bin/koha/opac-ISBDdetail.pl > Disallow:/cgi-bin/koha/opac-MARCdetail.pl This is the file we use: ---------------------------- Crawl-delay: 60 User-agent: * Disallow: / User-agent: Googlebot Disallow: /cgi-bin/koha/opac-search.pl Disallow: /cgi-bin/koha/opac-showmarc.pl Disallow: /cgi-bin/koha/opac-detailprint.pl Disallow: /cgi-bin/koha/opac-ISBDdetail.pl Disallow: /cgi-bin/koha/opac-MARCdetail.pl Disallow: /cgi-bin/koha/opac-reserve.pl Disallow: /cgi-bin/koha/opac-export.pl Disallow: /cgi-bin/koha/opac-detail.pl Disallow: /cgi-bin/koha/opac-authoritiesdetail.pl ---------------------------- Can we mark this bug as resolved now? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:35:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:35:21 +0000 Subject: [Koha-bugs] [Bug 17394] New: exporting checkouts with items selects without items in combo-box Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17394 Bug ID: 17394 Summary: exporting checkouts with items selects without items in combo-box Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In checkouts table, the is an export form (when some exports syspref are enabled). When selecting some checkouts and selecting "ISO2709 with items" in export format combo-box, clicking on "Export" will select "ISO2709 without items" in the export format combo-box. This is quite strange. Its because the form as 2 inputs with same name and id "output_format" : an hidden input (the wanted arg for tools/export.pl) and a select (the export format combo-box). So an action meant on the hidden input impacts the select. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:35:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:35:29 +0000 Subject: [Koha-bugs] [Bug 17394] exporting checkouts with items selects without items in combo-box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17394 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:35:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:35:43 +0000 Subject: [Koha-bugs] [Bug 17394] exporting checkouts with items selects without items in combo-box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17394 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:44:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:44:59 +0000 Subject: [Koha-bugs] [Bug 17394] exporting checkouts with items selects without items in combo-box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17394 --- Comment #1 from Fridolin SOMERS --- Created attachment 56018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56018&action=edit Bug 17394 - exporting checkouts with items selects without items in combo-box In checkouts table, the is an export form (when some exports syspref are enabled). When selecting some checkouts and selecting "ISO2709 with items" in export format combo-box, clicking on "Export" will select "ISO2709 without items" in the export format combo-box. This is quite strange. Its because the form as 2 inputs with same name and id "output_format" : an hidden input (the wanted arg for tools/export.pl) and a select (the export format combo-box). So an action meant on the hidden input impacts the select. This patch corrects by changing id and name of the export format combo-box : issues-table-output-format TEST plan : - Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile - Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx - Show checkouts table - Select some checkboxes in "Export" column - Select "ISO2709 with items" in export format combo-box - Click on "Export" => Without patch, the export format combo-box changes to "ISO2709 without items" => Without patch, the export format combo-box does not changes - Check the export file contains the items - Check exports "ISO2709 without items" and "CSV" are OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:45:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:45:56 +0000 Subject: [Koha-bugs] [Bug 17394] exporting checkouts with items selects without items in combo-box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17394 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:51:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:51:02 +0000 Subject: [Koha-bugs] [Bug 17395] New: exporting checkouts in CVS generates a file with wrong extension Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Bug ID: 17395 Summary: exporting checkouts in CVS generates a file with wrong extension Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In checkouts table, the is an export form (when some exports syspref are enabled). Export using a CSV profile will create a file with name koha.mrc (same as ISO2709 export). It would be better with koha.csv. Bug 14647 manages the export page, this but will only manage for export from checkouts table where file name is hard-coded. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:51:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:51:09 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:51:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:51:19 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14647 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:51:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:51:19 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17395 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:53:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:53:05 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17394 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:53:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:53:05 +0000 Subject: [Koha-bugs] [Bug 17394] exporting checkouts with items selects without items in combo-box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17394 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17395 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:55:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:55:50 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 --- Comment #1 from Fridolin SOMERS --- Created attachment 56019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56019&action=edit Bug 17395 - exporting checkouts in CVS generates a file with wrong extension In checkouts table, the is an export form (when some exports syspref are enabled). Export using a CSV profile will create a file with name koha.mrc (same as ISO2709 export). It would be better with koha.csv. Bug 14647 manages the export page, this but will only manage for export from checkouts table where file name is hard-coded. Test plan : - Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile for record export - Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx - Show checkouts table - Select some checkboxes in "Export" column - Select "CSV" in export format combo-box - Click on "Export" => Without patch, the generated file is koha.mrc => With patch, the generated file is koha.csv - Check ISO2709 export generates a file named koha.mrc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:56:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:56:46 +0000 Subject: [Koha-bugs] [Bug 17394] exporting checkouts with items selects without items in combo-box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17394 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56018|0 |1 is obsolete| | --- Comment #2 from Fridolin SOMERS --- Created attachment 56020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56020&action=edit Bug 17394 - exporting checkouts with items selects without items in combo-box In checkouts table, the is an export form (when some exports syspref are enabled). When selecting some checkouts and selecting "ISO2709 with items" in export format combo-box, clicking on "Export" will select "ISO2709 without items" in the export format combo-box. This is quite strange. Its because the form as 2 inputs with same name and id "output_format" : an hidden input (the wanted arg for tools/export.pl) and a select (the export format combo-box). So an action meant on the hidden input impacts the select. This patch corrects by changing id and name of the export format combo-box : issues-table-output-format TEST plan : - Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile - Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx - Show checkouts table - Select some checkboxes in "Export" column - Select "ISO2709 with items" in export format combo-box - Click on "Export" => Without patch, the export format combo-box changes to "ISO2709 without items" => With patch, the export format combo-box does not changes - Check the export file contains the items - Check exports "ISO2709 without items" and "CSV" are OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:57:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:57:11 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:59:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:59:28 +0000 Subject: [Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:59:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:59:31 +0000 Subject: [Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55986|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 56021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56021&action=edit Bug 17375: Search by dateofbirth - Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 12:59:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 10:59:34 +0000 Subject: [Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 --- Comment #5 from Jonathan Druart --- Created attachment 56022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56022&action=edit Bug 17375: Search by dateofbirth - handle invalid dates Prevent internal software error when searching patron with invalid birth date To reproduce: - Go to Home > Patron - Expand patron search (click on + at the left of the search button) - In drop down 'Search fields', select 'Date of birth' - Enter a valid date (e.g. 11.02.1995 if syspref 'dateformat' is set to dmydot) Result: Search works OK - Enter an invalid date, e.g. 11.02 or abcd... Result: Internal server error - Do a patron search with many results - Use filter on results screen, select 'Date of birth' as search field and enter an invalid date to search (e.g. 'a') Result: Endless message 'Processing' To test: - Apply patch - Repeat steps above - In both cases, you should get "No results" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:00:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 11:00:20 +0000 Subject: [Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Hi Marc, Could you have a look at these 2 patches? I think they provide a more robust and durable solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:01:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 11:01:53 +0000 Subject: [Koha-bugs] [Bug 17396] New: t/DataTables/Members.t is unnecessary Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17396 Bug ID: 17396 Summary: t/DataTables/Members.t is unnecessary Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The subroutine C4::Utils::DataTables::Members::search is covered by tests from t/db_dependent/Utils/Datatables_Members.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:02:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 11:02:51 +0000 Subject: [Koha-bugs] [Bug 17396] t/DataTables/Members.t is unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17396 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:02:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 11:02:54 +0000 Subject: [Koha-bugs] [Bug 17396] t/DataTables/Members.t is unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17396 --- Comment #1 from Jonathan Druart --- Created attachment 56023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56023&action=edit Bug 17396: Remove unnecessary t/DataTables/Members.t is unnecessary tests The subroutine C4::Utils::DataTables::Members::search is covered by tests from t/db_dependent/Utils/Datatables_Members.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:03:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 11:03:32 +0000 Subject: [Koha-bugs] [Bug 17396] t/DataTables/Members.t is unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17396 --- Comment #2 from Jonathan Druart --- No test plan, nothing to test here. If you don't understand how to validate it, please pick another patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:04:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 11:04:29 +0000 Subject: [Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 [Bug 9811] Patrons search improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:04:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 11:04:29 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17375 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 [Bug 17375] Prevent internal software error when searching patron with invalid birth date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:05:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 11:05:55 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:07:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 11:07:12 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 --- Comment #2 from Jonathan Druart --- Would not have been better to revive the patch from bug 14647? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:36:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 11:36:08 +0000 Subject: [Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56021|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 56024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56024&action=edit Bug 17375: Search by dateofbirth - Add tests Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:37:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 11:37:00 +0000 Subject: [Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56022|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 56025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56025&action=edit Bug 17375: Search by dateofbirth - handle invalid dates Prevent internal software error when searching patron with invalid birth date To reproduce: - Go to Home > Patron - Expand patron search (click on + at the left of the search button) - In drop down 'Search fields', select 'Date of birth' - Enter a valid date (e.g. 11.02.1995 if syspref 'dateformat' is set to dmydot) Result: Search works OK - Enter an invalid date, e.g. 11.02 or abcd... Result: Internal server error - Do a patron search with many results - Use filter on results screen, select 'Date of birth' as search field and enter an invalid date to search (e.g. 'a') Result: Endless message 'Processing' To test: - Apply patch - Repeat steps above - In both cases, you should get "No results" Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:37:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 11:37:11 +0000 Subject: [Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:54:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 11:54:57 +0000 Subject: [Koha-bugs] [Bug 17397] New: Add name of librarian who created circulation message Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 Bug ID: 17397 Summary: Add name of librarian who created circulation message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 13:55:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 11:55:31 +0000 Subject: [Koha-bugs] [Bug 17397] Add name of librarian who created circulation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:04:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:04:05 +0000 Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:04:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:04:02 +0000 Subject: [Koha-bugs] [Bug 17397] Add name of librarian who created circulation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 --- Comment #1 from Josef Moravec --- Created attachment 56026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56026&action=edit Bug 17397: Show name of librarian who created circulation message Test plan: 1) Apply the patch 2) Update DB structure 3) Run update_dbix_class_files.pl 4) Select patron for checking out 5) Try to add some circulation and opac messages 6) Note that now there is creator (you ;) ) shown by every message added (with link to creator profile) 7) Try to delete messages to confirm that everything works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:04:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:04:09 +0000 Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55919|0 |1 is obsolete| | Attachment #55920|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart --- Created attachment 56027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56027&action=edit Bug 14874 - Add ability to search for patrons by date of birth from checkout and patron quick searches This patch adds a new syspef 'DefaultPatronSearchFields' which defines the fields that should be used when searching for a patron if none are defined. To test: 1 - Aply patch, updatedatabase 2 - Ensure patron search has not changed 3 - Add dateofbirth to new pref 4 - Ensure things work wll 5 - Experiment with adding and removing other fields from borrowers table 6 - prove t/db_dependent/Utils/Datatables_Members.t Tested together with followup. Works as described. Signed-off-by: Marc V?ron Bug 14874 (QA Followup) Fix atomicupdate file name Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:04:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:04:14 +0000 Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #40 from Jonathan Druart --- Created attachment 56028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56028&action=edit Bug 14874: Set default DefaultPatronSearchFields just in case... Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:04:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:04:32 +0000 Subject: [Koha-bugs] [Bug 17397] Add name of librarian who created circulation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:04:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:04:49 +0000 Subject: [Koha-bugs] [Bug 17397] Show name of librarian who created circulation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add name of librarian who |Show name of librarian who |created circulation message |created circulation message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:04:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:04:58 +0000 Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #41 from Jonathan Druart --- Great Nick, this version is much more better :) The type of the pref should not be "multi" but it does not seem to hurt and bug 17374 has been opened. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:06:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:06:06 +0000 Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17375 --- Comment #42 from Jonathan Druart --- I have also rebased the patch on top of bug 17375, as it is a bug fix. Second patch as been squashed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 [Bug 17375] Prevent internal software error when searching patron with invalid birth date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:06:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:06:06 +0000 Subject: [Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:08:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:08:27 +0000 Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #43 from Jonathan Druart --- I'd like to see a patch on bug 17374 in order to have them in the same release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:08:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:08:55 +0000 Subject: [Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|veron at veron.ch |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:56:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:56:59 +0000 Subject: [Koha-bugs] [Bug 17398] New: Enhance circulation message UI Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Bug ID: 17398 Summary: Enhance circulation message UI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:57:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:57:39 +0000 Subject: [Koha-bugs] [Bug 17398] Enhance circulation message UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | Depends on| |17397 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 [Bug 17397] Show name of librarian who created circulation message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:57:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:57:39 +0000 Subject: [Koha-bugs] [Bug 17397] Show name of librarian who created circulation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17398 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 [Bug 17398] Enhance circulation message UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:58:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:58:40 +0000 Subject: [Koha-bugs] [Bug 17386] Add opac notes for patron to self checkout screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17386 --- Comment #3 from Jonathan Druart --- Created attachment 56029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56029&action=edit Bug 17386: Add opac notes for patron to self checkout screen Display patron messages from OPAC summary page on SCO screen as well. To test: - Make sure you have patrons with and without OPAC note and OPAC messages - Log in to OPAC and go to patrons 'your summary' page to display note and messages - Apply patch - Refresh patrons detail page. Verify that it looks the same as before - Go to SCO - Log in as such patron - Verify that note and messages appear the same as on OPAC summary page Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:58:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:58:44 +0000 Subject: [Koha-bugs] [Bug 17386] Add opac notes for patron to self checkout screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17386 --- Comment #4 from Jonathan Druart --- Created attachment 56030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56030&action=edit Bug 17386: Simplify code Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:59:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:59:10 +0000 Subject: [Koha-bugs] [Bug 17386] Add opac notes for patron to self checkout screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 14:59:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 12:59:25 +0000 Subject: [Koha-bugs] [Bug 17386] Add opac notes for patron to self checkout screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55987|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:02:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 13:02:40 +0000 Subject: [Koha-bugs] [Bug 17398] Enhance circulation message UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:02:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 13:02:42 +0000 Subject: [Koha-bugs] [Bug 17398] Enhance circulation message UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 --- Comment #1 from Josef Moravec --- Created attachment 56031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56031&action=edit Bug 17398: Enhance circulation messages UI Test plan: 1) Apply patch 2) Add same circulation messages, note that both buttons are in bootstrap style and the whole form is a bit cleaner 3) Confirm that adding works as expected 4) Try to delete some of your messages, note the delete link is also button now 5) Confirm that deleting works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:04:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 13:04:48 +0000 Subject: [Koha-bugs] [Bug 16514] Force scalar cotext where param assumes a list incorrectly in admin/ edi scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:50:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 13:50:03 +0000 Subject: [Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:50:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 13:50:06 +0000 Subject: [Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55609|0 |1 is obsolete| | Attachment #55610|0 |1 is obsolete| | Attachment #55611|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 56032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56032&action=edit Bug 17088 - Bad MARC XML can halt export_records.pl If export_records.pl encounters a record that fails to load correctly as a MARC::Record the export process will fail and only the records encountered up to that point will be exported. Test Plan: 1) Pick a record in your database, and replace the biblioitems.marcxml field with some random characters 2) Export your records using the command: misc/export_records.pl --format xml --record-type bibs --filename /tmp/biblios.xml 3) Note you get an error and the script ends prematurely 4) Apply this patch 5) Repeat step 2 6) Note the full record set is exported ( except for your bad record ) 7) Note an error is still generated for your bad record ( useful for tracking down bad records ). Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:50:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 13:50:10 +0000 Subject: [Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088 --- Comment #8 from Jonathan Druart --- Created attachment 56033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56033&action=edit Bug 17088: [Follow-up] Adjust POD in Logger.pm Not important enough to go on its own. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:50:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 13:50:14 +0000 Subject: [Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088 --- Comment #9 from Jonathan Druart --- Created attachment 56034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56034&action=edit Bug 17088: [Follow-up] Use Logger for failed exports Fixes a TODO for logging unsupported record_type in _get_record_for_export. Also logs a warning when the record_type parameter is not supplied at all in sub export. Replaces a warn by a log message about an invalid record for format iso2709. Also adds a log message about an invalid record for format xml. Adds a trivial unit test for passing no record_type to export. Test plan: See also first patch. Run t/db_dependent/Exporter/Record.t. Signed-off-by: Marcel de Rooy Also tested the log messages for iso2709 and xml by manipulating the record_type parameter with: $params->{record_type}='xx'; before calling _get_record_for_export in Record.pm. Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 15:50:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 13:50:21 +0000 Subject: [Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088 --- Comment #10 from Jonathan Druart --- Created attachment 56035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56035&action=edit Bug 17088: Add tests to cover the changes Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:16:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 14:16:18 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 --- Comment #8 from Bouzid --- Created attachment 56036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56036&action=edit bug 5620 - Capture Mode of payment, receipt number and notes in pay fines. Using sql file in atomiqueupdate using function GetKohaAuthorisedValues -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:17:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 14:17:34 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51290|0 |1 is obsolete| | Attachment #56036|0 |1 is obsolete| | --- Comment #9 from Bouzid --- Created attachment 56037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56037&action=edit bug 5620 - Capture Mode of payment, receipt number and notes in pay fines. Using sql file in atomiqueupdate using function GetKohaAuthorisedValues -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:20:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 14:20:06 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #32 from Jonathan Druart --- Created attachment 56038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56038&action=edit Bug 17196: follow-up for bug 17088 If bug 17088 is pushed first, we will need this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:24:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 14:24:24 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:35:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 14:35:13 +0000 Subject: [Koha-bugs] [Bug 17396] t/DataTables/Members.t is unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17396 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56023|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 56039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56039&action=edit Bug 17396: Remove unnecessary t/DataTables/Members.t is unnecessary tests The subroutine C4::Utils::DataTables::Members::search is covered by tests from t/db_dependent/Utils/Datatables_Members.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 16:35:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 14:35:28 +0000 Subject: [Koha-bugs] [Bug 17396] t/DataTables/Members.t is unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17396 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:15:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 15:15:02 +0000 Subject: [Koha-bugs] [Bug 17397] Show name of librarian who created circulation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Sorry, QA-Tools complain: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt (...) FAIL tt_valid lines 855 See: https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:22:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 15:22:16 +0000 Subject: [Koha-bugs] [Bug 17397] Show name of librarian who created circulation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 17:53:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 15:53:46 +0000 Subject: [Koha-bugs] [Bug 17399] New: SIP2 Screen messages for checkout failure should be improved Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17399 Bug ID: 17399 Summary: SIP2 Screen messages for checkout failure should be improved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Koha should return useful screen messages for patrons when a checkout fails for some reason, currently it seems we just get the last kye/value pair: In C4 / SIP / ILS / Transaction / Checkout.pm Line 69 is quite correct: 67 if (scalar keys %$issuingimpossible) { 68 foreach (keys %$issuingimpossible) { 69 # do something here so we pass these errors 70 $self->screen_msg($_ . ': ' . $issuingimpossible->{$_}); 71 $noerror = 0; 72 } 73 } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:10:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:10:32 +0000 Subject: [Koha-bugs] [Bug 7937] Silence warns in OPAC error log (koha-opac-error_log) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #19 from Marc V?ron --- Is this patch set still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:11:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:11:27 +0000 Subject: [Koha-bugs] [Bug 5295] ctype index Zebra configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #12 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:12:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:12:17 +0000 Subject: [Koha-bugs] [Bug 8740] Serials Claims should be exportable all at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #10 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:12:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:12:44 +0000 Subject: [Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #11 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:13:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:13:34 +0000 Subject: [Koha-bugs] [Bug 10503] incorrect initialization parameters passed to Memoize:: Memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10503 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #12 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:14:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:14:36 +0000 Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #12 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:16:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:16:01 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #25 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:16:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:16:59 +0000 Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #24 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:18:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:18:59 +0000 Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 --- Comment #10 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:33:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:33:00 +0000 Subject: [Koha-bugs] [Bug 12242] Allow hiding branches from the OPAC search pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12242 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:33:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:33:55 +0000 Subject: [Koha-bugs] [Bug 11005] Centralize the UseBranchTransferLimits-check under one function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #15 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:36:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:36:11 +0000 Subject: [Koha-bugs] [Bug 11291] Change the behavior of any index in DOM indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11291 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #6 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:38:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:38:47 +0000 Subject: [Koha-bugs] [Bug 10135] Adding the ability to define customised basketgroups pdf layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #10 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:41:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:41:29 +0000 Subject: [Koha-bugs] [Bug 8074] Define default library for holds to pull report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #10 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 18:51:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 16:51:16 +0000 Subject: [Koha-bugs] [Bug 12374] Add koha-mqsqldump script, analagous to koha-mysql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12374 Larry Baerveldt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larry at bywatersolutions.com --- Comment #14 from Larry Baerveldt --- There is very much a need for this tool. We at ByWater have needed this for so long, that I wrote my own script very much like this. To my mind, I have no problem with there being two scripts with overlapping functionality. They serve different purposes. Koha-dump is optimized for backups, plain and simple. Koha-mysqldump has a different purpose, and is geared for those who need to have the option to use the full range of mysqldump options. The fact that both scripts happen to share a common underlying program should not be a strike against this one. As for the issue of maintaining another script, I think that's inconsequential. The script itself is dead simple, and once added, I think will not require much in the way of ongoing support. As for modifying the existing koha-dump script to allow mysqldump parameters, I think that's actually the more complicated solution. You would have to add an option to skip the configs backup, override the output directory and automatic gzipping of output, override the chown and chmod commands etc. Honestly, it would be easier to add this script and simply modify koha-dump to call *this* one for the mysql dump portion. Also, if you were to modify koha-dump, it will probably require one or more command line option flags, to both override its normal function and to pass in the new options you might want to use. Koha-mysqldump is simpler, as after the initial command and site name, all remaining command line options are the same as for mysqldump. To reiterate my earlier comment about different functions, koha-dump's purpose is to do backups, koha-mysqldump's purpose is to simply put a wrapper around mysqldump. Yes, it would be possible to modify koha-dump to add this functionality, but my vote is for the new script. In my opinion, it's the simpler and easier way to add needed functionality, without making an existing script more complicated. - Larry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 20:39:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 18:39:21 +0000 Subject: [Koha-bugs] [Bug 14090] add link to basket from invoice and vice versa In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14090 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 21:35:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 19:35:42 +0000 Subject: [Koha-bugs] [Bug 17400] New: KOHA keeps requesting log-in Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17400 Bug ID: 17400 Summary: KOHA keeps requesting log-in Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbiggs at washoecounty.us QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com KOHA keeps requesting log-in information every time I start a new transaction. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 21:36:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 19:36:10 +0000 Subject: [Koha-bugs] [Bug 17400] KOHA keeps requesting log-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17400 cbiggs at washoecounty.us changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 23:29:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 21:29:40 +0000 Subject: [Koha-bugs] [Bug 17342] Plack does not work after upgrading to 3.22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17342 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 23:29:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 21:29:44 +0000 Subject: [Koha-bugs] [Bug 17342] Plack does not work after upgrading to 3.22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17342 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55967|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 56040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56040&action=edit Bug 17342: (bug 17262 follow-up) fix the way to retrieve memcached config from apache The problem is that the memcached configuration variables are extracted from the apache configuration file incorrectly so you get '"127.0.0.1:11211"' including double quotes as the servers parameter to memcached. Signed-off-by: Chris Cormack Note this only applies on 3.22.x but it does fix the problem Definitely needed for 3.22.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 23:42:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 21:42:56 +0000 Subject: [Koha-bugs] [Bug 17324] branchcode is NULL in letter triggers red upgrade message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17324 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 23:42:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 21:42:59 +0000 Subject: [Koha-bugs] [Bug 17324] branchcode is NULL in letter triggers red upgrade message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17324 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55728|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 56041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56041&action=edit Bug 17324: Deal with branchcode NULL issue In a database update we alter the letter table, making a column (branchcode) not be able to contain NULL values. However if it already does, this SQL fails. So before changing the column we change the NULL values [Tue Sep 20 19:08:10 2016] updatedatabase.pl: DBD::mysql::db do failed: Invalid use of NULL value [for Statement " [Tue Sep 20 19:08:10 2016] updatedatabase.pl: ALTER TABLE letter MODIFY COLUMN branchcode varchar(10) NOT NULL DEFAULT '' [Tue Sep 20 19:08:10 2016] updatedatabase.pl: "] at /home/mtompset/kohaclone/installer/data/mysql/updatedatabase.pl line 12638. Reproduce: on an ubuntu 16.04 LTS machine with MySQL 5.7 install git koha development environment. ... git checkout -b my_3.18.x origin/3.18.x drop database koha_library; create database koha_library; quit; web install all sample data (ignore some issues with sample data, and one with mandatory) git checkout -b bug_17234 origin/master git bz apply 17292 git bz apply 17320 git bz apply 17260 git bz apply 17234 web install Two warning messages are expected output from upgrade process, but the above message is not. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 4 23:43:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 21:43:23 +0000 Subject: [Koha-bugs] [Bug 17324] branchcode is NULL in letter triggers red upgrade message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17324 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Signed off and fixed the commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 00:14:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 22:14:18 +0000 Subject: [Koha-bugs] [Bug 17323] MySQL 5.7 - Column search_history.time cannot be null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17323 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 00:14:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Oct 2016 22:14:21 +0000 Subject: [Koha-bugs] [Bug 17323] MySQL 5.7 - Column search_history.time cannot be null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17323 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55717|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 56042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56042&action=edit Bug 17323: Column search_history.time cannot be null When doing a search, with SearchHistory pref switched on: DBD::mysql::st execute failed: Column 'time' cannot be null [for Statement " INSERT INTO search_history( userid, sessionid, query_desc, query_cgi, type, total, time ) VALUES( ?, ?, ?, ?, ?, ?, ? ) " with ParamValues: 0="7874", 1='12338a0bd8da63e32c79ee84f8493a07', 2="kw,wrdl: d", 3='q=d', 4='biblio', 5=6104, 6=undef] at C4/Search/History.pm line 34. Since MySLQ 5.7, undef does not mean "the default value". To let the DBMS set the default value (CURRENT_TIMESTAMP), the parameter should not be passed Test plan: OPAC+Intranet, swith the 2 SearchHistory syspref on Do a search => Without this patch, you will get an error in the log and the row will not be inserted in the table. => With this patch, everything must go fine Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 04:05:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 02:05:15 +0000 Subject: [Koha-bugs] [Bug 16245] RIS export file type incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 04:05:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 02:05:18 +0000 Subject: [Koha-bugs] [Bug 16245] RIS export file type incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55941|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 56043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56043&action=edit Bug 16245: RIS export file type incorrect When exporting lists to a RIS file, the TY field of the RIS file is always 'book' even if the item being exported is a journal or serial. Since unimarc and marc21 is coded in Koha, just a few references types are included. This needs a much better code. This bug changes only TY BOOK result. Other resources needs a case by case basis. To test: -In advanced search limit by itemtype (books, music, continue resources, etc). -Search and save result in Cart -Export to RIS Format and notice about the new TY change with all materials -Export record in bib record details page in OPAC and Intranet. -Confirm that works as expected. -Bonus test: -Try to import the RIS file in http://www.myendnoteweb.com if you have account or create one. NOTE: According with previous comment, some values has changed. Sponsored-by: Universidad de El Salvador Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 07:23:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 05:23:46 +0000 Subject: [Koha-bugs] [Bug 17397] Show name of librarian who created circulation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56026|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 56044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56044&action=edit Bug 17397: Show name of librarian who created circulation message Test plan: 1) Apply the patch 2) Update DB structure 3) Run update_dbix_class_files.pl 4) Select patron for checking out 5) Try to add some circulation and opac messages 6) Note that now there is creator (you ;) ) shown by every message added (with link to creator profile) 7) Try to delete messages to confirm that everything works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 07:33:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 05:33:21 +0000 Subject: [Koha-bugs] [Bug 17397] Show name of librarian who created circulation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56044|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 56045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56045&action=edit Bug 17397: Show name of librarian who created circulation message Test plan: 1) Apply the patch 2) Update DB structure 3) Run update_dbix_class_files.pl 4) Select patron for checking out 5) Try to add some circulation and opac messages 6) Note that now there is creator (you ;) ) shown by every message added (with link to creator profile) 7) Try to delete messages to confirm that everything works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 07:35:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 05:35:07 +0000 Subject: [Koha-bugs] [Bug 17397] Show name of librarian who created circulation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56045|0 |1 is obsolete| | --- Comment #5 from Josef Moravec --- Created attachment 56046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56046&action=edit Bug 17397: Show name of librarian who created circulation message Test plan: 1) Apply the patch 2) Update DB structure 3) Run update_dbix_class_files.pl 4) Select patron for checking out 5) Try to add some circulation and opac messages 6) Note that now there is creator (you ;) ) shown by every message added (with link to creator profile) 7) Try to delete messages to confirm that everything works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 07:35:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 05:35:59 +0000 Subject: [Koha-bugs] [Bug 17397] Show name of librarian who created circulation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Josef Moravec --- Sorry, now Koha QA tools passed cleanly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 07:38:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 05:38:46 +0000 Subject: [Koha-bugs] [Bug 17398] Enhance circulation message UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56031|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 56047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56047&action=edit Bug 17398: Enhance circulation messages UI Test plan: 1) Apply patch 2) Add same circulation messages, note that both buttons are in bootstrap style and the whole form is a bit cleaner 3) Confirm that adding works as expected 4) Try to delete some of your messages, note the delete link is also button now 5) Confirm that deleting works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:13:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 07:13:43 +0000 Subject: [Koha-bugs] [Bug 17342] Plack does not work after upgrading to 3.22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:13:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 07:13:49 +0000 Subject: [Koha-bugs] [Bug 17342] Plack does not work after upgrading to 3.22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56040|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 56048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56048&action=edit Bug 17342: (bug 17262 follow-up) fix the way to retrieve memcached config from apache The problem is that the memcached configuration variables are extracted from the apache configuration file incorrectly so you get '"127.0.0.1:11211"' including double quotes as the servers parameter to memcached. Signed-off-by: Chris Cormack Note this only applies on 3.22.x but it does fix the problem Definitely needed for 3.22.12 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:14:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 07:14:55 +0000 Subject: [Koha-bugs] [Bug 17342] Plack does not work after upgrading to 3.22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |16.05 --- Comment #9 from Jonathan Druart --- (In reply to Chris Cormack from comment #7) > Note this only applies on 3.22.x but it does fix the problem > Definitely needed for 3.22.12 It's needed for 16.05.x as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:20:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 07:20:09 +0000 Subject: [Koha-bugs] [Bug 17342] Plack does not work after upgrading to 3.22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17342 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #10 from Fr?d?ric Demians --- Pushed in 16.05. Will be in 16.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:21:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 07:21:52 +0000 Subject: [Koha-bugs] [Bug 17324] branchcode is NULL in letter triggers red upgrade message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:21:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 07:21:57 +0000 Subject: [Koha-bugs] [Bug 17324] branchcode is NULL in letter triggers red upgrade message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56041|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 56049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56049&action=edit Bug 17324: Deal with branchcode NULL issue In a database update we alter the letter table, making a column (branchcode) not be able to contain NULL values. However if it already does, this SQL fails. So before changing the column we change the NULL values [Tue Sep 20 19:08:10 2016] updatedatabase.pl: DBD::mysql::db do failed: Invalid use of NULL value [for Statement " [Tue Sep 20 19:08:10 2016] updatedatabase.pl: ALTER TABLE letter MODIFY COLUMN branchcode varchar(10) NOT NULL DEFAULT '' [Tue Sep 20 19:08:10 2016] updatedatabase.pl: "] at /home/mtompset/kohaclone/installer/data/mysql/updatedatabase.pl line 12638. Reproduce: on an ubuntu 16.04 LTS machine with MySQL 5.7 install git koha development environment. ... git checkout -b my_3.18.x origin/3.18.x drop database koha_library; create database koha_library; quit; web install all sample data (ignore some issues with sample data, and one with mandatory) git checkout -b bug_17234 origin/master git bz apply 17292 git bz apply 17320 git bz apply 17260 git bz apply 17234 web install Two warning messages are expected output from upgrade process, but the above message is not. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Did not follow the test plan, but the changes make sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:22:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 07:22:35 +0000 Subject: [Koha-bugs] [Bug 17324] branchcode is NULL in letter triggers red upgrade message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17324 --- Comment #7 from Jonathan Druart --- Mark, did you get how it happened? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:30:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 07:30:30 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|kyle.m.hall at gmail.com |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:34:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 07:34:17 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from Jonathan Druart --- The status is needs signoff when you want someone to test your patch! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:37:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 07:37:08 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Jonathan Druart --- And the status is failed qa and a patch modifies code without any test coverage. You should also have a look at bug 17248 and bug 15894. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:41:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 07:41:21 +0000 Subject: [Koha-bugs] [Bug 16245] RIS export file type incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- What is 'MANSCPT'? Are the changes related to MANSCPT expected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:46:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 07:46:47 +0000 Subject: [Koha-bugs] [Bug 17366] create patron list, software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17366 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I do not recreate. Could you check your koga log file please, there is certainly an error in it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:51:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 07:51:29 +0000 Subject: [Koha-bugs] [Bug 17380] Cannot edit authorities with authtypecode = default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Could you give us the exact error with the file and line number where it crashes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 09:56:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 07:56:30 +0000 Subject: [Koha-bugs] [Bug 17123] Can't call method "raw" on an undefined value at C4/ Search.pm line 806 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17123 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- This error usually happens when you zebra index is not up-to-date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 10:07:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 08:07:44 +0000 Subject: [Koha-bugs] [Bug 17401] New: Returns form not submitting after printing slip Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17401 Bug ID: 17401 Summary: Returns form not submitting after printing slip Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: benjamin.rokseth at kul.oslo.kommune.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 16566 ('Print slip' button formatting inconsistent) broke returns. The popup modal javascript uses preventdefault when generating print slip but is also preventing form submit. The status of the item is therefore not updated. This patch simply adds the form submit to return to expected behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 10:44:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 08:44:12 +0000 Subject: [Koha-bugs] [Bug 17401] Returns form not submitting after printing slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17401 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 11:00:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 09:00:09 +0000 Subject: [Koha-bugs] [Bug 17401] Returns form not submitting after printing slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17401 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 11:18:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 09:18:50 +0000 Subject: [Koha-bugs] [Bug 17398] Enhance circulation message UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56047|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 56050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56050&action=edit Bug 17398: Enhance circulation messages UI Test plan: 1) Apply patch 2) Add same circulation messages, note that both buttons are in bootstrap style and the whole form is a bit cleaner 3) Confirm that adding works as expected 4) Try to delete some of your messages, note the delete link is also button now 5) Confirm that deleting works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 11:35:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 09:35:12 +0000 Subject: [Koha-bugs] [Bug 17342] Plack does not work after upgrading to 3.22.11 and 16.05.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17342 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Plack does not work after |Plack does not work after |upgrading to 3.22.11 |upgrading to 3.22.11 and | |16.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:46:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 10:46:39 +0000 Subject: [Koha-bugs] [Bug 17402] New: Enhance the actions button on serials-search.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17402 Bug ID: 17402 Summary: Enhance the actions button on serials-search.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Enhance the button similar way as in reports see bug 17341 Default value should be receive serial if applicable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:52:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 10:52:28 +0000 Subject: [Koha-bugs] [Bug 17341] Enhance the report action button on guided_reports.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17341 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17402 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:52:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 10:52:28 +0000 Subject: [Koha-bugs] [Bug 17402] Enhance the actions button on serials-search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17402 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17341 Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:52:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 10:52:50 +0000 Subject: [Koha-bugs] [Bug 17402] Enhance the actions button on serials-search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17402 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 12:52:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 10:52:52 +0000 Subject: [Koha-bugs] [Bug 17402] Enhance the actions button on serials-search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17402 --- Comment #1 from Josef Moravec --- Created attachment 56051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56051&action=edit Bug 17402 Enhance the actions button on serials-search.pl Test plan: 1) Apply the patch 2) Go to serials home page 3) Search for a subscription 4) Ensure you have permission to receive serials 5) In the most right column of table you should see "Receive serial" button with caret button, that should work as trigger form dropdown menu with other options 6) Ensure that all actions work as expected 7) Login with user without permission to receive serials 8) repeat 2-3 9) In the most right column of table you should see normal dropdown mane with label "Actions" and all applicable options 10) Ensure that all actions work as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 13:58:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 11:58:42 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbit at rbit.cz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:11:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 12:11:31 +0000 Subject: [Koha-bugs] [Bug 15729] SIP server allows checkin of reserved item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15729 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #4 from Magnus Enger --- I have another variation on this. Some of my libraries would like the checkin to go through, but then the borrower should be alerted that the books sh/he just returned has one or more holds on it, so it needs to be placed somewhere special. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:59:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 12:59:10 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53699|0 |1 is obsolete| | --- Comment #39 from Bouzid --- Created attachment 56052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56052&action=edit Bug 12532 - Redirect guarantee email to guarantor Fixed merge conflicts. Both the guarantor and the guarantee will receive the email now. Also fixed some log errors since the "save" button is the same one use for editing the patron details. Changed the save button "save" id whene editing only the Patron messaging preferences so we can detect where the request is comming from. Added unit tests. Added an atomicupdate file. Reordered the sysprefs in alphabetical order. Refactored some code. TEST PLAN: I Apply the patch II Run updatedatabase.pl III Run db_dependent/Letters.t and db_dependant/Members.t 0) Enable EnhancedMessagingPreferences preference; 0) Enable EnableRedirectGuaranteeEmail preference; 1) Select a patron with child; 2) Enable Item checkout -> email in patron messaging preferences; 3) Select the patron's child; 4) Checkout an item; 5) Valide child checkout message in patron's inbox; sponsored by the ville de victoriaville Tested together with follow-up works as expected. Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 14:59:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 12:59:32 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53700|0 |1 is obsolete| | Attachment #55985|0 |1 is obsolete| | --- Comment #40 from Bouzid --- Created attachment 56053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56053&action=edit Bug 12532 - QA Follow-up Fixed tests, they now work without any fails https://bugs.koha-community.org/show_bug.cgi?id=12532 Signed-off-by: Marc pouet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:02:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 13:02:10 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #41 from Bouzid --- Fix conflict and rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:09:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 13:09:52 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:30:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 13:30:02 +0000 Subject: [Koha-bugs] [Bug 17392] opac/svc/overdrive_proxy is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:30:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 13:30:06 +0000 Subject: [Koha-bugs] [Bug 17392] opac/svc/overdrive_proxy is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56016|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 56054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56054&action=edit Bug 17392 - opac/svc/overdrive_proxy is not plack safe This patch simply replaces the ';' in the param passed to OverDrive with '&' To test: 1 - Enable overdrive (requires an account) 2 - Perform an opac search 3 - Note the number of overdrive results reported 4 - Click the link to view the actualt overdrive results 5 - Note the result numbers don't match 6 - Apply patch 7 - Repeat 1-4 and note results numbers match and results are relevant 8 - Test a search with a ';' to ensure this patch isn't breaking searches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:42:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 13:42:05 +0000 Subject: [Koha-bugs] [Bug 17403] New: Internal Server Error while deleting patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17403 Bug ID: 17403 Summary: Internal Server Error while deleting patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To reproduce: - Go to a patron's detail page - Toolbar : More : Delete - Confirm "Are you sure you want to delete..." Result: Internal Server Error Plack error log: exited nonzero: 1 at /home/marc/koha/members/deletemem.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:42:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 13:42:42 +0000 Subject: [Koha-bugs] [Bug 17403] Internal Server Error while deleting patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17403 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Priority|P5 - low |P1 - high Version|unspecified |master Severity|enhancement |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:47:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 13:47:33 +0000 Subject: [Koha-bugs] [Bug 17403] Internal Server Error while deleting patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17403 --- Comment #1 from Marc V?ron --- Created attachment 56055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56055&action=edit Bug 17403: Internal Server Error while deleting patron This patch fixes a Internal Server Error while deleting patrons. To reproduce: - Go to a patron's detail page - Toolbar : More : Delete - Confirm "Are you sure you want to delete..." Result: Internal Server Error Plack error log: exited nonzero: 1 at /home/marc/koha/members/deletemem.pl Note: Patron is deleted To test: - Apply patch - Re-start plack - Try to reproduce steps above (with other patron) Expected result: No Internal Server Error, Redirect to Home > Patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:48:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 13:48:29 +0000 Subject: [Koha-bugs] [Bug 17403] Internal Server Error while deleting patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17403 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 15:57:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 13:57:17 +0000 Subject: [Koha-bugs] [Bug 17376] rebuild_zebra.pl in daemon mode no database access kills the process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17376 --- Comment #4 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #3) > The error "Can't connect to local MySQL server through socket" will be > output to stderr anyway (regardless $verbose). Is it expected? Yes I think this is better to know it does not work. This log will end in daemon.log or journalctl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:03:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 14:03:37 +0000 Subject: [Koha-bugs] [Bug 17398] Enhance circulation message UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 --- Comment #4 from Owen Leonard --- I get this error on the circulation page after applying this patch: DBIx::Class::ResultSource::_resolve_join(): No such relationship manager on Message at kohaclone/Koha/Objects.pm line 168 Have I missed a step in the test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:05:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 14:05:00 +0000 Subject: [Koha-bugs] [Bug 15729] SIP server allows checkin of reserved item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15729 --- Comment #5 from Magnus Enger --- (In reply to Magnus Enger from comment #4) > I have another variation on this. Some of my libraries would like the > checkin to go through, but then the borrower should be alerted that the > books sh/he just returned has one or more holds on it, so it needs to be > placed somewhere special. When a book is returned on a self check machine, and the book has one or more holds on it, Koha adds these two fields to the checkin response: |CY (, )| So in theory, the self check machines that my customers have should be able to check if these fields are present, and act accordingly. If so, my scenario does not require any changes to Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:07:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 14:07:40 +0000 Subject: [Koha-bugs] [Bug 17404] New: Patron deletion page: Fix title and breadcrumb Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17404 Bug ID: 17404 Summary: Patron deletion page: Fix title and breadcrumb Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Title and breadcrumb of patron deletion page (deletemember.pl) say: "Can't Delete Patron". This should be changed to "Delete patron". To verify: - Go to a patron's detail page - Toolbar : More : Delete - You get a question: "Are you sure...", but title and breadcrumb say: "Can't Delete Patron" rsp "Cant delete patron" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:08:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 14:08:26 +0000 Subject: [Koha-bugs] [Bug 17404] Patron deletion page: Fix title and breadcrumb In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17404 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:10:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 14:10:14 +0000 Subject: [Koha-bugs] [Bug 17400] KOHA keeps requesting log-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17400 --- Comment #1 from Owen Leonard --- This sounds like it might be a support request rather than a bug report. Have you contacted your Koha support provider? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:11:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 14:11:28 +0000 Subject: [Koha-bugs] [Bug 17404] Patron deletion page: Fix title and breadcrumb In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17404 --- Comment #1 from Marc V?ron --- Created attachment 56056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56056&action=edit Bug 17404: Patron deletion page: Fix title and breadcrumb Title and breadcrumb of patron deletion page (deletemember.pl) say: "Can't Delete Patron". This should be changed to "Delete patron". To verify: - Go to a patron's detail page - Toolbar : More : Delete Result: You get a question: "Are you sure...", but title and breadcrumb say: "Can't Delete Patron" rsp "Cant delete patron" To test: - Apply patch - Repeat steps above. - Verify that title and breadcrumb display properly, including patron's name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:14:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 14:14:14 +0000 Subject: [Koha-bugs] [Bug 3841] Should have Default ACQ Framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:27:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 14:27:43 +0000 Subject: [Koha-bugs] [Bug 17398] Enhance circulation message UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17398 --- Comment #5 from Josef Moravec --- You will need to apply 17397 first and also update db structure and update dbix class files. Sorry to not mention it here... I'll add a schema change to 17397... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:40:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 14:40:36 +0000 Subject: [Koha-bugs] [Bug 17403] Internal Server Error while deleting patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17403 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56055|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 56057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56057&action=edit Bug 17403: Internal Server Error while deleting patron This patch fixes a Internal Server Error while deleting patrons. To reproduce: - Go to a patron's detail page - Toolbar : More : Delete - Confirm "Are you sure you want to delete..." Result: Internal Server Error Plack error log: exited nonzero: 1 at /home/marc/koha/members/deletemem.pl Note: Patron is deleted Additional tests: Try to delete yourself, to delete a staff member without having superlibrarian permission etc. To test: - Apply patch - Re-start plack - Try to reproduce steps above (with other patron) Expected result: No Internal Server Error, Redirect to Home > Patrons Amended to include all occurences of 'exit 1' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 16:50:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 14:50:43 +0000 Subject: [Koha-bugs] [Bug 11907] Status in search.pl doesn't match status in detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11907 --- Comment #2 from Christopher Brannon --- Still hoping someone will address this issue. A specific example: an item in transit for a hold shows as available on the search.pl screen. Since the item is on its way to fulfill a hold, it should either be in the unavailable list, or in an in transit list. It really is not available, but because it isn't checked out, it defaults to the available list. At the very least, this item should default to unavailable. If the item is just in transit to its home library, and there is no hold, it would make sense if it is in the available list at that point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:03:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 15:03:21 +0000 Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387 --- Comment #2 from Christopher Brannon --- I would love to see this resolved. I've even provided some clues to the problem. Any takers? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:37:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 15:37:22 +0000 Subject: [Koha-bugs] [Bug 17324] branchcode is NULL in letter triggers red upgrade message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17324 --- Comment #8 from M. Tompsett --- (In reply to Jonathan Druart from comment #7) > Mark, did you get how it happened? Ah. I think I figured out how. I got it to happen as a result of tweaking PRIMARY to UNIQUE (see bug 17234) as part of upgrade testing. Whereas, the preferred option, by other newer patches, was to change NULL to ''. NULL cascades nicely on relationships, '' does not in my experience. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:41:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 15:41:26 +0000 Subject: [Koha-bugs] [Bug 14885] Browser printed slips still using the 'email' transport slip content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14885 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Barton Chittenden --- *** This bug has been marked as a duplicate of bug 13498 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:41:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 15:41:26 +0000 Subject: [Koha-bugs] [Bug 13498] ISSUESLIP, ISSUEQSLIP use 'email' template for print. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #2 from Barton Chittenden --- *** Bug 14885 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:44:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 15:44:29 +0000 Subject: [Koha-bugs] [Bug 13498] ISSUESLIP, ISSUEQSLIP use 'email' template for print. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 --- Comment #3 from Barton Chittenden --- (In reply to Barton Chittenden from comment #2) > *** Bug 14885 has been marked as a duplicate of this bug. *** I've marked bug 14885 as a duplicate, but we should note that there are other slips affected -- RESERVESLIP comes to mind. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 17:52:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 15:52:00 +0000 Subject: [Koha-bugs] [Bug 17405] New: The creation of the url on cat-toolbar.inc is using obsolete current_framework Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Bug ID: 17405 Summary: The creation of the url on cat-toolbar.inc is using obsolete current_framework Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: rsantellan at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 56058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56058&action=edit Remove current_framework. When viewing a biblio the url generated for editing generated is with the parameters: current_framework that is not initialized anywhere. I remove it from the call edit record and Edit as new (duplicate). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:02:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 16:02:24 +0000 Subject: [Koha-bugs] [Bug 13498] ISSUESLIP, ISSUEQSLIP use 'email' template for print. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 --- Comment #4 from Barton Chittenden --- If we use the message transport type 'print', I believe that we may risk having the slips processed by gather_print_notices.pl. Perhaps we should introduce a message_transport_type of 'slip' for these? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:14:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 16:14:42 +0000 Subject: [Koha-bugs] [Bug 16245] RIS export file type incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16245 --- Comment #8 from H?ctor Eduardo Castro Avalos --- (In reply to Jonathan Druart from comment #7) > What is 'MANSCPT'? Hi Jonathan MANSCPT is "manuscript" according with official documentation This exist in UNIMARC and MARC21. This was coded as BOOK/GEN and is a wrong reference type. For example in UNIMARC you can find in Record label in position 6 (type of record) the value (b = language materials, manuscript) you can see more about it at MARC21 in Leader position 06 (type of record) is coded "t - Manuscript language material" and textually cite "Examples include marked or corrected galley and page proofs, manuscript books, legal papers, and unpublished theses and dissertations. " If librarian coded in MARC21 Leader/06 "t" or UNIMARC 000/6 "b" he or she is coding a manuscript and unplublished book rather than a published book. > Are the changes related to MANSCPT expected? Not was the expected but I think this is wrong coded as BOOK in UNIMARC and GEN in MARC21. So if we started comparing at this point this is wrong anyway. The expected was as Hugo pointed out in Description >Catalogue a record with LDR 6 and 7 'ab' --> this is an article >check the record type is article in koha leader But for this we need to see more subfields than leader 06 and leader 07. See "In Analytics" at MARC21 Journal article JOUR Leader/06 a Leader/07 a not b see examples at 773$7/02 a 773$7/03 s UNIMARC Journal article JOUR Leader/06 a Leader/07 a 461 But this needs more work, and if we include journal article we can include more reference types as annotated in comment 4 and I think (IMHO) this could be treat it in another bug. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 18:17:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 16:17:07 +0000 Subject: [Koha-bugs] [Bug 17324] branchcode is NULL in letter triggers red upgrade message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17324 --- Comment #9 from M. Tompsett --- I also just attempted playing around with upgrading and downgrading MySQL. http://repo.mysql.com/ It would seem that upgrading your MySQL to 5.7 isn't likely to encounter this problem. Anyways, this is explicit, rather than assuming MySQL's implicit tweaking of NULL to ''. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:24:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 19:24:49 +0000 Subject: [Koha-bugs] [Bug 17406] New: Simplify pay.pl interface - pt.1 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406 Bug ID: 17406 Summary: Simplify pay.pl interface - pt.1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I think we can simplify the payment screen. 1) Remove the Pay Amount button. By default, all items are selected, so the Pay selected will do the job. 2) Remove the cancel link. A) It's a link, not a button. B) All it does is change tabs. There isn't anything to really cancel. Changing tabs or navigating elsewhere does the same thing. 3) Remove Write off all button and replace with Write off selected button. 4) Remove the individual Pay and Write off buttons. They are redundant. #4 is my opinion, but they really convolute the flow. The checkboxes and two buttons are sufficient and straight forward. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:33:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 19:33:04 +0000 Subject: [Koha-bugs] [Bug 17406] Simplify pay.pl interface buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Simplify pay.pl interface - |Simplify pay.pl interface |pt.1 |buttons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:37:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 19:37:48 +0000 Subject: [Koha-bugs] [Bug 17408] New: paycollect.pl should show more information Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17408 Bug ID: 17408 Summary: paycollect.pl should show more information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When you click Pay selected on pay.pl, paycollect.pl should show a list of what is being paid as confirmation, and not just a total. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:37:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 19:37:20 +0000 Subject: [Koha-bugs] [Bug 17407] New: Fields cataloged using MARC21 880 are only searchable using keyword search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17407 Bug ID: 17407 Summary: Fields cataloged using MARC21 880 are only searchable using keyword search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org According to http://www.loc.gov/marc/bibliographic/bd880.html, the MARC21 880 field is used to store versions of other MARC21 fields that have a different representation than the main cataloged fields. This would be used, for instance, to hold title or author information not stored in a Latin character set. The 880 field is then linked back to 245 (Title), 100 (author), etc, via 880$6. The $6 subfield follows the linkage rules here: http://www.loc.gov/marc/bibliographic/ecbdcntf.html under '$6 - Linkage'. ... the linkage fields are used to give context -- which field / occurrence is being linked to, which language / is being used, and whether the script is written right-to-left or left-to-right. -- Without this development, titles cataloged using 880 fields can be searched using keyword searches, but searches using the linked title, author, subject are not searchable using title, author, subject searches. This will be an issue for both Zebra and Elastic search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:41:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 19:41:10 +0000 Subject: [Koha-bugs] [Bug 17407] Fields cataloged using MARC21 880 are only searchable using keyword search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17407 --- Comment #1 from Barton Chittenden --- Created attachment 56059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56059&action=edit Example data, marcxml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:42:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 19:42:05 +0000 Subject: [Koha-bugs] [Bug 17407] Fields cataloged using MARC21 880 are only searchable using keyword search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17407 --- Comment #2 from Barton Chittenden --- Created attachment 56060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56060&action=edit Example data, marc / utf8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:58:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 19:58:03 +0000 Subject: [Koha-bugs] [Bug 17409] New: Remove redundant note fields for payments on pay.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17409 Bug ID: 17409 Summary: Remove redundant note fields for payments on pay.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently there is an inconsistency with inputting notes on a payment. When you go to pay.pl, there is a note field for input next to each item. However, depending on what you select, there might be a following note field. That field is populated with the all the notes from the pay.pl screen if you click on Pay selected, blank if you click Pay amount, and not even an option if you Write off all. Having individual notes lumped together into one payment line might be confusing and depending on the notes, might not make any sense when the payment is made as a single payment. Because this enhancement is written in hopes that bug 17406 is accepted by the Koha community, I am making this dependent on those enhancements. 1) I suggest that the note fields be removed from the pay.pl page. 2) If bug 17406 is accepted, there will only be two buttons on the pay.pl screen: Pay selected and Write off selected. Regardless of which button is clicked, a summary page should come up showing what was selected, and totals. 3) The summary page should have a checkbox reading (use first note for all items). If checked, only the note field on the first item is active. If unchecked, all note fields are active. The default should be checked. 4) If there is only 1 item selected, the checkbox should not show. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:58:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 19:58:23 +0000 Subject: [Koha-bugs] [Bug 17409] Remove redundant note fields for payments on pay.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17409 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17406 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406 [Bug 17406] Simplify pay.pl interface buttons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 21:58:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 19:58:23 +0000 Subject: [Koha-bugs] [Bug 17406] Simplify pay.pl interface buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17409 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17409 [Bug 17409] Remove redundant note fields for payments on pay.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:05:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 20:05:37 +0000 Subject: [Koha-bugs] [Bug 17406] Simplify pay.pl interface buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406 --- Comment #1 from Christopher Brannon --- I'll add one more. Since a Write off means removing a fine/fee without payment we might consider: 5) Have only one action button at the bottom. It defaults to Pay selected, but a dropdown button to the side reveals Write off selected. If this is too controversial, perhaps it could be setup as an option in preferences. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:06:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 20:06:57 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #6 from Chris Cormack --- Created attachment 56061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56061&action=edit Bug 14242 Follow up, renaming syspref, there should be no changes OPACAutoFill -> OPACSuggestionAutoFill -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 22:44:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 20:44:16 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #7 from Chris Cormack --- > And lastly, not a problem but a question: In my test copyright date is never > populated. Is that a bug or a problem with Google Books' data? Yes, Google books API only hands back publication date, not copyright date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 23:00:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 21:00:52 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 23:00:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 21:00:56 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #8 from Chris Cormack --- Created attachment 56062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56062&action=edit Bug 14242 Follow up Change the icon to words Fix a bug that meant it would search on empty ISBN To test 1. Fill in a valid ISBN (Book data is correctly loaded) 2. Clear the ISBN from the field (Book data is correctly removed) 3. Tab away from the empty ISBN field: Data is loaded for a title "ISBN 0-9690745-2-2" 4. Apply patch 5. Repeat 1,2 and 3 notice a search is no longer done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 5 23:42:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 21:42:37 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com --- Comment #1 from Benjamin Daeuber --- I'd like to add to this that this is also patrons, not simply items and bibs. I think each one of these should be assigned a unique number, i.e. no item number should be assigned a number that already exists as a bib number or a patron number. I realize we can't fix existing records, but we can certainly ensure this doesn't happen going forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 00:10:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 22:10:33 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Depends on| |13624 --- Comment #47 from Chris Cormack --- Testing this now Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 00:10:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 22:10:33 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 [Bug 12772] Overdue Notice/Status triggers tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 00:33:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Oct 2016 22:33:02 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #48 from Chris Cormack --- Ok, this won't apply in its current form. The bugs it depends on have been pushed, but this is written to modify the sql of them. We can't do that, peoples databases will already have been upgraded. So we need a new atomic script to just make the changes that are needed now the other changes have been made. I will work on that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 04:23:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 02:23:12 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #29 from Nicholas van Oudtshoorn --- Hmmm - I don't see SelfCheckAllowByIPRanges preferencing suggesting one use /36. The library I've used should support something like /24, which is what the preference gives as a suggestion. Is /36 even a legal CIDR for ipv4? (I wouldn't have thought so - you'd be masking out more than the ipv4 address allows, I think...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 04:49:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 02:49:20 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45546|0 |1 is obsolete| | Attachment #45547|0 |1 is obsolete| | --- Comment #49 from Chris Cormack --- Created attachment 56063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56063&action=edit Bug 12772 : Update kohastructure.sql And add atomic update To rejig the overduerules table so more than 3 types of notices can be sent Also removes the letternumber column from overduerules_transport_types This patch will break the system until the others are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 07:30:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 05:30:53 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #30 from Marc V?ron --- (In reply to Nicholas van Oudtshoorn from comment #29) > Hmmm - I don't see SelfCheckAllowByIPRanges preferencing suggesting one use > /36. The library I've used should support something like /24, which is what > the preference gives as a suggestion. Is /36 even a legal CIDR for ipv4? (I > wouldn't have thought so - you'd be masking out more than the ipv4 address > allows, I think...) Sorry, my mistake... - Set SelfCheckAllowByIPRanges to 192.168.1.1 192.168.1.32/24 Allowed for clients with such IP's OK Client with other IP redirected to OPAC main page OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 07:32:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 05:32:37 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #31 from Marc V?ron --- Created attachment 56064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56064&action=edit Bug 14407 - Allow restricting SCO to IP or IP range Fix presence of tabs in files, and printslip refering to $query instead of $input Tested with scenarios above, works OK Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 07:33:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 05:33:28 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 07:35:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 05:35:35 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56064|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 07:36:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 05:36:48 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 07:38:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 05:38:52 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #32 from Marc V?ron --- Created attachment 56065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56065&action=edit Bug 14407 - Allow restricting SCO to IP or IP range Fix presence of tabs in files, and printslip refering to $query instead of $input Tested two patches together, with scenario above. Works OK Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 07:41:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 05:41:50 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56065|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 07:45:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 05:45:20 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55746|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 07:45:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 05:45:50 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56065|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 07:50:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 05:50:39 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56065|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 07:52:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 05:52:05 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55746|1 |0 is obsolete| | --- Comment #33 from Marc V?ron --- Comment on attachment 55746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55746 Latest version of patch, with errors fixed Sorry for the noise - made mistakes with the patches while signing off. Reset... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 08:15:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 06:15:13 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #34 from Marc V?ron --- Created attachment 56066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56066&action=edit Bug 14407 - Allow restricting SCO to IP or IP range Fix presence of tabs in files, and printslip refering to $query instead of $input Tested with scenarios above, works as expected. Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 08:15:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 06:15:41 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55746|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 08:16:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 06:16:03 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 10:12:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 08:12:55 +0000 Subject: [Koha-bugs] [Bug 17403] Internal Server Error while deleting patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17403 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 10:12:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 08:12:59 +0000 Subject: [Koha-bugs] [Bug 17403] Internal Server Error while deleting patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17403 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56057|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 56067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56067&action=edit Bug 17403: Internal Server Error while deleting patron This patch fixes a Internal Server Error while deleting patrons. To reproduce: - Go to a patron's detail page - Toolbar : More : Delete - Confirm "Are you sure you want to delete..." Result: Internal Server Error Plack error log: exited nonzero: 1 at /home/marc/koha/members/deletemem.pl Note: Patron is deleted Additional tests: Try to delete yourself, to delete a staff member without having superlibrarian permission etc. To test: - Apply patch - Re-start plack - Try to reproduce steps above (with other patron) Expected result: No Internal Server Error, Redirect to Home > Patrons Amended to include all occurences of 'exit 1' Signed-off-by: Chris Cormack Good catch Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 10:13:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 08:13:59 +0000 Subject: [Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 10:17:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 08:17:50 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #22 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #21) > (In reply to Jonathan Druart from comment #20) > > Created attachment 56012 [details] [review] [review] > > Bug 15341: Retrieve all sysprefs at once > > Jacek, did you have something like that in mind? Something like that, yes - i.e. that retrieving all sysprefs together from L2 cache, as a single data structure, should be (arguably) better then fetching 80-150 scalars individually per script run. I expect there will be some speed improvements involved (nothing really major, maybe 5-10 msec on average), but the main benefit from such change would be the possibility to use the upstream (L2) cache more effectively. E.g.: for a start: no more need to call ->flush_all() in clear_syspref_cache(), ->clear_from_cache("sysprefs") will do the trick, without clearing all other existing L2 cache entries. If you are using the single memcached instance for multiple tenants (or worse: storing user sessions in the very same cache), avoiding ->flush_all() like a plague may be kind of important. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 10:21:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 08:21:47 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #9 from Marc V?ron --- I like this feature very much, and it works nicely (with FF and IE). However I have following problem: If I indicate an ISBN like it is printed in a book, like e.g. 978-1-78416-110-1, I get a "Sorry, not found" I have to "normalize" the ISBEN to 9781784161101 in order get a result. Is it possible to do such normalizing for the search - but leaving the content of the ISBN field "as is"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 10:36:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 08:36:28 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #10 from Chris Cormack --- Yep, that is possible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 10:38:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 08:38:57 +0000 Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54920|0 |1 is obsolete| | --- Comment #2 from Benjamin Rokseth --- Created attachment 56068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56068&action=edit Bug 16694 - Limit SIP2 auth by patron attribute The main use case of this bug is to use patron attributes to grant special privileges, e.g. to open a door to an unmanned library. This patch adds an extra check against patron attributes if login account in SIPconfig.xml has a key validate_patron_attribute set to some patron attribute. If a patron information request is sent (63), and patron has proper rights in the given attribute: (a value of 1/true or some authorised value mapping to 1) The user will be allowed access (in SIP: charge and/or renewal ok). Otherwise denied. Please note that this is specific to the SIP login account, so self checkout machines can be handled differently than e.g. a door card terminal. To test: 0) you need to debug using telnet or the koha provided sip_client 1) add validate_patron_attribute="testattribute" to some login account in SIPconfig.xml 2) add a patron attribute "testattribute" 3) edit some patron and set "testattribute" to "1" 4) do a sip login with the given login account from SIPconfig.xml 5) do a patron information request (63) on the patron 6) observe that no charge or renewal denied is given in the response (64 ) 7) try all or any of the following: - set patron attribute to anything but "1" - delete the patron attribute - map the patron attribute to an authorized list, e.g. (YES_NO) and set it to a value that doesn't map to "1", e.g. "No". 8) do a patron information request (63) again 9) observe that charge and renewal is now denied in the SIP response (64YY) 10) thank yourself if noone else does and grab a coffee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 10:40:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 08:40:06 +0000 Subject: [Koha-bugs] [Bug 17392] opac/svc/overdrive_proxy is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 10:40:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 08:40:11 +0000 Subject: [Koha-bugs] [Bug 17392] opac/svc/overdrive_proxy is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56054|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 56069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56069&action=edit Bug 17392 - opac/svc/overdrive_proxy is not plack safe This patch simply replaces the ';' in the param passed to OverDrive with '&' To test: 1 - Enable overdrive (requires an account) 2 - Perform an opac search 3 - Note the number of overdrive results reported 4 - Click the link to view the actualt overdrive results 5 - Note the result numbers don't match 6 - Apply patch 7 - Repeat 1-4 and note results numbers match and results are relevant 8 - Test a search with a ';' to ensure this patch isn't breaking searches Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 10:48:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 08:48:01 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56062|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 56070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56070&action=edit Bug 14242 Follow up - Change the icon to words Fix a bug that meant it would search on empty ISBN To test 1. Fill in a valid ISBN (Book data is correctly loaded) 2. Clear the ISBN from the field (Book data is correctly removed) 3. Tab away from the empty ISBN field: Data is loaded for a title "ISBN 0-9690745-2-2" 4. Apply patch 5. Repeat 1,2 and 3 notice a search is no longer done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 10:51:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 08:51:19 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #12 from Chris Cormack --- Created attachment 56071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56071&action=edit Bug 14242 - Strip - from ISBN for serach purposes To test, enter a valid ISBN complete with - eg 978-1-78416-110-1 The search should still work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 10:58:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 08:58:38 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #13 from Marc V?ron --- Works great. It is still "assigned". I will have time to sign off in the afternoon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 11:01:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 09:01:54 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 11:55:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 09:55:08 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Jokin Perez de Vi?aspre changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jokin.lana at gmail.com --- Comment #13 from Jokin Perez de Vi?aspre --- Hi! If the results of the search is bigger than the page size, the pagination appears but it doesnt work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 11:59:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 09:59:39 +0000 Subject: [Koha-bugs] [Bug 17410] New: Export default Framework gives always empty file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17410 Bug ID: 17410 Summary: Export default Framework gives always empty file Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In koha 16.05.04 when tries to export the default framework, generates an emtpy file even choosing any format. In plack-error.log Use of uninitialized value $mode in string eq at /usr/share/koha/lib/C4/ImportExportFramework.pm line 212. Use of uninitialized value $mode in string eq at /usr/share/koha/lib/C4/ImportExportFramework.pm line 212. Use of uninitialized value $mode in string eq at /usr/share/koha/lib/C4/ImportExportFramework.pm line 232. Use of uninitialized value $mode in string eq at /usr/share/koha/lib/C4/ImportExportFramework.pm line 232. Use of uninitialized value $mode in string eq at /usr/share/koha/lib/C4/ImportExportFramework.pm line 249. Use of uninitialized value $mode in string eq at /usr/share/koha/lib/C4/ImportExportFramework.pm line 251. Use of uninitialized value $format in string eq at /usr/share/koha/intranet/cgi-bin/admin/import_export_framework.pl line 58. Use of uninitialized value $format in string eq at /usr/share/koha/intranet/cgi-bin/admin/import_export_framework.pl line 65. There is no problem when exporting any other framework TEsted in Koha 16.05.04 on Debian 8 with plack enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 13:20:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 11:20:09 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55949|0 |1 is obsolete| | --- Comment #14 from Marc V?ron --- Created attachment 56072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56072&action=edit Bug 14242: Use ISBN-field to automaticly fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automaticly fills requested fields with search result. Use in OPAC purchase suggestions to automaticly fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACAutoFill" 3. Log into OPAC and go to purchase suggetions page 4. Write a valid ISBN into the ISBN field and press the edit icon next to the field, or unfocus the field. 5. Title, Author, Publisher and Item Type fields should now be filled automaticly. 6. Press "undo" to undo - should restore all changed fields to original values Tested all patches together, works as expected. Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 13:21:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 11:21:01 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56061|0 |1 is obsolete| | --- Comment #15 from Marc V?ron --- Created attachment 56073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56073&action=edit Bug 14242 Follow up, renaming syspref, there should be no changes OPACAutoFill -> OPACSuggestionAutoFill Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 13:21:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 11:21:59 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56070|0 |1 is obsolete| | --- Comment #16 from Marc V?ron --- Created attachment 56074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56074&action=edit Bug 14242 Follow up - Change the icon to words Fix a bug that meant it would search on empty ISBN To test 1. Fill in a valid ISBN (Book data is correctly loaded) 2. Clear the ISBN from the field (Book data is correctly removed) 3. Tab away from the empty ISBN field: Data is loaded for a title "ISBN 0-9690745-2-2" 4. Apply patch 5. Repeat 1,2 and 3 notice a search is no longer done Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 13:23:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 11:23:15 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56071|0 |1 is obsolete| | --- Comment #17 from Marc V?ron --- Created attachment 56075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56075&action=edit Bug 14242 - Strip - from ISBN for serach purposes To test, enter a valid ISBN complete with - eg 978-1-78416-110-1 The search should still work Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 13:23:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 11:23:45 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:15:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 12:15:27 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 --- Comment #3 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #2) > Would not have been better to revive the patch from bug 14647? Bug 14647 manages exports made by a real user with the page form, it will not manage when export page is called from exporting checkouts : arg filename is not provided so it is then hardcoded. Maybe we can add an hidden input for filename but its more complicated I'd say. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:22:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 12:22:10 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #4 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Fridolin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:22:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 12:22:24 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:26:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 12:26:14 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 --- Comment #5 from Fridolin SOMERS --- (In reply to sandboxes at biblibre.com from comment #4) > Patch tested with a sandbox, by Fridolin I'm just testing our new sandboxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:36:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 12:36:09 +0000 Subject: [Koha-bugs] [Bug 17411] New: Change exit 1 to exit 0 in acqui/ basket.pl to prevent Internal Server Error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17411 Bug ID: 17411 Summary: Change exit 1 to exit 0 in acqui/basket.pl to prevent Internal Server Error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org In acqui/basket.pl line 236, the statement exit 1 is most likely to lead to an Internal Server Error. It should be exit 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:36:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 12:36:38 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:36:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 12:36:43 +0000 Subject: [Koha-bugs] [Bug 17411] Change exit 1 to exit 0 in acqui/ basket.pl to prevent Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17411 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:37:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 12:37:12 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56019|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:41:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 12:41:54 +0000 Subject: [Koha-bugs] [Bug 17411] Change exit 1 to exit 0 in acqui/ basket.pl to prevent Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17411 --- Comment #1 from Marc V?ron --- Created attachment 56076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56076&action=edit Bug 17411 - Change exit 1 to exit 0 in acqui/basket.pl to prevent Internal Server Error Note: Same situation as in Bug 17403 To test: - Verifiy that code change makes sense. Note: Same situation as in Bug 17403 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:43:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 12:43:30 +0000 Subject: [Koha-bugs] [Bug 17411] Change exit 1 to exit 0 in acqui/ basket.pl to prevent Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17411 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17403 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:43:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 12:43:30 +0000 Subject: [Koha-bugs] [Bug 17403] Internal Server Error while deleting patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17403 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17411 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 14:45:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 12:45:12 +0000 Subject: [Koha-bugs] [Bug 17404] Patron deletion page: Fix title and breadcrumb In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17404 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:43:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 13:43:14 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron at veron.ch --- Comment #14 from Marc V?ron --- Wanted to test, but sorry, does not apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:53:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 13:53:17 +0000 Subject: [Koha-bugs] [Bug 17410] Export default Framework gives always empty file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17410 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15057 CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:53:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 13:53:17 +0000 Subject: [Koha-bugs] [Bug 15057] Exporting Default Framework results in empty file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15057 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17410 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:56:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 13:56:07 +0000 Subject: [Koha-bugs] [Bug 17410] Export default Framework gives always empty file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17410 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16035 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 15:56:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 13:56:07 +0000 Subject: [Koha-bugs] [Bug 16035] MARC framework Export misbehaving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16035 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17410 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:03:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 14:03:10 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Fridolin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:03:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 14:03:24 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:10:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 14:10:30 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:10:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 14:10:44 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56019|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:11:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 14:11:08 +0000 Subject: [Koha-bugs] [Bug 17395] exporting checkouts in CVS generates a file with wrong extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395 --- Comment #7 from Fridolin SOMERS --- (In reply to sandboxes at biblibre.com from comment #6) > Patch tested with a sandbox, by Fridolin Aborted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:52:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 14:52:07 +0000 Subject: [Koha-bugs] [Bug 8016] Items are not tie to the transaction using "global" action. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8016 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila at ccsr.qc | |.ca | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 16:52:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 14:52:14 +0000 Subject: [Koha-bugs] [Bug 8016] Items are not tie to the transaction using "global" action. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8016 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 20:37:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 18:37:56 +0000 Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call number in layout definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 6 23:46:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Oct 2016 21:46:02 +0000 Subject: [Koha-bugs] [Bug 17412] New: Circulation rule for "not for loan" items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17412 Bug ID: 17412 Summary: Circulation rule for "not for loan" items Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: costalc at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries set items with a "not for loan" status mark (tag 952, subfield 7). But many times, it is needed to loan this material for few days. In Koha it is possible to check out "not for loan" items. But nevertheless it is not possible to set a circulation rule for these cases. So, it would be nice to add a column in the circulation rules parameters to set a new "not for loan period" column. Now, "not for loan" checkouts inherit the normal rule that is defined in the circulation rules parameters for it's itemtype. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 02:02:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 00:02:28 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45548|0 |1 is obsolete| | --- Comment #50 from Chris Cormack --- Created attachment 56077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56077&action=edit Bug 12772 - Overdue rules tool and backend library modified: C4/Overdues.pm modified: koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt modified: tools/overduerules.pl Note I had to do a lot of work to get this to apply. It won't work fully until the following patches are done. But attaching now so that we dont lose history of who wrote. Working on a follow up now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 03:11:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 01:11:09 +0000 Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 03:17:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 01:17:56 +0000 Subject: [Koha-bugs] [Bug 5655] printing of fines should support more than one line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5655 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 03:31:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 01:31:17 +0000 Subject: [Koha-bugs] [Bug 11340] make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 10:08:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 08:08:47 +0000 Subject: [Koha-bugs] [Bug 17413] New: Translatability: Rental fee, Renewal of Rental Item etc. are hard coded Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17413 Bug ID: 17413 Summary: Translatability: Rental fee, Renewal of Rental Item etc. are hard coded Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Descriptions for account lines are hard coded in C4/Criculation.pm, e.g. 'Rental', 'Rent', 'Renewal of Rental Item'. They are not translatable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 10:15:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 08:15:57 +0000 Subject: [Koha-bugs] [Bug 11217] The # in accountlines descriptions makes them un-writeoffable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11217 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Confirmed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 11:09:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 09:09:56 +0000 Subject: [Koha-bugs] [Bug 11217] The # in accountlines descriptions makes them un-writeoffable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11217 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 11:24:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 09:24:17 +0000 Subject: [Koha-bugs] [Bug 11217] The # in accountlines descriptions makes them un-writeoffable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11217 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 11:52:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 09:52:01 +0000 Subject: [Koha-bugs] [Bug 14953] Adlibris (Swedish supplier) cover image support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14953 Pontus Juth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pontusjuth at gmail.com --- Comment #1 from Pontus Juth --- There is another bug for this: 8630. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 14:27:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 12:27:45 +0000 Subject: [Koha-bugs] [Bug 16018] merges not modifying biblios properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #7 from Blou --- Another way of asking for testers, please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 14:43:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 12:43:25 +0000 Subject: [Koha-bugs] [Bug 17392] opac/svc/overdrive_proxy is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7172 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 [Bug 7172] Omnibus for Plack variable scoping problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 14:43:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 12:43:25 +0000 Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17392 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 [Bug 17392] opac/svc/overdrive_proxy is not plack safe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:59:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 14:59:22 +0000 Subject: [Koha-bugs] [Bug 11217] The # in accountlines descriptions makes them un-writeoffable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11217 --- Comment #3 from Marc V?ron --- Created attachment 56078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56078&action=edit Bug 11217: The # in accountlines descriptions makes them un-writeoffable This patch adds escaping to url params in mambers/pay.pl To test: - Apply patch - Go to Home > Patrons > Manual invoice and create an invoice with a description containing a # - Go to tab "Pay fines" - Write off the fine Expected result: Fine is written off and does no longer display in pay tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 16:59:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 14:59:59 +0000 Subject: [Koha-bugs] [Bug 11217] The # in accountlines descriptions makes them un-writeoffable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11217 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:11:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 15:11:53 +0000 Subject: [Koha-bugs] [Bug 17414] New: Add GIR codes added to Edifact since 1.2 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17414 Bug ID: 17414 Summary: Add GIR codes added to Edifact since 1.2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org 4 new GIR codes have been added to Edifact since version 1.2 see http://www.editeur.org/files/EDIfact%20eancom%20pdfs/EDIfact%20library%20supply/100204%20EDItEUR%20Library%20EDI%20changes.pdf The following codes have been added to DE 7405: LHC Library Holding Code: may hold a combination of information i ncluding location , sequence, item type etc. as a single data string (contents defined by the library). LRP Library Rotation Plan: a code number assigned by a library to identify a rotation plan to which an item belongs. LSC Statistical category: a c ode used by a library to identify a statistical category (e.g. ?605? or ?Children?s Picture Books?) for management reporting purposes. RIC Reader Interest Category: code to identify stock at a lower level than LST (Stock Category) eg. Western, Science Fiction. These need to be added to list of recognized codes for future developments ( e.g. to include Stock Rotation intp in LRP ) to be able to utilize these -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:19:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 15:19:25 +0000 Subject: [Koha-bugs] [Bug 17414] Add GIR codes added to Edifact since 1.2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17414 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 56079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56079&action=edit Proposed patch No new code merely adds the four new codes to the list so that extract_gir recognizes them. This is to allow their use by future development -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:57:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 15:57:55 +0000 Subject: [Koha-bugs] [Bug 17405] The creation of the url on cat-toolbar.inc is using obsolete current_framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Rodrigo Santellan changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:59:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 15:59:35 +0000 Subject: [Koha-bugs] [Bug 11926] HEA - Report usage statistics to Koha community In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14707 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 [Bug 14707] Change UsageStatsCountry from free text to a dropdown list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 17:59:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 15:59:35 +0000 Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry from free text to a dropdown list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926 [Bug 11926] HEA - Report usage statistics to Koha community -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 18:16:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 16:16:59 +0000 Subject: [Koha-bugs] [Bug 12497] OPAC search history page should only be accessible when feature is activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 18:20:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 16:20:53 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|enhancement |major --- Comment #3 from Marc V?ron --- Tested on current master. I can reproduce the scenario from initial comment. The behavior seems to be intended, see C4/Auth.pm lines 334 ff: # And if there are searches performed when the user was not logged in, # we add them to the logged-in search history On public computer rsp. a computer used by several persons, previous searches will be added to the (private!) search history of the patron who logs in. That should not happen! Changing status to "major" because patron data is arbitrarily changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 18:23:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 16:23:50 +0000 Subject: [Koha-bugs] [Bug 9699] Allow patrons to see notices sent to them in their OPAC account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9699 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 18:41:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 16:41:53 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 --- Comment #12 from Bouzid --- Created attachment 56080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56080&action=edit Bug5620 - Add tests for sub GetKohaAuthorisedValues -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 18:42:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 16:42:21 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 18:47:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 16:47:08 +0000 Subject: [Koha-bugs] [Bug 15792] Double-clicking the 'renew' button on circulation.pl will double-charge account management fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15792 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Confirmed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 7 23:06:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 21:06:39 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #40 from Blou --- That's an easy change, but is this a requirement? I think it would be more precise, but maybe some would not like this new "unpersonnal phrasing" ? An easy fix, just let us know if required to reach Signed Off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 00:10:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 22:10:55 +0000 Subject: [Koha-bugs] [Bug 16149] Generate and send custom notices based on report output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 00:15:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 22:15:31 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 00:16:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 22:16:14 +0000 Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 00:18:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Oct 2016 22:18:43 +0000 Subject: [Koha-bugs] [Bug 15494] Make Longoverdue/Lost items not renewable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 12:26:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2016 10:26:30 +0000 Subject: [Koha-bugs] [Bug 10135] Adding the ability to define customised basketgroups pdf layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 8 19:23:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Oct 2016 17:23:07 +0000 Subject: [Koha-bugs] [Bug 17415] New: Search for parent bib record fails when link clicked in child Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17415 Bug ID: 17415 Summary: Search for parent bib record fails when link clicked in child Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org When a child bib record is linked to a parent bib record, a link to the parent record shows below the child title, such as: Test Fiction Title for Kindle [Coeur d'Alene] [eBook] In: High demand fiction [Coeur d'Alene] Amazon.com, Inc The link below the title to the parent record, such as above in the "In" line is incorrect. When you click on the link, it does a title phrase search, but it is including the 101a field (author), which makes the search fail. Either the 101a field needs to be omitted in a title phrase search, or the search needs to be changed to either a keyword search or a combo search. Seems like this link should go right to the bib record number rather than doing a search of any kind, since it is already linked. Current workaround is to edit the child record and delete the author in the field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 02:21:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2016 00:21:20 +0000 Subject: [Koha-bugs] [Bug 2237] Use primary email address as Koha login account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2237 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #4 from Christopher Brannon --- Many families utilize the same e-mail address for more than one library card. What is the solution for this? Will the single e-mail login prompt you to pick the family member and enter their password? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 08:48:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2016 06:48:16 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Jerwyn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |os.jerwynfernandez at gmail.co | |m --- Comment #6 from Jerwyn --- Hi Mark, Thanks a lot for your inputs! Dear David, This feature will be useful for those libraries that has multiple branches miles and miles away, that employees usually come and go often. The mother library or main library who registers the patron accounts in Koha is having a hard time tracking them down. With the centralized email registration in gmail they can limit all the automatic registration in Koha limiting it to its domain name. This would be a great feature for those libraries that has a single patron category however, it may have implications with libraries that has different circulation policies, for different patron categories. Looking forward to this. Thank you and best regards! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 14:42:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2016 12:42:00 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #7 from M. Tompsett --- Jerwyn, I think you missed David's point. This does not limit to a particular domain. Though, you do bring up a valid counter point, but would need further implementation. Google does provide domain hosting capabilities which those using their services do control the domain. There is currently no logic in this code to actually limit the domain, which is what David is complaining about, I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 14:44:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2016 12:44:26 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #8 from M. Tompsett --- Comment on attachment 53257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53257 Bug 16892: Add automatic patron registration via OAuth2 login Review of attachment 53257: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16892&attachment=53257) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref @@ +161,2 @@ > - Google OpenID Connect Restrict to domain (or subdomain of this domain) > - pref: GoogleOpenIDConnectDomain Oh wait. That is already implemented. Next problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 16:02:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2016 14:02:33 +0000 Subject: [Koha-bugs] [Bug 2237] Use primary email address as Koha login account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2237 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16711 --- Comment #5 from Marc V?ron --- (In reply to Christopher Brannon from comment #4) > Many families utilize the same e-mail address for more than one library > card. What is the solution for this? Will the single e-mail login prompt > you to pick the family member and enter their password? That is somehow already a problem, see: Bug 16711 - OPAC Password recovery: Handling if multiple accounts have the same mail address -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 9 16:02:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Oct 2016 14:02:33 +0000 Subject: [Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2237 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 05:48:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 03:48:27 +0000 Subject: [Koha-bugs] [Bug 17178] Add a popup/ keyboard shortcuts for diacritics and symbols in the cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Irma Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |irma at calyx.net.au --- Comment #1 from Irma Birchall --- 3) Also macrons like in the word ?M?ori? should be included. A macron is a line above a vowel to indicate that it should be spoken as a long vowel: ?, ?, ?, ?, ?, ?, ?, ?, ? and ?. The M?ori word for macron is tohut? (or p?tae - hat). For more detailed information on its use, see M?ori Orthographic Conventions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 06:00:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 04:00:21 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #9 from Jerwyn --- Created attachment 56081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56081&action=edit domain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 06:01:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 04:01:00 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #10 from Jerwyn --- Yeap good thing its already available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 08:50:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 06:50:32 +0000 Subject: [Koha-bugs] [Bug 11943] AcceptShare should check for double accepts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 --- Comment #4 from Marcel de Rooy --- (In reply to Marc V?ron from comment #3) > Still valid? It probably is. Unless you can prove that it is no longer? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 09:34:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 07:34:21 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #330 from Marcel de Rooy --- >From the general mailing list: It seems that I missed the election as Bug wrangler (continued) for Koha 16.11, see: https://wiki.koha-community.org/wiki/Roles_for_16.11 That's why I kindly request to be listed in the release team for 16.11, as I was for previous versions. Thanks and kind regards Marc V?ron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 10:03:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 08:03:47 +0000 Subject: [Koha-bugs] [Bug 17405] The creation of the url on cat-toolbar.inc is using obsolete current_framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |rsantellan at gmail.com Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 10:05:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 08:05:54 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 --- Comment #20 from Nick Clemens --- I prefer to show 'Holds (0)' when there are no holds, this is how it is currently done on the details page. If we want to display nothing then we should alter the details page to be 'Holds' instead of 'Holds (0)' Happy to do it either way, but want it to be consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 10:22:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 08:22:53 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 10:22:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 08:22:58 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 --- Comment #21 from Nick Clemens --- Created attachment 56082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56082&action=edit Bug 14876 (QA Followup) Don't show (0) as holds counts when no holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 10:25:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 08:25:49 +0000 Subject: [Koha-bugs] [Bug 17405] The creation of the url on cat-toolbar.inc is using obsolete current_framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 10:25:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 08:25:54 +0000 Subject: [Koha-bugs] [Bug 17405] The creation of the url on cat-toolbar.inc is using obsolete current_framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 --- Comment #1 from Owen Leonard --- Created attachment 56083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56083&action=edit Bug 17405 - The creation of the url on cat-toolbar.inc is using obsolete current_framework When viewing a biblio the url generated for editing generated is with the parameters: current_framework that is not initialized anywhere. This patch removes the parameter because it is not necessary To test, apply the patch and view the detail page for a bibliographic record which uses a framework other than the default. Test that the "Edit" and "Edit as new (duplicate)" loads the MARC editor using the correct framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 10:26:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 08:26:17 +0000 Subject: [Koha-bugs] [Bug 17405] The creation of the url on cat-toolbar.inc is using obsolete current_framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56058|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 10:29:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 08:29:29 +0000 Subject: [Koha-bugs] [Bug 17405] The creation of the url on cat-toolbar.inc is using obsolete current_framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 --- Comment #2 from Owen Leonard --- Rodrigo, I took the attachment you posted and formatted it as a patch. There is information on the wiki about how to create patches: https://wiki.koha-community.org/wiki/Version_Control_Using_Git#Doing_work_on_Koha_with_Git Take a look and feel free to ask questions if you need help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 10:49:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 08:49:40 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:10:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 09:10:51 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55556|0 |1 is obsolete| | Attachment #55557|0 |1 is obsolete| | Attachment #55558|0 |1 is obsolete| | Attachment #55559|0 |1 is obsolete| | Attachment #55560|0 |1 is obsolete| | Attachment #55561|0 |1 is obsolete| | Attachment #55569|0 |1 is obsolete| | --- Comment #207 from Kyle M Hall --- Created attachment 56084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56084&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:11:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 09:11:12 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #208 from Kyle M Hall --- Created attachment 56085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56085&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:11:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 09:11:19 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #209 from Kyle M Hall --- Created attachment 56086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56086&action=edit Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:11:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 09:11:26 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #210 from Kyle M Hall --- Created attachment 56087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56087&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:11:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 09:11:37 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #211 from Kyle M Hall --- Created attachment 56088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56088&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:11:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 09:11:45 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #212 from Kyle M Hall --- Created attachment 56089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56089&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:11:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 09:11:56 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #213 from Kyle M Hall --- Created attachment 56090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56090&action=edit Bug 14610 [QA Followup] - Implement staff patron tab Also fixes a few other minor issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:50:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 09:50:24 +0000 Subject: [Koha-bugs] [Bug 17416] New: Move javascript in doc-head-close.inc into a separate include Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 Bug ID: 17416 Summary: Move javascript in doc-head-close.inc into a separate include Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org I would like to move the staff client JavaScript assets from the header to the footer. This is a best practice for speed because pages can begin rendering before all JavaScript is loaded. This bug is a first step which shouldn't affect any JS behavior. It will move the parts of doc-head-close.inc which relate to JavaScript into a separate file, js_includes.inc. A later patch will move the include into the footer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 11:52:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 09:52:36 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 fpichenot at ville-roubaix.fr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |fpichenot at ville-roubaix.fr --- Comment #46 from fpichenot at ville-roubaix.fr --- This patch doesn't apply, I get this message : Can't locate C4/Branch.pm in @INC (@INC contains: /home/sandbox1/src /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /home/sandbox1/src/reports/suggestions_stats.pl line 27. BEGIN failed--compilation aborted at /home/sandbox1/src/reports/suggestions_stats.pl line 27. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 12:02:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 10:02:35 +0000 Subject: [Koha-bugs] [Bug 17384] Categories do not display in patron editing form if they have only one category assigned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17384 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher --- Pushed to Master - Should be in the November Release 16.11 - Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 12:06:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 10:06:50 +0000 Subject: [Koha-bugs] [Bug 17345] Typo in sysprefs.sql prevents all systempreferences from being installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17345 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher --- Pushed to Master - Should be in the November Release 16.11 - Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 12:07:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 10:07:06 +0000 Subject: [Koha-bugs] [Bug 17403] Internal Server Error while deleting patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17403 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I can't reproduce the problem under Plack - patron got deleted just fine. What am I missing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 12:16:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 10:16:36 +0000 Subject: [Koha-bugs] [Bug 17324] branchcode is NULL in letter triggers red upgrade message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17324 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the November Release 16.11 - Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 12:21:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 10:21:56 +0000 Subject: [Koha-bugs] [Bug 17396] t/DataTables/Members.t is unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17396 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 12:21:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 10:21:59 +0000 Subject: [Koha-bugs] [Bug 17396] t/DataTables/Members.t is unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17396 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56039|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 56091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56091&action=edit [PASSED QA] Bug 17396: Remove unnecessary t/DataTables/Members.t is unnecessary tests The subroutine C4::Utils::DataTables::Members::search is covered by tests from t/db_dependent/Utils/Datatables_Members.t Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 12:28:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 10:28:40 +0000 Subject: [Koha-bugs] [Bug 17394] exporting checkouts with items selects without items in combo-box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17394 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 12:28:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 10:28:46 +0000 Subject: [Koha-bugs] [Bug 17394] exporting checkouts with items selects without items in combo-box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17394 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56020|0 |1 is obsolete| | --- Comment #3 from Jesse Maseto --- Created attachment 56092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56092&action=edit Bug 17394 - exporting checkouts with items selects without items in combo-box In checkouts table, the is an export form (when some exports syspref are enabled). When selecting some checkouts and selecting "ISO2709 with items" in export format combo-box, clicking on "Export" will select "ISO2709 without items" in the export format combo-box. This is quite strange. Its because the form as 2 inputs with same name and id "output_format" : an hidden input (the wanted arg for tools/export.pl) and a select (the export format combo-box). So an action meant on the hidden input impacts the select. This patch corrects by changing id and name of the export format combo-box : issues-table-output-format TEST plan : - Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile - Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx - Show checkouts table - Select some checkboxes in "Export" column - Select "ISO2709 with items" in export format combo-box - Click on "Export" => Without patch, the export format combo-box changes to "ISO2709 without items" => With patch, the export format combo-box does not changes - Check the export file contains the items - Check exports "ISO2709 without items" and "CSV" are OK Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 12:34:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 10:34:11 +0000 Subject: [Koha-bugs] [Bug 17292] Use of DBIx in updatedatabase.pl broke upgrade (from bug 12375 ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17292 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the November Release 16.11 - Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:07:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 11:07:00 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55489|0 |1 is obsolete| | --- Comment #331 from Marcel de Rooy --- Created attachment 56093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56093&action=edit Bug 7143: Release team for 16.11 Also adding Marc Veron as bug wrangler (see his mail on the general ml dated Oct 5). Test plan: Verify changes by comparing with Roles for 16.11 page on the wiki. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:07:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 11:07:58 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #332 from Marcel de Rooy --- (In reply to M. Tompsett from comment #329) > I think the previous way better indicates a continuity that this version is > unclear about as people may not have noticed the context above. > If she has been Documentation Manager contiguously since 3.0, wouldn't a > hypen (3.0 - 16.05) be better? Patch adjusted accordingly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 13:44:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 11:44:43 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #42 from Marcel de Rooy --- (In reply to Fr?d?ric Demians from comment #8) > > Having complete test coverage is even better. > > Now, there isn't any test at all now. So modularizing is a first step. If > you want tests, add them. And don't forget UT for you own patch which modify > a lot of OAI server code without guaranty it won't something somewhere. Frederic, the absence of unit tests in this patch set might be a reason for these patches getting stuck in the SO queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:10:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:10:21 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56093|0 |1 is obsolete| | Attachment #56093|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:15:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:15:05 +0000 Subject: [Koha-bugs] [Bug 17417] New: Correct invalid markup around news on the staff client home page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Bug ID: 17417 Summary: Correct invalid markup around news on the staff client home page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org There are a couple of HTML validation errors in the area of the staff client home page template related to displaying news. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:15:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:15:18 +0000 Subject: [Koha-bugs] [Bug 17417] Correct invalid markup around news on the staff client home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:17:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:17:49 +0000 Subject: [Koha-bugs] [Bug 17417] Correct invalid markup around news on the staff client home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:17:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:17:54 +0000 Subject: [Koha-bugs] [Bug 17417] Correct invalid markup around news on the staff client home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417 --- Comment #1 from Owen Leonard --- Created attachment 56094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56094&action=edit Bug 17417 - Correct invalid markup around news on the staff client home page This patch fixes two minor errors in the markup around displaying news on the staff client home page: Adding a missing "class" attribute, and changing the container around news items from

to

(because news items might contain

and nesting them is incorrect). To test, apply the patch and view the staff client home page with news items showing. Validate the page and confirm that there are no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:27:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:27:09 +0000 Subject: [Koha-bugs] [Bug 17088] Bad MARC XML can halt export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17088 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #11 from Brendan Gallagher --- Pushed to Master - Should be in the November Release 16.11 - Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:32:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:32:13 +0000 Subject: [Koha-bugs] [Bug 17396] t/DataTables/Members.t is unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17396 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the November Release 16.11 - Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:32:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:32:53 +0000 Subject: [Koha-bugs] [Bug 17404] Patron deletion page: Fix title and breadcrumb In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17404 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:32:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:32:56 +0000 Subject: [Koha-bugs] [Bug 17404] Patron deletion page: Fix title and breadcrumb In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17404 --- Comment #2 from Claire Gravely --- Created attachment 56095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56095&action=edit Bug 17403: Patron deletion page: Fix title and breadcrumb Title and breadcrumb of patron deletion page (deletemember.pl) say: "Can't Delete Patron". This should be changed to "Delete patron". To verify: - Go to a patron's detail page - Toolbar : More : Delete Result: You get a question: "Are you sure...", but title and breadcrumb say: "Can't Delete Patron" rsp "Cant delete patron" To test: - Apply patch - Repeat steps above. - Verify that title and breadcrumb display properly, including patron's name Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:34:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:34:27 +0000 Subject: [Koha-bugs] [Bug 17310] Broken URLs in 'Item renewed' / 'Cannot renew' messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the November Release 16.11 - Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:38:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:38:42 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #333 from Marcel de Rooy --- Hmm. Already in master? Not a big deal, but not via the main road :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:40:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:40:18 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51982|0 |1 is obsolete| | --- Comment #23 from Julian Maurice --- Created attachment 56096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56096&action=edit Bug 13323: Tax rate can change on receiving - DB changes This patch adds 4 new DB fields to the aqorders table: * tax_rate_on_ordering * tax_rate_on_receiving * tax_value_on_ordering * tax_value_on_receiving Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:40:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:40:23 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51983|0 |1 is obsolete| | --- Comment #24 from Julian Maurice --- Created attachment 56097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56097&action=edit Bug 13323: Tax rate can change on receiving This commit permits to update the tax rate on receiving. Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:40:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:40:29 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51984|0 |1 is obsolete| | --- Comment #25 from Julian Maurice --- Created attachment 56098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56098&action=edit Bug 13323: QA fix (trailing whitespace) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:42:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:42:17 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #334 from Brendan Gallagher --- Sorry Marcel - just pushed ;) We asked Jesse to obsolete it for us ;) Hope you are well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:47:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:47:27 +0000 Subject: [Koha-bugs] [Bug 13376] Include a user-editable area/ page for terms and conditions of use in the opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 --- Comment #3 from Olli-Antti Kivilahti --- We have cut this feature from the scope of our current self-service automation project. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:49:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:49:17 +0000 Subject: [Koha-bugs] [Bug 13376] Include a user-editable area/ page for terms and conditions of use in the opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 --- Comment #4 from Olli-Antti Kivilahti --- The reason being. We need to have a stronger level of authentication than simple username + password. For example a strong authentication from the national identification service would suffice. This is out of scope as well :) Regional and Country differences apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:51:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:51:00 +0000 Subject: [Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 10 14:51:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Oct 2016 12:51:05 +0000 Subject: [Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 --- Comment #1 from Owen Leonard --- Created attachment 56099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56099&action=edit Bug 17416 - Move javascript in doc-head-close.inc into a separate include In order to prepare to move staff client javascript assets into the footer, this patch creates a new include file containing all " Save and look at the data Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 11:34:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2016 09:34:03 +0000 Subject: [Koha-bugs] [Bug 17423] patronimage.pl permission is too restrictive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17423 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56136|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS --- Created attachment 56150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56150&action=edit Bug 17423 - patronimage.pl permission is too restrictive Bug 14566 added the permission "borrowers" on patronimage.pl. This perm is too restrictive because circulation pages also uses this page. I propose to simply use "catalogue" perm. Test plan - Set an image to borrower xx - Create a user with only catalogue permission - Log with this user - Go to page (replace xx by borrower number) : /cgi-bin/koha/members/patronimage.pl?borrowernumber=xx => Without patch you get the page saying you do not have the permission => With patch you get the image - Log out and retest the page patronimage.pl => You get 403 error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 11:39:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2016 09:39:21 +0000 Subject: [Koha-bugs] [Bug 17392] opac/svc/overdrive_proxy is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 11:39:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2016 09:39:24 +0000 Subject: [Koha-bugs] [Bug 17392] opac/svc/overdrive_proxy is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17392 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56069|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 56151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56151&action=edit [PASSED QA] Bug 17392 - opac/svc/overdrive_proxy is not plack safe This patch simply replaces the ';' in the param passed to OverDrive with '&' To test: 1 - Enable overdrive (requires an account) 2 - Perform an opac search 3 - Note the number of overdrive results reported 4 - Click the link to view the actual overdrive results 5 - Note the result numbers don't match 6 - Apply patch 7 - Repeat 1-4 and note results numbers match and results are relevant 8 - Test a search with a ';' to ensure this patch isn't breaking searches Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Verified by reading code - couldn't verify using Overdrive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 11:45:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2016 09:45:06 +0000 Subject: [Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 11 11:45:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Oct 2016 09:45:11 +0000 Subject: [Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56099|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 56152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56152&action=edit Bug 17416 - Move javascript in doc-head-close.inc into a separate include In order to prepare to move staff client javascript assets into the footer, this patch creates a new include file containing all