[Koha-bugs] [Bug 11943] AcceptShare should check for double accepts

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943

Marc Véron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16711

--- Comment #5 from Marc Véron <veron at veron.ch> ---
(In reply to Marcel de Rooy from comment #4)
> (In reply to Marc Véron from comment #3)
> > Still valid?
> It probably is. Unless you can prove that it is no longer?

Still valid.

At the moment you send an inivtation, an entry is created in table
virtualshelfshares.
The table does not know, where the invitation went to (borrowernumber is NULL),
mail address of invitee is not captured).

After confirmation (link contained in mail), the borrowernumber is filled in
with the inviteed's number, and the invitee is redirected to the list as
appropriate.

If the list owner created two invitations, we have two entries in
virtualshelfshares. No chance to find out that the invitee already has been
invited.

With 2 invitations, invitee gets 2 mails (as expected from findings above and
as described in initial comment).
Clicking on the link in the first mail results in following message:
"Sorry, but we could not accept this key. The invitation may have expired.
Contact the patron who sent you the invitation."

Clicking on the link in the 2nd mail works and shows the list.

If I delete the list, both entries are removed from virtualshelfshares.

-----------

Hmm, what happens if I have 2 patrons with the same email address?

Sending an invitation with this email address creates 1 entry in
virtualshelfshares and 1 invitation mail. 

Clicking on the link takes me to the OPAC login screen. The first of the 2
patrons who logs in wins the race.

We have something similar with password resetting requests, see
Bug 16711 - OPAC Password recovery: Handling if multiple accounts have the same
mail address
and it would be a problem with:
Bug 2237 - Use primary email address as Koha login account

-- 
You are receiving this mail because:
You are watching all bug changes.