[Koha-bugs] [Bug 17403] Internal Server Error while deleting patron

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17403

--- Comment #7 from Marc Véron <veron at veron.ch> ---
(In reply to David Cook from comment #6)
> Comment on attachment 56067 [details] [review]
> Bug 17403: Internal Server Error while deleting patron
> 
> Review of attachment 56067 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: members/deletemem.pl
> @@ -98,4 @@
> >      if ( !C4::Context->IsSuperLibrarian() && $bor->{'branchcode'}){
> >          unless ($userenv->{branch} eq $bor->{'branchcode'}){
> >              print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_OTHERLIBRARY");
> > -            exit;
> 
> "exit" is the same as "exit 0", so this doesn't really matter, but I'm
> certainly in favour of a consistent approach. 
> 
> Why use "exit 0" over "exit" though? Just to be more explicit?

Yes. I prefer it because it clearly shows the intention.
BTW, it's used at many other places as well ( git grep 'exit 0' ).

-- 
You are receiving this mail because:
You are watching all bug changes.