[Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Oct 12 15:49:43 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56251|0                           |1
        is obsolete|                            |

--- Comment #18 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 56281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56281&action=edit
Bug 17008: Test to compare Swagger property types against column data types

This patch adds a test that iterates through each definition-object in Swagger
and compares their properties' data types to corresponding Koha-object's
column's
data type by using Koha::Util::Swagger::column_type_to_swagger_type().

This test will also check if the column is nullable and will complain
unless property has also "null" defined in its type.

To test:
1. Run t/db_dependent/api/v1/swagger/definitions.t
2. Observe that tests pass (if not, open a Bug to fix issues)
3. Modify api/v1/swagger/definitions/patron.json cardnumber to be type
"integer".
4. Run the test again.
5. Observe that test fails and will complain about incorrect data type.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list