[Koha-bugs] [Bug 17441] t/db_dependent/Letters.t fails on Jenkins

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17441

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
>From Jenkins:
#   Failed test 'Successfully sent claim'
#   at t/db_dependent/Letters.t line 431.
#          got: undef
#     expected: '1'
# Looks like you failed 1 test of 74.
[15:18:31] t/db_dependent/Letters.t .................................. 

By returning 1, you will resolve this issue on Jenkins.
But the change itself is somewhat obscure now.

Looking further, we never really defined what SendAlerts should really return.
In most cases we call like: $err=SendAlerts(...)
In some cases SendAlerts warns and returns undef on an error.
Or carps and returns { error => ... }

Another line in Letters.t tests the results of SendAlerts with 
is($err2, "", "Successfully sent serial notification");

Added a follow-up to return 1 on success and add some consistency on the
sendmail calls in SendAlerts. Adjusted the one line in Letters.t.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.