[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Oct 24 11:08:49 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 56555
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56555
Bug 17428: [REST] Cities swagger specification

Review of attachment 56555:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17428&attachment=56555)
-----------------------------------------------------------------

Minor query regarding returned serialised bodies

::: api/v1/swagger/definitions/city.json
@@ +3,5 @@
> +  "properties": {
> +      "cityid": {
> +        "$ref": "../x-primitives.json#/cityid"
> +      },
> +      "city_name": {

Does this not break our own rule of following the UI term.. I feel this should
simply be 'name' and not expose the db field names to the end user (the api
consumer in this case).

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list