[Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
            Version|unspecified                 |master
             Status|Signed Off                  |Passed QA

--- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Looks good to me.
Few small remarks.

As mentioned, would be good to keep consistency between ISBN -- ISSN stuff.
Returning the invalid one for ISSN will not lead to much discussion, since this
is just new. I prefer it. ISBN side is not new, might raise discussion..

Using the private routine _issn is not recommended.

Too bad this has a relation with the unfinished QueryParser..

I also tested with 1234-5679 (some text)
You could also imagine importing 1234-5679 (text) while only having 1234-5679
in the database? Should this match or not? Depends on your length set in the
rule too.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.