[Koha-bugs] [Bug 15906] Remove use of makepayment in paycollect.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906

Michael Kuhn <mik at adminkuhn.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #9 from Michael Kuhn <mik at adminkuhn.ch> ---
I succesfully applied patches 15896 and 15906.

In a user account some reasons for payments were created. In the leftside-tab
"Details" I click on "Make payment" and the individual fines & charges are
shown. One is selected, then the button "Pay" on the right is clicked. Now the
system asks for confirmation and the amount is paid.

(So I can't reproduce the message "Software error: ..." from 2016-07-30 anymore
and evyerything looks alright).

I made another paymont via button "Pay amount" and this works also as I expect
it.

I then created a fee of 7, table "accountlines" looks as follows.

mysql> select accounttype, amount, amountoutstanding, lastincrement, timestamp
from accountlines;
+-------------+------------+-------------------+---------------+---------------------+
| accounttype | amount     | amountoutstanding | lastincrement | timestamp     
     |
+-------------+------------+-------------------+---------------+---------------------+
| N           |   7.000000 |          7.000000 |          NULL | 2016-10-29
12:33:03 |
+-------------+------------+-------------------+---------------+---------------------+

Out of 7 I pay only 4. Now table "accountlines" looks as follows - the original
line (N) changes in fields "amountoutstanding" and "timestamp" and another line
(Pay) is added. This looks as I expect ist.

+-------------+------------+-------------------+---------------+---------------------+
| accounttype | amount     | amountoutstanding | lastincrement | timestamp     
     |
+-------------+------------+-------------------+---------------+---------------------+
| N           |   7.000000 |          3.000000 |          NULL | 2016-10-29
12:33:42 |
| Pay         |   4.000000 |          0.000000 |          NULL | 2016-10-29
12:33:42 |
+-------------+------------+-------------------+---------------+---------------------+

However, as already reported by M. de Rooy the logfile shows a lot of warnings
like the following for every Pay action:

[Sat Oct 29 12:33:43.008191 2016] [cgi:error] [pid 3382] [client
10.0.2.2:44132] AH01215: [Sat Oct 29 12:33:43 2016] paycollect.pl: Argument
"7.00&descr..." isn't numeric in sprintf at
/usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Filters.pm line 467., referer:
http://localhost:8081/cgi-bin/koha/members/paycollect.pl?borrowernumber=52&pay_individual=1&accounttype=N&amount=7.00&amountoutstanding=7.00%26description%3DN%26title%3D&notify_id=1&notify_level=0&accountlines_id=13&remote_user=

-- 
You are receiving this mail because:
You are watching all bug changes.