From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 00:46:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 22:46:51 +0000
Subject: [Koha-bugs] [Bug 13445] Scheduled Report, Type=URL fails
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ephetteplace at cca.edu
--- Comment #3 from Eric Phetteplace ---
I agree strongly with Katrin that it's a bad idea to leave broken features in
the UI. This doesn't work as advertised and should be removed.
I'm perfectly willing to write a patch and removes the from the
scheduler.tt template, replacing it with a hidden input, and the corresponding
help text in corresponding template as well if people are agreed that that's
the best course of action. While this may be a useful feature I think it's
better to remove the broken appendage of it first and add back if/when it's
fully complete.
It's also already possible to construct a link that goes to the results of a
particular report. One could create a calendar reminder in some external
application that handles this use case easily.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 00:48:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 22:48:30 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
overwritten by the next one
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #54972|0 |1
is obsolete| |
--- Comment #31 from Chris Cormack ---
Created attachment 55080
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55080&action=edit
Bug 17135 - Fine for the previous overdue may get overwritten by the next one
External maintenace script for fixing unclosed (FU), non accruing fine
records which may still need FU -> F correction post-Bug 15675.
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 00:48:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 22:48:54 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
overwritten by the next one
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55075|0 |1
is obsolete| |
--- Comment #32 from Chris Cormack ---
Created attachment 55081
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55081&action=edit
Bug 17135 - Some minor changes & fixes in the script
- all non-fatal output redirected to STDOUT (as there is an intention
to run this script from updatedatabase.pl)
- added borrowernumber and itemnumber equality checks to the SELECT
statement in getFinesForChecking() - accountlines.issue_id alone is not
entirely trustworthy (because InnoDB forgets it's highest auto_increment
after server restart), in some rare cases it may point to some random
issue for different patron and different item
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 00:49:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 22:49:31 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
overwritten by the next one
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 00:49:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 22:49:35 +0000
Subject: [Koha-bugs] [Bug 17135] Fine for the previous overdue may get
overwritten by the next one
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55077|0 |1
is obsolete| |
--- Comment #33 from Chris Cormack ---
Created attachment 55082
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55082&action=edit
Bug 17135 - Maintenance script execution added as part of an atomic DB upgrade
(plus warnings for 16.05+ production setups possibly already affected)
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 01:34:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 23:34:44 +0000
Subject: [Koha-bugs] [Bug 16556] KohaToMarcMapped columns sharing same field
with biblio(item) number are removed.
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 01:34:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 23:34:47 +0000
Subject: [Koha-bugs] [Bug 16556] KohaToMarcMapped columns sharing same field
with biblio(item) number are removed.
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #51622|0 |1
is obsolete| |
--- Comment #6 from Chris Cormack ---
Created attachment 55083
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55083&action=edit
Bug 16556 - KohaToMarcMapped columns sharing same field with biblio(item)number
are removed.
REPLICATE ISSUE:
1. Map biblio.frameworkcode to 999$b
2. Map biblio.biblionumber to 999$c
3. Add a record with something in 999$b
4. 999$b is removed by C4::Biblio::AddBiblio()
After this patch, the field used by biblio.biblionumber or
biblioitems.biblioitemnumber
is not removed and created anew, thus dropping all existing additions.
There is no point in dropping the field in any case, since we can just replace
the existing subfields in-place with no need to recreate the whole field.
UNIT TESTS INCLUDED
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 01:46:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 23:46:01 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #54894|0 |1
is obsolete| |
--- Comment #43 from Tom?s Cohen Arazi ---
Created attachment 55084
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55084&action=edit
Bug 14868: Swagger2-driven Permission checking
Define 'x-koha-permission' for the Swagger2 Operation Object, to automatically
authorize against the required permissions.
This way we immediately tell the API consumer in the Swagger2-definition, which
permissions are needed to access defined resources.
Also we don't need to maintain permissions in multiple locations and we can
build
a smart testing framework to help a lot in creating tests for the new REST API.
Signed-off-by: Benjamin Rokseth
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 01:46:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 23:46:08 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #54895|0 |1
is obsolete| |
--- Comment #44 from Tom?s Cohen Arazi ---
Created attachment 55085
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55085&action=edit
Bug 14868: Give users possibility to request their own object
Allow access to user's own objects even if they do not have required
permissions.
This will be very useful in many cases where an user wants to request their own
object, for example renewing their checkouts or placing a hold for themselves.
First, this patch renames "x-koha-permission" to "x-koha-authorization" in
order
to describe the new functionality better.
Second, we can now add two extra parameters under "x-koha-authorization":
- "allow-owner"; Allows the owner of object to access it (without permission)
- "allow-guarantor"; Allows guarantor of the owner of object to access it
(without permission)
Third, since permission checking is outside of actual controller, we need a way
to find out ownership from different types of parameters, e.g. checkout_id from
/checkouts/{checkout_id}, borrowernumber from /patrons/{borrowernumber} etc.
A solution is to match the parameter with a subroutine that is designed to
verify
the ownership for that object. See the new subroutines in Koha::REST::V1.
To use this functionality you will simply define it in Swagger:
"/patrons/{borrowernumber}": {
"get": {
...,
"x-koha-authorization": {
"allow-owner": true,
"permissions": {
"borrowers": "1"
}
}
}
}
If a parameter that is not yet defined in
Koha::REST::V1::check_object_ownership,
you also need to define it and implement a subroutine that determines
ownership.
Tests are provided in a following patch that adds this functionality for
current
API operations.
Signed-off-by: Benjamin Rokseth
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 01:46:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 23:46:16 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #54896|0 |1
is obsolete| |
--- Comment #45 from Tom?s Cohen Arazi ---
Created attachment 55086
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55086&action=edit
Bug 14868: Use x-koha-authorization in current routes
To test:
1. Run t/db_dependent/api/v1/holds.t
2. Run t/db_dependent/api/v1/patrons.t
Signed-off-by: Benjamin Rokseth
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 01:46:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 23:46:24 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #54897|0 |1
is obsolete| |
--- Comment #46 from Tom?s Cohen Arazi ---
Created attachment 55087
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55087&action=edit
Bug 14868: Display required permissions in permission error response
When user does not have required permissions to use API operation, it would be
useful to let them know which permissions he is missing. Since they are now
defined in Swagger, we can easily render them into the response.
To test:
1. Use a patron without any permissions
2. Make GET request to http://yourlib/api/v1/patrons
3. Observe permission error and see that required_permissions are displayed.
4. Run t/db_dependent/api/v1/patrons.t
Signed-off-by: Benjamin Rokseth
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 01:46:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 23:46:29 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: ---
Created attachment 55088
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55088&action=edit
Bug 14868: (QA followup) Change permission check order
This patch changes the permission check order because haspermission
is the smaller check, and going through the patron/user and its guaranteed
before checking if it is (say) a staff member or even a superlibrarian doesn't
seem right.
Bonus: Remove unneeded C4::Auth import in Patron.pm
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 01:46:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 23:46:34 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: ---
Created attachment 55089
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55089&action=edit
Bug 14868: (QA followup) POD fixes
To make the QA scripts happy, the POD needed a fix, and also
keys applied to a hashref needs to be avoided.
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 01:51:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Aug 2016 23:51:41 +0000
Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP
Replication not using autoMemberNum if configured
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chris at bigballofwax.co.nz
--- Comment #6 from Chris Cormack ---
Hi Lee
Thanks for marking this signed off. Would you please be able to add a signoff
to the patch
(git commit --amend -s)
And then obsolete the old ones.
Thanks heaps
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 10:30:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 08:30:48 +0000
Subject: [Koha-bugs] [Bug 17228] Make two versions of SIPconfig.xml identical
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 10:30:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 08:30:51 +0000
Subject: [Koha-bugs] [Bug 17228] Make two versions of SIPconfig.xml identical
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55054|0 |1
is obsolete| |
--- Comment #5 from Claire Gravely ---
Created attachment 55090
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55090&action=edit
Bug 17228 - Make two versions of SIPconfig.xml identical
Several bugs have made changes to etc/SIPconfig.xml but not
updated debian/templates/SIPconfig.xml. This means that an admin
using the Debian packages who enables SIP2 for a site and looks at
/etc/koha/sites//SIPconfig.xml will not see an up-to-date
version of that file, with the risk of missing possible config
opportunities.
Since debian/templates/SIPconfig.xml contains no placeholders or
other magic stuff related to the Debian packaging, this patch simply
copies etc/SIPconfig.xml to debian/templates/SIPconfig.xml
To test:
$?diff etc/SIPconfig.xml debian/templates/SIPconfig.xml
There should be no difference between the files
Signed-off-by: Claire Gravely
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 11:03:15 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 09:03:15 +0000
Subject: [Koha-bugs] [Bug 17231] HTML5MediaYouTube should recognize youtu.be
links from youtube as well at the full links
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |claire_gravely at hotmail.com
--- Comment #2 from Claire Gravely ---
After applying the patch: I get the following error when doing a catalogue
search on the intranet for a record which already has a link in 856 $u
GET
http://www.youtube.com/watch?v=http://bulbapedia.bulbagarden.net/wiki/Jigglypuff_(Pok%C3%A9mon)
failed. status: 404 Not Found at /home/claire/koha/C4/HTML5Media.pm line 106.
Search for a record without an 856 $u works fine.
Searching for a record with a youtube.com or youtu.be link works fine.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 12:22:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 10:22:47 +0000
Subject: [Koha-bugs] [Bug 17231] HTML5MediaYouTube should recognize youtu.be
links from youtube as well at the full links
In-Reply-To: ---
(In reply to Claire Gravely from comment #2)
> After applying the patch: I get the following error when doing a catalogue
> search on the intranet for a record which already has a link in 856 $u
>
> GET
> http://www.youtube.com/watch?v=http://bulbapedia.bulbagarden.net/wiki/
> Jigglypuff_(Pok%C3%A9mon) failed. status: 404 Not Found at
> /home/claire/koha/C4/HTML5Media.pm line 106.
>
> Search for a record without an 856 $u works fine.
> Searching for a record with a youtube.com or youtu.be link works fine.
Also applies to OPAC if HTML5MediaEnabled is set to OPAC and staff client.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 13:17:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 11:17:24 +0000
Subject: [Koha-bugs] [Bug 17231] HTML5MediaYouTube should recognize youtu.be
links from youtube as well at the full links
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55076|0 |1
is obsolete| |
--- Comment #4 from Nick Clemens ---
Created attachment 55091
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55091&action=edit
Bug 17231 - HTML5MediaYouTube should recognize youtu.be links from youtube as
well at the full links
To test:
Enable HTML5MediaYouTube and ensure WWW::YouTube::Download is installed
Add an 856$u to a record like: https://www.youtube.com/watch?v=tu0qtEwb9gE
Verify you can see the embedded player
Use the youtube shortened like (from the share button) like:
https://youtu.be/tu0qtEwb9gE
Verify you can see the embedded player
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 13:19:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 11:19:38 +0000
Subject: [Koha-bugs] [Bug 17231] HTML5MediaYouTube should recognize youtu.be
links from youtube as well at the full links
In-Reply-To: ---
Fixed! That was bad grepping on my part, worked cause it matched everything :-)
I added an eval to catch those errors as well, say if you link to something
like:
http://www.nytimes.com/topic/company/youtube
Which will match, but is not a youtube video
(In reply to Claire Gravely from comment #3)
> (In reply to Claire Gravely from comment #2)
> > After applying the patch: I get the following error when doing a catalogue
> > search on the intranet for a record which already has a link in 856 $u
> Also applies to OPAC if HTML5MediaEnabled is set to OPAC and staff client.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 14:27:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 12:27:39 +0000
Subject: [Koha-bugs] [Bug 17231] HTML5MediaYouTube should recognize youtu.be
links from youtube as well at the full links
In-Reply-To: ---
(In reply to Nick Clemens from comment #5)
> Fixed! That was bad grepping on my part, worked cause it matched everything
> :-)
>
> I added an eval to catch those errors as well, say if you link to something
> like:
> http://www.nytimes.com/topic/company/youtube
>
> Which will match, but is not a youtube video
>
>
> (In reply to Claire Gravely from comment #3)
> > (In reply to Claire Gravely from comment #2)
> > > After applying the patch: I get the following error when doing a catalogue
> > > search on the intranet for a record which already has a link in 856 $u
> > Also applies to OPAC if HTML5MediaEnabled is set to OPAC and staff client.
It now searches ok :), but if the record has two 856 $u (one for a link and one
for a video for example) it does not embed the youtube video.
I should note, that adding the two kinds of youtube style link does work fine
on items without additional 856$u fields.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 14:55:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 12:55:36 +0000
Subject: [Koha-bugs] [Bug 15388] Show Syndetics covers by UPC in search
results
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
Attachment #54940|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:01:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 13:01:06 +0000
Subject: [Koha-bugs] [Bug 17232] New: Subfield default values are not ported
when creating a new framework from an old one
Message-ID: ---
Sorry about that Chris! Still learning the procedures! I just signed off on it
so I'll upload the signed off patch now!
Thanks for the info!
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:29:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 13:29:52 +0000
Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP
Replication not using autoMemberNum if configured
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55048|0 |1
is obsolete| |
Attachment #55058|0 |1
is obsolete| |
--- Comment #8 from Lee Jamison ---
Created attachment 55092
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55092&action=edit
Bug 17215 - converted tabs to whitespace
To test:
1. Set the autoMemberNum System Preference to "Don't".
2. Login to the OPAC with an LDAP account that does not currently exist as a
patron record.
3. Check the patron record's cardnumber.
4. the cardnumber should equal the patron's LDAP username.
5. Delete the patron record.
6. Apply the patch.
7. Set the autoMemberNum System Preference to "Do".
8. Login to the OPAC with an LDAP account that does not currently exist as a
patron record.
9. Check the patron record's cardnumber.
10. The cardnumber should now be the next highest cardnumber based on
autoMemberNum.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 15:50:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 13:50:18 +0000
Subject: [Koha-bugs] [Bug 17191] Confirm message on deleting tag in OPAC
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:24:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 14:24:32 +0000
Subject: [Koha-bugs] [Bug 17231] HTML5MediaYouTube should recognize youtu.be
links from youtube as well at the full links
In-Reply-To: ---
(In reply to Claire Gravely from comment #6)
> It now searches ok :), but if the record has two 856 $u (one for a link and
> one for a video for example) it does not embed the youtube video.
Hmm...It works if you put two separate 856 fields, each with their own $u
In master a link plus a youtube $u in a single 856 causes an error
In master as well, two regular links in a single 856 only seems to display the
first link anyways. I think this is not a bug but intended functionality
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:28:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 14:28:09 +0000
Subject: [Koha-bugs] [Bug 17231] HTML5MediaYouTube should recognize youtu.be
links from youtube as well at the full links
In-Reply-To: ---
(In reply to Nick Clemens from comment #7)
> (In reply to Claire Gravely from comment #6)
> > It now searches ok :), but if the record has two 856 $u (one for a link and
> > one for a video for example) it does not embed the youtube video.
>
> Hmm...It works if you put two separate 856 fields, each with their own $u
>
> In master a link plus a youtube $u in a single 856 causes an error
>
> In master as well, two regular links in a single 856 only seems to display
> the first link anyways. I think this is not a bug but intended functionality
I meant two separate 856$u fields. Will retest!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:56:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 14:56:02 +0000
Subject: [Koha-bugs] [Bug 17231] HTML5MediaYouTube should recognize youtu.be
links from youtube as well at the full links
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:56:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 14:56:05 +0000
Subject: [Koha-bugs] [Bug 17231] HTML5MediaYouTube should recognize youtu.be
links from youtube as well at the full links
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55091|0 |1
is obsolete| |
--- Comment #9 from Claire Gravely ---
Created attachment 55093
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55093&action=edit
Bug 17231 - HTML5MediaYouTube should recognize youtu.be links from youtube as
well at the full links
To test:
Enable HTML5MediaYouTube and ensure WWW::YouTube::Download is installed
Add an 856$u to a record like: https://www.youtube.com/watch?v=tu0qtEwb9gE
Verify you can see the embedded player
Use the youtube shortened like (from the share button) like:
https://youtu.be/tu0qtEwb9gE
Verify you can see the embedded player
Sorry - all working as expected!!
Signed-off-by: Claire Gravely
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 16:56:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 14:56:41 +0000
Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files
In-Reply-To: ---
> However, and this might be tangential, the authorized value does not appear
> to be updating when either creating the items or receiving them. Currently
> acquisitions would place a record in an Ordered NOT_LOAN status. This may be
> a local script, but it does not appear to be syspref. When we create an
> order using acquisitions in the sandbox, the items appear as available.
Just thought I'd chime in on this. Benjamin, this works because in your ACQ
marc framework, you have 952$7 ( not for loan ) set to have a default value of
-1, which in your NOT_LOAN authorised value list is "Ordered". So I don't think
this is an issue with this patch.
> Additionally, if we do set AcqItemSetSubfieldsWhenReceived in the system
> preferences, receiving the items does not seem to update the subfields. I
> know this works in production, but does appear broken here.
This patch doesn't really affect receiving items either. It's most likely an
independent regression. It may be worth your time to create a sandbox on master
with no patches applied to test this. If it still doesn't work you can file a
new bug report for that!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 17:18:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 15:18:16 +0000
Subject: [Koha-bugs] [Bug 17072] 006 not filling in with existing values
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |abl at biblos.pk.edu.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 17:19:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 15:19:48 +0000
Subject: [Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to
be customizable per-basket
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #47783|0 |1
is obsolete| |
--- Comment #2 from Nick Clemens ---
Created attachment 55094
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55094&action=edit
Bug 15685: Allow creation of items (AcqCreateItem) to be customizable
per-basket
This adds a new basket attribute (create_items) that can optionally be
set to override AcqCreateItem.
The following have been modified to reflect this (with the value of
create_items that causes them to behave differently in parentheses):
* Cancelling receipt of an order (receiving)
* Creating an order by hand or from MARC (ordering)
* Receiving an order (receiving)
* Showing orders with uncertain price (ordering)
* Showing orders (receiving)
* Showing acquisition details in the OPAC (ordering)
Test plan:
1) Create baskets with "Create items when:" set to ordering,
receiving, cataloging and unset.
2) Test each of the above for each of these baskets, verifying that
the basket-specific attribute overrides AcqCreateItem if set and
falls back to the syspref otherwise.
NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it
was redundant; the code path in question cannot be triggered unless
create_items/AcqCreateItems is set to the correct value anyway.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 18:16:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 16:16:14 +0000
Subject: [Koha-bugs] [Bug 15924] Coce not enabled on lists
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #2 from Owen Leonard ---
[% coce_id = SEARCH_RESULT.normalized_ean || SEARCH_RESULT.normalized_isbn %]
I don't think this can work because SEARCH_RESULT isn't a valid variable as far
as I can tell. Looks like existing instances of it don't do anything. This
should work:
[% coce_id = itemsloo.normalized_ean || itemsloo.normalized_isbn %]
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 18:22:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 16:22:22 +0000
Subject: [Koha-bugs] [Bug 17072] 006 not filling in with existing values
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 18:22:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 16:22:24 +0000
Subject: [Koha-bugs] [Bug 17072] 006 not filling in with existing values
In-Reply-To: ---
Created attachment 55095
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55095&action=edit
Bug 17072 - 006 not filling in with existing values
When you use the 006 builder to view the existing values in the 006
tag, Koha is not pulling these existing values into the builder
window. Instead, Koha appears to be using defaults.
To reproduce:
1. Open a record in the editor
2. Switch from BKS to another material type.
3. Change as many settings as possible.
4. Close plugin.
5. Reopen plugin - notice your selections are not shown.
Trivial patch, heavilly inspired by Bug 9093.
To test:
1. Apply patch
2. Ensure that issue described above is no longer reproductible
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 18:23:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 16:23:20 +0000
Subject: [Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=17072
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 18:23:20 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 16:23:20 +0000
Subject: [Koha-bugs] [Bug 17072] 006 not filling in with existing values
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|gmcharlt at gmail.com |abl at biblos.pk.edu.pl
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=9093
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 19:09:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 17:09:33 +0000
Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP
Replication not using autoMemberNum if configured
In-Reply-To: ---
I noticed that my last update didn't indicate that the patch was signed off on
(still working on figuring out how to do that when I do the git commit/signoff
- sorry!). So I'll add it in here manually for archival purposes.
Created attachment 55092
Bug 17215 - converted tabs to whitespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215
Signed-off-by: Lee Jamison
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 19:39:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 17:39:54 +0000
Subject: [Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to
be customizable per-basket
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55094|0 |1
is obsolete| |
--- Comment #3 from Nick Clemens ---
Created attachment 55096
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55096&action=edit
Bug 15685: Allow creation of items (AcqCreateItem) to be customizable
per-basket
This adds a new basket attribute (create_items) that can optionally be
set to override AcqCreateItem.
The following have been modified to reflect this (with the value of
create_items that causes them to behave differently in parentheses):
* Cancelling receipt of an order (receiving)
* Creating an order by hand or from MARC (ordering)
* Receiving an order (receiving)
* Showing orders with uncertain price (ordering)
* Showing orders (receiving)
* Showing acquisition details in the OPAC (ordering)
Test plan:
1) Create baskets with "Create items when:" set to ordering,
receiving, cataloging and unset.
2) Test each of the above for each of these baskets, verifying that
the basket-specific attribute overrides AcqCreateItem if set and
falls back to the syspref otherwise.
NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it
was redundant; the code path in question cannot be triggered unless
create_items/AcqCreateItems is set to the correct value anyway.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:01:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 18:01:26 +0000
Subject: [Koha-bugs] [Bug 17213] Self registration cardnumber is not
editable if errors found when form submitted
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
Status|Needs Signoff |Failed QA
--- Comment #3 from Kyle M Hall ---
With the patch applied, instead of getting the 'cardnumber in use' error, the
account is created with a NULL cardnumber!
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:31:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 18:31:03 +0000
Subject: [Koha-bugs] [Bug 17213] Self registration cardnumber is not
editable if errors found when form submitted
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #54971|0 |1
is obsolete| |
--- Comment #4 from Nick Clemens ---
Created attachment 55097
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55097&action=edit
Bug 17213 - Add HTML5 validation to cardnumber field on patron self
registration
To test:
Verify that different values in 'CardnumberLength' system preference
display correctly in the self reigstration form
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:31:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 18:31:48 +0000
Subject: [Koha-bugs] [Bug 17213] Self registration cardnumber is not
editable if errors found when form submitted
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #5 from Nick Clemens ---
(In reply to Kyle M Hall from comment #3)
> With the patch applied, instead of getting the 'cardnumber in use' error,
> the account is created with a NULL cardnumber!
Fixed bad copy paste error (wrong variable names)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:34:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 18:34:14 +0000
Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error
In-Reply-To: ---
I looked into this and it's working exactly as intended! Basically, the tables
hashref is a list of key/value pairs. The value can either be a) a hashref or
b) an arrayref. If it is a hashref, the keys are pulled out as would be
expected, based on the key name. For the arrayref, they simply need to be
ordered correctly. In the case of Holds, the lookup key is the fk combo
borrowernumber/biblionumber, in that order.
(In reply to Kyle M Hall from comment #16)
> > So maybe you should explain me why the following test pass:
> >
> > 180 $prepared_letter = GetPreparedLetter(
> > 181 (
> > 182 module => 'test',
> > 183 letter_code => 'TEST_HOLD',
> > 184 tables => {
> > 185 reserves => [ $patron->{borrowernumber}, $biblio->id() ]
> > 186 },
> > 187 )
> > 188 );
> > 189 is( $prepared_letter->{content}, $hold->id(), 'Hold object used
> > correctly' )
> >
> > What does reserves => { $borrowernumber, $biblionumber } mean?
> > How do you know that $borrowernumber is a borrowernumber?
> > It looks like something magic and to me it should not work.
>
> Ah, I see now! I'll look into that!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 20:34:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 18:34:46 +0000
Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #18 from Kyle M Hall ---
Pushed to master for Koha 16.11!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 21:10:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 19:10:34 +0000
Subject: [Koha-bugs] [Bug 17233] New: Add 008 value builder plugin for
MARC21 classifications
Message-ID: changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 21:38:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 19:38:00 +0000
Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21
classifications
In-Reply-To: ---
Created attachment 55098
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55098&action=edit
Bug 17233 - Add 008 value builder plugin for MARC21 classifications
This patch adds 008 cataloguing value builder for MARC21 classifications
records (LCC, DDC/Dewey, UDC and so on).
For most practical purposes, MARC21 classification records
().
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 22:47:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 20:47:33 +0000
Subject: [Koha-bugs] [Bug 17234] New: ALTER IGNORE TABLE is invalid in mysql
5.7. This breaks updatedatabase.pl
Message-ID: changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Assignee|gmcharlt at gmail.com |philippe.blouin at inlibro.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 22:59:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 20:59:31 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55087|0 |1
is obsolete| |
--- Comment #49 from Benjamin Rokseth ---
Created attachment 55099
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55099&action=edit
Bug 14868: Display required permissions in permission error response
When user does not have required permissions to use API operation, it would be
useful to let them know which permissions he is missing. Since they are now
defined in Swagger, we can easily render them into the response.
To test:
1. Use a patron without any permissions
2. Make GET request to http://yourlib/api/v1/patrons
3. Observe permission error and see that required_permissions are displayed.
4. Run t/db_dependent/api/v1/patrons.t
Signed-off-by: Benjamin Rokseth
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 23:01:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 21:01:18 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55084|0 |1
is obsolete| |
--- Comment #50 from Benjamin Rokseth ---
Created attachment 55100
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55100&action=edit
Bug 14868: Swagger2-driven Permission checking
Define 'x-koha-permission' for the Swagger2 Operation Object, to automatically
authorize against the required permissions.
This way we immediately tell the API consumer in the Swagger2-definition, which
permissions are needed to access defined resources.
Also we don't need to maintain permissions in multiple locations and we can
build
a smart testing framework to help a lot in creating tests for the new REST API.
Signed-off-by: Benjamin Rokseth
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 23:01:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 21:01:28 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55085|0 |1
is obsolete| |
--- Comment #51 from Benjamin Rokseth ---
Created attachment 55101
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55101&action=edit
Bug 14868: Give users possibility to request their own object
Allow access to user's own objects even if they do not have required
permissions.
This will be very useful in many cases where an user wants to request their own
object, for example renewing their checkouts or placing a hold for themselves.
First, this patch renames "x-koha-permission" to "x-koha-authorization" in
order
to describe the new functionality better.
Second, we can now add two extra parameters under "x-koha-authorization":
- "allow-owner"; Allows the owner of object to access it (without permission)
- "allow-guarantor"; Allows guarantor of the owner of object to access it
(without permission)
Third, since permission checking is outside of actual controller, we need a way
to find out ownership from different types of parameters, e.g. checkout_id from
/checkouts/{checkout_id}, borrowernumber from /patrons/{borrowernumber} etc.
A solution is to match the parameter with a subroutine that is designed to
verify
the ownership for that object. See the new subroutines in Koha::REST::V1.
To use this functionality you will simply define it in Swagger:
"/patrons/{borrowernumber}": {
"get": {
...,
"x-koha-authorization": {
"allow-owner": true,
"permissions": {
"borrowers": "1"
}
}
}
}
If a parameter that is not yet defined in
Koha::REST::V1::check_object_ownership,
you also need to define it and implement a subroutine that determines
ownership.
Tests are provided in a following patch that adds this functionality for
current
API operations.
Signed-off-by: Benjamin Rokseth
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 23:01:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 21:01:35 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55086|0 |1
is obsolete| |
--- Comment #52 from Benjamin Rokseth ---
Created attachment 55102
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55102&action=edit
Bug 14868: Use x-koha-authorization in current routes
To test:
1. Run t/db_dependent/api/v1/holds.t
2. Run t/db_dependent/api/v1/patrons.t
Signed-off-by: Benjamin Rokseth
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 23:01:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 21:01:51 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55099|0 |1
is obsolete| |
--- Comment #53 from Benjamin Rokseth ---
Created attachment 55103
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55103&action=edit
Bug 14868: Display required permissions in permission error response
When user does not have required permissions to use API operation, it would be
useful to let them know which permissions he is missing. Since they are now
defined in Swagger, we can easily render them into the response.
To test:
1. Use a patron without any permissions
2. Make GET request to http://yourlib/api/v1/patrons
3. Observe permission error and see that required_permissions are displayed.
4. Run t/db_dependent/api/v1/patrons.t
Signed-off-by: Benjamin Rokseth
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 23:01:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 21:01:59 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55088|0 |1
is obsolete| |
--- Comment #54 from Benjamin Rokseth ---
Created attachment 55104
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55104&action=edit
Bug 14868: (QA followup) Change permission check order
This patch changes the permission check order because haspermission
is the smaller check, and going through the patron/user and its guaranteed
before checking if it is (say) a staff member or even a superlibrarian doesn't
seem right.
Bonus: Remove unneeded C4::Auth import in Patron.pm
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 23:02:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 21:02:05 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55089|0 |1
is obsolete| |
--- Comment #55 from Benjamin Rokseth ---
Created attachment 55105
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55105&action=edit
Bug 14868: (QA followup) POD fixes
To make the QA scripts happy, the POD needed a fix, and also
keys applied to a hashref needs to be avoided.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Sep 1 23:59:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Sep 2016 21:59:30 +0000
Subject: [Koha-bugs] [Bug 17235] New: Error when trying to modify personal
details in OPAC ( memberentry.pl)
Message-ID: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:25:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 07:25:25 +0000
Subject: [Koha-bugs] [Bug 17228] Make two versions of SIPconfig.xml identical
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55053|0 |1
is obsolete| |
--- Comment #6 from Marcel de Rooy ---
Created attachment 55106
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55106&action=edit
Bug 17228 - Fix whitespace in etc/SIPconfig.xml
Remove trailing whitespace and replace tabs with 4 spaces.
Signed-off-by: Claire Gravely
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:25:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 07:25:30 +0000
Subject: [Koha-bugs] [Bug 17228] Make two versions of SIPconfig.xml identical
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55090|0 |1
is obsolete| |
--- Comment #7 from Marcel de Rooy ---
Created attachment 55107
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55107&action=edit
Bug 17228 - Make two versions of SIPconfig.xml identical
Several bugs have made changes to etc/SIPconfig.xml but not
updated debian/templates/SIPconfig.xml. This means that an admin
using the Debian packages who enables SIP2 for a site and looks at
/etc/koha/sites//SIPconfig.xml will not see an up-to-date
version of that file, with the risk of missing possible config
opportunities.
Since debian/templates/SIPconfig.xml contains no placeholders or
other magic stuff related to the Debian packaging, this patch simply
copies etc/SIPconfig.xml to debian/templates/SIPconfig.xml
To test: diff etc/SIPconfig.xml debian/templates/SIPconfig.xml
There should be no difference between the files
Signed-off-by: Claire Gravely
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:26:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 07:26:18 +0000
Subject: [Koha-bugs] [Bug 17238] Warnings in gather_print_notices.pl
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |magnus at libriotech.no
--- Comment #1 from Magnus Enger ---
I am seeing the same warnings on Koha 16.05.x.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 09:27:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 07:27:46 +0000
Subject: [Koha-bugs] [Bug 17228] Make two versions of SIPconfig.xml identical
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
CC| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 10:23:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 08:23:11 +0000
Subject: [Koha-bugs] [Bug 17237] Stop koha-create from creating MySQL users
without host restriction
In-Reply-To: ---
>From IRC:
I think it's for when koha-create creates databases on remote
servers, perhaps.
It probably should be off by default but configureable.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 11:11:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 09:11:35 +0000
Subject: [Koha-bugs] [Bug 17206] Can't switch to default framework
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |veron at veron.ch
--- Comment #1 from Marc V?ron ---
Bug reproduced.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 11:18:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 09:18:59 +0000
Subject: [Koha-bugs] [Bug 16514] Force scalar cotext where param assumes a
list incorrectly in admin/ edi scripts
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #4 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #2)
> I cannot test this patch, edi_accounts.pl is not plack compatible:
> Variable "$schema" is not available at /home/koha/src/admin/edi_accounts.pl
> line 147.
> Variable "$input" is not available at /home/koha/src/admin/edi_accounts.pl
> line 157.
> Variable "$schema" is not available at /home/koha/src/admin/edi_accounts.pl
> line 159.
> Variable "$template" is not available at
> /home/koha/src/admin/edi_accounts.pl line 161.
Colin,
It seems that this is not hard to fix. Just make sure not to use the global
lexicals in your subroutines.
Could you either send a followup here or open a new report when you would
insist that this is outside the scope ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 11:41:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 09:41:19 +0000
Subject: [Koha-bugs] [Bug 16449] unimarc_field_4XX raises a warning
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 11:41:22 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 09:41:22 +0000
Subject: [Koha-bugs] [Bug 16449] unimarc_field_4XX raises a warning
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #53491|0 |1
is obsolete| |
--- Comment #4 from Marcel de Rooy ---
Created attachment 55109
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55109&action=edit
Bug 16449: Remove "no method selected" warning from unimarc_field_4XX
Because of bug 14828, the unimarc_field_4XX now raises a warning:
"No method selected!"
There are no need to select an item type on this page, the default (all)
is always selected.
Test plan:
Link the unimarc_field_4XX value builder with on of the subfield
Edit a record, click on the value builder icon
Note the warning without the patch and that it's gone with the patch
applied
NOTE: Code fix that I derived was identical. Ran
prove t/db_dependent/FrameworkPlugin.t
to confirm it works.
Signed-off-by: Mark Tompsett
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 11:41:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 09:41:34 +0000
Subject: [Koha-bugs] [Bug 16449] unimarc_field_4XX raises a warning
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 12:03:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 10:03:40 +0000
Subject: [Koha-bugs] [Bug 17235] Error when trying to modify personal
details in OPAC ( memberentry.pl)
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |abl at biblos.pk.edu.pl
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=16996
--- Comment #1 from Jacek Ablewicz ---
Patch for this issue (tagged as [16.05] ) is in Bug 16996.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 12:03:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 10:03:40 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
Can't call method " description"
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=17235
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 12:26:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 10:26:45 +0000
Subject: [Koha-bugs] [Bug 17240] New: Allow processes that rely on
background jobs run in Plack mode
Message-ID: changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|gmcharlt at gmail.com |fridolin.somers at biblibre.co
| |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 12:33:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 10:33:51 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
jobs run in Plack mode
In-Reply-To: ---
Created attachment 55110
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55110&action=edit
Bug 17240 - Allow processes that rely on background jobs run in Plack mode
This adds prepares the main one by adding method "is_psgi" to C4::Context and
using it in about.pl
Test plan :
- On a Koha running with Plack
- Go to about.pl
- Look at line "PGSI:"
=> You should see "Plack"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 12:34:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 10:34:38 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
jobs run in Plack mode
In-Reply-To: ---
Created attachment 55111
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55111&action=edit
Bug 17240 - Allow processes that rely on background jobs run in Plack mode -
prepare
This adds prepares the main one by adding method "is_psgi" to C4::Context and
using it in about.pl
Test plan :
- On a Koha running with Plack
- Go to about.pl
- Look at line "PGSI:"
=> You should see "Plack"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 12:35:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 10:35:06 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
jobs run in Plack mode
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55110|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 13:02:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 11:02:14 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
jobs run in Plack mode
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=15032
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 13:02:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 11:02:14 +0000
Subject: [Koha-bugs] [Bug 15032] (Plack) Stage MARC records for import
breaks in Plack
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=17240
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 13:02:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 11:02:29 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
jobs run in Plack mode
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |15218
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15218
[Bug 15218] Make processes that rely on background jobs run in CGI mode
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 13:02:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 11:02:29 +0000
Subject: [Koha-bugs] [Bug 15218] Make processes that rely on background jobs
run in CGI mode
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |17240
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240
[Bug 17240] Allow processes that rely on background jobs run in Plack mode
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 13:21:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 11:21:08 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
jobs run in Plack mode
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 13:37:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 11:37:34 +0000
Subject: [Koha-bugs] [Bug 17235] Error when trying to modify personal
details in OPAC ( memberentry.pl)
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|NEW |RESOLVED
--- Comment #2 from Claudio ---
I applied this patch and all works fine again, thank you Jacek.
*** This bug has been marked as a duplicate of bug 16996 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 13:37:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 11:37:34 +0000
Subject: [Koha-bugs] [Bug 16996] Template process failed: undef error -
Can't call method " description"
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |costalc at gmail.com
--- Comment #17 from Claudio ---
*** Bug 17235 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 13:39:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 11:39:50 +0000
Subject: [Koha-bugs] [Bug 16908] Koha::Patrons - Remove GetSortDetails
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 13:39:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 11:39:52 +0000
Subject: [Koha-bugs] [Bug 16908] Koha::Patrons - Remove GetSortDetails
In-Reply-To: ---
Created attachment 55112
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55112&action=edit
Bug 16908: Koha::Patrons - Remove GetSortDetails
This subroutine was only used in one script and its job is the same as
GetAuthorisedValueByCode.
It's better to use the AuthorisedValues TT plugin to retrieve AV
descriptions.
Test plan:
Edit a patron with sort1 and/or sort2 defined.
On the patron details page (members/moremember.pl) you should see the
sort1 and/or sort2 info displayed.
Signed-off-by: Owen Leonard
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 13:41:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 11:41:04 +0000
Subject: [Koha-bugs] [Bug 16908] Koha::Patrons - Remove GetSortDetails
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
Attachment #53474|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 13:41:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 11:41:11 +0000
Subject: [Koha-bugs] [Bug 16908] Koha::Patrons - Remove GetSortDetails
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 13:48:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 11:48:39 +0000
Subject: [Koha-bugs] [Bug 17188] Koha does not support several memcached
servers
In-Reply-To: ---
It's strange, but I'm not able to reproduce this issue in unpatched master
(wheezy, 5.14.2, no plack). I'm wondering if plack / no plack can be a factor
here (and if yes - why?).
This statement
my @servers =
split /,/, $self->{'cache_servers'}
? $self->{'cache_servers'}
: ($ENV{MEMCACHED_SERVERS} || '');
(while ugly as bat s**t) seems to work fine for me, I'm getting:
Default caching system: memcached at /home/koha/devkohaclone/C4/Context.pm
line 514
Memcached server settings: localhost:11301, localhost:11302 with koha at
/home/koha/devkohaclone/C4/Context.pm line 514
Selected caching system: Cache::Memcached::Fast=SCALAR(0x297b488) at
/home/koha/devkohaclone/C4/Context.pm line 514
in both patched and unpatched master.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 14:22:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 12:22:30 +0000
Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7.
This breaks updatedatabase.pl
In-Reply-To: ---
Created attachment 55113
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55113&action=edit
Bug 17234 - updatedatabase.pl's ALTER IGNORE break with mysql 5.7.4+
The doc says: "As of MySQL 5.7.4, the IGNORE clause for ALTER TABLE is removed
and its use produces an error."
This fix replaces ALTER IGNORE with ALTER in updatedatabase.pl
To TEST, try an upgrade from 3.18 to 3.22 after installing the latest mysql (at
least 5.7.4, by the doc).
Some will fail with error
DBD::mysql::db do failed: You have an error in your SQL syntax; check the
manual that corresponds to your MySQL server version for the right syntax to
use near 'IGNORE TABLE aqbasket
ADD KEY authorisedby (authorisedby)' at line 1 [for Statement "
ALTER IGNORE TABLE aqbasket
ADD KEY authorisedby (authorisedby)
"] at ./installer/data/mysql/updatedatabase.pl line 10563.
0) Find a database on 3.18, save it.
1) Set your code base to 3.22(or master)
2) run updatedatabase.pl
3) See the errors.
4) Apply the patch
5) Reload the 3.18 database
6) succeed with updatedatabase.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 14:23:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 12:23:40 +0000
Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7.
This breaks updatedatabase.pl
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |eric.begin at inLibro.com,
| |francois.charbonnier at inlibr
| |o.com,
| |philippe.blouin at inlibro.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 14:52:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 12:52:57 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:11:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:11:54 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:12:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:12:00 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #54546|0 |1
is obsolete| |
Attachment #54547|0 |1
is obsolete| |
Attachment #54548|0 |1
is obsolete| |
Attachment #54549|0 |1
is obsolete| |
Attachment #54550|0 |1
is obsolete| |
Attachment #54551|0 |1
is obsolete| |
Attachment #54552|0 |1
is obsolete| |
Attachment #54553|0 |1
is obsolete| |
Attachment #54554|0 |1
is obsolete| |
Attachment #54555|0 |1
is obsolete| |
Attachment #54556|0 |1
is obsolete| |
Attachment #54557|0 |1
is obsolete| |
Attachment #54558|0 |1
is obsolete| |
Attachment #54559|0 |1
is obsolete| |
--- Comment #174 from Kyle M Hall ---
Created attachment 55114
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55114&action=edit
Bug 14695 - Update database
Signed-off-by: Nick Clemens
Signed-off-by: Jason M. Burds
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:12:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:12:54 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: ---
Created attachment 55115
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55115&action=edit
Bug 14695 - Update DB Schema file
Signed-off-by: Nick Clemens
Signed-off-by: Jason M. Burds
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:13:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:13:00 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: ---
Created attachment 55116
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55116&action=edit
Bug 14695 - Add new circulation rule
Signed-off-by: Nick Clemens
Signed-off-by: Jason M. Burds
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:13:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:13:06 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: ---
Created attachment 55117
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55117&action=edit
Bug 14695 - Tidy C4::Reserves::CanItemBeReserved
Signed-off-by: Nick Clemens
Signed-off-by: Jason M. Burds
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:13:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:13:11 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: ---
Created attachment 55118
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55118&action=edit
Bug 14695 - Add ability to place multiple item holds on a given record per
patron
Signed-off-by: Nick Clemens
Signed-off-by: Jason M. Burds
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:13:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:13:17 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: ---
Created attachment 55119
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55119&action=edit
Bug 14695 [QA Followup] - Filling one hold fills all of them
Signed-off-by: Nick Clemens
Signed-off-by: Jason M. Burds
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:13:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:13:23 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: ---
Created attachment 55120
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55120&action=edit
Bug 14695 [QA Followup] - Make existing unit tests pass
* Removes tests no longer needed
* Updates rules to work with existing tests
* Fixes code issues revealed by unit tests
Signed-off-by: Nick Clemens
Signed-off-by: Jason M. Burds
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:13:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:13:29 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: ---
Created attachment 55121
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55121&action=edit
Bug 14695 [QA Followup] - Fix clearing of all holds by patron at checkout
Signed-off-by: Nick Clemens
Signed-off-by: Jason M. Burds
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:13:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:13:35 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: ---
Created attachment 55122
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55122&action=edit
Bug 14695 - Warn librarian if max_holds_per_record is reached
Signed-off-by: Jason M. Burds
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:13:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:13:41 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: ---
Created attachment 55123
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55123&action=edit
Bug 14695 - Don't use holds_to_place_count when checking an item.
This fix the following bug:
If you select 2 in "Holds to place (count)" and finally
check an item, so you get 2 holds for the same item.
Signed-off-by: Jason M. Burds
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:13:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:13:47 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: ---
Created attachment 55124
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55124&action=edit
Bug 14695 [QA Followup] - Fix method names 'type' to '_type'
Signed-off-by: Jason M. Burds
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:13:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:13:53 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: ---
Created attachment 55125
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55125&action=edit
Bug 14695: Fix typo in template
Signed-off-by: Jason M. Burds
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:13:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:13:59 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: ---
Created attachment 55126
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55126&action=edit
Bug 14695 [QA Followup] - Disable "Holds to place (count)" unless "Hold next
available item" is checked
Signed-off-by: Jason M. Burds
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:14:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:14:05 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: ---
Created attachment 55127
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55127&action=edit
Bug 14695 [QA Followup] - Tell librarian if item doesn't allow or forces item
level holds in the OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:14:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:14:12 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
a given record per patron
In-Reply-To: ---
Created attachment 55128
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55128&action=edit
Bug 14695 [QA Followup] - Unit Tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:19:41 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:19:41 +0000
Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7.
This breaks updatedatabase.pl
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:26:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:26:34 +0000
Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission
checking
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |kyle at bywatersolutions.com
--- Comment #56 from Kyle M Hall ---
Pushed to master for 16.11, thanks Olli, Lari, Tomas!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:28:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:28:26 +0000
Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron
record
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|BLOCKED |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:31:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:31:40 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
jobs run in Plack mode
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55111|0 |1
is obsolete| |
--- Comment #3 from Fridolin SOMERS ---
Created attachment 55129
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55129&action=edit
Bug 17240 - Allow processes that rely on background jobs run in Plack mode -
prepare
This adds prepares the main one by adding method "is_psgi" to C4::Context and
using it in C4::Auth for all templates.
It is used by about.pl and Koha::AuthUtils.
Test plan :
- On a Koha running with Plack
- Go to about.pl
- Look at line "PGSI:"
=> You should see "Plack"
- Enable CAS authentication
- Go to OPAC auth page
- Look at the CAS link
=> You see the current page in this URL
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:32:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:32:00 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
jobs run in Plack mode
In-Reply-To: ---
Created attachment 55130
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55130&action=edit
Bug 17240 - Allow processes that rely on background jobs run in Plack mode
Since Plack mode (PSGI), the processes running with background jobs are broken.
Bug 15218 corrected by using CGI mode for concerned pages.
This patch proposes to allow running those pages in PSGI mode by disabling
background jobs when PSGI is used.
Script are running so faster with Plack, there are less chances that the
process will end in HTTP timeout.
Test plan :
- on a Koha running with plack
- revert Bug 15218 changes
- test processes on pages :
offline_circ/process_koc.pl
tools/batchMod-edit.pl
tools/batch_record_modification.pl
tools/manage-marc-import.pl
tools/stage-marc-import.pl
tools/upload-images.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:36:48 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:36:48 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
jobs run in Plack mode
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:37:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:37:11 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
jobs run in Plack mode
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |christophe.croullebois at bibl
| |ibre.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 15:40:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 13:40:12 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
jobs run in Plack mode
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:01:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:01:27 +0000
Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #48371|0 |1
is obsolete| |
--- Comment #52 from Julian Maurice ---
Created attachment 55131
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55131&action=edit
Bug 8995: Show OpenURL links in OPAC search results
This patch use GetCOinS sub to provide an OpenURL link in OPAC search
results. It uses 4 new system preferences:
- OpenURLinOPACResults: enable or disable this feature
- OpenURLResolverURL: url of the openURL resolver
- OpenURLText: text of the link
- OpenURLImageLocation: image of the link
Link is displayed as an image if OpenURLImageLocation is defined, and as
text otherwise.
It works both with and without XSLT enabled.
Changes made to GetCOinSBiblio:
For 'journal':
- Title should be in rft.jtitle instead of rft.title
- rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have
no meaning for a subscription, so they are simply removed from URL
This patch refactors GetCOinSBiblio, so the construction of URL is done
only at the end. This way we do not have ugly
$var .= "&$value"
in the function body.
Also use URI::Escape instead of custom regexps.
This development consider the value of syspref OPACURLOpenInNewWindow
when building the link.
Test plan:
1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in
OpenURLResolverURL syspref (if you don't have one, just fill it with
some fake URL, you'll have to check if OpenURL links are correct)
2/ If you want, set the other sysprefs OpenURLImageLocation and
OpenURLText
3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your
item types.
4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
5/ Go to OPAC and launch a search.
6/ Check you have in the results (near the title) the OpenURL link (only
for itemtypes that are in OPACOpenURLItemTypes).
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
7/ Go to the detail page of one of those and check you have the OpenURL
link too. (Above tags)
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to
"default" and repeat steps 5 to 7
Signed-off-by: Paola Rossi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:01:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:01:33 +0000
Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #48372|0 |1
is obsolete| |
--- Comment #53 from Julian Maurice ---
Created attachment 55132
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55132&action=edit
Bug 8995: Update opac.css
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:01:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:01:38 +0000
Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
In-Reply-To: ---
Created attachment 55133
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55133&action=edit
Bug 8995: Remove useless code
OpenURL link display is done in XSLT only, so this code is now useless
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:01:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:01:42 +0000
Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
In-Reply-To: ---
Created attachment 55134
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55134&action=edit
Bug 8995: Fix URL generation when the URL in syspref has a query part
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:01:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:01:47 +0000
Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
In-Reply-To: ---
Created attachment 55135
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55135&action=edit
Bug 8995: Tell about the new sysprefs in COinSinOPACResults description
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:01:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:01:51 +0000
Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
In-Reply-To: ---
Created attachment 55136
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55136&action=edit
Bug 8995: Fix and simplify usage of syspref OpenURLImageLocation
There were still references to the OPAC 'prog' theme in XSL files
Now, when using a relative URL, we have to give the full path
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:03:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:03:35 +0000
Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #58 from Julian Maurice ---
First 2 patches rebased on master
4 new patches added to fix some issues
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:15:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:15:12 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
jobs run in Plack mode
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55129|0 |1
is obsolete| |
--- Comment #5 from Fridolin SOMERS ---
Created attachment 55137
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55137&action=edit
Bug 17240 - Allow processes that rely on background jobs run in Plack mode -
prepare
This adds prepares the main one by adding method "is_psgi" to C4::Context and
using it in C4::Auth for all templates.
It is used by about.pl and Koha::AuthUtils.
Test plan :
- On a Koha running with Plack
- Go to about.pl
- Look at line "PGSI:"
=> You should see "Plack"
- Enable CAS authentication
- Go to OPAC auth page
- Look at the CAS link
=> You see the current page in this URL
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:15:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:15:24 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
jobs run in Plack mode
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #55130|0 |1
is obsolete| |
--- Comment #6 from Fridolin SOMERS ---
Created attachment 55138
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55138&action=edit
Bug 17240 - Allow processes that rely on background jobs run in Plack mode
Since Plack mode (PSGI), the processes running with background jobs are broken.
Bug 15218 corrected by using CGI mode for concerned pages.
This patch proposes to allow running those pages in PSGI mode by disabling
background jobs when PSGI is used.
Script are running so faster with Plack, there are less chances that the
process will end in HTTP timeout.
Test plan :
- on a Koha running with plack
- revert Bug 15218 changes
- test processes on pages :
offline_circ/process_koc.pl
tools/batchMod-edit.pl
tools/batch_record_modification.pl
tools/manage-marc-import.pl
tools/stage-marc-import.pl
tools/upload-images.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:35:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:35:14 +0000
Subject: [Koha-bugs] [Bug 17241] New: Start using Bower for installing and
managing Koha' s JavaScript Dependencies
Message-ID: changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:38:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:38:05 +0000
Subject: [Koha-bugs] [Bug 17241] Start using Bower for installing and
managing Koha' s JavaScript Dependencies
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:38:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:38:08 +0000
Subject: [Koha-bugs] [Bug 17241] Start using Bower for installing and
managing Koha' s JavaScript Dependencies
In-Reply-To: ---
Created attachment 55139
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55139&action=edit
Bug 17241 - Start using Bower for installing and managing Koha's JavaScript
Dependencies
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:38:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:38:16 +0000
Subject: [Koha-bugs] [Bug 17241] Start using Bower for installing and
managing Koha' s JavaScript Dependencies
In-Reply-To: ---
Created attachment 55140
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55140&action=edit
Bug 17241 - Replace existing version of requirejs with bower installed
requirejs
Test Plan:
1) Apply this patch set
2) Enable the advancedMARCeditor system preference
3) Attempt to edit a MARC record using the advanced editor
4) The editor should continue to load and function as previously
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:43:33 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:43:33 +0000
Subject: [Koha-bugs] [Bug 17241] Start using Bower for installing and
managing Koha' s JavaScript Dependencies
In-Reply-To: ---
Also, if you want to play with Bower, installing it on Debian is pretty
trivial:
sudo apt-get install nodejs npm
sudo ln -s /usr/bin/nodejs /usr/bin/node # Most node packages look for node,
not nodejs
sudo npm install bower -g
Because we have separate lib directories on the staff and opac side, they will
need to be managed separately ( unless we decide to unify them at some point ).
This patch starts with the staff side.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:50:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:50:11 +0000
Subject: [Koha-bugs] [Bug 17048] Authority search result list page scrolling
not working properly
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |kyle at bywatersolutions.com
--- Comment #12 from Kyle M Hall ---
Pushed to master for 16.11, thanks Jonathan!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Sep 2 16:51:28 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Sep 2016 14:51:28 +0000
Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal
- fines - overdue notices
In-Reply-To: changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #44 from Kyle M Hall