[Koha-bugs] [Bug 17243] New: git ignore swagger.min.json

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17243

            Bug ID: 17243
           Summary: git ignore swagger.min.json
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: benjamin.rokseth at kul.oslo.kommune.no
        QA Contact: testopia at bugs.koha-community.org

With the advent of the new Koha REST API and recently Bug 16699 and Bug 14868,
the minified version of the swagger definitions has snuck into the code.

A bad, but understandable idea. However it will make patching a nightmare, so I
propose in this patch to add swagger.min.json to .gitignore and shift the
responsibility of minifying elsewhere.

Specific use case: patching two independent bugs on the rest API will fail, as
both bugs will need to modify the same swagger.min.json.

Pros: extensible patching on the API will be possible, as was the main bonus of
Bug 16699, and is probably going to be the real life use of the API for some
time.

Cons: minifySwagger.pl must be run manually, and plack restarted, to pick up
changes. This is sysop/deployment responsibility anyways. Alternatively, Bug
17102 can be used to automate minifying.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.