[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 55144
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55144
Bug 17234 - updatedatabase.pl fails on invalid entry in ENUM column

Review of attachment 55144:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17234&attachment=55144)
-----------------------------------------------------------------

::: installer/data/mysql/updatedatabase.pl
@@ +12280,4 @@
>               `id` int(11) NOT NULL AUTO_INCREMENT, 
>               `name` varchar(255) NOT NULL COMMENT 'the name of the field as it will be stored in the search engine',
>               `label` varchar(255) NOT NULL COMMENT 'the human readable name of the field, for display', 
> +             `type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum') NOT NULL COMMENT 'what type of data this holds, relevant when storing it in the search engine',

I haven't looked yet, but this seems like a bad solution. Invalid entries in
the ENUM column are likely caused by applying patches that didn't get into
master. I may get around to looking further, but this patch portion doesn't
seem right to me.

-- 
You are receiving this mail because:
You are watching all bug changes.