[Koha-bugs] [Bug 17246] New: GetPreparedLetter should not allow multiple FK defined in arrayref

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17246

            Bug ID: 17246
           Summary: GetPreparedLetter should not allow multiple FK defined
                    in arrayref
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 14757

Currently you can call GetPreparedLetter like:

$prepared_letter = GetPreparedLetter(
    (
        module      => 'test',
        letter_code => 'TEST_HOLD',
        tables      => { 
            reserves => [ $fk1, $fk2 ],
        },
    )
);

It assumes that $fk1 is a borrowernumber and $fk2 a biblionumber.
It seems hazardous to do this guess.

I suggest to remove this feature and only allow hashref indeed.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
-- 
You are receiving this mail because:
You are watching all bug changes.