[Koha-bugs] [Bug 17231] HTML5MediaYouTube should recognize youtu.be links from youtube as well at the full links

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 55093
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55093
Bug 17231 - HTML5MediaYouTube should recognize youtu.be links from youtube as
well at the full links

Review of attachment 55093:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17231&attachment=55093)
-----------------------------------------------------------------

::: C4/HTML5Media.pm
@@ +98,4 @@
>          # src
>          if ( $HTML5Media_field->subfield('u') ) {
>              $HTML5Media{srcblock} = $HTML5Media_field->subfield('u');
> +            if (grep /youtube|youtu[.]be/, $HTML5Media_field->subfield('u') ) {

/youtu\.?be/
seems easier to read, don't you think?

@@ +109,5 @@
> +                                'fmt' => '43' #webm is the only format compatible to all modern browsers. maybe check for available qualities
> +                            }
> +                        );
> +                    };
> +                    if ($@) { warn $@; }

What kind of errors do you handle here?

-- 
You are receiving this mail because:
You are watching all bug changes.