[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
QA comments:
1/ The date field should have the datepicker class, you should not force the
dateformat to yyyy-mm-dd
2/ from the logs:
No method category_type! at
/home/koha/src/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt
line 294.
The borrowers table does not have a category_type column
3/ When editing a patron, the "Housebound" tab does not appear
4/ From the logs again:
CGI::param called in list context from /home/koha/src/members/housebound.pl
line 56, this can lead to vulnerabilities. See the warning in "Fetching the
value or values of a single named parameter" at /usr/share/perl5/CGI.pm line
407.
5/
FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt
   FAIL   forbidden patterns
forbidden pattern: console.log (line 208)
forbidden pattern: console.log (line 329)

FAIL   members/housebound.pl
   FAIL   critic
"$deliverer" is declared but not used at line 78, column 1. Unused variables
clutter code and make it harder to read.
"$chooser" is declared but not used at line 78, column 1. Unused variables
clutter code and make it harder to read.
"$houseboundvisits" is declared but not used at line 77, column 1. Unused
variables clutter code and make it harder to 
6/ Compare the div.patroninfo with another page from the members module
(members/moremember.pl?borrowernumber=42 for instance), lot of infos are
missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.