[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tomás Cohen Arazi from comment #19)
> FTR: I still don't think it is a good measure to just remove the IGNORE
> keywords. We need to deal with those errors in a better way for end users.
> 
> Right now Koha will show really scary messages about wrong DB structure when
> updatedatabase.pl is ran. I think it is far better to just add a warning
> about 5.7 with a pointer to 'how to disable mysql 5.7 strictness' than
> scaring end users.

I completely agree with that.
We need to replace these occurrences with a call to a new subroutine which will
check if the key already exists or not.

Something like:

unless ( constraint_exist($table, $constraint_name ) ) {
    # Execute the alter table
}

-- 
You are receiving this mail because:
You are watching all bug changes.