[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

--- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #38)
> (In reply to Kyle M Hall from comment #37)
> > Created attachment 55447 [details] [review] [review]
> > Bug 16911 [QA Followup] - No need to 'use C4::Members'
> > 
> > For some reason, this is causing t/db_dependent/Circulation.t to fail if
> > run independently.
> > 
> > Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
> 
> I do not understand this patch, the subroutine AddEnrolmentFeeIfNeeded from
> C4::Members is called from Koha::Patron. It would make sense to use it.

Do the unit tests fail for you without that patch? If not, maybe it's a quirk
of my environment. Because the call to AddEnrolmentFeeIfNeeded is fully
qualified, the 'use' is not needed, and would be unnecessary overhead ( though
incredibly minimal ).

If the tests pass for you without that patch, I'd be happy to revert that
specific commit.

-- 
You are receiving this mail because:
You are watching all bug changes.