From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 03:00:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2017 01:00:05 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 --- Comment #2 from Alex Buckley --- Created attachment 61764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61764&action=edit Bug 2545 - Removed credits being shown on the Pay fines tab. Now instead of showing a whole row for each credit there is a credit subtotal shown in order to make it clear what the users total outstanding fine is -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 03:09:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2017 01:09:49 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz --- Comment #3 from Alex Buckley --- Created attachment 61765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61765&action=edit Screenshot example of pay fines tab after patches for this bug are applied Test plan for patch "Bug 2545 - Removed credits being shown on the Pay fines tab": 1. From the Koha staff interface home page navigate to a Patron page 2. Create a fine for the patron (if one does not already exist) by clicking on the 'Fines' tab on the left hand side of the page and then creating a fine in the 'Create manual invoice' page 3. Create a credit for the patron in the 'Create manual credit' page 4. Then go to the 'Pay fines' tab and notice that there is a row for the fine and another for the credit 5. Apply the patch attached to this bug 6. Refresh the page 7. Notice there is no row for credit (as this attachment screenshot example shows) instead above the 'Total due' row there is a 'Credit subtotal' row with the amount of credit. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 03:10:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2017 01:10:06 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 05:34:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2017 03:34:24 +0000 Subject: [Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190 --- Comment #1 from Alex Buckley --- Created attachment 61766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61766&action=edit Bug 17190 - Marked REST API as mandatory (require = 1) in PerlDependencies.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 05:40:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2017 03:40:41 +0000 Subject: [Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz Status|NEW |Needs Signoff --- Comment #2 from Alex Buckley --- Hi Katrin I am assuming the changes you requested in this bug report were covered by the two minor changes I made in this patch. Test plan: 1. In your terminal view C4/Installer/PerlDependencies.pm and notice that the Mojolicious and swagger2 dependencies which use REST API are optionally required (i.e. have 'required' => '0') 2. Apply this patch 3. View C4/Installer/PerlDependencies.pm again and notice that Mojolicious and swagger2 now have mandatory dependency on REST API (i.e. 'require' => '1') -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 08:45:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2017 06:45:21 +0000 Subject: [Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- "yes it is a bit hacky" Not a bit imo LOL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 11:22:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2017 09:22:56 +0000 Subject: [Koha-bugs] [Bug 16355] Searching for items added before or after a specific date [ add item for label only] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16355 bestbookbuddies changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |info at bestbookbuddies.com |u | CC| |info at bestbookbuddies.com Status|NEW |Needs Signoff --- Comment #1 from bestbookbuddies --- Created attachment 61767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61767&action=edit Bug 16355 - Fix Searching for items added before or after a specific data As specified searching for items added before or after a specific data is not working in Koha 16.x while using MARC-21 format. After applying this patch desired result is generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 11:25:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2017 09:25:20 +0000 Subject: [Koha-bugs] [Bug 16355] Searching for items added before or after a specific date [ add item for label only] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16355 --- Comment #2 from bestbookbuddies --- As specified "Searching for items added before or after a specific date" is not working in Koha 16.x while using MARC-21. After applying this patch, desired result is generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 18:18:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2017 16:18:05 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 21:09:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2017 19:09:14 +0000 Subject: [Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 23:20:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2017 21:20:24 +0000 Subject: [Koha-bugs] [Bug 12930] Web installer does not show login errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 --- Comment #1 from Alex Buckley --- Created attachment 61768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61768&action=edit Bug 12930 - Implemented error message display for invalid username or password on web installer login Now InstallAuth.pm hands the invalid_username_or_password variable to the template file auth.tt if the user entered an invalid username or password and this is displayed to the user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 01:16:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2017 23:16:14 +0000 Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 02:54:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 00:54:42 +0000 Subject: [Koha-bugs] [Bug 12930] Web installer does not show login errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Alex Buckley --- The patch I have attached displays an error message if the user writes in an invalid username and/or password. The InstallAuth.pm module does not contain subroutines to check for permissions, session timeout, or if the ip address is different even though the markup checking for these in the auth.tt has been implemented. Regarding the nopermission check, as I understand it the only password that is valid to be written into this installer login is the database admin credentials and so I don't see why we need the nopermission check in the markup (as is required for the staff interface login). Test plan: 1. Restart memcached: sudo service memcached restart 2. Drop and recreate the database 3. Login with these pretend credentials: username: fred password: password 4. Notice the page refreshes and you get no "invalid username or password" error displayed 5. Apply the patch attached to this bug 6. Try logging in with the same username and password specified in step 3 7. Notice the page refreshes and a "invalid username or password' error message is displayed 8. Now login with the Koha database administrator account and notice you are logged in successfully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 12:40:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 10:40:30 +0000 Subject: [Koha-bugs] [Bug 18323] Create option to retain accountlines data when a borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- We have been trying to avoid this problem by basing reports on statistics/action_logs whenever possible. Maybe this could be helpful for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 16:56:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 14:56:23 +0000 Subject: [Koha-bugs] [Bug 18366] New: On shelf holds allowed > "If all unavailable" ignores library of the rule and considers all libraries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18366 Bug ID: 18366 Summary: On shelf holds allowed > "If all unavailable" ignores library of the rule and considers all libraries Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: costalc at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On shelf holds allowed : "If all unavailable" ignores library of the rule and considers all libraries will continue... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 17:47:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 15:47:00 +0000 Subject: [Koha-bugs] [Bug 18066] Hea - Version 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066 --- Comment #47 from Katrin Fischer --- Jonathan, is it ok to push this for 16.11.07? Will be my first Schema change patch, so want to push it early if possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 17:48:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 15:48:45 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 17:48:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 15:48:46 +0000 Subject: [Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Bug 17828 depends on bug 13757, which changed state. Bug 13757 Summary: Make patron attributes editable in the opac if set to 'editable in OPAC' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 17:50:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 15:50:14 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 17:50:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 15:50:15 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Bug 16892 depends on bug 10988, which changed state. Bug 10988 Summary: Allow login via Google OAuth2 (OpenID Connect) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 17:50:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 15:50:16 +0000 Subject: [Koha-bugs] [Bug 18144] Removal of persona broke Google OAuth2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 Bug 18144 depends on bug 10988, which changed state. Bug 10988 Summary: Allow login via Google OAuth2 (OpenID Connect) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 17:50:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 15:50:16 +0000 Subject: [Koha-bugs] [Bug 18118] Unexpected behaviour with 'GoogleOpenIDConnect' and ' OpacPublic' syspref combination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118 Bug 18118 depends on bug 10988, which changed state. Bug 10988 Summary: Allow login via Google OAuth2 (OpenID Connect) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 17:50:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 15:50:46 +0000 Subject: [Koha-bugs] [Bug 18144] Removal of persona broke Google OAuth2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17486 CC| |katrin.fischer at bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 [Bug 17486] Remove 'Mozilla Persona' as an authentication method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 17:50:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 15:50:46 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 [Bug 18144] Removal of persona broke Google OAuth2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 17:51:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 15:51:53 +0000 Subject: [Koha-bugs] [Bug 18144] Removal of persona broke Google OAuth2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #10 from Katrin Fischer --- bug 17586 is not in 18144, so this should not be needed. Please let me know, if I should be mistaken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 17:51:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 15:51:54 +0000 Subject: [Koha-bugs] [Bug 18118] Unexpected behaviour with 'GoogleOpenIDConnect' and ' OpacPublic' syspref combination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118 Bug 18118 depends on bug 18144, which changed state. Bug 18144 Summary: Removal of persona broke Google OAuth2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 17:59:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 15:59:36 +0000 Subject: [Koha-bugs] [Bug 18312] Export is broken unless a file is supplied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:09:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:09:43 +0000 Subject: [Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- I was able to reproduce this error on 16.11.x, but the patch doesn't apply cleanly. There is a conflict in Koha/Account.pm. Jonathan, could you please take a look? I'd really like this for 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:13:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:13:31 +0000 Subject: [Koha-bugs] [Bug 18058] 'borrowers-force-messaging-defaults --doit --truncate ' gives DBI error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18058 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.07. Could not reproduce the error before the patch, but it seems better with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:15:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:15:06 +0000 Subject: [Koha-bugs] [Bug 18270] No need to fetch the MARC record when deleting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18270 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Severity|minor |enhancement --- Comment #5 from Katrin Fischer --- Code enhancement. This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:15:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:15:35 +0000 Subject: [Koha-bugs] [Bug 18258] Add the Koha::Biblio->subscriptions method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #6 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:15:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:15:35 +0000 Subject: [Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Bug 18259 depends on bug 18258, which changed state. Bug 18258 Summary: Add the Koha::Biblio->subscriptions method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:16:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:16:03 +0000 Subject: [Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #11 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:16:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:16:04 +0000 Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Bug 15779 depends on bug 17844, which changed state. Bug 17844 Summary: Move C4::Koha::get_notforloan_label_of to Koha::AuthorisedValues https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:16:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:16:04 +0000 Subject: [Koha-bugs] [Bug 15799] Move authorised values related code into Koha:: AuthorisedValues - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 Bug 15799 depends on bug 17844, which changed state. Bug 17844 Summary: Move C4::Koha::get_notforloan_label_of to Koha::AuthorisedValues https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:16:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:16:35 +0000 Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Bug 15779 depends on bug 17847, which changed state. Bug 17847 Summary: Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:16:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:16:35 +0000 Subject: [Koha-bugs] [Bug 15799] Move authorised values related code into Koha:: AuthorisedValues - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 Bug 15799 depends on bug 17847, which changed state. Bug 17847 Summary: Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:16:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:16:34 +0000 Subject: [Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #9 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:18:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:18:49 +0000 Subject: [Koha-bugs] [Bug 14146] Add option to add restriction period when checking-in several overdues for same patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Additional days are not |Add option to add |added to restriction period |restriction period when |when checking-in several |checking-in several |overdues for same patron |overdues for same patron Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #26 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:19:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:19:24 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Bug 15449 depends on bug 18269, which changed state. Bug 18269 Summary: Move field mappings related code to Koha::FieldMapping[s] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:19:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:19:24 +0000 Subject: [Koha-bugs] [Bug 18269] Move field mappings related code to Koha::FieldMapping[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18269 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:20:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:20:22 +0000 Subject: [Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #11 from Katrin Fischer --- Dependencies are not in 16.11.x, so this is not needed there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:20:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:20:22 +0000 Subject: [Koha-bugs] [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 Bug 17961 depends on bug 17963, which changed state. Bug 17963 Summary: TT syntax for notices - Prove that AR_* are compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:20:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:20:23 +0000 Subject: [Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Bug 17964 depends on bug 17963, which changed state. Bug 17963 Summary: TT syntax for notices - Prove that AR_* are compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:22:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:22:09 +0000 Subject: [Koha-bugs] [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Bug 17965 depends on bug 17970, which changed state. Bug 17970 Summary: GetPreparedLetter does not warn when expected https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:22:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:22:08 +0000 Subject: [Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #11 from Katrin Fischer --- Dependency is not in 16.11.x, so this should not be needed there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:22:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:22:09 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Bug 17971 depends on bug 17970, which changed state. Bug 17970 Summary: GetPreparedLetter does not warn when expected https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:23:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:23:10 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #12 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:23:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:23:10 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Bug 17966 depends on bug 17971, which changed state. Bug 17971 Summary: TT syntax for notices - Add support for plurals https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:29:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:29:31 +0000 Subject: [Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #40 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:31:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:31:04 +0000 Subject: [Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Bug 17964 depends on bug 18332, which changed state. Bug 18332 Summary: Add the Koha::Objects->last method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18332 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:31:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:31:04 +0000 Subject: [Koha-bugs] [Bug 18332] Add the Koha::Objects->last method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18332 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #8 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:35:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:35:22 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 --- Comment #24 from Katrin Fischer --- Please see last comment! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:39:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:39:54 +0000 Subject: [Koha-bugs] [Bug 18367] New: Fix untranslatable string from Bug 18264 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367 Bug ID: 18367 Summary: Fix untranslatable string from Bug 18264 Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Bug 18264 added the following line to the .pl file: +my $inumber = $itemnumber ? "(blank) (itemnumber:$itemnumber)" : ""; This blank is untranslatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:40:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:40:27 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18367 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367 [Bug 18367] Fix untranslatable string from Bug 18264 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:40:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:40:27 +0000 Subject: [Koha-bugs] [Bug 18367] Fix untranslatable string from Bug 18264 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18264 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 [Bug 18264] Course reserves - use itemnumber for editing existing reserve items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:40:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:40:51 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #14 from Katrin Fischer --- I've filed bug 18367 about the string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:41:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:41:50 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #15 from Katrin Fischer --- Jonathan, could you please provide patches for 16.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:42:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:42:40 +0000 Subject: [Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:46:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:46:42 +0000 Subject: [Koha-bugs] [Bug 18022] Empty barcode causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #12 from Katrin Fischer --- Please ping me on IRC about patches for 16.11.x - almost missed this! :) This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:48:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:48:26 +0000 Subject: [Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #7 from Katrin Fischer --- You've persuaded me. This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:48:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:48:33 +0000 Subject: [Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:48:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:48:40 +0000 Subject: [Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:48:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:48:47 +0000 Subject: [Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:48:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:48:55 +0000 Subject: [Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:50:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:50:02 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #44 from Katrin Fischer --- If someone would be willing to test and sign-off for 16.11.x, I am willing to push this :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:51:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:51:52 +0000 Subject: [Koha-bugs] [Bug 18368] New: DBversion 16.12.00.022 not set by updatedatabase.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 Bug ID: 18368 Summary: DBversion 16.12.00.022 not set by updatedatabase.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:53:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:53:26 +0000 Subject: [Koha-bugs] [Bug 17758] SIP checkin does not handle holds correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Hm, must have missed this before? This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:54:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:54:47 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- What should we do about this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:55:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:55:06 +0000 Subject: [Koha-bugs] [Bug 18368] DBversion 16.12.00.022 not set by updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical --- Comment #1 from Marc V?ron --- Updating to 16.12.00.22 puts the upgrade process in an endless loop because DBversione is not set by updatedatabase.pl Missing line: SetVersion( $DBversion ) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:57:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:57:05 +0000 Subject: [Koha-bugs] [Bug 18173] Remove issues.return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:58:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:58:01 +0000 Subject: [Koha-bugs] [Bug 17728] Move C4::Reserves code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 Bug 17728 depends on bug 17736, which changed state. Bug 17736 Summary: Move GetReservesFromBiblionumber to Koha::Biblio->holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:58:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:58:01 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Bug 17737 depends on bug 17736, which changed state. Bug 17736 Summary: Move GetReservesFromBiblionumber to Koha::Biblio->holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:58:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:58:00 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #62 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 18:58:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 16:58:46 +0000 Subject: [Koha-bugs] [Bug 17560] Hold fee placement at point of checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #58 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:00:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:00:45 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #45 from Katrin Fischer --- (In reply to Martin Renvoize from comment #43) > OK.. Passing QA. > > I'm happy with the code here, and it moves us towards a more secure by > default model. > > However, we'll need to highlight in the release notes that this patch > effectively removes the auth by password comparison option from koha.. one > always binds with this model. I don't think this is a bad move and I've yet > to ever come across somewhere that actually requires a password comparison > regime. > > We should push and fix the consequences in this case in my opinion. If this is removing a 'feature' I is not suitable for pushing to a stable release. Martin, can you please take a look and confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:02:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:02:58 +0000 Subject: [Koha-bugs] [Bug 18368] DBversion 16.12.00.022 not set by updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:03:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:03:04 +0000 Subject: [Koha-bugs] [Bug 12913] Fix wrong inventory results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.07. . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:03:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:03:26 +0000 Subject: [Koha-bugs] [Bug 18368] DBversion 16.12.00.022 not set by updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 --- Comment #2 from Marc V?ron --- Created attachment 61769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61769&action=edit Bug 18368 - DBversion 16.12.00.022 not set by updatedatabase.pl Updating to 16.12.00.22 puts the upgrade process in an endless loop because DBversione is not set by updatedatabase.pl Missing line: SetVersion( $DBversion ) This patch inserts the line as appropriate. To test: - Apply patch - Verify code change makes sense - Verify that upgrade smoothly runs through -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:04:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:04:08 +0000 Subject: [Koha-bugs] [Bug 18329] Batch record deletion broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Dependency indicates that we will need to resolve 18242 first before this can be pushed to 16.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:04:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:04:12 +0000 Subject: [Koha-bugs] [Bug 18368] DBversion 16.12.00.022 not set by updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:05:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:05:43 +0000 Subject: [Koha-bugs] [Bug 8548] Add callnumber sort option to overdue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8548 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Severity|normal |enhancement Status|Pushed to Master |RESOLVED --- Comment #12 from Katrin Fischer --- Nice patch, but I think more an enhancement than a bug fix! This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:06:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:06:18 +0000 Subject: [Koha-bugs] [Bug 18366] On shelf holds allowed > "If all unavailable" ignores library of the rule and considers all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18366 Claudio changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:08:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:08:12 +0000 Subject: [Koha-bugs] [Bug 17708] Renewal log seems empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #28 from Katrin Fischer --- This adds a new system preference and appears more like an enh to me. Not pushing to 16.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:09:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:09:27 +0000 Subject: [Koha-bugs] [Bug 14535] Late orders does not show orders with price = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #26 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.07. . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:10:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:10:23 +0000 Subject: [Koha-bugs] [Bug 18244] Patron card creator does not take in account fields with underscore ( B_address etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #16 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:15:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:15:30 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #23 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.07. . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:15:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:15:38 +0000 Subject: [Koha-bugs] [Bug 18321] One more checkouts possible than allowed by rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61759|0 |1 is obsolete| | --- Comment #15 from Marc V?ron --- Created attachment 61770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61770&action=edit Bug 18321: Add tests Clean a bit existing tests by adding default values and add a test to highlight the issue. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:17:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:17:10 +0000 Subject: [Koha-bugs] [Bug 12972] Transfer slip and transfer message (blue box) can conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12972 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:19:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:19:09 +0000 Subject: [Koha-bugs] [Bug 18321] One more checkouts possible than allowed by rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61760|0 |1 is obsolete| | --- Comment #16 from Marc V?ron --- Created attachment 61771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61771&action=edit Bug 18321: Correctly calculate switch_onsite_checkout Silly error here, the $switch_onsite_checkout is not correctly calculated, it should not only be set to the value of the syspref, but meet all the conditions. Test plan: Set a circ rule with number of on-site checkout = 2 and number of checkouts = 2. Switch on both ConsiderOnSiteCheckoutsAsNormalCheckouts and SwitchOnSiteCheckouts Do a regular checkout Do another regular checkout At this point you have reach the maximum number of checkouts allowed. Not try another one. => Without this patch you will not get the warning => With this patch you will see it Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:20:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:20:36 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #23 from Katrin Fischer --- While the behaviour is a bit odd at the moment, the patch proposes a behaviour change and should not be a sudden surprise in a stable release in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:22:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:22:04 +0000 Subject: [Koha-bugs] [Bug 18321] One more checkouts possible than allowed by rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #17 from Marc V?ron --- Jonathan, this Bug was marked as assigned but the patches work, so I assume that you forgot to set to NSO. Switching to NSO and then to Signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:22:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:22:15 +0000 Subject: [Koha-bugs] [Bug 18321] One more checkouts possible than allowed by rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:25:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:25:09 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #24 from Katrin Fischer --- Btw, this also appears to change the acq claim and order notices if I am reading the code correctly, but it isn't noted in the database update message or bug title. Marcel, could you take a look please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:25:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:25:18 +0000 Subject: [Koha-bugs] [Bug 18367] Fix untranslatable string from Bug 18264 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:28:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:28:47 +0000 Subject: [Koha-bugs] [Bug 17346] Enable the check in option in Columns settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Holding back on this because of comment#5 for the stable release. Please link the new bug with this one once opened. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:29:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:29:46 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #11 from Katrin Fischer --- Dependency is not in 16.11.x, so this should not be needed there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:31:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:31:43 +0000 Subject: [Koha-bugs] [Bug 18209] Patron's card manage.pl page is not fully translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18209 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #9 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:32:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:32:52 +0000 Subject: [Koha-bugs] [Bug 18307] Branchname is no longer displayed in subscription tab view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #8 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:34:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:34:01 +0000 Subject: [Koha-bugs] [Bug 17290] Standardize on "Patron categories" when referring to patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:37:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:37:43 +0000 Subject: [Koha-bugs] [Bug 18263] Make use of syspref 'CurrencyFormat' for Account and Pay fines tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18263 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #5 from Katrin Fischer --- Hm, this could also be seen as an enhancement to the current views. In sake of more consistency in this part of Koha, I am pushing this to 16.11.x to be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:38:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:38:32 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #11 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:39:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:39:11 +0000 Subject: [Koha-bugs] [Bug 17946] Show number of subscriptions on tab in OPAC record details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #12 from Katrin Fischer --- Nice! This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:39:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:39:11 +0000 Subject: [Koha-bugs] [Bug 18307] Branchname is no longer displayed in subscription tab view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Bug 18307 depends on bug 17946, which changed state. Bug 17946 Summary: Show number of subscriptions on tab in OPAC record details https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:39:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:39:47 +0000 Subject: [Koha-bugs] [Bug 18134] Batch authority record modification Preview MARC button needs updating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18134 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:40:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:40:39 +0000 Subject: [Koha-bugs] [Bug 18181] Can' t tell which subscriptions already have routing lists if seeing all subs attached to a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #8 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:42:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:42:02 +0000 Subject: [Koha-bugs] [Bug 4969] Vendors can not be deleted / show only active vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #29 from Katrin Fischer --- Like! This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:42:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:42:45 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #39 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:43:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:43:35 +0000 Subject: [Koha-bugs] [Bug 14365] SQL Reports Last Edit Date column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:43:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:43:41 +0000 Subject: [Koha-bugs] [Bug 14365] SQL Reports Last Edit Date column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14365 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:44:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:44:05 +0000 Subject: [Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #15 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:44:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:44:06 +0000 Subject: [Koha-bugs] [Bug 16895] Allow writeoffs via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 Bug 16895 depends on bug 16757, which changed state. Bug 16757 Summary: Add ability to pay fee by id for SIP2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:45:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:45:05 +0000 Subject: [Koha-bugs] [Bug 17945] Breadcrumbs broken on opac-serial-issues.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17945 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #8 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:45:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:45:37 +0000 Subject: [Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #15 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:46:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:46:00 +0000 Subject: [Koha-bugs] [Bug 18174] Add the Koha::Object->update method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18174 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:46:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:46:00 +0000 Subject: [Koha-bugs] [Bug 18314] Account lockout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 Bug 18314 depends on bug 18174, which changed state. Bug 18174 Summary: Add the Koha::Object->update method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18174 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:46:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:46:00 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Bug 18235 depends on bug 18174, which changed state. Bug 18174 Summary: Add the Koha::Object->update method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18174 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:46:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:46:43 +0000 Subject: [Koha-bugs] [Bug 18200] Fix a potential issue with preceding space in GetMarcUrls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18200 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #7 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:47:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:47:25 +0000 Subject: [Koha-bugs] [Bug 18303] Release team omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 Bug 18303 depends on bug 18302, which changed state. Bug 18302 Summary: Release team 17.05 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18302 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:47:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:47:25 +0000 Subject: [Koha-bugs] [Bug 18302] Release team 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18302 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Obviously not for 16.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:47:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:47:53 +0000 Subject: [Koha-bugs] [Bug 18304] Do not mail cart or list contents to the library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18304 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #8 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:48:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:48:31 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #83 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:48:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:48:33 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Bug 12027 depends on bug 12026, which changed state. Bug 12026 Summary: Shibboleth auto-provisioning https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:49:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:49:13 +0000 Subject: [Koha-bugs] [Bug 18189] Elasticsearch sorting broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer --- Is enh correct here or should this not be a bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:49:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:49:48 +0000 Subject: [Koha-bugs] [Bug 17014] Remove more event attributes from patron templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #8 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:50:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:50:55 +0000 Subject: [Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 Bug 18339 depends on bug 17828, which changed state. Bug 17828 Summary: Koha::Patron::Attribute->store should raise an exception if unique_id is being broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:50:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:50:55 +0000 Subject: [Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #22 from Katrin Fischer --- Dependency is not in 16.11.x, so this should not be needed there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:51:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:51:43 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Bug 15449 depends on bug 17825, which changed state. Bug 17825 Summary: Remove C4::Members::AttributeTypes::AttributeTypeExists https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17825 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:51:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:51:43 +0000 Subject: [Koha-bugs] [Bug 17825] Remove C4::Members::AttributeTypes::AttributeTypeExists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Dependency is not in 16.11.x so this should not be needed there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:58:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:58:59 +0000 Subject: [Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61766|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 61772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61772&action=edit Bug 17190 - Marked REST API as mandatory (require = 1) in PerlDependencies.pm For testing I went in Staff client to Home > About Koha > tab Perl modules and verified that both Mojolicious (6.0) and Swagger2 (0.59) are marked as mandatory. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 19:59:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 17:59:27 +0000 Subject: [Koha-bugs] [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 20:11:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 18:11:14 +0000 Subject: [Koha-bugs] [Bug 12930] Web installer does not show login errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Hi Alex I do not understand the empty else branch in https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61768&action=diff#a/C4/InstallAuth.pm_sec5 Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 20:50:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 18:50:18 +0000 Subject: [Koha-bugs] [Bug 18366] On shelf holds allowed > "If all unavailable" ignores library of the rule and considers all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18366 --- Comment #1 from Claudio --- On shelf holds allowed : "If all unavailable" ignores library of the rule and considers all libraries to make a reserve. 1) Supose there's a Koha instance with two libraries: A and B. Both libraries are configured -> On shelf holds allowed : "If all unavailable" in the issuingrules table 2) There's a record catalogued with two items attached: one for library A and one for library B 3) The items are barcode 100 (library A) and barcode 200 (library B) 4) We check-out item 100 5) Now item 100 is checked-out so "all items are unavailable" in library A 6) And item 200 is "available" in library B 7) Then if we try to make a reserve for a user of library A Koha refuse to do because of "there's no item available to make the reserve" (remember point 5) 8) Now we check-out item 200 of library B 9) If we try to make a reserve for a user of library A again, Koha makes de reserve correctly So it seems Koha does not respect the library configuration rule when tries to make a reserve but considers all availability status of all items of all libraries instead. In my opinion this is wrong. Syspref IndependentBranches has no effect (it is set to OFF). Syspref canreservefromotherbranches has no effect (it is set to OFF) BZ 18150 has no effect. Tested in 16.11.06 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 2 23:32:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Apr 2017 21:32:16 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #11 from Chris Cormack --- We could do a patch that adds the cd /tmp && Otherwise we could try to fix the upstream module, to work better with perl 5.22 and cron. But yeah, it's an upstream problem, I think the module is pretty much unmaintained, maybe finding a better module is a better plan. Maybe the cd /tmp && for cron patch, and then work on a long term solution? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 03:00:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 01:00:50 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #14 from M. Tompsett --- (In reply to Katrin Fischer from comment #13) > I am applying the "It doesn't hurt it's there right now" rule, minimizing > risk that his could theoretically cause a new bug :) Wise call. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 07:39:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 05:39:31 +0000 Subject: [Koha-bugs] [Bug 18368] DBversion 16.12.00.022 not set by updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 07:39:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 05:39:33 +0000 Subject: [Koha-bugs] [Bug 18368] DBversion 16.12.00.022 not set by updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61769|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 61773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61773&action=edit Bug 18368 - DBversion 16.12.00.022 not set by updatedatabase.pl Updating to 16.12.00.22 puts the upgrade process in an endless loop because DBversione is not set by updatedatabase.pl Missing line: SetVersion( $DBversion ) This patch inserts the line as appropriate. To test: - Apply patch - Verify code change makes sense - Verify that upgrade smoothly runs through Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 07:59:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 05:59:30 +0000 Subject: [Koha-bugs] [Bug 11113] Title of pages are not easy to translate in some languages, especially in french In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11113 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:00:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:00:50 +0000 Subject: [Koha-bugs] [Bug 5016] Basket PDF has several non-translatable issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:01:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:01:41 +0000 Subject: [Koha-bugs] [Bug 11494] Pay patron fines shows cryptic, untranslatable, account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11494 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:02:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:02:12 +0000 Subject: [Koha-bugs] [Bug 11506] Untranslatable table headers in several perl files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11506 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:05:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:05:05 +0000 Subject: [Koha-bugs] [Bug 11276] Sprite icons not in right spot on translated templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11276 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- (In reply to Owen Leonard from comment #1) > FWIW I believe this bug does not affect the Bootstrap theme. Still valid? - Can bug be closed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:05:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:05:31 +0000 Subject: [Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:05:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:05:52 +0000 Subject: [Koha-bugs] [Bug 11971] Untranslatable "Reserve Charge" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11971 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:06:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:06:46 +0000 Subject: [Koha-bugs] [Bug 12130] Translations should live in /var not /usr for package installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12130 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:07:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:07:15 +0000 Subject: [Koha-bugs] [Bug 12129] Translations should be removed when koha-common package is removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12129 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:07:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:07:53 +0000 Subject: [Koha-bugs] [Bug 12208] schema.org microdata should not be picked up for translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12208 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:08:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:08:24 +0000 Subject: [Koha-bugs] [Bug 11527] Do not pick up MARC subfield codes for translation from XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11527 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:09:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:09:06 +0000 Subject: [Koha-bugs] [Bug 12221] Remove TT statement placeholders from translatable strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12221 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:09:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:09:40 +0000 Subject: [Koha-bugs] [Bug 13187] Access keys should be localizable/translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13187 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:27:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:27:12 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 --- Comment #3 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:27:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:27:44 +0000 Subject: [Koha-bugs] [Bug 4503] Javascript files in js directory are not translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4503 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:28:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:28:10 +0000 Subject: [Koha-bugs] [Bug 10001] Translation scripts pick up TT comments for translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10001 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:30:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:30:35 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 --- Comment #4 from Katrin Fischer --- Hm, needs testing? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:50:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:50:35 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #25 from Marcel de Rooy --- Created attachment 61774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61774&action=edit Bug 17866: [QA Follow-up] Add forgotten SetVersion call In db revision 16.12.00.022. Signed-off-by: Marcel de Rooy Current status: REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:50:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:50:58 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:51:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:51:05 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 08:51:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 06:51:12 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:03:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:03:30 +0000 Subject: [Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #3 from Julian Maurice --- If LOCK TABLE commits any active transaction, is it useful to start a transaction just before (line 3385) ? > Better ideas are welcome! While it may be a change too big for this patch, has someone already considered using a separate database for tests ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:08:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:08:39 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #26 from Katrin Fischer --- Marcel, did you see my comment? There is also already another bug for this: bug 18368. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:10:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:10:47 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #27 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #23) > While the behaviour is a bit odd at the moment, the patch proposes a > behaviour change and should not be a sudden surprise in a stable release in > my opinion. Looks like a good decision to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:11:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:11:29 +0000 Subject: [Koha-bugs] [Bug 18368] DBversion 16.12.00.022 not set by updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61773|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 61775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61775&action=edit Bug 18368 - DBversion 16.12.00.022 not set by updatedatabase.pl Updating to 16.12.00.22 puts the upgrade process in an endless loop because DBversione is not set by updatedatabase.pl Missing line: SetVersion( $DBversion ) This patch inserts the line as appropriate. To test: - Apply patch - Verify code change makes sense - Verify that upgrade smoothly runs through Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:11:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:11:43 +0000 Subject: [Koha-bugs] [Bug 18368] DBversion 16.12.00.022 not set by updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:12:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:12:27 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61774|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:12:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:12:42 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Passed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:13:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:13:02 +0000 Subject: [Koha-bugs] [Bug 18368] DBversion 16.12.00.022 not set by updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:14:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:14:15 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #28 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #24) > Btw, this also appears to change the acq claim and order notices if I am > reading the code correctly, but it isn't noted in the database update > message or bug title. Marcel, could you take a look please? $type eq 'claimacquisition' or $type eq 'claimissues' or $type eq 'orderacquisition' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:14:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:14:30 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Change sender for serial |Change sender for claim |claim notifications |notifications -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:19:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:19:38 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #29 from Marcel de Rooy --- Changed the title. Maybe we should rephrase the dbrev message too. Include the acq claim at least. The other one is a new feature from 16.11, not widely used yet probably. (But you will use it already :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:24:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:24:34 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #30 from Marcel de Rooy --- Reopening it again :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:24:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:24:55 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:24:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:24:58 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #31 from Marcel de Rooy --- Created attachment 61776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61776&action=edit Bug 17866: [QA Follow-up] Change wording of db revision As Katrin noted on the report, we should not limit the db rev message to the serial claims only. Applies to acquisision claims too. Note: Strictly speaking, we could also mention the new ACQORDER notice, but this will not yet be widely used. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:25:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:25:09 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:25:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:25:17 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:25:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:25:35 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #32 from Marcel de Rooy --- Kyle: please push the last patch too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:31:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:31:26 +0000 Subject: [Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364 --- Comment #4 from Marcel de Rooy --- (In reply to Julian Maurice from comment #3) > If LOCK TABLE commits any active transaction, is it useful to start a > transaction just before (line 3385) ? Would it solve the problem? Can imagine that LOCK does not like a nested transaction either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:34:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:34:15 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61583|Bug 17866: Change sender |[PUSHED] Bug 17866: Change description|for serial claim |sender for serial claim |notifications |notifications -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:34:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:34:34 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61584|Bug 17866: [QA Follow-up] |[PUSHED] Bug 17866: [QA description|Add notification for |Follow-up] Add notification |changed sender address |for changed sender address -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:34:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:34:43 +0000 Subject: [Koha-bugs] [Bug 12930] Web installer does not show login errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 --- Comment #4 from Alex Buckley --- Created attachment 61777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61777&action=edit Bug 12930 - Followup removing empty else branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:34:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:34:51 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61585|Bug 17866: [QA Follow-up] |[PUSHED] Bug 17866: [QA description|Reword message for missing |Follow-up] Reword message |email address |for missing email address -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:37:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:37:09 +0000 Subject: [Koha-bugs] [Bug 12930] Web installer does not show login errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 --- Comment #5 from Alex Buckley --- Thanks for noticing that Marc, I forgot to remove it. The followup patch I have just attached removes it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:44:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:44:51 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim and order notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Change sender for claim |Change sender for claim and |notifications |order notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 09:53:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 07:53:18 +0000 Subject: [Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|koha-bugs at lists.koha-commun |techservspec at gmail.com |ity.org | Version|3.22 |master --- Comment #6 from Marcel de Rooy --- I guess the Version (== 3.22) left this patch in the queue last friday.. It seems to be directed for master. Changing the version. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:02:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:02:21 +0000 Subject: [Koha-bugs] [Bug 15854] Race condition for sending renewal/check-in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854 --- Comment #16 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #15) > Stable releases should be safe, SendCirculationAlert is not covered by tests It may not be called directly from a test. But what about indirect calls? Maybe from AddReturn or AddRenewal or AddIssue ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:26:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:26:36 +0000 Subject: [Koha-bugs] [Bug 18300] Delete missing upload records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18300 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61470|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 61778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61778&action=edit Bug 18300: Delete missing upload records If you deleted files from the upload directories manually, or you rebooted with files in the temporary upload folder, or for some other reason have records without a file, you may want to cleanup your records in the uploaded_files table. This patch adds the method delete_missing to Koha::UploadedFiles. It also supports a keep_record parameter to do a dry run (count the missing files first). Also, we add an option --uploads-missing to cleanup_database. If you add the flag 1 after this option, you will delete missing files. If you add the flag 0 or only use the option, you will count missing files. A subtest is added to Upload.t for delete_missing tests. Test plan: [1] Run t/db_dependent/Upload.t [2] Upload a file and delete the file manually. [3] Run cleanup_database.pl --uploads-missing It should report at least one missing file now. Check that the record has not been deleted. [4] Run cleanup_database.pl --uploads-missing 1 It should report that it removed at least one file. Check that the record is gone. Signed-off-by: Marcel de Rooy Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:27:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:27:14 +0000 Subject: [Koha-bugs] [Bug 18300] Delete missing upload records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18300 --- Comment #4 from Marcel de Rooy --- Rebased on top of changes in report 17669 (cleanup_database.pl) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:28:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:28:28 +0000 Subject: [Koha-bugs] [Bug 18317] Allow check out of already checked out items trough sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18317 Marianne Rolfsen changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:28:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:28:51 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #55 from Marcel de Rooy --- Rebasing this one now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:30:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:30:57 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60594|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy --- Created attachment 61779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61779&action=edit Bug 9988: Database revision for AuthorityMergeLimit Introduce the new preference and remove dontmerge. If dontmerge was enabled, the new pref will be set to zero and we will print a message about raising this value now. Test plan: Run the database revision or a new install. In case of an upgrade, check the new pref value. Should be 0 when dontmerge was enabled, otherwise 50. Signed-off-by: Marcel de Rooy Also tested sysprefs.sql on a new database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:31:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:31:03 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60595|0 |1 is obsolete| | --- Comment #57 from Marcel de Rooy --- Created attachment 61780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61780&action=edit Bug 9988: Table revision for need_merge_authorities In order to let merge do exactly the same when called from the merge cron job, we need three additional fields in the table. The use of these fields will be explained in a follow-up. Test plan: Run the dbrev (updatestructure step in webinstaller). Signed-off-by: Marcel de Rooy Also tested running kohastructure.sql for this table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:31:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:31:08 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60596|0 |1 is obsolete| | --- Comment #58 from Marcel de Rooy --- Created attachment 61781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61781&action=edit Bug 9988: DBIx schema changes for need_merge_authorities As generated by misc/devel/update_dbix_class_files.pl. No test plan. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:31:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:31:12 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60597|0 |1 is obsolete| | --- Comment #59 from Marcel de Rooy --- Created attachment 61782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61782&action=edit Bug 9988: Add Koha objects for table need_merge_authorities This patch adds two Koha objects: MergeRequest(s). MergeRequest has a new method and an oldmarc method. A class method reporting_tag_xml is added to MergeRequests.pm. All new routines are tested in Authorities.t. Removes a few unneeded modules from Koha::Authority. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:31:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:31:17 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60598|0 |1 is obsolete| | --- Comment #60 from Marcel de Rooy --- Created attachment 61783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61783&action=edit Bug 9988: Add extract_biblionumber to Koha/SearchEngine When we will replace the Zebra code in sub merge, we will call SearchEngine to pass records and we need a routine to extract a biblionumber from a search result record. A record from Zebra still must be converted to MARC::Record. This is no longer needed for a ElasticSearch record. Test plan: Run t/db_dependent/Koha/SearchEngine/Search.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:31:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:31:22 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60599|0 |1 is obsolete| | --- Comment #61 from Marcel de Rooy --- Created attachment 61784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61784&action=edit Bug 9988: Add get_usage_count and linked_biblionumbers to Koha::Authority When replacing the Zebra code in sub merge, we actually need CountUsage as well as the results it gets from SearchEngine. In order to get count and/or results, we now create: [1] instance methods get_usage_count and linked_biblionumbers in Koha::Authority, [2] class methods of the same name in Koha::Authorities. The instance method calls the class method. The class method can be used for deleted authority records, and in 'legacy calls' before refactoring. Note: On BZ 18149 we will replace all CountUsage calls. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:31:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:31:27 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60668|0 |1 is obsolete| | --- Comment #62 from Marcel de Rooy --- Created attachment 61785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61785&action=edit Bug 9988: Merge should have a parameter hash We will need a few additional parameters for merge later on. This patch puts the original parameters in a parameter hash. For the same reason DelAuthority gets a parameter hash here. Note: We remove the second parameter from the DelAuthority call in authorities/authorities-home.pl here. It was not used and could have presented problems in the future. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t. [2] Run t/db_dependent/Authorities/Merge.t. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:31:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:31:32 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60669|0 |1 is obsolete| | --- Comment #63 from Marcel de Rooy --- Created attachment 61786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61786&action=edit Bug 9988: Remove the Zebra code from sub merge Since we can now call linked_biblionumbers, we can now remove all Zebra related code from merge. We also add a parameter biblionumbers; we use it in the test now, but it may be handy too later in the maintenance script when we want to trigger a merge for specific biblionumber(s). See bug report 18071. All mocks for ZOOM, Context::Zconn, Search::new_record_for_zebra in the merge test can now be replaced by one mock for linked_biblionumbers. Note that we test the biblionumbers parameter in the last subtest without that mock. Remove unused vars $countunmodifiedbiblio, $counterrors from merge. Renamed zebrarecords to linkedrecords in the Merge test. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Modify an authority record. Check the linked biblio records. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:31:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:31:37 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60670|0 |1 is obsolete| | --- Comment #64 from Marcel de Rooy --- Created attachment 61787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61787&action=edit Bug 9988: Check the merge limit in sub merge At this point, we are replacing dontmerge functionality by the new AuthorityMergeLimit logic. Instead of doing this check before calling merge, we just call merge and check it there. In order to let the cron job do the larger (postponed) merges, we add a parameter override_limit. A subtest is added in Merge.t to test the 'postponed merge' feature. Since merge now also calls get_usage_count, an additional mock is added. All references to dontmerge are removed. In merge two lines, initializing $dbh and $counteditbiblios, are moved. The dontmerge test in DelAuthority and ModAuthority is removed. Since this did not leave much in ModAuthority, I fixed the whitespace on the remaining lines rightaway (yes, I know). A minimal set of changes is applied to the cron script; it will get further attention on a next patch. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Set AuthorityMergeLimit to 2. Modify an authority with two linked biblios. Check that the merge was done immediately. [3] Now modify an authority with more than 2 linked records. Verify that the merge was postponed; a record must be inserted in the need_merge_authorities table. [4] Testing of the merge cron job is *postponed* to a next patch. Note: I tested a modification, but the script just needs more attention. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:31:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:31:43 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60671|0 |1 is obsolete| | --- Comment #65 from Marcel de Rooy --- Created attachment 61788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61788&action=edit Bug 9988: Remove further references to dontmerge [1] The preference was sent to HEA. We can now send both AuthorityMergeMode as well as AuthorityMergeLimit. [2] A comment in authorities/merge.pl is removed. Note that a subsequent patch will modify and test the cron job. [3] Script misc/batchRebuildItemsTables.pl temporarily enabled dontmerge. This is equivalent to setting the mergelimit to zero. The function defnonull is no longer needed. (If the pref was NULL, we restore that value. Sub merge won't mind.) Test plan: [1] Run t/db_dependent/UsageStats.t [2] Run misc/batchRebuildItemsTables.pl -t This just ensures you it still compiles; the changes speak for itself. [3] Now git grep on dontmerge. You should only find hits in atomicupdate and misc/translator/po. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:31:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:31:48 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61306|0 |1 is obsolete| | --- Comment #66 from Marcel de Rooy --- Created attachment 61789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61789&action=edit Bug 9988: Add a subtest for specific postponed merge issues This subtest shows that we need a few little tweaks to make merge work in some specific postponed merge situations. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should fail. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:31:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:31:52 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61307|0 |1 is obsolete| | --- Comment #67 from Marcel de Rooy --- Created attachment 61790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61790&action=edit Bug 9988: Few subtle changes for postponed merge The fails in the previous test showed that we need the first three changes here. Some final polishing in points 4 to 6. [1] Sub merge: Refine the condition for initializing $tags_new. A postponed 'modify'-merge (A to B) makes that $authtypefrom is not defined when running merge later. When crossing the type boundary, we need a new field too. [2] Sub merge: Add condition for an empty @record_to array. This indicates also that a field should be removed, since we should otherwise only add a $9 subfield. [3] Sub merge: Adjust initializing @record_from. This change is tested by verifying a cleared subfield in the test. [4] DelAuthority: Adding a skipmerge parameter to allow the call from authorities/merge.pl to skip an unneeded merge. This also prevents that the 'delete-merge' would precede the 'modify-merge' under a hypothetical race condition. [5] DelAuthority: There is actually no need to call GetAuthority. The subfields of the old record are not relevant in this case. [6] Added a few POD lines to merge. [7] Removed a trailing space in a comment line in merge. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should no longer fail now. [2] See test plan of next patch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:31:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:31:57 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61308|0 |1 is obsolete| | --- Comment #68 from Marcel de Rooy --- Created attachment 61791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61791&action=edit Bug 9988: Refactor the cron script The cron job is moved from migration tools to cronjobs. And renamed to a plural form. The script is now based on Koha objects. It does no longer include the code to merge one record. This can be done via the interface, and will be added to a maintenance script on bug 18071. Should not be part of this cron job. Adding a cron_cleanup method to MergeRequests; this method is called from the cron script to reset older entries still marked in progress and to also remove old processed entries. Tested in a separate unit test. Test plan: [1] Run t/db_dependent/Authorities/MergeRequests.t [2] Set AuthorityMergeLimit to 0. (All merges are postponed.) [3] Modify an authority linked to a few records. [4] Delete an authority linked to a few records with batch delete tool. [5] And select two auth records with linked records. Merge these two records with authority/merge.pl. Note: Do not select Default. See also bug 17380. [6] Check the need_merge_authorities table for inserted records. [7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked records and the record status in need_merge_authorities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 10:32:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 08:32:02 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61309|0 |1 is obsolete| | --- Comment #69 from Marcel de Rooy --- Created attachment 61792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61792&action=edit Bug 9988: Add the cronjob and print an upgrade message The Debian cron file and the misc crontab example are updated. A message is printed when upgrading. Note: At this moment the merge cron job is run once a day. This is imo a good starting point. The load for this job greatly depends on the value of pref AuthorityMergeLimit. Of course you can schedule the job more often, and if this need is felt more globally, we can adjust it later. Test plan: [1] Run the dbrev and see the message. [2] Read the changes to the cron files. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 12:11:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 10:11:27 +0000 Subject: [Koha-bugs] [Bug 18369] New: Broken title link in UNIMARC catalog search results table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 Bug ID: 18369 Summary: Broken title link in UNIMARC catalog search results table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: synapse.ova at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In staff client, ?Search the catalog? returns a table, where biblio title has a broken link (biblionumber is absent), yet other links works good (Holds, Edit Record, Edit items, OPAC view) Steps to Reproduce: In staff client, search the catalog (Cataloging ? ?Search the catalog? (/cgi-bin/koha/catalogue/search.pl)) Actual Results: Title of the biblio has a link, that doesn't have biblionumber Expected Results: Title of the biblio should have a link with a proper biblionumber at the end Additional Information: Each biblio in the results table is shown by XSL transformation of MARC data. XSL (\intranet-tmpl\prog\en\xslt\UNIMARCslim2intranetResults.xsl) prepares a link, and adds a biblionumber, that it expects to get from controlfield 001. But since this field could be either empty or contain something different than biblionumber (see https://lists.katipo.co.nz/public/koha/2015-September/043652.html), it is better to pass the biblionumber to this script. This script is already receiving sysprefs (that is not according to marcxml standart), so I suggest to pass the biblionumber the same way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 12:27:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 10:27:52 +0000 Subject: [Koha-bugs] [Bug 18368] DBversion 16.12.00.022 not set by updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 12:31:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 10:31:40 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim and order notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #33 from Kyle M Hall --- Followup pushed for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 12:37:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 10:37:51 +0000 Subject: [Koha-bugs] [Bug 18093] Add the Koha::Objects->get_column method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 12:39:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 10:39:36 +0000 Subject: [Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Pushed to master for 17.05, thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 13:09:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 11:09:30 +0000 Subject: [Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61685|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 13:33:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 11:33:16 +0000 Subject: [Koha-bugs] [Bug 18369] Broken title link in UNIMARC catalog search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |synapse.ova at gmail.com |ity.org | Status|NEW |Needs Signoff --- Comment #1 from Oleg Vasilenko --- Created attachment 61793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61793&action=edit Bug 18369: Broken title link in UNIMARC catalog search results table Patch adds biblionumber to XSLT the same way Sysprefs are added, in the C4/XSLT.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 13:37:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 11:37:22 +0000 Subject: [Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #8 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #2) > I tried to imagine why this was introduced; perhaps it was meant as a > compare with the last inventory date. But since all scanned items are > already updated, this compare does not work. > > I will remove this section on bug 12913. But this section could still be handy when we allow the use of datelastseen without the barcode file.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 13:45:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 11:45:25 +0000 Subject: [Koha-bugs] [Bug 18369] Broken title link in UNIMARC catalog search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17730 --- Comment #2 from Oleg Vasilenko --- This problem happens in 16.05+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 13:45:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 11:45:25 +0000 Subject: [Koha-bugs] [Bug 17730] Uniform mapping for biblio.biblionumber (Unimarc) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17730 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18369 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 14:25:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 12:25:10 +0000 Subject: [Koha-bugs] [Bug 18370] New: Columns settings patrons>id=memberresultst : bug with Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 Bug ID: 18370 Summary: Columns settings patrons>id=memberresultst : bug with Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When checking box on Patrons > id=memberresultst (menu Administration > Column settings), displays are different if a superadmin is connected or if it's an other user, on the staff interface. For exemple : - when "Fines" is checked, a super admin doesn't see the column "Fines" but an other user sees the "Fines" but not the "Circ notes" column. - when "Circ_notes" is checked, a superadmin doesn't see the column but an other user sees it. Seen on different versions of Koha (3.20, 16.05, 16.11). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 14:25:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 12:25:31 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Columns settings |Columns settings |patrons>id=memberresultst : |patrons>id=memberresultst : |bug with |display bug -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 14:35:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 12:35:04 +0000 Subject: [Koha-bugs] [Bug 15854] Race condition for sending renewal/check-in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854 --- Comment #17 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #16) > (In reply to Jonathan Druart from comment #15) > > Stable releases should be safe, SendCirculationAlert is not covered by tests > > It may not be called directly from a test. > But what about indirect calls? Maybe from AddReturn or AddRenewal or > AddIssue ? AFAIK we do not have tests covering messaging preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 14:47:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 12:47:19 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 --- Comment #5 from Jonathan Druart --- acqui/basket.pl: $line{rrp_tax_excluded} .= ' (Uncertain)'; acqui/invoice.pl: $line{rrp} .= ' (Uncertain)'; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 14:50:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 12:50:17 +0000 Subject: [Koha-bugs] [Bug 18189] Elasticsearch sorting broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #15 from Jonathan Druart --- Sort is broken, it's a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 14:54:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 12:54:03 +0000 Subject: [Koha-bugs] [Bug 17346] Enable the check in option in Columns settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 --- Comment #11 from Jonathan Druart --- (In reply to Katrin Fischer from comment #10) > Holding back on this because of comment#5 for the stable release. > Please link the new bug with this one once opened. Comment 5 was wrong and the behavior I described is not added by this patch. New bug is linked already, it's bug 18257. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 14:55:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 12:55:08 +0000 Subject: [Koha-bugs] [Bug 18321] One more checkouts possible than allowed by rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 --- Comment #18 from Jonathan Druart --- (In reply to Marc V?ron from comment #17) > Jonathan, this Bug was marked as assigned but the patches work, so I assume > that you forgot to set to NSO. > Switching to NSO and then to Signed off Yes indeed, I forgot to change the status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 15:00:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 13:00:11 +0000 Subject: [Koha-bugs] [Bug 17730] Uniform mapping for biblio.biblionumber (Unimarc) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17730 Serhij Dubyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk at ukr.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 15:01:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 13:01:12 +0000 Subject: [Koha-bugs] [Bug 18369] Broken title link in UNIMARC catalog search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 Serhij Dubyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk at ukr.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 15:05:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 13:05:19 +0000 Subject: [Koha-bugs] [Bug 18371] New: XSLT transformation fails if UNIMARC 100$a is hidden Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18371 Bug ID: 18371 Summary: XSLT transformation fails if UNIMARC 100$a is hidden Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: synapse.ova at gmail.com QA Contact: testopia at bugs.koha-community.org In UNIMARC XSLT trasformation on page opac-detail.pl fails with software error Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> at /usr/share/perl5/MARC/File/XML.pm line 568. Error occurs if subfield 100$a is made invisible in OPAC. It appears, that after filtering (rows 92-100), record is passed to XSLT processing (rows 152-163), and it already lacks field 100$a (it was filtered before). SetUTF8Flag (row 147) does not add filtered 100$a. So right now turning 100$a OPAC visibility off leads to error when user accesses opac-detail.pl. There is no problems with opac-MARCdetail.pl and opac-ISBDdetail.pl ? subfield is hidden correctly. Quick fix for those, who have this problem is to make 100$a fully visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 15:06:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 13:06:55 +0000 Subject: [Koha-bugs] [Bug 18371] XSLT transformation fails if UNIMARC 100$a is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18371 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11592 --- Comment #1 from Oleg Vasilenko --- This applies to 16.10+ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 [Bug 11592] opac detail scripts do not respect MARC tag visibility -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 15:06:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 13:06:55 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18371 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18371 [Bug 18371] XSLT transformation fails if UNIMARC 100$a is hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 15:07:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 13:07:53 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #16 from Jonathan Druart --- Created attachment 61794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61794&action=edit Bug 18242: 16.11.x adaptation - Old::Checkouts vs OldIssues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 15:20:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 13:20:09 +0000 Subject: [Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61687|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 61795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61795&action=edit [16.11.x] Bug 18266: Fix internal error when paying fine for lost item without.. item If a fine is created for a lost item but the itemnumber is not supplied, the system will return it. The item should not be mark as returned if there is no item linked to the fine. Test plan: 1. Turn StoreLastBorrower on 2. Create a manual invoice for a lost item, do not supply a barcode 3. Pay the fines 'Pay fines > Pay' => Without this patch applied you get Can't call method "last_returned_by" on an undefined value at /home/marc/koha/C4/Circulation.pm line 2188. => With this patch applied, you must not get the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 15:23:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 13:23:08 +0000 Subject: [Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC framework don' t work correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #23 from Marcel de Rooy --- (In reply to M. Tompsett from comment #22) > And 'In Discussion' is a wasteland. Sometimes used as an euphemism (nice alias) for Failed QA ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 15:26:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 13:26:54 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 --- Comment #25 from Baptiste --- Hi ! - "This contains strings, so will have to wait to be considered next month." I don't quite understand what you mean.. - "I am not sure about the pref description Maybe we could rephrase that a bit to make it clearer?" What do you think about: "When a user log in [load/don't load] on his own history all searches performed while no user were logged in" - "We'd also want to make it INSERT IGNORE if we want this in 16.11.x in master." You mean in "bug_8010-add_LoadSearchHistoryToTheFirstLoggedUser_syspref.sql" ? - "The sypsref name got a bit long :) Why Load and not Add?" Will one character change anything ? I couldn't find shorter and still.. hum.. let's say explicit. Any idea ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 15:28:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 13:28:39 +0000 Subject: [Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364 --- Comment #5 from Jonathan Druart --- (In reply to Julian Maurice from comment #3) > If LOCK TABLE commits any active transaction, is it useful to start a > transaction just before (line 3385) ? No I do not think so, I wanted to remove it in this patch but did not want to add more confusions/complexity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 15:29:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 13:29:25 +0000 Subject: [Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364 --- Comment #6 from Jonathan Druart --- The doc says """ The correct way to use LOCK TABLES and UNLOCK TABLES with transactional tables, such as InnoDB tables, is to begin a transaction with SET autocommit = 0 (not START TRANSACTION) followed by LOCK TABLES, and to not call UNLOCK TABLES until you commit the transaction explicitly. """ https://dev.mysql.com/doc/refman/5.7/en/lock-tables-and-transactions.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 15:42:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 13:42:24 +0000 Subject: [Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #34 from Baptiste --- Created attachment 61796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61796&action=edit Bug 18110: Update addressFormat in atomicupdate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:06:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:06:47 +0000 Subject: [Koha-bugs] [Bug 15441] columns_settings.pl: Circulation issues-table - cannot toggle checkin column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15441 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 17346 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:06:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:06:47 +0000 Subject: [Koha-bugs] [Bug 17346] Enable the check in option in Columns settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |croseburg at ncrl.org --- Comment #12 from Jonathan Druart --- *** Bug 15441 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:28:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:28:49 +0000 Subject: [Koha-bugs] [Bug 18371] XSLT transformation fails if UNIMARC 100$a is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18371 Serhij Dubyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk at ukr.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:31:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:31:17 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #12 from Christopher Brannon --- (In reply to Katrin Fischer from comment #11) > Dependency is not in 16.11.x, so this should not be needed there. I don't know what this means. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:35:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:35:47 +0000 Subject: [Koha-bugs] [Bug 18275] opac-memberentry.pl security vulnerabilities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18275 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #20 from Mason James --- Pushed to 16.05.x, for 16.05.11 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:36:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:36:52 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #21 from Mason James --- Pushed to 16.05.x, for 16.05.11 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:38:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:38:11 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #365 from Mason James --- (In reply to Kyle M Hall from comment #358) > Comment on attachment 60448 [details] [review] > Bug 7143: Replace Santallan by Santellan > > Pushed to master for 17.05! Pushed to 16.05.x, for 16.05.11 release -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:39:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:39:19 +0000 Subject: [Koha-bugs] [Bug 18122] Audio alerts: Add hint on where to enable sounds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18122 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.11 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:40:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:40:12 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #15 from Mason James --- Pushed to 16.05.x, for 16.05.11 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:40:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:40:44 +0000 Subject: [Koha-bugs] [Bug 13968] Branch email hints are misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13968 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #12 from Mason James --- Pushed to 16.05.x, for 16.05.11 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:42:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:42:46 +0000 Subject: [Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #15 from Mason James --- Pushed to 16.05.x, for 16.05.11 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:48:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:48:47 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:48:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:48:52 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:55:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:55:24 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 16:55:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 14:55:29 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 --- Comment #1 from Jonathan Druart --- Created attachment 61797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61797&action=edit Bug 18370: Columns visibility on patron search - Hide the correct column When a column is hidden by default on the patron search result table, if the logged in user does not have the "tools > manage_patron_lists" permission, the wrong column will be hidden. Test plan: Edit the column visibility detail for "Patrons > id=memberresultst" Set "Fines" hidden by default Search for patrons => Without this patch, if the logged in user does not have the manage_patron_lists permission, the wrong column will be hidden/displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:00:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:00:48 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #13 from Mason James --- Pushed to 16.05.x, for 16.05.11 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:00:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:00:55 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim and order notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #34 from Jonathan Druart --- A test fails: prove t/db_dependent/Letters.t t/db_dependent/Letters.t .. 1/80 Can't call method "branchemail" on an undefined value at /home/vagrant/kohaclone/C4/Letters.pm line 576. userenv is not set in tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:01:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:01:12 +0000 Subject: [Koha-bugs] [Bug 17895] Small typo -'re-set' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.11 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:03:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:03:47 +0000 Subject: [Koha-bugs] [Bug 18343] Manage MARC import DBH should not be shared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:04:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:04:08 +0000 Subject: [Koha-bugs] [Bug 18028] install_misc directory is outdated and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #7 from Colin Campbell --- make upgrade falls over unless you revert this patch there still a make_upgrade_backup target in the generated makefile -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:13:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:13:24 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #36 from Jonathan Druart --- Very small thing again, delete_temporary returns true if no errors occur. I am wondering if we should not return true if the delete worked. 92 } elsif( !defined($days) || $days eq '' ) { # allow 0, not NULL or "" 93 return 1; 94 } would then be 'return;' It's how delete and delete_missing work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:25:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:25:58 +0000 Subject: [Koha-bugs] [Bug 18372] New: transits are not created at check in despite user responsing Yes to the prompt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 Bug ID: 18372 Summary: transits are not created at check in despite user responsing Yes to the prompt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When checking in an item from another library the user is prompted whether the item should go into transit if they respond Yes no transit is created and the item status is shown as Available. The changes to the template circ/returns.tt lines 408-412 in bug 15821 appear to be the cause meaning no value is returned as dotransfer to the returns.pl script. Reverting these lines to how they were prior to bug 15821 restores transit behaviour -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:27:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:27:29 +0000 Subject: [Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 --- Comment #35 from Marc V?ron --- Hi Babtiste - My followup patch would need a sign-off (See comment #32) - Atomic update produces an sql error, UPDATE sytax seems to be wrong. Did you test it? Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:33:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:33:20 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from S?verine Queune --- Display is ok for the "Fines " column for both type of user. "Circ notes" is still visible for a no-superadmin user even when it's checked. It's hidden when both "Fines" and "Circ_notes" are checked but in this case, "Fines" is visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:48:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:48:30 +0000 Subject: [Koha-bugs] [Bug 18373] New: `make upgrade` is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 Bug ID: 18373 Summary: `make upgrade` is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Bug 18028 removed the install_misc directory but install_misc/UpgradeBackup.pm was still used by the 'upgrade' rule of make. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:48:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:48:54 +0000 Subject: [Koha-bugs] [Bug 18028] install_misc directory is outdated and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18373 --- Comment #8 from Jonathan Druart --- (In reply to Colin Campbell from comment #7) > make upgrade falls over unless you revert this patch there still a > make_upgrade_backup target in the generated makefile I will try & fix it on bug 18373.h Thanks for reporting! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 [Bug 18373] `make upgrade` is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:48:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:48:54 +0000 Subject: [Koha-bugs] [Bug 18373] `make upgrade` is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18028 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 [Bug 18028] install_misc directory is outdated and must be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:54:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:54:58 +0000 Subject: [Koha-bugs] [Bug 18373] `make upgrade` is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:55:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:55:02 +0000 Subject: [Koha-bugs] [Bug 18373] `make upgrade` is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 --- Comment #1 from Jonathan Druart --- Created attachment 61798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61798&action=edit Bug 18373: Re-add UpgradeBackup.pm Bug 18028 removed the install_misc directory but install_misc/UpgradeBackup.pm was still used by the 'upgrade' rule of make. Other files from install_misc were useless to it may be better not to reintroduce this directory with only 1 file. Test plan: `make` `sudo make install` `make upgrade` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 17:57:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 15:57:40 +0000 Subject: [Koha-bugs] [Bug 18373] `make upgrade` is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61798|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 61799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61799&action=edit Bug 18373: Re-add UpgradeBackup.pm Bug 18028 removed the install_misc directory but install_misc/UpgradeBackup.pm was still used by the 'upgrade' rule of make. Other files from install_misc were useless to it may be better not to reintroduce this directory with only 1 file. Test plan: `make` `sudo make install` `make upgrade` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 18:02:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 16:02:14 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 --- Comment #3 from Jonathan Druart --- Hum, seems ok to me. How did you test, on a sandbox? If that the case, please send me the url to compare the permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 18:15:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 16:15:42 +0000 Subject: [Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|master |16.11 --- Comment #1 from Colin Campbell --- setting version to 16.11 appears that master is not affected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 18:41:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 16:41:03 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #22 from M. Tompsett --- (In reply to Jonathan Druart from comment #21) > Koha::Patron->new should not be called directly yet. > Please use AddMember instead (unless there is a good reason?). Valid point, due to add_enrollment_fee_if_needed. Fixing and retesting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 19:07:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 17:07:14 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 19:07:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 17:07:19 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #23 from M. Tompsett --- Created attachment 61800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61800&action=edit Bug 16892: Follow up use AddMember as per QA comment Same Test plan as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 19:08:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 17:08:07 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58373|0 |1 is obsolete| | --- Comment #24 from M. Tompsett --- Created attachment 61801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61801&action=edit Bug 16892: Add automatic patron registration via OAuth2 login 10988 added the ability to log into the OPAC authenticating with Google Open ID Connect. This extends it, by allowing an unregistered patron to have an account automatically created with default category code and branch. This is accomplished by adding 3 system preferences. - GoogleOpenIDConnectAutoRegister whether it will attempt to auto-register the patron. - GoogleOpenIDConnectDefaultCategory This category code will be used to create Google OpenID Connect patrons. - GoogleOpenIDConnectDefaultBranch' This branch code will be used to create Google OpenID Connect patrons. Sponsored-by: Tulong Aklatan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 19:08:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 17:08:13 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58374|0 |1 is obsolete| | --- Comment #25 from M. Tompsett --- Created attachment 61802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61802&action=edit Bug 16892: System Preferences This adds the missing system preferences for a fresh install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 19:08:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 17:08:18 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58375|0 |1 is obsolete| | --- Comment #26 from M. Tompsett --- Created attachment 61803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61803&action=edit Bug 16892: Follow up with adding missing IGNORE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 19:08:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 17:08:24 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61800|0 |1 is obsolete| | --- Comment #27 from M. Tompsett --- Created attachment 61804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61804&action=edit Bug 16892: Follow up use AddMember as per QA comment Same Test plan as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 19:26:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 17:26:05 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #37 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #36) > Very small thing again, delete_temporary returns true if no errors occur. I > am wondering if we should not return true if the delete worked. > > 92 } elsif( !defined($days) || $days eq '' ) { # allow 0, not NULL or "" > 93 return 1; > 94 } > > would then be 'return;' > > It's how delete and delete_missing work. Hope we still make it before release :) I agree that we should make this more consistent. But returning undef is perhaps not the best solution. I will add a follow-up that returns 0E0 just as DBIx does when DBI is the storage backend. This affects UploadedFile too. Only a few small changes, but more than one line.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 19:29:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 17:29:06 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #38 from Marcel de Rooy --- Created attachment 61805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61805&action=edit Bug 17669: [QA Follow-up] More consistency in return values of delete See Bugzilla comment36 (QA request). Koha::UploadedFile->delete Returns number of deleted records. POD corrected. Handles a possible or fictive undef from the storage backend. 0E0 means zero (like DBI), -1 means unknown. Koha::UploadedFile->delete Returns number of deleted records (just as above), and no longer true or false depending on errors encountered. POD corrected. Koha::UploadedFile->delete_temporary Returns number of deleted records (just as above). Does no longer return true when the associated pref contains NULL or empty string. POD corrected. Signed-off-by: Marcel de Rooy As often in Koha, the return values of delete operations are ignored. The test t/db_dependent/Upload.t still passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 19:29:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 17:29:50 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #39 from Marcel de Rooy --- If you insist now on further tests of the return value, I would rather move the last follow-up somewhere else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 19:33:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 17:33:07 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #65 from Blou --- I don't reproduce it, but I'll try different scenarios. Expect some new patches coming from me or Mehdi in the comming week. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 20:28:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 18:28:14 +0000 Subject: [Koha-bugs] [Bug 17546] Importing records with a matching rules fails when using Elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17546 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 18131 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 20:28:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 18:28:14 +0000 Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #6 from Nick Clemens --- *** Bug 17546 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 20:30:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 18:30:40 +0000 Subject: [Koha-bugs] [Bug 18374] New: Respect QueryAutoTruncate syspref in Elasticsearch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Bug ID: 18374 Summary: Respect QueryAutoTruncate syspref in Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently in Elasticsearch a search for 'shakes' will not match 'shakespeare' but you cna force it with 'shakes*' This patchset will obey the QueryAutoTruncate to add '*' to all search terms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 20:37:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 18:37:05 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 20:37:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 18:37:07 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 --- Comment #1 from Nick Clemens --- Created attachment 61806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61806&action=edit Bug 18374 - Respect QueryAutoTruncate syspref in Elasticsearch This patchset adds a subroutine '_truncate_terms' to the ES QueryParser. If QueryAutoTruncate is enabled this function will be called for any search to add wildcard '*' to all terms To test: 1 - Enable Elasticsearch and have some records indexed 2 - Search for partial terms 3 - Note they fail unless '*' is appended 4 - Apply patch, leave QueryAutoTruncate disabled 5 - Note partial term searches still fail 6 - Enable QueryAutoTruncate 7 - Note partial term searches succeed 8 - Do some regular and advanced searches to make sure results are as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 20:37:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 18:37:50 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com, | |tomascohen at gmail.com Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 20:39:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 18:39:08 +0000 Subject: [Koha-bugs] [Bug 12930] Web installer does not show login errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61768|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 61807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61807&action=edit Bug 12930 - Implemented error message display for invalid username or password on web installer login Now InstallAuth.pm hands the invalid_username_or_password variable to the template file auth.tt if the user entered an invalid username or password and this is displayed to the user I tested both patches together by direkctly calling [MY SERVER]/cgi-bin/koha/installer/install.pl?step=1&op=updatestructure Works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 20:39:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 18:39:59 +0000 Subject: [Koha-bugs] [Bug 12930] Web installer does not show login errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61777|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 61808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61808&action=edit Bug 12930 - Followup removing empty else branch Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 20:51:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 18:51:27 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 --- Comment #2 from Jonathan Druart --- Nick, please provide tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 21:20:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 19:20:50 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #10 from Barton Chittenden --- Per Nick 'Yes, you can mark it as assigned - it needs rewrites to respect current guidelines' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 21:23:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 19:23:40 +0000 Subject: [Koha-bugs] [Bug 12930] Web installer does not show login errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 21:26:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 19:26:01 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #40 from Marcel de Rooy --- Hmm Still a very small thing: if I come across an undef, pass -1 instead of 0E0 (two places?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 21:31:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 19:31:44 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61805|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy --- Created attachment 61809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61809&action=edit Bug 17669: [QA Follow-up] More consistency in return values of delete See Bugzilla comment36 (QA request). Koha::UploadedFile->delete Returns number of deleted records. POD corrected. Handles a possible or fictive undef from the storage backend. 0E0 means zero (like DBI), -1 means unknown. Koha::UploadedFile->delete Returns number of deleted records (just as above), and no longer true or false depending on errors encountered. POD corrected. Koha::UploadedFile->delete_temporary Returns number of deleted records (just as above). Does no longer return true when the associated pref contains NULL or empty string. POD corrected. Signed-off-by: Marcel de Rooy As often in Koha, the return values of delete operations are ignored. The test t/db_dependent/Upload.t still passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 21:33:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 19:33:00 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #42 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #39) > If you insist now on further tests of the return value, I would rather move > the last follow-up somewhere else. Suppose I do that on 18300? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 21:41:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 19:41:56 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #43 from Marcel de Rooy --- Temporarily blocked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 21:42:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 19:42:20 +0000 Subject: [Koha-bugs] [Bug 18300] Delete missing upload records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18300 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #5 from Marcel de Rooy --- Temporarily blocked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 3 21:45:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Apr 2017 19:45:36 +0000 Subject: [Koha-bugs] [Bug 18300] Delete missing upload records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18300 --- Comment #6 from Marcel de Rooy --- Created attachment 61810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61810&action=edit Bug 18300: [QA Follow-up] Fix return value inconsistency As noted on bug report 17669, the return values of delete (both singular and plural), delete_missing and delete_temporary should be consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 04:46:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 02:46:18 +0000 Subject: [Koha-bugs] [Bug 18375] New: If no upper age limit supplied for patron category it will read years Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18375 Bug ID: 18375 Summary: If no upper age limit supplied for patron category it will read years Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: luke.honiss at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 61811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61811&action=edit Patron category list When a patron category with no upper age limit/age required is created the table of categories just reads 'years'. It should probably read something like 'unspecified' or '0 years'. To recreate 1) Create any patron category with either/both upper age or minumum age blank 2) The /cgi-bin/koha/admin/categories.pl table show the field as 'years' (see attachment) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 08:18:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 06:18:45 +0000 Subject: [Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- RMaint is watching... can we get a patch please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 08:24:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 06:24:45 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 --- Comment #26 from Katrin Fischer --- A week before release of the maintenance release (usually around 15th, release on 22nd) we go into 'string freeze'. I try not to push any more patches to my branch that contain strings. It's to give translators time to finish translations and bring them up to 100% before release. When I looked at this, it was in 'string freeze' - so was planning to come back for the next release. bug_8010-add_LoadSearchHistoryToTheFirstLoggedUser_syspref.sql was moved to updatedatabase.sql in master. When I decide to push this to 16.11.x people upgrading from 16.11.x to 17.05 will get an ugly warning. We can prevent that by adding the IGNORE to updatedatabase.pl in master. My thinking was that the 'load onto' or 'load' sounded not quite right to me in English - but best would be to get a native speaker on this. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 08:28:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 06:28:43 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #13 from Katrin Fischer --- This bug is supposed to be caused by bug 16530 (depends on: 16530 above). As this 16530 is not in 16.11.x, we should not need the bugfix for it. If this is wrong, please let me know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 09:21:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 07:21:37 +0000 Subject: [Koha-bugs] [Bug 8010] Search history can be added to the wrong patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com --- Comment #27 from Claire Gravely --- maybe: SaveSearchHistoryToNextLoggedInUser Save/don't save unlogged search history to the next logged in user's account Add/don't add could also work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 09:22:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 07:22:30 +0000 Subject: [Koha-bugs] [Bug 18376] New: authority framework creation fails under Plack Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Bug ID: 18376 Summary: authority framework creation fails under Plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com With plack, when creating a new authority framework from another, you get the error : Can't call method "prepare" on an undefined value at (...)/src/admin/auth_tag_structure.pl line 267. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 09:22:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 07:22:38 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 09:23:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 07:23:33 +0000 Subject: [Koha-bugs] [Bug 18377] New: Add Plack/PSGI file for dev install Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Bug ID: 18377 Summary: Add Plack/PSGI file for dev install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Koha lacks a proper Plack file for dev install. debian/templates/plack.psgi is for package install and misc/plack/koha.psgi seems a bit outdated (you need 2 plack servers running ? 1 for opac and 1 for intranet ? and the REST API is not enabled in it) I'll attach a new one, based on debian/templates/plack.psgi but suited for a dev install -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 09:24:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 07:24:30 +0000 Subject: [Koha-bugs] [Bug 18377] Add Plack/PSGI file for dev install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 --- Comment #1 from Julian Maurice --- Created attachment 61812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61812&action=edit Bug 18377: Add PSGI file for dev install It is very similar to the one for debian install, but uses FindBin to set the paths -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 09:26:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 07:26:09 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 --- Comment #4 from S?verine Queune --- Yes it was the Biblibre's sandbox n?4. http://pro.demo1605-koha.test.biblibre.eu/cgi-bin/koha/mainpage.pl I used test//test as a superadmin user and 4941//4941 as a no-superadmin user. Currently on this sandbox, "Fines" and "Circ_Notes" are checked but when I use the user 4941, only the "Circ notes" is hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 09:32:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 07:32:18 +0000 Subject: [Koha-bugs] [Bug 18377] Add Plack/PSGI file for dev install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Julian Maurice --- Test plan: 1. Install koha in dev mode 2. Run `starman /your/koha/install/app.psgi` 3. Configure your webserver as a reverse proxy for starman (there is some examples for apache in debian/templates/apache-shared-*-plack.conf) 4. Verify that you can access OPAC, intranet and the REST API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 12:34:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 10:34:47 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 13:09:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 11:09:26 +0000 Subject: [Koha-bugs] [Bug 18375] If no upper age limit supplied for patron category it will read years In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18375 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 13:10:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 11:10:06 +0000 Subject: [Koha-bugs] [Bug 18375] If no upper age limit supplied for patron category it will read years In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18375 --- Comment #1 from Marc V?ron --- Created attachment 61813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61813&action=edit Bug 18375: Better readability of patron category table for zero ages and fees In patron category table, this patch displays zero / empty values for ages and fees with '-' for better readability To test: - Go to Home > Administration > Patron categories - Verify that you have 0 years and/or only years in Age required and Uper age limit colums - Verify that you have Enrollment and Hold fees of 0.00 - Apply patch - Verify that such values are replaced by - to enhance table readability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 13:11:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 11:11:01 +0000 Subject: [Koha-bugs] [Bug 18375] Better readability of patron category table for zero ages and fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18375 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|If no upper age limit |Better readability of |supplied for patron |patron category table for |category it will read years |zero ages and fees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 13:11:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 11:11:17 +0000 Subject: [Koha-bugs] [Bug 18375] Better readability of patron category table for zero ages and fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18375 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 13:56:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 11:56:25 +0000 Subject: [Koha-bugs] [Bug 18378] New: Author name cannot add Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18378 Bug ID: 18378 Summary: Author name cannot add Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: librarian at tipsglobal.net QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl There is no tag for author in default framework. If import books framework cannot add author name. the following error shows Can't call method "auth_tag_to_report" on an undefined value at /usr/share/koha/lib/C4/Biblio.pm line 588. If add without auhtorname cannot search the books detail thorough search the catalogue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:06:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:06:35 +0000 Subject: [Koha-bugs] [Bug 18379] New: ejournal add Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18379 Bug ID: 18379 Summary: ejournal add Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: sunitabarve at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com For renewing ejournals there is only a need of subscription period and no need to add issues. But this feature is not there for renewing ejournals through serials. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:17:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:17:09 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:17:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:17:13 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #21 from Josef Moravec --- Created attachment 61814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61814&action=edit [SIGNED-OFF] Bug 10382 - collection not returning to null when removed from course reserves Test Plan: 1) Create an item, do not set a collection code 2) Add the item to a course, and choose to set a collection code 3) Ensure the course is enabled, and the collection code is now visible 4) Disable the course, ensure the collection code is no longer visible Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:17:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:17:23 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #22 from Josef Moravec --- Created attachment 61815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61815&action=edit [SIGNED-OFF] Bug 10382 - Add unit tests for course items Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:17:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:17:32 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60947|0 |1 is obsolete| | Attachment #60948|0 |1 is obsolete| | Attachment #60979|0 |1 is obsolete| | --- Comment #23 from Josef Moravec --- Created attachment 61816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61816&action=edit [SIGNED-OFF] Bug 10382 - Course reserves: handle empty values Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:24:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:24:52 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 --- Comment #1 from Fridolin SOMERS --- Created attachment 61817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61817&action=edit Bug 18376 - authority framework creation fails under Plack With plack, when creating a new authority framework from another, you get the error : Can't call method "prepare" on an undefined value at (...)/src/admin/auth_tag_structure.pl line 267. Looks like plack does not like when the var $dbh from the script is called inside a sub. This patch adds a local var $dbh inside sub duplicate_auth_framework(), like in sub StringSearch(). Also correctes a redefine of my $sth. Test plan: - Go to Administration > Authority types - Create a new type - On this new type click on Actions > MARC Structure - Select another type and click OK => You must get a table filled with the tag structure Check with and without plack You may not be able to reproduce the error with plack. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:24:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:24:49 +0000 Subject: [Koha-bugs] [Bug 18376] authority framework creation fails under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:32:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:32:40 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61809|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy --- Created attachment 61818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61818&action=edit Bug 17669: [QA Follow-up] More consistency in return values of delete See Bugzilla comment36 (QA request). Koha::UploadedFile->delete Returns 1, 0E0 or -1 (unknown). Return value may depend on storage backend. Koha::UploadedFiles->delete and delete_temporary Returns number of deleted records, 0E0 or -1. POD lines are corrected accordingly. Unit tests adjusted too. Signed-off-by: Marcel de Rooy Added a note that Koha::Object->delete itself is not completely consistent with Koha::Objects->delete (DBIx). The singular may return 1 when it gets 0E0 from DBIx, while the plural one may return 0E0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:36:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:36:09 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:36:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:36:11 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61818|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:45:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:45:07 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #45 from Marcel de Rooy --- Created attachment 61819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61819&action=edit Bug 17669: [QA Follow-up] More consistency in return values of delete See Bugzilla comment36 (QA request). Koha::UploadedFile->delete Returns 1, 0E0 or -1 (unknown). Koha::UploadedFiles->delete and delete_temporary Returns number of deleted records, 0E0 or -1. POD lines are corrected accordingly. Unit tests adjusted too. Signed-off-by: Marcel de Rooy Added a note that Koha::Object->delete itself is not completely consistent with Koha::Objects->delete (DBIx). The singular may return 1 when it gets 0E0 from DBIx, while the plural one may return 0E0. But should be handled somewhere else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:46:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:46:54 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #46 from Marcel de Rooy --- Back to Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:53:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:53:06 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:53:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:53:10 +0000 Subject: [Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60858|0 |1 is obsolete| | --- Comment #11 from Josef Moravec --- Created attachment 61820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61820&action=edit [SIGNED-OFF] Bug 16758 - Caching issues in scripts running in daemon mode As L1 cache does not have expiration mechanism, scripts running in daemon mode (rebuild_zebra.pl -daemon, sip server ?, ...) would not be aware of any possible changes in the data being cached in upstream L2 cache. This patch adds ->flush_L1_caches() call in rebuild_zebra.pl inside daemon mode loop. To test: 1) apply patch 2) ensure that rebuild_zebra.pl -daemon is still working properly, without any noticeable performance degradation 3) stop memcached daemon and try to run rebuild_zebra.pl -daemon again: there should be a warning emitted stating that the script is running in daemon mode but without recommended caching system Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 14:56:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 12:56:28 +0000 Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #28 from Julian Maurice --- (In reply to Katrin Fischer from comment #25) > The problem is, that there is no context in translation. A string like > "Title: " could mean all 3 things, but we'd like to translate it > differently. This is currently not possible - you can only have one > translation for identical strings. Please have a look at bug 15395. It allows to attach context to a string, so the same string can be translated in different ways, depending on the context. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:02:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:02:11 +0000 Subject: [Koha-bugs] [Bug 18315] authentication and authorization refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18315 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #5 from Olli-Antti Kivilahti --- Hi! Check out https://github.com/KohaSuomi/kohasuomi/blob/kohasuomi3.16/Koha/Auth/PermissionManager.pm https://github.com/KohaSuomi/kohasuomi/blob/kohasuomi3.16/Koha/Auth.pm https://github.com/KohaSuomi/kohasuomi/blob/kohasuomi3.16/Koha/Auth/Route/Password.pm https://github.com/KohaSuomi/kohasuomi/blob/kohasuomi3.16/C4/Auth.pm#L1713 I rewrote the permission system and authentication system some time ago. Nobody is interested about it, even thought the horrible way of managing permissions is a blocker for writing smooth user interface tests (or REST API tests). Not a lot of people care about user interface tests either. We have been indecisive should we drop my authentication rewrite and revert to the community system, but it is so stale and in a need of a rewrite that we couldn't get back into it. I hope you can work on top of my solution and improve it, instead of reinventing the wheel. It would be great to get best of both worlds. My solution has a compatibility layer between CGI and Mojolicious, normalizing the way HTTP request headers/cookies/parameters are fetched. It would be bestest to get rid of CGI completely and just rewrite everything as a Mojolicious application. Also ashimema and tcohen are working with OAuth2.0 and replacing CGISESSID with JWT. Not sure how they can do it with the current C4::Auth. Maybe they will provide a third and a fourth rewrite :) (I hope not) BTW: Where is your code? I see no attachments? My work in Bugzilla: Bug 7174 - Authentication rewriting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:03:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:03:53 +0000 Subject: [Koha-bugs] [Bug 18315] authentication and authorization refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18315 --- Comment #6 from Olli-Antti Kivilahti --- (In reply to Olli-Antti Kivilahti from comment #5) > BTW: Where is your code? I see no attachments? But I found the URL to github. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:07:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:07:30 +0000 Subject: [Koha-bugs] [Bug 18315] authentication and authorization refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18315 --- Comment #7 from Francesco Rivetti --- Hi Olli-Antti Kivilahti, I didn't know you were working on it, will have a look immediately. You are right: I haven't submitted any patch here. But you can see what i did so far here: https://github.com/digibib/Koha/commits/auth_session_refactor there are lots of changes on my side, but I might be able to combine what you did so far and integrate it. I just wish there were more hours in a day! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:11:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:11:01 +0000 Subject: [Koha-bugs] [Bug 18300] Delete missing upload records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18300 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61778|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 61821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61821&action=edit Bug 18300: Delete missing upload records If you deleted files from the upload directories manually, or you rebooted with files in the temporary upload folder, or for some other reason have records without a file, you may want to cleanup your records in the uploaded_files table. This patch adds the method delete_missing to Koha::UploadedFiles. It also supports a keep_record parameter to do a dry run (count the missing files first). Also, we add an option --uploads-missing to cleanup_database. If you add the flag 1 after this option, you will delete missing files. If you add the flag 0 or only use the option, you will count missing files. A subtest is added to Upload.t for delete_missing tests. Test plan: [1] Run t/db_dependent/Upload.t [2] Upload a file and delete the file manually. [3] Run cleanup_database.pl --uploads-missing It should report at least one missing file now. Check that the record has not been deleted. [4] Run cleanup_database.pl --uploads-missing 1 It should report that it removed at least one file. Check that the record is gone. Signed-off-by: Marcel de Rooy Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:11:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:11:05 +0000 Subject: [Koha-bugs] [Bug 18300] Delete missing upload records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18300 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61810|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 61822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61822&action=edit Bug 18300: [QA Follow-up] Fix return value inconsistency As noted on bug report 17669, the return values of delete (both singular and plural), delete_missing and delete_temporary should be consistent. Removed the if-construction around full_path. We do not need it; in the very exceptional case that full_path would be empty, we should delete the record since the file is missing. Adjusted POD and unit tests accordingly. Test plan: Run t/db_dependent/Upload.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:11:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:11:54 +0000 Subject: [Koha-bugs] [Bug 18300] Delete missing upload records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18300 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:31:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:31:06 +0000 Subject: [Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #4 from Tom?s Cohen Arazi --- Comment on attachment 61754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61754 Bug 18361: Koha::Objects->find should accept composite primary keys > sub find { >- my ( $self, $id ) = @_; >+ my ( $self, @id ) = @_; While I agree with the general idea, I'd prefer that we keep in mind that this is a passthrough to DBIC ->find method. In that sense, please look at ResultSet.pm: sub find { my $self = shift; my $attrs = (@_ > 1 && ref $_[$#_] eq 'HASH' ? pop(@_) : {}); IMHO we should implement exactly that, probably accept whatever is passed to K:O->find and just pass it to RS->find. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:38:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:38:22 +0000 Subject: [Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #5 from Marcel de Rooy --- (In reply to Tom?s Cohen Arazi from comment #4) > Comment on attachment 61754 [details] [review] > Bug 18361: Koha::Objects->find should accept composite primary keys > > > sub find { > >- my ( $self, $id ) = @_; > >+ my ( $self, @id ) = @_; > > While I agree with the general idea, I'd prefer that we keep in mind that > this is a passthrough to DBIC ->find method. In that sense, please look at > ResultSet.pm: > > sub find { > my $self = shift; > my $attrs = (@_ > 1 && ref $_[$#_] eq 'HASH' ? pop(@_) : {}); > > IMHO we should implement exactly that, probably accept whatever is passed to > K:O->find and just pass it to RS->find. my $result = $self->_resultset()->find(@id); So we pass them to RS. What is exactly your point ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:41:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:41:05 +0000 Subject: [Koha-bugs] [Bug 18380] New: Current location in OPAC not visible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18380 Bug ID: 18380 Summary: Current location in OPAC not visible Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 61823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61823&action=edit Staff client Koha version 16.11.06. After saving record current location visible in staff client. Current location in OPAC not visible. Please check the screenshot with this mesage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:41:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:41:55 +0000 Subject: [Koha-bugs] [Bug 18380] Current location in OPAC not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18380 --- Comment #1 from vimal kumar --- Created attachment 61824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61824&action=edit Record details in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:42:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:42:24 +0000 Subject: [Koha-bugs] [Bug 18380] Current location in OPAC not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18380 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:44:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:44:08 +0000 Subject: [Koha-bugs] [Bug 18381] New: Return values inconsistent between Koha::Object-> delete and its plural form Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18381 Bug ID: 18381 Summary: Return values inconsistent between Koha::Object->delete and its plural form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org >From bug 17669: Added a note that Koha::Object->delete itself is not completely consistent with Koha::Objects->delete (DBIx). The singular may return 1 when it gets 0E0 from DBIx, while the plural one may return 0E0. But should be handled somewhere else. And the singular now returns -1 when $self is not in storage. Should we return another value? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:44:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:44:33 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18381 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:44:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:44:33 +0000 Subject: [Koha-bugs] [Bug 18381] Return values inconsistent between Koha::Object-> delete and its plural form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18381 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17669 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:49:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:49:57 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:50:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:50:00 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58207|0 |1 is obsolete| | Attachment #58208|0 |1 is obsolete| | Attachment #58209|0 |1 is obsolete| | Attachment #58210|0 |1 is obsolete| | Attachment #58211|0 |1 is obsolete| | Attachment #58212|0 |1 is obsolete| | Attachment #58213|0 |1 is obsolete| | Attachment #58214|0 |1 is obsolete| | Attachment #58692|0 |1 is obsolete| | Attachment #58693|0 |1 is obsolete| | Attachment #58694|0 |1 is obsolete| | Attachment #58695|0 |1 is obsolete| | Attachment #58696|0 |1 is obsolete| | --- Comment #35 from Alex Sassmannshausen --- Created attachment 61825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61825&action=edit Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:50:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:50:14 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #36 from Alex Sassmannshausen --- Created attachment 61826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61826&action=edit Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:50:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:50:29 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #38 from Alex Sassmannshausen --- Created attachment 61828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61828&action=edit Bug 11897: Add Koha::Objects for Stockrotation module. * Koha/Stockrotationitem.pm: New file. * Koha/Stockrotationitems.pm: New file. * Koha/Stockrotationrota.pm: New file. * Koha/Stockrotationrotas.pm: New file. * Koha/Stockrotationstage.pm: New file. * Koha/Stockrotationstages.pm: New file. * t/db_dependent/Stockrotationitems.t: New file. * t/db_dependent/Stockrotationrotas.t: New file. * t/db_dependent/Stockrotationstages.t: New file. * Koha/Item.pm (stockrotationitem, add_to_rota, biblio): New procedures. * Koha/Library.pm (stockrotationstages): New procedure. * t/db_dependent/Items.t: Add tests. * t/db_dependent/Koha/Libraries.t: Add tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:50:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:50:23 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #37 from Alex Sassmannshausen --- Created attachment 61827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61827&action=edit Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:50:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:50:35 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #39 from Alex Sassmannshausen --- Created attachment 61829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61829&action=edit Bug 11897: Add stockrotation cron script. * misc/cronjobs/stockrotation.pl: New file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:50:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:50:41 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #40 from Alex Sassmannshausen --- Created attachment 61830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61830&action=edit Bug 11897: Add Utils library for Stockrotation module * Koha/Util/Stockrotation.pm: new file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:50:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:50:52 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #42 from Alex Sassmannshausen --- Created attachment 61832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61832&action=edit Bug 11897: Add JS to provide rota stage manipulation * koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js: new file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:50:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:50:47 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #41 from Alex Sassmannshausen --- Created attachment 61831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61831&action=edit Bug 11897: REST API - add path defs, controller & tests * Koha/REST/V1/Stage.pm: New file * api/v1/swagger/paths.json: Add route for stage manipulation * api/v1/swagger/paths/rotas.json: New file * t/db_dependent/api/v1/stockrotationstage.t: New file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:51:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:51:03 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #44 from Alex Sassmannshausen --- Created attachment 61834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61834&action=edit Bug 11897: Add Stock Rotation permissions to list * koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc: Add new permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:50:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:50:58 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #43 from Alex Sassmannshausen --- Created attachment 61833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61833&action=edit Bug 11897: Add Stockrotation CSS rules * koha-tmpl/intranet-tmpl/prog/css/staff-global.css: New rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:51:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:51:15 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #46 from Alex Sassmannshausen --- Created attachment 61836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61836&action=edit Bug 11897: Interface for rota items from biblio * catalogue/stockrotation.pl: New file * koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt: New file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:51:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:51:09 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #45 from Alex Sassmannshausen --- Created attachment 61835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61835&action=edit Bug 11897: Interface for rotas from Tools menu * tools/stockrotation.pl: New file * koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt: New file * koha-tmpl/intranet-tmpl/prog/en/includes/stockrotation-toolbar.inc: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:51:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:51:22 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #47 from Alex Sassmannshausen --- Created attachment 61837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61837&action=edit Bug 11897: Add menu options for Stock Rotation * koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc: Add menu option * koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc: Add menu option * koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt: Add menu option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:51:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:51:23 +0000 Subject: [Koha-bugs] [Bug 17439] Orders price are not recalculated when transfered to another vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17439 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:51:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:51:37 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #49 from Alex Sassmannshausen --- Created attachment 61839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61839&action=edit Bug 11897: Fix style of button links, & form wording. * koha-tmpl/intranet-tmpl/prog/en/includes/stockrotation-toolbar.inc * koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt * koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:51:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:51:29 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #48 from Alex Sassmannshausen --- Created attachment 61838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61838&action=edit Bug 11897: Bugfixes, unit tests, feedback, documentation. A (squashed) patch implementing significant changes to many parts of the module. Also adds thorough unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:52:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:52:25 +0000 Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15395 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:52:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:52:25 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11285 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:54:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:54:02 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #50 from Alex Sassmannshausen --- I'm reposting the test plan, after some further extensive modifications (some internal redesign, add loads of unit tests, act upon feedback). We believe this is now of sufficient quality to be included in Koha. Test Plan ========= Setup ----- - Ensure the patches apply cleanly and without problems - Run the unit tests, and ensure no regressions. In particular: * t/db_dependent/Stockrotationitems.t * t/db_dependent/Stockrotationrotas.t * t/db_dependent/Stockrotationstages.t * t/db_dependent/Items.t * t/db_dependent/Koha/Libraries.t User Interface -------------- - Enable the stockrotation system preference - A new menu, "stockrotation" should have appeared under the "tools" page. Test: * creating rota * editing rota * adding stages * adding items * removing items * "move item to next stage" - Any biblio should now have a "rotas" tab in the biblio view - From there any items attached to that biblio can be added/removed to/from rotas Cron Script ----------- The task of the cron script is to traverse all the items in all rotas and to see whether any of them need to be moved on to the next stage. It does this by, for each item, checking whether it has spent more days than "duration" at the current branch since it's last (stockrotation) branch transfer. To test the script, run it with the "-h" flag. You should get documentation. If you want to see the script actually do something, you should: - setup an item as described above - run the script to create initial stock rotation branch transfers (don't forget the "-x" flag!) - fiddle the database, so that the initial stock rotation branch transfer is in the past by at least the "duration" of the stage that the item is currently at - run the script again (without the "-x" flag): you should see that the cron script would now move the item to the next stage - running it with the "-x" flag will create the new branch transfer and will emit a report for the library currently holding the item to inform them it needs to be fetched from shelf to be put in transit. If you prefer you can have the script send emails. Follow the documentation for this. Please let me know if you have any questions! I'll be happy to help :-) Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 15:57:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 13:57:21 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 16:07:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 14:07:34 +0000 Subject: [Koha-bugs] [Bug 18373] `make upgrade` is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 16:07:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 14:07:38 +0000 Subject: [Koha-bugs] [Bug 18373] `make upgrade` is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61799|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 61840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61840&action=edit [SIGNED-OFF] Bug 18373: Re-add UpgradeBackup.pm Bug 18028 removed the install_misc directory but install_misc/UpgradeBackup.pm was still used by the 'upgrade' rule of make. Other files from install_misc were useless to it may be better not to reintroduce this directory with only 1 file. Test plan: `make` `sudo make install` `make upgrade` Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 16:13:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 14:13:24 +0000 Subject: [Koha-bugs] [Bug 18340] Progress bar length is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18340 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 16:13:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 14:13:27 +0000 Subject: [Koha-bugs] [Bug 18340] Progress bar length is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18340 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61647|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 61841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61841&action=edit [SIGNED-OFF] Bug 18340: Fix progress bar length The progress bar (for background jobs) should be fully filled when 100% is hit, right? :) It has been introduced quite long time ago when the size of the progress bar has been changed from 150 to 200px, and the code has been refactored. Test plan: Launch a big modification/deletion of records/items in a batch. You should see the progress bar progressing to 100 and reach 100! Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 16:13:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 14:13:48 +0000 Subject: [Koha-bugs] [Bug 17661] Differences in whitespace cause duplicate facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 16:16:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 14:16:33 +0000 Subject: [Koha-bugs] [Bug 18382] New: action_logs entry for module HOLDS, action SUSPEND is spammy Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18382 Bug ID: 18382 Summary: action_logs entry for module HOLDS, action SUSPEND is spammy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 61842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61842&action=edit Sample Action logs entry for suspend. When a hold is suspended, 'suspend_until' is represented as a DateTime object, complete with locale. All told, this is about 800 lines of text. See the attached 'action_logs.out' To replicate: To test: - Enable the HoldsLog syspref - Add a hold on a record/item - Click on the button Check the logs using module 'Holds' and Action 'Suspend' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 16:20:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 14:20:08 +0000 Subject: [Koha-bugs] [Bug 18382] action_logs entry for module HOLDS, action SUSPEND is spammy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18382 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14642 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 16:20:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 14:20:08 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18382 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 16:34:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 14:34:22 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 16:34:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 14:34:26 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44705|0 |1 is obsolete| | --- Comment #19 from Lari Taskula --- Created attachment 61843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61843&action=edit Bug 14620: Contact information validations This patch adds a phone number validation by regex and centralizes different validation methods into Koha::Validation class. Introduces a new system preference, ValidatePhoneNumber, that takes a regular expression and uses it to validate phone numbers both client and server side. Unit tests to test: 1. prove t/db_dependent/Koha/Validation.t To test: 1. Apply the patches and run updatedatabase.pl to install the new system preference 2. Set system preference ValidatePhoneNumber to any regex you like (there is an example in the description of the preference) 3. Navigate to edit user contact informations in Staff client and OPAC. 4. Insert invalid email (e.g. "invalid") and invalid phone number ("+123invalid") and send the form. 5. Confirm that form will not be submitted and errors will be given. 6. Disable JavaScript and test that these errors will also be provided by the server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 16:35:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 14:35:58 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7174 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 [Bug 7174] Authentication rewriting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 16:35:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 14:35:58 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14620 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 [Bug 14620] Contact information validations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 16:37:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 14:37:45 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 --- Comment #20 from Lari Taskula --- Rebased on top of master, created unit tests for Koha::Validation, removed dependency to Bug 7174. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 17:08:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 15:08:34 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #14 from Christopher Brannon --- No, but (In reply to Katrin Fischer from comment #13) > This bug is supposed to be caused by bug 16530 (depends on: 16530 above). As > this 16530 is not in 16.11.x, we should not need the bugfix for it. If this > is wrong, please let me know. No, but 16530 is pushed to 17.05. So, why wouldn't this be pushed to 17.05 as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 17:21:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 15:21:38 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 17:21:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 15:21:59 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 17:37:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 15:37:47 +0000 Subject: [Koha-bugs] [Bug 18383] New: items.onloan schema comment seems to be incorrect. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 Bug ID: 18383 Summary: items.onloan schema comment seems to be incorrect. Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: pongtawat at punsarn.asia QA Contact: testopia at bugs.koha-community.org Currently the items.onloan schema comment (in SQL and hence on schema.koha-community.org too) is like this: defines if item is checked out (NULL for not checked out, and checkout date for checked out) However, on my installation (16.11.06), the date that Koha put into items.onloan column seems to be due date. So, probably the comment should be changed to: defines if item is checked out (NULL for not checked out, and due date for checked out) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 18:08:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 16:08:54 +0000 Subject: [Koha-bugs] [Bug 18383] items.onloan schema comment seems to be incorrect. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 --- Comment #1 from Pongtawat --- Created attachment 61844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61844&action=edit Correct schema comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 18:11:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 16:11:27 +0000 Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 Pongtawat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58427|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 18:13:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 16:13:12 +0000 Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 --- Comment #7 from Pongtawat --- Created attachment 61845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61845&action=edit Add retry to koha-plack stop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 19:42:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 17:42:14 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #15 from Jonathan Druart --- It is pushed to 17.05 (i.e. master), see comment 10. Katrin was talking about not backporting it to the latest stable version (16.11.x). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 19:44:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 17:44:42 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 --- Comment #5 from Jonathan Druart --- S?verine, the link you gave is not the sandbox 4, sounds like it's a 16.05 version install, so without the patch I guess. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 19:47:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 17:47:51 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #16 from Christopher Brannon --- Okay, I am confused then by the status of resolved fixed. She said the bug isn't in 16.11.x and we shouldn't need a bug fix. There was nothing mentioned about it being needed for 17.05. Shouldn't it be pushed to master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 19:50:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 17:50:15 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #17 from Christopher Brannon --- Ignore me. I am confused today. I guess I am just confused by the status. I get that it is pushed to master. :/ Sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 19:56:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 17:56:42 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 19:57:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 17:57:34 +0000 Subject: [Koha-bugs] [Bug 18366] On shelf holds allowed > "If all unavailable" ignores library of the rule and considers all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18366 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 20:46:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 18:46:22 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #18 from Katrin Fischer --- Release Manager sets the status to 'pushed to master' after pushing - I check all those if they apply to my branch 16.11.x - if not, I change to Resolved Fixed, because there is nothing more to to. If I push them, I change to Pushed to stable, which then is checked by the other Rmaints for back?orting to their versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 20:57:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 18:57:45 +0000 Subject: [Koha-bugs] [Bug 18219] "Not checked out." problem message displays twice on local use. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #19 from Christopher Brannon --- (In reply to Katrin Fischer from comment #18) > Release Manager sets the status to 'pushed to master' after pushing - I > check all those if they apply to my branch 16.11.x - if not, I change to > Resolved Fixed, because there is nothing more to to. If I push them, I > change to Pushed to stable, which then is checked by the other Rmaints for > back?orting to their versions. Thank you for the clarification! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 21:22:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 19:22:51 +0000 Subject: [Koha-bugs] [Bug 18366] On shelf holds allowed > "If all unavailable" ignores library of the rule and considers all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18366 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master CC| |andreas.hedstrom.mace at sub.s | |u.se, | |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hm, not sure if this is an alternative behaviour or a bug fix - I am adding some people CC in hope they can shed some light on the intended behaviour. That said - I like the suggested workflow and would like to see it! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 21:29:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 19:29:14 +0000 Subject: [Koha-bugs] [Bug 18378] Author name cannot add In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- In MARC21 the first author is stored in 100 and further authors in 700. Those are visible in the default framework and no error appears for me when I test adding an author/authority. I think this is more likely to be a problem with the installation/configuration or similar. Please bring this up on the mailing list and include information about the version of Koha you use, how it was set up, which MARC flavour you use and if you have changed your frameworks etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 21:48:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 19:48:07 +0000 Subject: [Koha-bugs] [Bug 18366] On shelf holds allowed > "If all unavailable" ignores library of the rule and considers all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18366 Claudio changed: What |Removed |Added ---------------------------------------------------------------------------- OS|All |Mac OS --- Comment #3 from Claudio --- Additional comment: each library has it's own issuing rules, which are the same but that are defined one per library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 21:57:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 19:57:29 +0000 Subject: [Koha-bugs] [Bug 18366] On shelf holds allowed > "If all unavailable" ignores library of the rule and considers all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18366 --- Comment #4 from Katrin Fischer --- We have some overall settings also - I see where you are coming from, but we should check if a change here would break something for the sponsoring library. The use case I think about is if the branches are close to each other (maybe faculty libraries on a campus?) where you actually want to check against all items over all libraries and expect the patron to walk there, if there is still one item available there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 22:02:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 20:02:49 +0000 Subject: [Koha-bugs] [Bug 18366] On shelf holds allowed > "If all unavailable" ignores library of the rule and considers all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18366 --- Comment #5 from Claudio --- You are right Katrin. I was thinking about branches that are not close to each other... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 22:46:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 20:46:50 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 --- Comment #1 from Aleisha Amohia --- Created attachment 61846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61846&action=edit Bug 18351: Able to delete budget with funds To test: 1) Create a budget, add a fund 2) Delete budget. Notice this is successful and triggers no warning message etc. 3) Go to Funds. Notice the funds appear as if they are not there 4) Go into mysql and view the aqbudgetperiods table - notice the funds are still there and are now inaccessible. 5) Apply patch 6) Create a budget, add a fund 7) Attempt to delete budget. Notice you can't click Delete button. Confirm number of funds in hover message is correct. 8) Delete fund 9) Confirm you can now delete budget. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 22:47:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 20:47:10 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 23:06:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 21:06:29 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59779|0 |1 is obsolete| | --- Comment #81 from Aleisha Amohia --- Created attachment 61847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61847&action=edit Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 23:06:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 21:06:38 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59798|0 |1 is obsolete| | --- Comment #82 from Aleisha Amohia --- Created attachment 61848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61848&action=edit Bug 14224: Do not reintroduce GetItemIssue, it's dying Bug 17680 is removing it. Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 23:06:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 21:06:45 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59799|0 |1 is obsolete| | --- Comment #83 from Aleisha Amohia --- Created attachment 61849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61849&action=edit Bug 14224: Reintroduce previous copyright Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 23:06:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 21:06:52 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59800|0 |1 is obsolete| | --- Comment #84 from Aleisha Amohia --- Created attachment 61850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61850&action=edit Bug 14224: Remove SQL query in svc script Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 23:06:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 21:06:59 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59801|0 |1 is obsolete| | --- Comment #85 from Aleisha Amohia --- Created attachment 61851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61851&action=edit Bug 14224: Fix prevent submit That did not work, the form was submitted anyway Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 23:07:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 21:07:06 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59802|0 |1 is obsolete| | --- Comment #86 from Aleisha Amohia --- Created attachment 61852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61852&action=edit Bug 14224: Make strings translatable The strings should be translatable. This patch also removes the error as it appears that we only have 1 error. To improve we could surround the store with an eval. Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 23:07:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 21:07:12 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59803|0 |1 is obsolete| | --- Comment #87 from Aleisha Amohia --- Created attachment 61853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61853&action=edit Bug 14224: Replace AllowIssueNotes with AllowCheckoutNotes Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 23:07:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 21:07:18 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59804|0 |1 is obsolete| | --- Comment #88 from Aleisha Amohia --- Created attachment 61854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61854&action=edit Bug 14224: Update Copyright Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 23:07:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 21:07:31 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59806|0 |1 is obsolete| | --- Comment #90 from Aleisha Amohia --- Created attachment 61856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61856&action=edit Bug 14224: Check if the columns do not exist before creating them Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 23:07:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 21:07:25 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59805|0 |1 is obsolete| | --- Comment #89 from Aleisha Amohia --- Created attachment 61855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61855&action=edit Bug 14224: Improve escaped characters To recreate the problem, submit a note like doh"doh Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 23:07:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 21:07:51 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 4 23:09:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 21:09:26 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59957|0 |1 is obsolete| | --- Comment #19 from Aleisha Amohia --- Created attachment 61857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61857&action=edit Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowCheckoutNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave a checkout note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage checkout notes. 13) Go to main intranet page. There should be no message saying 'checkout notes pending'. 14) Go to circulation home page. There should be no link to Checkout notes. 15) Go back to user's permissions and tick circulate->manage checkout notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Checkout notes pending: 2' 17) Go to circulation home page. There should be a link to Checkout notes with a 2 next to it. Click this link 18) Attempt to mark an checkout note as seen. This should update the status of the checkout note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Confirm that buttons at the bottom are only enabled if a checkbox is checked 22) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 23) Confirm the barcode link to the item works as expected. 24) Confirm the cardnumber link to the user works as expected. 25) Confirm all table details show correctly. Sponsored-by: Catalyst IT Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 00:59:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 22:59:06 +0000 Subject: [Koha-bugs] [Bug 10357] Send email when serial received subscription link is hard to find In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61726|0 |1 is obsolete| | --- Comment #15 from Aleisha Amohia --- Created attachment 61858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61858&action=edit Bug 10357: Adding link for email notification for new subscription issues to opac-detail This patch adds the link to the opac-detail.pl page so it is less hard to find. Update: Fixing link to look like button, adding span ID around element Update: Changing ID to Class Update: Comment 14 fixes To test: 1) Add a subscription, attach it to a record and select a notice under 'Patron notification'. Hit Next, fill in some fields and save the subscription 2) Go to that record detail page in the OPAC. Go to the subscriptions tab, click 'More details'. Notice how many clicks it takes to see the 'Subscribe' button 3) Apply patch and go back to the details page for the record 4) Notice now there is a 'subscribe' button 5) Confirm this button works as expected and you are redirected to the detail page 6) Confirm 'Cancel' works and redirect works too 7) Go down to 'More details' and confirm the buttons work and you are redirected back to the serial-issues plage from here Sponsored-by: Catalyst IT Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 00:59:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 22:59:01 +0000 Subject: [Koha-bugs] [Bug 10357] Send email when serial received subscription link is hard to find In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 01:54:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 23:54:34 +0000 Subject: [Koha-bugs] [Bug 18184] Subscriptions summaries don' t show if seeing all subs attached to a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18184 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 01:54:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 23:54:38 +0000 Subject: [Koha-bugs] [Bug 18184] Subscriptions summaries don' t show if seeing all subs attached to a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18184 --- Comment #1 from Aleisha Amohia --- Created attachment 61859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61859&action=edit Bug 18184: Show frequency and numbering pattern info when viewing all subs attached to a biblio To test: 1) Go to Serials, find a serial with more than one subscription 2) Click Serial collection 3) Notice how Frequency and Numbering pattern are filled out correctly 4) Click 'see any sub attached to this biblio' 5) Notice how Frequency and Numbering pattern are now missing info 6) Apply patch and refresh page 7) Confirm Frequency and Numbering pattern now show as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 01:54:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 23:54:51 +0000 Subject: [Koha-bugs] [Bug 18184] Subscriptions summaries don' t show if seeing all subs attached to a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18184 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 01:58:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2017 23:58:08 +0000 Subject: [Koha-bugs] [Bug 18384] New: Add syspref to show all subs attached to a biblio in serial collection by default Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18384 Bug ID: 18384 Summary: Add syspref to show all subs attached to a biblio in serial collection by default Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com At the moment, to see all subscriptions attached to a biblio in serial collection you must click another link. It would be nice to have a syspref that showed this page by default when viewing serial collection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 02:16:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 00:16:48 +0000 Subject: [Koha-bugs] [Bug 18384] Add syspref to show all subs attached to a biblio in serial collection by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18384 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 02:16:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 00:16:52 +0000 Subject: [Koha-bugs] [Bug 18384] Add syspref to show all subs attached to a biblio in serial collection by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18384 --- Comment #1 from Aleisha Amohia --- Created attachment 61860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61860&action=edit Bug 18384: ShowAllAttachedSubsSerialCollection syspref To test: 1) Apply patch and update database 2) Find ShowAllAttachedSubsSerialCollection syspref, confirm it is set to "Don't" 3) Go to Serials, find a serial with more than one subscription 4) Click Serial Collection, confirm you are taken to the subscription summary for that one subscription 5) Set syspref to 'Always' 6) Go back to serials and find that same serial 7) Click Serial Collection, confirm you can see the subscription summaries of all attached subs straight away. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 02:17:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 00:17:04 +0000 Subject: [Koha-bugs] [Bug 18384] Add syspref to show all subs attached to a biblio in serial collection by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18384 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 06:08:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 04:08:09 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 06:08:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 04:08:13 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 --- Comment #1 from Aleisha Amohia --- Created attachment 61861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61861&action=edit Bug 3137: HideFieldsAddPatronForm syspref This patches adds a syspref - HideFieldsAddPatronFrom - that controls which fieldsets are hidden by default in the add patron form. To test: 1) Apply patch and refresh page 2) Go to System preferences and confirm HideFieldsAddPatronForm has no fields selected 3) Go to add a patron / edit an existing patron (any patron category). confirm everything still works as expected. 4) Tick some of the fields in the syspref to hide them in the form 5) Go back to add patron form. 6) Confirm these fields are hidden and listed at the top of the page 7) Toggle the checkbox and confirm the hidden fields show or hide as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 06:08:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 04:08:24 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Assignee|gmcharlt at gmail.com |aleisha at catalyst.net.nz Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 06:08:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 04:08:33 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 06:21:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 04:21:23 +0000 Subject: [Koha-bugs] [Bug 14537] The system preference 'OverdueNoticeBcc' is mis-named. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 06:21:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 04:21:27 +0000 Subject: [Koha-bugs] [Bug 14537] The system preference 'OverdueNoticeBcc' is mis-named. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 --- Comment #1 from Aleisha Amohia --- Created attachment 61862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61862&action=edit Bug 14537: Renaming OverdueNoticeBcc to NoticeBcc To test: 1) Apply patch and update database 2) Run 'git grep "OverdueNoticeBcc"' and confirm there are no other instances Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 06:22:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 04:22:00 +0000 Subject: [Koha-bugs] [Bug 14537] The system preference 'OverdueNoticeBcc' is mis-named. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |aleisha at catalyst.net.nz CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 06:22:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 04:22:29 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61861|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 61863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61863&action=edit Bug 3137: HideFieldsAddPatronForm syspref This patches adds a syspref - HideFieldsAddPatronFrom - that controls which fieldsets are hidden by default in the add patron form. To test: 1) Apply patch and update database 2) Go to System preferences and confirm HideFieldsAddPatronForm has no fields selected 3) Go to add a patron / edit an existing patron (any patron category). confirm everything still works as expected. 4) Tick some of the fields in the syspref to hide them in the form 5) Go back to add patron form. 6) Confirm these fields are hidden and listed at the top of the page 7) Toggle the checkbox and confirm the hidden fields show or hide as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 06:43:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 04:43:00 +0000 Subject: [Koha-bugs] [Bug 17465] Add a System Preference to control number of Saved Reports displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17465 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 06:43:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 04:43:04 +0000 Subject: [Koha-bugs] [Bug 17465] Add a System Preference to control number of Saved Reports displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17465 --- Comment #1 from Aleisha Amohia --- Created attachment 61864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61864&action=edit Bug 17465: NumSavedReports syspref To test: 1) Apply patch and update database 2) Go to system preferences. Default value should be 20 reports. 3) Go to Reports -> Use saved. Confirm 20 results are showing 4) Change value in syspref to any integer (i.e. 50) 5) Go back to Reports -> Use saved. Confirm the number of results shown is based on the value in the syspref. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 06:43:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 04:43:18 +0000 Subject: [Koha-bugs] [Bug 17465] Add a System Preference to control number of Saved Reports displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17465 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Assignee|gmcharlt at gmail.com |aleisha at catalyst.net.nz Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 07:12:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 05:12:36 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 07:12:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 05:12:40 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #2 from Aleisha Amohia --- Created attachment 61865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61865&action=edit Bug 12365: Adding a note column to circ rules This patch adds a note column to the circ and fine rules to act as a description line for the rule. To test: 1) Apply patch, update database (may have to also update schema) 2) Go to Admin -> Circ and fine rules 3) Scroll to the right, notice new Note column 4) Confirm it works to create a brand new rule with a Note 5) Confirm it works to modify an existing rule with a Note Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 07:12:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 05:12:51 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 07:13:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 05:13:57 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60857|0 |1 is obsolete| | --- Comment #8 from Srdjan Jankovic --- Created attachment 61866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61866&action=edit Bug 17602 Add Oneclickdigital integration to Koha Add OneClickdigital to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with Oneclickdigital) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 08:35:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 06:35:30 +0000 Subject: [Koha-bugs] [Bug 18375] Better readability of patron category table for zero ages and fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18375 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 08:35:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 06:35:32 +0000 Subject: [Koha-bugs] [Bug 18375] Better readability of patron category table for zero ages and fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18375 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61813|0 |1 is obsolete| | --- Comment #2 from Luke Honiss --- Created attachment 61867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61867&action=edit Bug 18375: Better readability of patron category table for zero ages and fees In patron category table, this patch displays zero / empty values for ages and fees with '-' for better readability To test: - Go to Home > Administration > Patron categories - Verify that you have 0 years and/or only years in Age required and Uper age limit colums - Verify that you have Enrollment and Hold fees of 0.00 - Apply patch - Verify that such values are replaced by - to enhance table readability Signed-off-by: Luke Honiss -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:33:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 07:33:03 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:14:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 08:14:12 +0000 Subject: [Koha-bugs] [Bug 18378] Author name cannot add In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18378 Ram Kumar changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|RESOLVED |REOPENED --- Comment #2 from Ram Kumar --- We are using 16.11. In that the field 100 name is General Procession Data (usually other versions named as PERSONAL NAME). 245 tag not is there. How can we add main title of the book, Thats why, i have download marc framework and import into koha.Mannual Installation have done. We have choosen MARC 21. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:38:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 08:38:02 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:49:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 08:49:55 +0000 Subject: [Koha-bugs] [Bug 18385] New: Strange display of tabs in subscription details (OPAC) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18385 Bug ID: 18385 Summary: Strange display of tabs in subscription details (OPAC) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 61868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61868&action=edit Strange display of tabs in subscription details (OPAC) Tabs do not display correctly in /cgi-bin/koha/opac-serial-issues.pl?biblionumber=nn To reproduce, create a subscription, then display serial in OPAC: Home > Details for [My serial] > Issues for a subscription See screenshot attached. Reproduced with Firefox and IE, same display. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:52:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 08:52:07 +0000 Subject: [Koha-bugs] [Bug 18385] Strange display of tabs in subscription details (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18385 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com Component|Staff Client |Serials -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:54:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 08:54:10 +0000 Subject: [Koha-bugs] [Bug 10357] Send email when serial received subscription link is hard to find In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61858|0 |1 is obsolete| | --- Comment #16 from Marc V?ron --- Created attachment 61869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61869&action=edit Bug 10357: Adding link for email notification for new subscription issues to opac-detail This patch adds the link to the opac-detail.pl page so it is less hard to find. Update: Fixing link to look like button, adding span ID around element Update: Changing ID to Class Update: Comment 14 fixes To test: 1) Add a subscription, attach it to a record and select a notice under 'Patron notification'. Hit Next, fill in some fields and save the subscription 2) Go to that record detail page in the OPAC. Go to the subscriptions tab, click 'More details'. Notice how many clicks it takes to see the 'Subscribe' button 3) Apply patch and go back to the details page for the record 4) Notice now there is a 'subscribe' button 5) Confirm this button works as expected and you are redirected to the detail page 6) Confirm 'Cancel' works and redirect works too 7) Go down to 'More details' and confirm the buttons work and you are redirected back to the serial-issues plage from here Sponsored-by: Catalyst IT Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE Followed test plan, works as expected. Signed-off-by: Marc V?ron Re-tested, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:54:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 08:54:31 +0000 Subject: [Koha-bugs] [Bug 10357] Send email when serial received subscription link is hard to find In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:56:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 08:56:52 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:57:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 08:57:57 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from S?verine Queune --- Sorry about the link, I was working on different Koha... There was still a display problem on sandbox #4 this morning. I tried to aply the patch again and it seems to work ! Thanks a lot Jonathan !! Ans sorry again about my careless mistake :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:59:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 08:59:25 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com --- Comment #7 from sandboxes at biblibre.com --- Patch tested with a sandbox, by S?verine Queune -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:59:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 08:59:38 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61797|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:59:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 08:59:46 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 --- Comment #8 from sandboxes at biblibre.com --- Created attachment 61870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61870&action=edit Bug 18370: Columns visibility on patron search - Hide the correct column When a column is hidden by default on the patron search result table, if the logged in user does not have the "tools > manage_patron_lists" permission, the wrong column will be hidden. Test plan: Edit the column visibility detail for "Patrons > id=memberresultst" Set "Fines" hidden by default Search for patrons => Without this patch, if the logged in user does not have the manage_patron_lists permission, the wrong column will be hidden/displayed. Signed-off-by: S?verine Queune Signed-off-by: S?verine Queune -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 11:10:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 09:10:15 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Marc V?ron --- Patch does no longer apply. How would disambiguation work? e.g. for the 3 meanings of "Title" mentioned in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285#c25 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 11:27:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 09:27:33 +0000 Subject: [Koha-bugs] [Bug 17439] Orders price are not recalculated when transfered to another vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17439 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 11:34:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 09:34:32 +0000 Subject: [Koha-bugs] [Bug 18380] Current location in OPAC not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18380 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- I can not reproduce on current master (OPAC). Library displays as expected in column "Current location" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 11:35:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 09:35:20 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 11:41:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 09:41:24 +0000 Subject: [Koha-bugs] [Bug 18353] Fix "Save" button on add/edit patron in IE11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18353 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #8 from Magnus Enger --- This was indeed solved by the upgrade, so I'm marking this as a duplicate. *** This bug has been marked as a duplicate of bug 18305 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 11:41:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 09:41:24 +0000 Subject: [Koha-bugs] [Bug 18305] jquery.fixFloat.js breaks advanced MARC editor for some browsers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #9 from Magnus Enger --- *** Bug 18353 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 11:59:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 09:59:11 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Felix Hemme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 11:59:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 09:59:24 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61846|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 11:59:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 09:59:32 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 61871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61871&action=edit Bug 18351: Able to delete budget with funds To test: 1) Create a budget, add a fund 2) Delete budget. Notice this is successful and triggers no warning message etc. 3) Go to Funds. Notice the funds appear as if they are not there 4) Go into mysql and view the aqbudgetperiods table - notice the funds are still there and are now inaccessible. 5) Apply patch 6) Create a budget, add a fund 7) Attempt to delete budget. Notice you can't click Delete button. Confirm number of funds in hover message is correct. 8) Delete fund 9) Confirm you can now delete budget. Sponsored-by: Catalyst IT Signed-off-by: Felix Hemme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 11:59:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 09:59:35 +0000 Subject: [Koha-bugs] [Bug 18378] Author name cannot add In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18378 --- Comment #3 from Katrin Fischer --- It sounds like you might have installed UNIMARC instead of MARC21? Please ask further questions on the mailing list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:02:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:02:35 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 Felix Hemme changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felix.hemme at thulb.uni-jena. | |de --- Comment #4 from Felix Hemme --- Comment on step 4: funds are stored in table aqbudgets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:12:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:12:06 +0000 Subject: [Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- I like the idea. However: If I disable e.g. Alternate address and then, from a patron's detail page, follow the "Edit" link for Alternate address, I get an empty form, and I can not toggle the fields. I would expect that the fields display anyway (without toggling), since I explicitely clicked the "Edit" button for Alternate address. - I think it is the same for all partial edit forms. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:14:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:14:34 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:18:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:18:04 +0000 Subject: [Koha-bugs] [Bug 18386] New: Renew message in Default messaging preferences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18386 Bug ID: 18386 Summary: Renew message in Default messaging preferences Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When renew a book user would like to get an SMS notification which contains when is the next due date. In default messaging preferences no option for the message to send after renewal. It's nice messaging preference for Renew in Administration > Patron categories > Default messaging preferences -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:19:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:19:08 +0000 Subject: [Koha-bugs] [Bug 18386] Renew message in Default messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18386 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 CC| |vimal0212 at gmail.com Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:21:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:21:50 +0000 Subject: [Koha-bugs] [Bug 14537] The system preference 'OverdueNoticeBcc' is mis-named. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61862|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 61872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61872&action=edit Bug 14537: Renaming OverdueNoticeBcc to NoticeBcc To test: 1) Apply patch and update database 2) Run 'git grep "OverdueNoticeBcc"' and confirm there are no other instances Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:22:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:22:06 +0000 Subject: [Koha-bugs] [Bug 14537] The system preference 'OverdueNoticeBcc' is mis-named. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:23:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:23:00 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50023|0 |1 is obsolete| | --- Comment #17 from Julian Maurice --- Created attachment 61873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61873&action=edit Bug 15395: Allow correct handling of plural translation Locale::Maketext does not allow correct handling of plural translation for languages that have more than one plural forms. Locale::Messages does. So Koha::I18N is now a wrapper around Locale::Messages, just like Locale::TextDomain, and export the same symbols as Locale::TextDomain. You can refer to documentation of Locale::TextDomain to know how to use exported subroutines. The PO file moves from misc/translator/po/xx-XX-messages.po to misc/translator/po/xx_XX/LC_MESSAGES/Koha.po and now needs to be compiled to MO in order to be used by Koha. Compilation of PO file is done by running: ./translate install xx-XX Remove dependency to Locale::Maketext and Locale::Maketext::Lexicon Add dependency to Locale::Messages Test plan: 1. Open a .pl script or .pm module with your favorite text editor 2. Add 'use Koha::I18N;' in the beginning of file 3. Use one of the subroutines exported by Koha::I18N and be sure to have a way to visualize the result (pass result to the template for example, or simply warn and watch the log file) 4. cd misc/translator && ./translate update fr-FR # try other languages 5. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po and translate your string(s) You will need to change the "Plural-Forms" header. See https://localization-guide.readthedocs.org/en/latest/l10n/pluralforms.html 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct Example usage: __("Hi") __x("Hi {name}", name => 'Bob') __n("item", "items", $num_items) __nx("one item", "{count} items", $num_items, count => $num_items) __p("Bibliographic record", "item") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:23:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:23:04 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50024|0 |1 is obsolete| | --- Comment #18 from Julian Maurice --- Created attachment 61874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61874&action=edit Bug 15395: Plural translations in templates Provides a way to handle translation of plural forms in templates Add Template::Toolkit plugin for Koha::I18N Use like this: [%# USE the plugin and define some macros %] [% PROCESS 'i18n.inc' %] [%# tn is the equivalent of __n %] [%# macro names can't start with underscore, t is for "translate" %] [% tn('item', 'items', num_items) %] Extraction of strings from templates is a bit complicated and use Template::Parser and PPI. Template is compiled into Perl code and then analyzed by PPI. It is slow, but should be correct even with complex constructions. Add dependency to PPI Test plan: 1. Open a template file (.tt or .inc) with your favorite text editor 2. Add the PROCESS directive mentioned above in the beginning of file 3. Use one of the t* macros defined in i18n.inc. They are used like their "__" equivalent, with one difference: the 'x' variants take a hashref instead of a hash as last parameter 4. cd misc/translator && ./translate update fr-FR 5. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po and translate your string(s) 6. ./translate install fr-FR 7. Use your web browser to go to the page that should display the translation, change language and verify the translation is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:23:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:23:08 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50025|0 |1 is obsolete| | --- Comment #19 from Julian Maurice --- Created attachment 61875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61875&action=edit Bug 15395: Example usage of I18N Template::Toolkit plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:23:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:23:13 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50026|0 |1 is obsolete| | --- Comment #20 from Julian Maurice --- Created attachment 61876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61876&action=edit Bug 15395: Add plural translation capabilities to JS files It adds Javascript equivalent of Koha::I18N's exported subroutines, and they are used the same way. String extraction is done only on *.js files and require gettext 0.19 (available in Debian stable, and also in wheezy-backports) It adds Javascript library Gettext.js for handling translation and a Perl script po2json to transform PO file into JSON. Gettext.js and po2json both come from Locale::Simple. There are several tools named po2json. It's simpler to integrate this one into Koha than to check if the good one is installed on the system. Locale::Simple is not needed. To avoid polluting the global namespace too much, this patch also introduce a global JS object named Koha and add some stuff in Koha.i18n Test plan: 1. Add a translatable string in a JS file. For example, add this: alert(__nx("There is one item", "There are {count} items", 3, {count: 3})); to staff-global.js 2. cd misc/translator && ./translate update fr-FR 3. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po, verify that your string is present, and translate it 4. cd misc/translator && ./translate install fr-FR 5. (Optional) Verify that koha-tmpl/intranet-tmpl/prog/fr-FR/js/locale_data.js exists and contains your translation 6. Open your browser on the staff main page, change language and verify that the message is translated 7. Repeat 1-6 on OPAC side -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:29:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:29:37 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #21 from Julian Maurice --- (In reply to Marc V?ron from comment #16) > Patch does no longer apply. > > How would disambiguation work? > > e.g. for the 3 meanings of "Title" mentioned in > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285#c25 To attach context to a string, you have to use one of the 'p' variants (__p, __px, __np, __npx). This context will appear in the PO file to help the translator and gettext will use this information to choose the right translation https://www.gnu.org/software/gettext/manual/html_node/Contexts.html Eg. __p('Patron', 'Title') __p('Bibliographic record', 'Title') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:31:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:31:12 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Felix Hemme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:31:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:31:26 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59198|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:31:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:31:34 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 61877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61877&action=edit Bug 17853 - Don't remove () from link text I have followed your test plan, applied the patch and have noticed that there are now brackets around the link text. Is this what you were looking for? Signed-off-by: Felix Hemme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:41:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:41:25 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45476|0 |1 is obsolete| | --- Comment #55 from Julian Maurice --- Created attachment 61878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61878&action=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:41:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:41:30 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57296|0 |1 is obsolete| | --- Comment #56 from Julian Maurice --- Created attachment 61879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61879&action=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. The _update_message_to_address becomes useless since the to_address is retrieved previously. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:41:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:41:35 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45478|0 |1 is obsolete| | --- Comment #57 from Julian Maurice --- Created attachment 61880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61880&action=edit Bug 12802: FIX use the first valid email address if noemail is needed Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:41:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:41:40 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45479|0 |1 is obsolete| | --- Comment #58 from Julian Maurice --- Created attachment 61881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61881&action=edit Bug 12802: Fix if AutoEmailOpacUser is enabled Test plan: Verify that the behavior of AutoEmailOpacUser still works as before. Note that now the email can receive several emails if AutoEmailPrimaryAddress has several values. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:41:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:41:44 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45480|0 |1 is obsolete| | --- Comment #59 from Julian Maurice --- Created attachment 61882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61882&action=edit Bug 12802: Fix QA script issues FAIL C4/Reserves.pm FAIL pod Spurious =cut command in file C4/Reserves.pm Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:41:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:41:49 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45481|0 |1 is obsolete| | --- Comment #60 from Julian Maurice --- Created attachment 61883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61883&action=edit Bug 12802: Fix tests in Letters.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:41:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:41:54 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45482|0 |1 is obsolete| | --- Comment #61 from Julian Maurice --- Created attachment 61884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61884&action=edit Bug 12802: Fix tests in Reserves.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:42:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:42:26 +0000 Subject: [Koha-bugs] [Bug 18378] Author name cannot add In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18378 --- Comment #4 from Ram Kumar --- How can install marc21? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:43:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 10:43:16 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #62 from Julian Maurice --- Patches reattached to fix their order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 13:12:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 11:12:53 +0000 Subject: [Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437 Felix Hemme changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felix.hemme at thulb.uni-jena. | |de --- Comment #4 from Felix Hemme --- Subfield $i is currently displayed on a new line. Wouldn't it be better to display $i in square brackets behind the subfields $a and $t? Just like field 246. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 13:41:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 11:41:11 +0000 Subject: [Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437 --- Comment #5 from Katrin Fischer --- (In reply to Felix Hemme from comment #4) > Subfield $i is currently displayed on a new line. Wouldn't it be better to > display $i in square brackets behind the subfields $a and $t? Just like > field 246. With our data that looks a little odd sometimes - I wonder if it would be nicer at the beginning of the field as an 'intro'? I think we have examples for both atm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 13:48:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 11:48:20 +0000 Subject: [Koha-bugs] [Bug 12836] Add a script to regenerate Explain files from configs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12836 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SRU Explain file needs to |Add a script to regenerate |be rewritten |Explain files from configs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:15:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 12:15:25 +0000 Subject: [Koha-bugs] [Bug 18387] New: 404 errors on page causes SCO user to be logged out Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Bug ID: 18387 Summary: 404 errors on page causes SCO user to be logged out Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If AutoSelfCheck is enabled but there is a 404 error in fetching resources on an SCO page the user is logged out on each request. This is because a 404 also requests the errorpages.tt which is outside the SCO module. This causes a redirect to the opac-auth page when trying to print receipts after completing SCO transaction To recreate: 1 - Enable AuthoSelfCheck prefs 2 - In opacuserjs or scouserjs add a fetch of an unreachable resources 3 - Visit the SCO 4 - Sign in as a patron then click 'finish' 5 - Say 'yes' to receipt 6 - Note you are directed to log in -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:11:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 13:11:52 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #51 from Alex Sassmannshausen --- Created attachment 61885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61885&action=edit Bug 11897: Add documentation for the cron script. * misc/cronjobs/stockrotation.pl: Add documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:48:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 13:48:29 +0000 Subject: [Koha-bugs] [Bug 18201] Confusing language on Export data - bibliographic records " Remove non-local items" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 --- Comment #1 from Nick Clemens --- It's worse, it means 'remove titles that don't contain items belonging to the branch I am signed in as' which means you get all items on the records, even if those specific items are from otherbranches Clarification: Record A has items from branches A B C Record B has items from branches B C Record C has items from branches A C Signed in a branch b Remove nonlocal items Get: Record A with all items Record B with all items Expected: Record A with item from branch B Record B with item from branch B -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:56:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 13:56:06 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #70 from Marc V?ron --- Went through test plans from comment #68 and comment #69, works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:59:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 13:59:12 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #28 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Eugene Jose Espinoza -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:59:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 13:59:40 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61801|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:59:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 13:59:46 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61802|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:59:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 13:59:52 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61803|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:59:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 13:59:58 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61804|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:00:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:00:08 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #29 from sandboxes at biblibre.com --- Created attachment 61886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61886&action=edit Bug 16892: Add automatic patron registration via OAuth2 login 10988 added the ability to log into the OPAC authenticating with Google Open ID Connect. This extends it, by allowing an unregistered patron to have an account automatically created with default category code and branch. This is accomplished by adding 3 system preferences. - GoogleOpenIDConnectAutoRegister whether it will attempt to auto-register the patron. - GoogleOpenIDConnectDefaultCategory This category code will be used to create Google OpenID Connect patrons. - GoogleOpenIDConnectDefaultBranch' This branch code will be used to create Google OpenID Connect patrons. Sponsored-by: Tulong Aklatan Signed-off-by: Eugene Jose Espinoza -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:00:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:00:14 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #30 from sandboxes at biblibre.com --- Created attachment 61887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61887&action=edit Bug 16892: System Preferences This adds the missing system preferences for a fresh install. Signed-off-by: Eugene Jose Espinoza -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:00:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:00:19 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #31 from sandboxes at biblibre.com --- Created attachment 61888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61888&action=edit Bug 16892: Follow up with adding missing IGNORE Signed-off-by: Eugene Jose Espinoza -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:00:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:00:23 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #32 from sandboxes at biblibre.com --- Created attachment 61889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61889&action=edit Bug 16892: Follow up use AddMember as per QA comment Same Test plan as before. Signed-off-by: Eugene Jose Espinoza -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:01:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:01:51 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61779|0 |1 is obsolete| | --- Comment #71 from Marc V?ron --- Created attachment 61890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61890&action=edit Bug 9988: Database revision for AuthorityMergeLimit Introduce the new preference and remove dontmerge. If dontmerge was enabled, the new pref will be set to zero and we will print a message about raising this value now. Test plan: Run the database revision or a new install. In case of an upgrade, check the new pref value. Should be 0 when dontmerge was enabled, otherwise 50. Signed-off-by: Marcel de Rooy Also tested sysprefs.sql on a new database. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:02:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:02:46 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61780|0 |1 is obsolete| | --- Comment #72 from Marc V?ron --- Created attachment 61891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61891&action=edit Bug 9988: Table revision for need_merge_authorities In order to let merge do exactly the same when called from the merge cron job, we need three additional fields in the table. The use of these fields will be explained in a follow-up. Test plan: Run the dbrev (updatestructure step in webinstaller). Signed-off-by: Marcel de Rooy Also tested running kohastructure.sql for this table. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:03:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:03:42 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61781|0 |1 is obsolete| | --- Comment #73 from Marc V?ron --- Created attachment 61892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61892&action=edit Bug 9988: DBIx schema changes for need_merge_authorities As generated by misc/devel/update_dbix_class_files.pl. No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:04:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:04:37 +0000 Subject: [Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370 --- Comment #9 from Jonathan Druart --- (In reply to S?verine Queune from comment #6) > Thanks a lot Jonathan !! Thank you for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:08:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:08:41 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61782|0 |1 is obsolete| | --- Comment #74 from Marc V?ron --- Created attachment 61893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61893&action=edit Bug 9988: Add Koha objects for table need_merge_authorities This patch adds two Koha objects: MergeRequest(s). MergeRequest has a new method and an oldmarc method. A class method reporting_tag_xml is added to MergeRequests.pm. All new routines are tested in Authorities.t. Removes a few unneeded modules from Koha::Authority. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:09:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:09:52 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61783|0 |1 is obsolete| | --- Comment #75 from Marc V?ron --- Created attachment 61894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61894&action=edit Bug 9988: Add extract_biblionumber to Koha/SearchEngine When we will replace the Zebra code in sub merge, we will call SearchEngine to pass records and we need a routine to extract a biblionumber from a search result record. A record from Zebra still must be converted to MARC::Record. This is no longer needed for a ElasticSearch record. Test plan: Run t/db_dependent/Koha/SearchEngine/Search.t Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:11:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:11:15 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61784|0 |1 is obsolete| | --- Comment #76 from Marc V?ron --- Created attachment 61895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61895&action=edit Bug 9988: Add get_usage_count and linked_biblionumbers to Koha::Authority When replacing the Zebra code in sub merge, we actually need CountUsage as well as the results it gets from SearchEngine. In order to get count and/or results, we now create: [1] instance methods get_usage_count and linked_biblionumbers in Koha::Authority, [2] class methods of the same name in Koha::Authorities. The instance method calls the class method. The class method can be used for deleted authority records, and in 'legacy calls' before refactoring. Note: On BZ 18149 we will replace all CountUsage calls. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:13:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:13:00 +0000 Subject: [Koha-bugs] [Bug 10295] add the ability to sort and filter batch of records in Staged Records Management Tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10295 --- Comment #2 from Alexandre --- Created attachment 61896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61896&action=edit Dynamic search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:13:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:13:18 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61785|0 |1 is obsolete| | --- Comment #77 from Marc V?ron --- Created attachment 61897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61897&action=edit Bug 9988: Merge should have a parameter hash We will need a few additional parameters for merge later on. This patch puts the original parameters in a parameter hash. For the same reason DelAuthority gets a parameter hash here. Note: We remove the second parameter from the DelAuthority call in authorities/authorities-home.pl here. It was not used and could have presented problems in the future. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t. [2] Run t/db_dependent/Authorities/Merge.t. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:14:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:14:14 +0000 Subject: [Koha-bugs] [Bug 10295] add the ability to sort and filter batch of records in Staged Records Management Tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10295 --- Comment #3 from Alexandre --- Hi, Some staff users have difficulty too to find their staged MARC records when they have a big quantity loaded into their system. Path : 1) Go to "Tools" module 2) Go to "Staged MARC record management" 3) Observe that no research option are present in the board (no filter, no advanced search) A space for a dynamic search like the one for the board in the acquisition module will be great. Or at least, up and down arrows in each title on the upper line will be good too. Thanks for helping, Alexandre from CCSR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:14:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:14:23 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61786|0 |1 is obsolete| | --- Comment #78 from Marc V?ron --- Created attachment 61898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61898&action=edit Bug 9988: Remove the Zebra code from sub merge Since we can now call linked_biblionumbers, we can now remove all Zebra related code from merge. We also add a parameter biblionumbers; we use it in the test now, but it may be handy too later in the maintenance script when we want to trigger a merge for specific biblionumber(s). See bug report 18071. All mocks for ZOOM, Context::Zconn, Search::new_record_for_zebra in the merge test can now be replaced by one mock for linked_biblionumbers. Note that we test the biblionumbers parameter in the last subtest without that mock. Remove unused vars $countunmodifiedbiblio, $counterrors from merge. Renamed zebrarecords to linkedrecords in the Merge test. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Modify an authority record. Check the linked biblio records. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:15:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:15:32 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61787|0 |1 is obsolete| | --- Comment #79 from Marc V?ron --- Created attachment 61899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61899&action=edit Bug 9988: Check the merge limit in sub merge At this point, we are replacing dontmerge functionality by the new AuthorityMergeLimit logic. Instead of doing this check before calling merge, we just call merge and check it there. In order to let the cron job do the larger (postponed) merges, we add a parameter override_limit. A subtest is added in Merge.t to test the 'postponed merge' feature. Since merge now also calls get_usage_count, an additional mock is added. All references to dontmerge are removed. In merge two lines, initializing $dbh and $counteditbiblios, are moved. The dontmerge test in DelAuthority and ModAuthority is removed. Since this did not leave much in ModAuthority, I fixed the whitespace on the remaining lines rightaway (yes, I know). A minimal set of changes is applied to the cron script; it will get further attention on a next patch. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Set AuthorityMergeLimit to 2. Modify an authority with two linked biblios. Check that the merge was done immediately. [3] Now modify an authority with more than 2 linked records. Verify that the merge was postponed; a record must be inserted in the need_merge_authorities table. [4] Testing of the merge cron job is *postponed* to a next patch. Note: I tested a modification, but the script just needs more attention. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:16:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:16:46 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61788|0 |1 is obsolete| | --- Comment #80 from Marc V?ron --- Created attachment 61900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61900&action=edit Bug 9988: Remove further references to dontmerge [1] The preference was sent to HEA. We can now send both AuthorityMergeMode as well as AuthorityMergeLimit. [2] A comment in authorities/merge.pl is removed. Note that a subsequent patch will modify and test the cron job. [3] Script misc/batchRebuildItemsTables.pl temporarily enabled dontmerge. This is equivalent to setting the mergelimit to zero. The function defnonull is no longer needed. (If the pref was NULL, we restore that value. Sub merge won't mind.) Test plan: [1] Run t/db_dependent/UsageStats.t [2] Run misc/batchRebuildItemsTables.pl -t This just ensures you it still compiles; the changes speak for itself. [3] Now git grep on dontmerge. You should only find hits in atomicupdate and misc/translator/po. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:17:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:17:48 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61789|0 |1 is obsolete| | --- Comment #81 from Marc V?ron --- Created attachment 61901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61901&action=edit Bug 9988: Add a subtest for specific postponed merge issues This subtest shows that we need a few little tweaks to make merge work in some specific postponed merge situations. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should fail. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:19:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:19:05 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61790|0 |1 is obsolete| | --- Comment #82 from Marc V?ron --- Created attachment 61902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61902&action=edit Bug 9988: Few subtle changes for postponed merge The fails in the previous test showed that we need the first three changes here. Some final polishing in points 4 to 6. [1] Sub merge: Refine the condition for initializing $tags_new. A postponed 'modify'-merge (A to B) makes that $authtypefrom is not defined when running merge later. When crossing the type boundary, we need a new field too. [2] Sub merge: Add condition for an empty @record_to array. This indicates also that a field should be removed, since we should otherwise only add a $9 subfield. [3] Sub merge: Adjust initializing @record_from. This change is tested by verifying a cleared subfield in the test. [4] DelAuthority: Adding a skipmerge parameter to allow the call from authorities/merge.pl to skip an unneeded merge. This also prevents that the 'delete-merge' would precede the 'modify-merge' under a hypothetical race condition. [5] DelAuthority: There is actually no need to call GetAuthority. The subfields of the old record are not relevant in this case. [6] Added a few POD lines to merge. [7] Removed a trailing space in a comment line in merge. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should no longer fail now. [2] See test plan of next patch. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:19:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:19:51 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:20:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:20:14 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61791|0 |1 is obsolete| | --- Comment #83 from Marc V?ron --- Created attachment 61903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61903&action=edit Bug 9988: Refactor the cron script The cron job is moved from migration tools to cronjobs. And renamed to a plural form. The script is now based on Koha objects. It does no longer include the code to merge one record. This can be done via the interface, and will be added to a maintenance script on bug 18071. Should not be part of this cron job. Adding a cron_cleanup method to MergeRequests; this method is called from the cron script to reset older entries still marked in progress and to also remove old processed entries. Tested in a separate unit test. Test plan: [1] Run t/db_dependent/Authorities/MergeRequests.t [2] Set AuthorityMergeLimit to 0. (All merges are postponed.) [3] Modify an authority linked to a few records. [4] Delete an authority linked to a few records with batch delete tool. [5] And select two auth records with linked records. Merge these two records with authority/merge.pl. Note: Do not select Default. See also bug 17380. [6] Check the need_merge_authorities table for inserted records. [7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked records and the record status in need_merge_authorities. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:21:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:21:33 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61792|0 |1 is obsolete| | --- Comment #84 from Marc V?ron --- Created attachment 61904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61904&action=edit Bug 9988: Add the cronjob and print an upgrade message The Debian cron file and the misc crontab example are updated. A message is printed when upgrading. Note: At this moment the merge cron job is run once a day. This is imo a good starting point. The load for this job greatly depends on the value of pref AuthorityMergeLimit. Of course you can schedule the job more often, and if this need is felt more globally, we can adjust it later. Test plan: [1] Run the dbrev and see the message. [2] Read the changes to the cron files. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:22:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:22:48 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:24:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:24:15 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #85 from Marcel de Rooy --- (In reply to Marc V?ron from comment #70) > Went through test plans from comment #68 and comment #69, works as described. Great, Marc ! Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:36:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 14:36:02 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #24 from Baptiste --- Created attachment 61905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61905&action=edit Bug 17047: Add report, factorize code, add a comment feature Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redisigned to improve the user experience - New Feature : report a record. - peoples can now report a weird report - if a record is reported a lot of time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - Added the syspref "AutoShareWithMana", which enables to select which fields you want to share automatically with mana API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) - Factorize a lot of code in order to improve the speed of next developments SytemPreferences: Mana Activation: - add a field "no, let me think" at the syspref "Mana" - as long as this field is selected, messages ask if user want to activate it messages in pages: - Administration - Add-subscription(page 2) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with mana (automatically not set) Report Share - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana - New feature: search report in Mana Knowledge Base with keywords - New feature: load reports from Mana Comment Resources - The comments can now be manually added - On a resource mana datatable, you can now see comments, add comment and vote for comments you think pertinent - Comments are NOT dynamically generated on the table you need to reload the page when you vote Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => mana shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other". - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 17:00:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 15:00:40 +0000 Subject: [Koha-bugs] [Bug 18388] New: Standardize serials volume information displaying in OPAC and staff Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388 Bug ID: 18388 Summary: Standardize serials volume information displaying in OPAC and staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl On the opac-detail page, volume information for serial does not take into account serialseq or published date. This is the on the staff side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 17:02:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 15:02:22 +0000 Subject: [Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388 --- Comment #1 from Alex Arnaud --- Created attachment 61906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61906&action=edit Bug 18388 - Standardize serials volume information displaying -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 17:02:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 15:02:39 +0000 Subject: [Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 17:02:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 15:02:49 +0000 Subject: [Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 18:21:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 16:21:49 +0000 Subject: [Koha-bugs] [Bug 18389] New: bulkmarcimport.pl does not take notice of MARC modification templates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 Bug ID: 18389 Summary: bulkmarcimport.pl does not take notice of MARC modification templates Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: J.P.Knight at lboro.ac.uk QA Contact: testopia at bugs.koha-community.org Created attachment 61907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61907&action=edit Patch for bulkmarcimport.pl When importing large numbers of MARC records from a legacy LMS to Koha we needed to convert some of 852 fields to 952 fields for item holdings. I'd created MARC modification templates in the web administration front end, but the bulkmarcimport.pl migration tool doesn't use these. Joubu on the #koha IRC channel told me that this was because bulkmarcimport.pl was written before C4::MarcModificationTemplates.pm Perl module was available. The change is actually relatively easy and I've attached a diff patch to this case for others to contemplate and critic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:09:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:09:28 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61893|0 |1 is obsolete| | --- Comment #89 from Jacek Ablewicz --- Created attachment 61915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61915&action=edit Bug 9988: Add Koha objects for table need_merge_authorities This patch adds two Koha objects: MergeRequest(s). MergeRequest has a new method and an oldmarc method. A class method reporting_tag_xml is added to MergeRequests.pm. All new routines are tested in Authorities.t. Removes a few unneeded modules from Koha::Authority. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:09:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:09:36 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61894|0 |1 is obsolete| | --- Comment #90 from Jacek Ablewicz --- Created attachment 61916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61916&action=edit Bug 9988: Add extract_biblionumber to Koha/SearchEngine When we will replace the Zebra code in sub merge, we will call SearchEngine to pass records and we need a routine to extract a biblionumber from a search result record. A record from Zebra still must be converted to MARC::Record. This is no longer needed for a ElasticSearch record. Test plan: Run t/db_dependent/Koha/SearchEngine/Search.t Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:09:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:09:12 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61891|0 |1 is obsolete| | --- Comment #87 from Jacek Ablewicz --- Created attachment 61913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61913&action=edit Bug 9988: Table revision for need_merge_authorities In order to let merge do exactly the same when called from the merge cron job, we need three additional fields in the table. The use of these fields will be explained in a follow-up. Test plan: Run the dbrev (updatestructure step in webinstaller). Signed-off-by: Marcel de Rooy Also tested running kohastructure.sql for this table. Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:09:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:09:20 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61892|0 |1 is obsolete| | --- Comment #88 from Jacek Ablewicz --- Created attachment 61914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61914&action=edit Bug 9988: DBIx schema changes for need_merge_authorities As generated by misc/devel/update_dbix_class_files.pl. No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:09:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:09:01 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61890|0 |1 is obsolete| | --- Comment #86 from Jacek Ablewicz --- Created attachment 61912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61912&action=edit Bug 9988: Database revision for AuthorityMergeLimit Introduce the new preference and remove dontmerge. If dontmerge was enabled, the new pref will be set to zero and we will print a message about raising this value now. Test plan: Run the database revision or a new install. In case of an upgrade, check the new pref value. Should be 0 when dontmerge was enabled, otherwise 50. Signed-off-by: Marcel de Rooy Also tested sysprefs.sql on a new database. Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:09:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:09:51 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61897|0 |1 is obsolete| | --- Comment #92 from Jacek Ablewicz --- Created attachment 61918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61918&action=edit Bug 9988: Merge should have a parameter hash We will need a few additional parameters for merge later on. This patch puts the original parameters in a parameter hash. For the same reason DelAuthority gets a parameter hash here. Note: We remove the second parameter from the DelAuthority call in authorities/authorities-home.pl here. It was not used and could have presented problems in the future. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t. [2] Run t/db_dependent/Authorities/Merge.t. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:09:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:09:43 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61895|0 |1 is obsolete| | --- Comment #91 from Jacek Ablewicz --- Created attachment 61917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61917&action=edit Bug 9988: Add get_usage_count and linked_biblionumbers to Koha::Authority When replacing the Zebra code in sub merge, we actually need CountUsage as well as the results it gets from SearchEngine. In order to get count and/or results, we now create: [1] instance methods get_usage_count and linked_biblionumbers in Koha::Authority, [2] class methods of the same name in Koha::Authorities. The instance method calls the class method. The class method can be used for deleted authority records, and in 'legacy calls' before refactoring. Note: On BZ 18149 we will replace all CountUsage calls. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:10:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:10:00 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61898|0 |1 is obsolete| | --- Comment #93 from Jacek Ablewicz --- Created attachment 61919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61919&action=edit Bug 9988: Remove the Zebra code from sub merge Since we can now call linked_biblionumbers, we can now remove all Zebra related code from merge. We also add a parameter biblionumbers; we use it in the test now, but it may be handy too later in the maintenance script when we want to trigger a merge for specific biblionumber(s). See bug report 18071. All mocks for ZOOM, Context::Zconn, Search::new_record_for_zebra in the merge test can now be replaced by one mock for linked_biblionumbers. Note that we test the biblionumbers parameter in the last subtest without that mock. Remove unused vars $countunmodifiedbiblio, $counterrors from merge. Renamed zebrarecords to linkedrecords in the Merge test. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Modify an authority record. Check the linked biblio records. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:10:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:10:11 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61899|0 |1 is obsolete| | --- Comment #94 from Jacek Ablewicz --- Created attachment 61920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61920&action=edit Bug 9988: Check the merge limit in sub merge At this point, we are replacing dontmerge functionality by the new AuthorityMergeLimit logic. Instead of doing this check before calling merge, we just call merge and check it there. In order to let the cron job do the larger (postponed) merges, we add a parameter override_limit. A subtest is added in Merge.t to test the 'postponed merge' feature. Since merge now also calls get_usage_count, an additional mock is added. All references to dontmerge are removed. In merge two lines, initializing $dbh and $counteditbiblios, are moved. The dontmerge test in DelAuthority and ModAuthority is removed. Since this did not leave much in ModAuthority, I fixed the whitespace on the remaining lines rightaway (yes, I know). A minimal set of changes is applied to the cron script; it will get further attention on a next patch. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Set AuthorityMergeLimit to 2. Modify an authority with two linked biblios. Check that the merge was done immediately. [3] Now modify an authority with more than 2 linked records. Verify that the merge was postponed; a record must be inserted in the need_merge_authorities table. [4] Testing of the merge cron job is *postponed* to a next patch. Note: I tested a modification, but the script just needs more attention. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:10:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:10:19 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61900|0 |1 is obsolete| | --- Comment #95 from Jacek Ablewicz --- Created attachment 61921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61921&action=edit Bug 9988: Remove further references to dontmerge [1] The preference was sent to HEA. We can now send both AuthorityMergeMode as well as AuthorityMergeLimit. [2] A comment in authorities/merge.pl is removed. Note that a subsequent patch will modify and test the cron job. [3] Script misc/batchRebuildItemsTables.pl temporarily enabled dontmerge. This is equivalent to setting the mergelimit to zero. The function defnonull is no longer needed. (If the pref was NULL, we restore that value. Sub merge won't mind.) Test plan: [1] Run t/db_dependent/UsageStats.t [2] Run misc/batchRebuildItemsTables.pl -t This just ensures you it still compiles; the changes speak for itself. [3] Now git grep on dontmerge. You should only find hits in atomicupdate and misc/translator/po. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:10:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:10:28 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61901|0 |1 is obsolete| | --- Comment #96 from Jacek Ablewicz --- Created attachment 61922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61922&action=edit Bug 9988: Add a subtest for specific postponed merge issues This subtest shows that we need a few little tweaks to make merge work in some specific postponed merge situations. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should fail. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:10:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:10:38 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61902|0 |1 is obsolete| | --- Comment #97 from Jacek Ablewicz --- Created attachment 61923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61923&action=edit Bug 9988: Few subtle changes for postponed merge The fails in the previous test showed that we need the first three changes here. Some final polishing in points 4 to 6. [1] Sub merge: Refine the condition for initializing $tags_new. A postponed 'modify'-merge (A to B) makes that $authtypefrom is not defined when running merge later. When crossing the type boundary, we need a new field too. [2] Sub merge: Add condition for an empty @record_to array. This indicates also that a field should be removed, since we should otherwise only add a $9 subfield. [3] Sub merge: Adjust initializing @record_from. This change is tested by verifying a cleared subfield in the test. [4] DelAuthority: Adding a skipmerge parameter to allow the call from authorities/merge.pl to skip an unneeded merge. This also prevents that the 'delete-merge' would precede the 'modify-merge' under a hypothetical race condition. [5] DelAuthority: There is actually no need to call GetAuthority. The subfields of the old record are not relevant in this case. [6] Added a few POD lines to merge. [7] Removed a trailing space in a comment line in merge. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should no longer fail now. [2] See test plan of next patch. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:10:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:10:53 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61903|0 |1 is obsolete| | --- Comment #98 from Jacek Ablewicz --- Created attachment 61924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61924&action=edit Bug 9988: Refactor the cron script The cron job is moved from migration tools to cronjobs. And renamed to a plural form. The script is now based on Koha objects. It does no longer include the code to merge one record. This can be done via the interface, and will be added to a maintenance script on bug 18071. Should not be part of this cron job. Adding a cron_cleanup method to MergeRequests; this method is called from the cron script to reset older entries still marked in progress and to also remove old processed entries. Tested in a separate unit test. Test plan: [1] Run t/db_dependent/Authorities/MergeRequests.t [2] Set AuthorityMergeLimit to 0. (All merges are postponed.) [3] Modify an authority linked to a few records. [4] Delete an authority linked to a few records with batch delete tool. [5] And select two auth records with linked records. Merge these two records with authority/merge.pl. Note: Do not select Default. See also bug 17380. [6] Check the need_merge_authorities table for inserted records. [7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked records and the record status in need_merge_authorities. Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:11:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:11:03 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61904|0 |1 is obsolete| | --- Comment #99 from Jacek Ablewicz --- Created attachment 61925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61925&action=edit Bug 9988: Add the cronjob and print an upgrade message The Debian cron file and the misc crontab example are updated. A message is printed when upgrading. Note: At this moment the merge cron job is run once a day. This is imo a good starting point. The load for this job greatly depends on the value of pref AuthorityMergeLimit. Of course you can schedule the job more often, and if this need is felt more globally, we can adjust it later. Test plan: [1] Run the dbrev and see the message. [2] Read the changes to the cron files. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:14:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:14:44 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #22 from Marc V?ron --- I tried to test "Example usage of I18N Template::Toolkit plugin" , using the test plan from comment #7 After perl translate update fr-FR, I edited: koha/misc/translator/po/fr_FR/LC_MESSAGES/Koha.po translated the strings and changed the line: "Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n" to: "Plural-Forms: nplurals=2; plural=(n > 1);\n" However, perl translate install fr-FR complains with following warnings: Use of uninitialized value $pref_name in concatenation (.) or string at LangInstaller.pm line 202. Use of uninitialized value $pref_name in concatenation (.) or string at LangInstaller.pm line 244. NO PLURAL FORM HEADER FOUND - DEFAULTING TO 2 print() on closed filehandle $fh at LangInstaller.pm line 689. What did I miss? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:26:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:26:38 +0000 Subject: [Koha-bugs] [Bug 17465] Add a System Preference to control number of Saved Reports displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17465 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61864|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 61926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61926&action=edit Bug 17465: NumSavedReports syspref To test: 1) Apply patch and update database 2) Go to system preferences. Default value should be 20 reports. 3) Go to Reports -> Use saved. Confirm 20 results are showing 4) Change value in syspref to any integer (i.e. 50) 5) Go back to Reports -> Use saved. Confirm the number of results shown is based on the value in the syspref. Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:27:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:27:02 +0000 Subject: [Koha-bugs] [Bug 17465] Add a System Preference to control number of Saved Reports displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17465 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:36:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:36:20 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #100 from Jacek Ablewicz --- I have tested a bit earlier version of this patchset (from a ~week ago - not exactly following the test plans, but focusing on the possibly "scary stuff" which was not directly covered by the tests instead), and by a look of it there is no need to fully retest it again. I reviewed all the changes in the code once more (well, except for the *.t files, to be honest), and they all look pretty solid to me - the only issue encountered in the previous try got fixed in the meanwhile. Sign off time ;). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:38:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:38:06 +0000 Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:48:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:48:04 +0000 Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16885 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:48:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:48:04 +0000 Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17814 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:49:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:49:18 +0000 Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 --- Comment #8 from Marc V?ron --- Created attachment 61927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61927&action=edit Bug 17814: koha-plack --stop should make sure that Plack really stop Followed test plan in comment #5. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:50:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:50:14 +0000 Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61845|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:50:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:50:25 +0000 Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:54:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:54:05 +0000 Subject: [Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:56:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 20:56:19 +0000 Subject: [Koha-bugs] [Bug 18391] New: Error: You do not have permission to access this page. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18391 Bug ID: 18391 Summary: Error: You do not have permission to access this page. Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: fcuellar at biteca.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Created attachment 61928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61928&action=edit Remove "index.html" to enter When you enter the administrator with the corresponding credentials the following error appears: "Error: You do not have permission to access this page." But when deleting "/index.html" from the url starts normally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 23:17:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 21:17:01 +0000 Subject: [Koha-bugs] [Bug 18392] New: Allow importing/ exporting circulation conditions as CSV or spreadsheet Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392 Bug ID: 18392 Summary: Allow importing/exporting circulation conditions as CSV or spreadsheet Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com As our circulation GUI is not perfect (yet) it would be nice if it offered a similar feature to the bibliographic frameworks, allowing to export/import the rules using CSV or spreadsheet files. This would make it much easier to update rules in bulk and keep track of changes to them as you could archive different versions easily too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 23:17:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 21:17:10 +0000 Subject: [Koha-bugs] [Bug 18392] Allow importing/ exporting circulation conditions as CSV or spreadsheet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 23:18:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 21:18:58 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 --- Comment #21 from Marc V?ron --- Hi Lari Validation of phone number works fine with the exception of - Fax number - Phone number in Alternative contact (both Staff client and OPAC) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 23:37:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 21:37:20 +0000 Subject: [Koha-bugs] [Bug 18393] New: Canned report reports/ acquisitions_stats.pl not filtering correctly by collection code Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Bug ID: 18393 Summary: Canned report reports/acquisitions_stats.pl not filtering correctly by collection code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 61929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61929&action=edit report settings The canned report under Home ? Reports ? Acquisitions statistics is not filtering on collection code. To replicate: 'Received on' check 'row' Filter: From: 01/01/2016 To: 12/31/2016 (or use a date range that corresponds to acquisitions on your system) 'Collection code' check 'column' Filter: Select 'All' Cell value Choose 'Count items' Output Choose 'To screen into the browser?' Click Submit. You will see columns of collection codes, with each row being a separate date. All collection codes will be displayed. Use the browser's back button, change the collection code 'Collection code' check 'column' Filter: Select 'Music' (or a collection code on your system) Click submit. We would expect to see a single column showing the 'Music' collection code -- instead we see all collection codes again. See screenshots for report settings and output. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 23:38:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 21:38:22 +0000 Subject: [Koha-bugs] [Bug 18393] Canned report reports/ acquisitions_stats.pl not filtering correctly by collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 --- Comment #1 from Barton Chittenden --- Created attachment 61930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61930&action=edit Report results, all collection codes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 23:39:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 21:39:17 +0000 Subject: [Koha-bugs] [Bug 18393] Canned report reports/ acquisitions_stats.pl not filtering correctly by collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 --- Comment #2 from Barton Chittenden --- Created attachment 61931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61931&action=edit Report results, choose collection code 'music only' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 23:40:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2017 21:40:35 +0000 Subject: [Koha-bugs] [Bug 18393] Canned report reports/ acquisitions_stats.pl not filtering correctly by collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 02:42:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 00:42:54 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61866|0 |1 is obsolete| | --- Comment #9 from Srdjan Jankovic --- Created attachment 61932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61932&action=edit Bug 17602 Add Oneclickdigital integration to Koha Add OneClickdigital to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with Oneclickdigital) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 05:34:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 03:34:56 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #17 from Fred --- Please I have problems in the loans, I deleted the circulation history, please in what files should I make the changes ?. What change should I make in the database ?. I have version 16.11.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 08:09:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 06:09:08 +0000 Subject: [Koha-bugs] [Bug 18391] Error: You do not have permission to access this page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18391 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 08:25:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 06:25:43 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #101 from Marcel de Rooy --- (In reply to Jacek Ablewicz from comment #100) > I have tested a bit earlier version of this patchset (from a ~week ago - not > exactly following the test plans, but focusing on the possibly "scary stuff" > which was not directly covered by the tests instead), and by a look of it > there is no need to fully retest it again. I reviewed all the changes in the > code once more (well, except for the *.t files, to be honest), and they all > look pretty solid to me - the only issue encountered in the previous try got > fixed in the meanwhile. Sign off time ;). Thanks again Jacek. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 08:27:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 06:27:12 +0000 Subject: [Koha-bugs] [Bug 7654] Add location at opac subscription view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18388 Status|Needs Signoff |Patch doesn't apply --- Comment #24 from Marc V?ron --- Merge conflict in opac-detail.tt BTW: Bug 18388 - Standardize serials volume information displaying will touch the same file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 08:27:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 06:27:12 +0000 Subject: [Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7654 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 08:48:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 06:48:15 +0000 Subject: [Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Tested, will sign off. Alex, next time please do not forget adding a test plan, even if it is a trivial patch. It makes testing and sign offs easier :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 08:48:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 06:48:35 +0000 Subject: [Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61906|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 61933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61933&action=edit Bug 18388 - Standardize serials volume information displaying OPAC: Home > Details for (serial) Compared information in tab 'Holdings' col 'Vol info' with same information in staff client. With patch it's the same. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 08:49:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 06:49:02 +0000 Subject: [Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 08:53:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 06:53:39 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:18:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 07:18:22 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sent notices using several |Send notices using several |email addresses |email addresses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:21:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 07:21:04 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim and order notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #35 from Marc V?ron --- (In reply to Jonathan Druart from comment #34) > A test fails: > prove t/db_dependent/Letters.t > t/db_dependent/Letters.t .. 1/80 Can't call method "branchemail" on an > undefined value at /home/vagrant/kohaclone/C4/Letters.pm line 576. > > userenv is not set in tests. Should that go to a new Bug report? - Just stumbled over while testing Bug 12802 - Send notices using several email addresses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:48:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 07:48:10 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim and order notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #36 from Marcel de Rooy --- (In reply to Marc V?ron from comment #35) > (In reply to Jonathan Druart from comment #34) > > A test fails: > > prove t/db_dependent/Letters.t > > t/db_dependent/Letters.t .. 1/80 Can't call method "branchemail" on an > > undefined value at /home/vagrant/kohaclone/C4/Letters.pm line 576. > > > > userenv is not set in tests. > > Should that go to a new Bug report? - Just stumbled over while testing Bug > 12802 - Send notices using several email addresses Yes, I will put it on a new report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 10:04:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 08:04:12 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #21 from Marc V?ron --- (In reply to Srdjan Jankovic from comment #20) > Things have moved on meanwhile, and it seems to me that the page is being > force reloaded now, so I'm not sure how useful this patch is. Maybe just a > start of a full ajax solution. Srdjan, do I get it right: No sign-off needed at the moment? Can status be switched e.g. to "In Discussion"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 10:13:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 08:13:46 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #23 from Julian Maurice --- Created attachment 61934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61934&action=edit Bug 15395: Exclude xslt from the list of themes when building locale_data.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 10:13:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 08:13:50 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #24 from Julian Maurice --- Created attachment 61935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61935&action=edit Bug 15395: Fix PO header reading in po2json Since version 0.24 Locale::PO do not escape newline characters in string returned by dequote() This patch set the required version of Locale::PO to 0.24 and fix po2json https://rt.cpan.org/Public/Bug/Display.html?id=96016 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 10:15:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 08:15:22 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #25 from Julian Maurice --- (In reply to Marc V?ron from comment #22) > NO PLURAL FORM HEADER FOUND - DEFAULTING TO 2 This was caused by an incompatibility between po2json and the newer version of Locale::PO. This is fixed in the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 11:19:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 09:19:41 +0000 Subject: [Koha-bugs] [Bug 18384] Add syspref to show all subs attached to a biblio in serial collection by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18384 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 11:19:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 09:19:43 +0000 Subject: [Koha-bugs] [Bug 18384] Add syspref to show all subs attached to a biblio in serial collection by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18384 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61860|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 61936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61936&action=edit Bug 18384: ShowAllAttachedSubsSerialCollection syspref To test: 1) Apply patch and update database 2) Find ShowAllAttachedSubsSerialCollection syspref, confirm it is set to "Don't" 3) Go to Serials, find a serial with more than one subscription 4) Click Serial Collection, confirm you are taken to the subscription summary for that one subscription 5) Set syspref to 'Always' 6) Go back to serials and find that same serial 7) Click Serial Collection, confirm you can see the subscription summaries of all attached subs straight away. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 11:29:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 09:29:42 +0000 Subject: [Koha-bugs] [Bug 5276] subscription end date shouldn't be required / allow indefinite subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5276 --- Comment #1 from Katrin Fischer --- +1 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 11:29:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 09:29:50 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #26 from Marc V?ron --- Hi Julian, I can not yet make it work. I think I missed something perl translate install fr-FR Use of uninitialized value $pref_name in concatenation (.) or string at LangInstaller.pm line 202. Use of uninitialized value $pref_name in concatenation (.) or string at LangInstaller.pm line 244. SKIPPING ERROR MARKER IN HEADER: #-#-#-#-# Koha-perl.pot (PACKAGE VERSION) #-#-#-#-# SKIPPING ERROR MARKER IN HEADER: #-#-#-#-# Koha-js.pot (PACKAGE VERSION) #-#-#-#-# Vales are not replaced in .tt file: [% SEARCH_RESULT.items_count %] [% tn('item', 'items', SEARCH_RESULT.items_count) %](...) I would expect: [% SEARCH_RESULT.items_count %] [% tn('exemplaire', 'exemplaires', SEARCH_RESULT.items_count) %](...) This is the .po file after editing Plural forms: ------------ # FIRST AUTHOR , YEAR. # #, fuzzy msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2017-04-06 10:52+0200\n" "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" "Last-Translator: FULL NAME \n" "Language-Team: LANGUAGE \n" "Language: \n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" "#-#-#-#-# Koha-perl.pot (PACKAGE VERSION) #-#-#-#-#\n" "Plural-Forms: nplurals=2; plural=(n > 1);\n" "#-#-#-#-# Koha-js.pot (PACKAGE VERSION) #-#-#-#-#\n" #: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:1 msgid "item" msgid_plural "items" msgstr[0] "exemplaire" msgstr[1] "exemplaires" --------------- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 11:42:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 09:42:02 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #27 from Julian Maurice --- (In reply to Marc V?ron from comment #26) > Hi Julian, I can not yet make it work. I think I missed something > > perl translate install fr-FR > Use of uninitialized value $pref_name in concatenation (.) or string at > LangInstaller.pm line 202. > Use of uninitialized value $pref_name in concatenation (.) or string at > LangInstaller.pm line 244. > SKIPPING ERROR MARKER IN HEADER: #-#-#-#-# Koha-perl.pot (PACKAGE VERSION) > #-#-#-#-# > SKIPPING ERROR MARKER IN HEADER: #-#-#-#-# Koha-js.pot (PACKAGE VERSION) > #-#-#-#-# I also have these messages, but they are only warnings, we can fix them later > > Vales are not replaced in .tt file: > [% SEARCH_RESULT.items_count %] [% tn('item', 'items', > SEARCH_RESULT.items_count) %](...) > I would expect: > [% SEARCH_RESULT.items_count %] [% tn('exemplaire', 'exemplaires', > SEARCH_RESULT.items_count) %](...) > This result is expected. Messages are not translated directly in template files, but tn() will return the correct translation at runtime. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 12:33:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 10:33:35 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #91 from Marc V?ron --- Test plan step 4): AllowIssueNotes should read AllowCheckoutNotes ------ Test plan step 7): Enter "Buchr?cken ist besch?digt", click "Submit changes", field shows: "Buchr?cken ist besch?digt". Same with ??? etc. Same in message "...has been saved and sent to the library." Text seems to be OK in database (select note from issues;) If I reload the page, text displays correctly. ------ Test plan step 17: If I return an item with a hold placed on it, the note does not show. I see only the message about confirming hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:09:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 12:09:50 +0000 Subject: [Koha-bugs] [Bug 18172] Logged in user page shows internal server error if OverDriveCirculation is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Marc V?ron --- Sorry, patch does not apply (merge conflict in opac-user.tt). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:20:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 13:20:13 +0000 Subject: [Koha-bugs] [Bug 18377] Add Plack/PSGI file for dev install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 16:07:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 14:07:57 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 16:07:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 14:07:57 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |11944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 [Bug 11944] Cleanup Koha UTF-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 16:08:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 14:08:10 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11944 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 [Bug 11944] Cleanup Koha UTF-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 16:08:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 14:08:10 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18336 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:05:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:05:47 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #3 from Marc V?ron --- Found a minor issue while testing: If you have text in the note field for 'All libraries' + 'All item types', the text 'sticks' in the input field. This is due to setting the value in smart-rules.tt line 384: Works well if I change the line to: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:25:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:25:32 +0000 Subject: [Koha-bugs] [Bug 18394] New: Add an option to item search to export a barcodes file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Bug ID: 18394 Summary: Add an option to item search to export a barcodes file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Searching Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:26:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:26:17 +0000 Subject: [Koha-bugs] [Bug 18395] New: Wrong article request methods in Koha::Patrons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Bug ID: 18395 Summary: Wrong article request methods in Koha::Patrons Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org There is something very wrong with the new subroutines, they have been added to both Koha::Patron and Koha::Patrons: % git grep 'sub article_request' Koha/Patron*.pm Koha/Patron.pm:sub article_requests { Koha/Patron.pm:sub article_requests_current { Koha/Patron.pm:sub article_requests_finished { Koha/Patrons.pm:sub article_requests { Koha/Patrons.pm:sub article_requests_current { Koha/Patrons.pm:sub article_requests_finished { The ones in Koha::Patrons are wrong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:26:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:26:32 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18395 --- Comment #265 from Jonathan Druart --- There is something very wrong with the new subroutines, they have been added to both Koha::Patron and Koha::Patrons: % git grep 'sub article_request' Koha/Patron*.pm Koha/Patron.pm:sub article_requests { Koha/Patron.pm:sub article_requests_current { Koha/Patron.pm:sub article_requests_finished { Koha/Patrons.pm:sub article_requests { Koha/Patrons.pm:sub article_requests_current { Koha/Patrons.pm:sub article_requests_finished { See bug 18395. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 [Bug 18395] Wrong article request methods in Koha::Patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:26:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:26:32 +0000 Subject: [Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 [Bug 14610] Add ability to place article requests in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:26:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:26:51 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 --- Comment #1 from Julian Maurice --- Created attachment 61937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61937&action=edit Bug 18394: Remove useless code from item search The item search was originally designed to work even with JS disabled. Since bug 15111, the staff interface does not work at all without JS, so some parts of this code are useless and should be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:26:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:26:55 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 --- Comment #2 from Julian Maurice --- Created attachment 61938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61938&action=edit Bug 18394: Add an option to item search to export a barcodes file Test plan: 1. Go to item search (/cgi-bin/koha/catalogue/itemsearch.pl) 2. Fill the form with whatever you want 3. Leave the 'Output' option to 'Screen' and click 'Search' 4. Verify that the search still works 5. Click on 'Edit search' and set 'Output' to 'Barcodes file', click 'Search' 6. You should be able to download a 'barcodes.txt' file, open it and compare it to the previous search results 7. Now click on the 'Export results to barcodes file' button above the results, you should have the same result as in step 5 8. Verify that the CSV export still works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:27:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:27:13 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:29:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:29:23 +0000 Subject: [Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:29:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:29:27 +0000 Subject: [Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 --- Comment #1 from Jonathan Druart --- Created attachment 61939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61939&action=edit Bug 18395: (bug 14601 followup) Remove article requests methods from Koha::Patrons There is something very wrong with the new subroutines, they have been added to both Koha::Patron and Koha::Patrons: % git grep 'sub article_request' Koha/Patron*.pm Koha/Patron.pm:sub article_requests { Koha/Patron.pm:sub article_requests_current { Koha/Patron.pm:sub article_requests_finished { Koha/Patrons.pm:sub article_requests { Koha/Patrons.pm:sub article_requests_current { Koha/Patrons.pm:sub article_requests_finished { The ones in Koha::Patrons are wrong Test plan: prove t/db_dependent/ArticleRequests.t should still return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:36:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:36:55 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:36:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:36:59 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60658|0 |1 is obsolete| | --- Comment #53 from Nick Clemens --- Created attachment 61940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61940&action=edit Bug 14576 - Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:37:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:37:08 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60659|0 |1 is obsolete| | --- Comment #54 from Nick Clemens --- Created attachment 61941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61941&action=edit Bug 14576 - Unit tests Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:37:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:37:31 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60660|0 |1 is obsolete| | --- Comment #55 from Nick Clemens --- Created attachment 61942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61942&action=edit Bug 14576 - (QA followup) Fix message for use of value not in authorized values Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:37:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:37:38 +0000 Subject: [Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61939|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 61943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61943&action=edit Bug 18395: (bug 14601 followup) Remove article requests methods from Koha::Patrons There is something very wrong with the new subroutines, they have been added to both Koha::Patron and Koha::Patrons: % git grep 'sub article_request' Koha/Patron*.pm Koha/Patron.pm:sub article_requests { Koha/Patron.pm:sub article_requests_current { Koha/Patron.pm:sub article_requests_finished { Koha/Patrons.pm:sub article_requests { Koha/Patrons.pm:sub article_requests_current { Koha/Patrons.pm:sub article_requests_finished { The ones in Koha::Patrons are wrong Test plan: prove t/db_dependent/ArticleRequests.t should still return green Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:37:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:37:39 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60661|0 |1 is obsolete| | --- Comment #56 from Nick Clemens --- Created attachment 61944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61944&action=edit Bug 14576 (QA Folllowup) Address issues use mock for tests use a separate variable for yaml fix indentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:37:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:37:46 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60662|0 |1 is obsolete| | --- Comment #57 from Nick Clemens --- Created attachment 61945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61945&action=edit Bug 14576 - (QA Followup) Remove other instances of ReturnToShelvingCart/InprocessingToShelvingCart This patch eliminates ReturnToShelvingCart and InProcessingToShelvingCart, Deletes Returns.t (it only tested those two prefs and new tests are in issue.t) Remaining instances found by: git grep "ReturnToShelvingCart\|InProcessingToShelvingCart" | grep -v translator | wc -l are db update files and release notes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:37:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:37:53 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60663|0 |1 is obsolete| | --- Comment #58 from Nick Clemens --- Created attachment 61946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61946&action=edit Bug 14576 (QA Followup) Fix undelcared use of $item Move strings from js files Delete duplicated lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:37:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:37:58 +0000 Subject: [Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:38:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:38:01 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60747|0 |1 is obsolete| | --- Comment #59 from Nick Clemens --- Created attachment 61947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61947&action=edit Bug 14576 (QA Followup) Remove C4:::Items::ShelfToCart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:38:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:38:08 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60748|0 |1 is obsolete| | --- Comment #60 from Nick Clemens --- Created attachment 61948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61948&action=edit Bug 14576 (QA Followup) Fix issue.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:38:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:38:14 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60751|0 |1 is obsolete| | --- Comment #61 from Nick Clemens --- Created attachment 61949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61949&action=edit Bug 14576 - (QA Followup) Fix Returns.t Two warnings, not one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:38:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 15:38:21 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #62 from Nick Clemens --- Created attachment 61950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61950&action=edit Bug 14576 (QA Followup) Fix warnings in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:24:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 18:24:39 +0000 Subject: [Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:24:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 18:24:42 +0000 Subject: [Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56275|0 |1 is obsolete| | Attachment #61173|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 61951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61951&action=edit Bug 16187 - Add a script to cancel unfilled holds after a specified number of days This script takes parameters: days - how many days waiting to concal an unfilled hold on or after library - (repeatable) branches to consider holidays - whether or not to count holidays (default is no) This patchset adds two methods and covers them with tests: Koha::Holds->unfilled(); To return holds where found = undef Koha::Hold->age( $use_calendar ); To return the number of days since a hold was placed (including or excluding holidays) To test: 1 - Place some holds with varying reservedates 2 - Run script with different parameters to verify options are respected (-v for verbosity will assist here) 3 - verify that script does nothing without days parameter Sponsored by: Siskiyou County Library (http://www.siskiyoulibrary.info/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:55:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 18:55:28 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61806|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 61952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61952&action=edit Bug 18374 - QueryAutoTruncate unit tests To test: 1 - Apply just this patch - should fail 2 - Apply the second patch - should pass https://bugs.koha-community.org/show_bug.cgi?id=18347 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:55:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 18:55:33 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 --- Comment #4 from Nick Clemens --- Created attachment 61953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61953&action=edit Bug 18374 - Respect QueryAutoTruncate syspref in Elasticsearch This patchset adds a subroutine '_truncate_terms' to the ES QueryParser. If QueryAutoTruncate is enabled this function will be called for any search to add wildcard '*' to all terms To test: 1 - Enable Elasticsearch and have some records indexed 2 - Search for partial terms 3 - Note they fail unless '*' is appended 4 - Apply patch, leave QueryAutoTruncate disabled 5 - Note partial term searches still fail 6 - Enable QueryAutoTruncate 7 - Note partial term searches succeed 8 - Do some regular and advanced searches to make sure results are as expected https://bugs.koha-community.org/show_bug.cgi?id=18347 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 21:45:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 19:45:26 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61952|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 61954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61954&action=edit Bug 18374 - QueryAutoTruncate unit tests To test: 1 - Apply just this patch - should fail 2 - Apply the other patch - should pass https://bugs.koha-community.org/show_bug.cgi?id=18347 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 21:45:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 19:45:46 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61953|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 61955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61955&action=edit Bug 18374 - Respect QueryAutoTruncate syspref in Elasticsearch This patchset adds a subroutine '_truncate_terms' to the ES QueryParser. If QueryAutoTruncate is enabled this function will be called for any search to add wildcard '*' to all terms To test: 1 - Enable Elasticsearch and have some records indexed 2 - Search for partial terms 3 - Note they fail unless '*' is appended 4 - Apply patch, leave QueryAutoTruncate disabled 5 - Note partial term searches still fail 6 - Enable QueryAutoTruncate 7 - Note partial term searches succeed 8 - Do some regular and advanced searches to make sure results are as expected https://bugs.koha-community.org/show_bug.cgi?id=18347 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 00:56:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 22:56:47 +0000 Subject: [Koha-bugs] [Bug 18396] New: UK format dates not sorting correctly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18396 Bug ID: 18396 Summary: UK format dates not sorting correctly Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 61956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61956&action=edit Screenshot showing UK date sorting problem When you view a user with a large number of checkouts, and you sort the checkouts by date issued, if the system uses UK date format (DD/MM/YYYY) the sorting doesn't working correctly - for example, you might see: 02/02/2017 03/03/2017 08/02/2017 10/01/2017 16/12/2016 instead of the correct order, which would be: 16/12/2016 10/01/2017 02/02/2017 08/02/2017 03/03/2017 See attached screenshot for a real example. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 01:51:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2017 23:51:06 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #22 from Srdjan Jankovic --- Ideally someone should try to replicate the original report in the top note. I could not. But in discussion is fine with me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 08:15:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 06:15:36 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #60 from Marcel de Rooy --- perl t/db_dependent/Holds/CancelReserves.t 1..5 ok 1 - use C4::Reserves; ok 2 - Reserve 1 should not be canceled. not ok 3 - Reserve 2 should be canceled. # Failed test 'Reserve 2 should be canceled.' # at t/db_dependent/Holds/CancelReserves.t line 66. # got: 'Koha::Hold=HASH(0x905fce8)' # expected: undef ok 4 - Reserve 3 should not be canceled. not ok 5 - Reserve 3 should be canceled. # Failed test 'Reserve 3 should be canceled.' # at t/db_dependent/Holds/CancelReserves.t line 101. # got: 'Koha::Hold=HASH(0x8f502b8)' # expected: undef # Looks like you failed 2 tests of 5. bug_12063-define_expirationdate_for_waitting_reserves.perl Please adjust conform skeleton file in this same directory (DBVersion test, SetVersion and print) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 08:19:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 06:19:44 +0000 Subject: [Koha-bugs] [Bug 18274] C4::Items - Remove GetItemStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 08:19:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 06:19:48 +0000 Subject: [Koha-bugs] [Bug 18274] C4::Items - Remove GetItemStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61116|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 61957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61957&action=edit Bug 18274: C4::Items - Remove GetItemStatus This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Test plan: git grep GetItemStatus should not return any used calls (only 1 occurrence in release notes) Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 08:19:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 06:19:59 +0000 Subject: [Koha-bugs] [Bug 18274] C4::Items - Remove GetItemStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 08:22:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 06:22:22 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #5 from Marcel de Rooy --- With and without 18274 I get: Applying: Bug 18278: C4::Items - Remove GetItemLocation fatal: sha1 information is lacking or useless (C4/Items.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 08:30:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 06:30:57 +0000 Subject: [Koha-bugs] [Bug 18121] Rename opac_news.new with opac_news.content - replace notice template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18121 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 08:31:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 06:31:01 +0000 Subject: [Koha-bugs] [Bug 18121] Rename opac_news.new with opac_news.content - replace notice template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18121 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61350|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 61958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61958&action=edit Bug 18121: Replace opac_news.new with opac_news.content in notices templates Bug 17960 replaces opac_news.new with opac_news.content, we can replace the content of the notices' templates automatically. Test plan: Checkout a commit prior to bug 17960. Install a new DB with sample data. You should have notices with <> Switch to a branch with this patch, on top of master Execute the updatedatabase.pl sript => The notices with opac_news.new should have been replaced with opac_news.content Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 08:31:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 06:31:43 +0000 Subject: [Koha-bugs] [Bug 18121] Rename opac_news.new with opac_news.content - replace notice template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18121 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 08:37:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 06:37:17 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 09:12:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 07:12:52 +0000 Subject: [Koha-bugs] [Bug 18397] New: Sent notices for...: Display email address ( including which field it's taken from) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18397 Bug ID: 18397 Summary: Sent notices for...: Display email address (including which field it's taken from) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Display in Home > Patrons > Sent notices for... the email address and the field where it is taken from. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 09:13:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 07:13:14 +0000 Subject: [Koha-bugs] [Bug 18397] Sent notices for...: Display email address ( including which field it's taken from) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18397 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 [Bug 12802] Send notices using several email addresses -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 09:13:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 07:13:14 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18397 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18397 [Bug 18397] Sent notices for...: Display email address (including which field it's taken from) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 09:38:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 07:38:09 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #20 from Marcel de Rooy --- Taking the liberty to pass QA on this one now. Retested. QA tools do not complain. Tests pass. Looks still good to me, no need to wait any longer. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 09:46:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 07:46:18 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #21 from Martin Renvoize --- This also gets the thumbs up from me, it was in my queue to properly QA but I'd been pulled into other things part way through. As Marcel says, it passes all the tests and the code looks good to me. As far through my manual checks and testing it had all passed with flying colours too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 10:15:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 08:15:04 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Chris changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ksadek36 at gmail.com --- Comment #9 from Chris --- I like the idea of storing history with timestamp and author. But storing whole record seems like overkill to me. Especially for huge libraries. So instead of whole history, just a "delta" of data changed (somewhat git does) and as mentioned - not JSON but TABLE. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 10:26:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 08:26:59 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #22 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #21) > This also gets the thumbs up from me, it was in my queue to properly QA but > I'd been pulled into other things part way through. As Marcel says, it > passes all the tests and the code looks good to me. As far through my manual > checks and testing it had all passed with flying colours too. Thanks, Martin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 10:48:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 08:48:55 +0000 Subject: [Koha-bugs] [Bug 18396] UK format dates not sorting correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18396 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 10:53:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 08:53:19 +0000 Subject: [Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:04:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:04:14 +0000 Subject: [Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 --- Comment #3 from Marcel de Rooy --- Created attachment 61960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61960&action=edit Bug 18395: (bug 14610 followup) Remove article requests methods from Koha::Patrons There is something very wrong with the new subroutines, they have been added to both Koha::Patron and Koha::Patrons: % git grep 'sub article_request' Koha/Patron*.pm Koha/Patron.pm:sub article_requests { Koha/Patron.pm:sub article_requests_current { Koha/Patron.pm:sub article_requests_finished { Koha/Patrons.pm:sub article_requests { Koha/Patrons.pm:sub article_requests_current { Koha/Patrons.pm:sub article_requests_finished { The ones in Koha::Patrons are wrong Test plan: prove t/db_dependent/ArticleRequests.t should still return green Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:04:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:04:48 +0000 Subject: [Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:04:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:04:49 +0000 Subject: [Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:05:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:05:13 +0000 Subject: [Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:18:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:18:02 +0000 Subject: [Koha-bugs] [Bug 14537] The system preference 'OverdueNoticeBcc' is mis-named. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61872|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 61961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61961&action=edit Bug 14537: Renaming OverdueNoticeBcc to NoticeBcc To test: 1) Apply patch and update database 2) Run 'git grep "OverdueNoticeBcc"' and confirm there are no other instances Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:17:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:17:59 +0000 Subject: [Koha-bugs] [Bug 14537] The system preference 'OverdueNoticeBcc' is mis-named. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:18:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:18:07 +0000 Subject: [Koha-bugs] [Bug 14537] The system preference 'OverdueNoticeBcc' is mis-named. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 --- Comment #4 from Marcel de Rooy --- Created attachment 61962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61962&action=edit Bug 14537: [QA Follow-up] Remove one overdues residue in pref description Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:18:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:18:22 +0000 Subject: [Koha-bugs] [Bug 14537] The system preference 'OverdueNoticeBcc' is mis-named. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:23:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:23:37 +0000 Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #12 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #7) > Test plan: > Make sure this change does not introduce regressions on bug 15581 and bug > 16344. Test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:31:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:31:39 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl --- Comment #32 from Marcel de Rooy --- Just a suggestion: If you rebase this one next Thursday, I will resume next Friday here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:32:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:32:56 +0000 Subject: [Koha-bugs] [Bug 18397] Sent notices for...: Display email addresses (sender / recipient) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18397 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Text to go in the| |Add email addresses (sender release notes| |/ Recipient) to table with | |notices sent to a patron. Summary|Sent notices for...: |Sent notices for...: |Display email address |Display email addresses |(including which field it's |(sender / recipient) |taken from) | --- Comment #1 from Marc V?ron --- Changed title. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:37:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:37:36 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #18 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #17) > If we merge these two permissions, we are limiting the possibilities. Will still answer more fully, but the foregoing comments already explain why this is done. Do you have a specific objection? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:41:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:41:14 +0000 Subject: [Koha-bugs] [Bug 18397] Sent notices for...: Display email addresses (sender / recipient) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18397 --- Comment #2 from Marc V?ron --- Created attachment 61963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61963&action=edit Bug 18397 - Sent notices for...: Display email addresses (sender / recipient) This patch adds the colums Sender and Recipient to the table of sent notices in Home > Patrons > Sent notices for... Related to Bug 18397 - Sent notices for...: Display email addresses (sender / recipient) To test: - Appply patch - Go to a patron's page for sent notices (members/notices.pl) - Verify that two new columns display sender and recipient - Use this patch to test 18397 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:58:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:58:47 +0000 Subject: [Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60815|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 61964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61964&action=edit Bug 18208: Add RecordProcessor filter to inject not onloan count to MARC records This patch adds a new filter for MARC records to be used with Koha::RecordProcessor. It's purpose is to inject the information about items not-onloan in a fixed subfield, 999$x. To test: - Apply the patch - Run: $ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions Followed test plan, test passes OK Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:58:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:58:52 +0000 Subject: [Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 --- Comment #6 from Marcel de Rooy --- Created attachment 61965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61965&action=edit Bug 18208: [QA Follow-up] Get count from Koha::Items Removes the loop by moving the onloan test to the query. Test plan: Run the test again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:59:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 09:59:12 +0000 Subject: [Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:00:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 10:00:51 +0000 Subject: [Koha-bugs] [Bug 18208] Add RecordProcessor filter to inject not onloan count to MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18208 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:04:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 10:04:03 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 --- Comment #14 from Koha Team Lyon 3 --- Hello, can you provide a test plan ? I would say that this patch complete the default biblio and authorities framework without overwrite it. To test, verify those frameworks and check if all the new field, subfield and authorized values are there. (https://www.ifla.org/publications/unimarc-authorities-3rd-edition-updates-2012?og=33) Is it right ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:07:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 10:07:49 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61695|0 |1 is obsolete| | --- Comment #33 from Lari Taskula --- Created attachment 61966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61966&action=edit Bug 17835: Create a ItemtypeLocalization view To properly move C4::Koha::GetItemTypes to Koha::ItemTypes we need DBIx::Class to make a join on the localization table to retrieve the possible translated description of the item types. To do so there are 2 possibilities. The first one would have been to rename the localization table to something like itemtype_localization. That way we could have had a relationship between itemtype_localization.code and itemtypes.itemtype That would have meant to create one table per "entity" (here an entity is itemtype) we allow the translability. There are pros and cons for this choice, so I opt for another solution. The other solution is to create a view on top of this localization table. With this new view we can define the missing relationship. That sounds like a quite clean solution and easy to implement. Once we have this relationship, the Koha::ItemTypes->search_with_localization will join on this view an return the same result as GetItemTypes( style => 'array' ). To replace GetItemtypes( style => 'hash' ) which is the default behavior of this subroutine, we can do something like: my $itemtypes = Koha::ItemTypes->search_with_localization; my %itemtypes = map { $_->{itemtype} => $_ } @{ $itemtypes->unblessed }; This patchset must not introduce big changes but it changes certain behaviors (which were wrong) in some scripts. Indeed sometimes the descriptions of the item types were not the translated ones. Moreover it happens that the item types displayed in a dropdown list were not ordered by translated description, but by description of code (itemtypes.itemtype value). These 2 behaviors are what we expect. Test plan: Bugs will be hard to catch since these patches change a lot of file, it will be easier to read the diff and catch possible typos or logic errors. However signoffers can focus on modified files and the item types values. Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:08:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 10:08:10 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61696|0 |1 is obsolete| | --- Comment #34 from Lari Taskula --- Created attachment 61967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61967&action=edit Bug 17835: Do not reselect translated_description if comes from search_with_localization If the Koha::ItemType object has been instanciated from a call to Koha::ItemTypes->search_with_localization, we already have the translated_description value. So there is no need to fetch it again from the DB. This is what this trick does: if the translated_description column exist in the DBIx::Class result source's column list, that means the value has already been retrieved. Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:08:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 10:08:30 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61697|0 |1 is obsolete| | --- Comment #35 from Lari Taskula --- Created attachment 61968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61968&action=edit Bug 17835: Replace GetItemTypes with Koha::ItemTypes Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:08:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 10:08:42 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61698|0 |1 is obsolete| | --- Comment #36 from Lari Taskula --- Created attachment 61969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61969&action=edit Bug 17835: Remove the subroutine GetItemTypes At this point the subroutine is no longer in used. Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:08:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 10:08:53 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61699|0 |1 is obsolete| | --- Comment #37 from Lari Taskula --- Created attachment 61970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61970&action=edit Bug 17835: Add an additional LEFT JOIN condition using DBIx::Class The previous query was wrong. If an item type did not contain the translation in the interface's language, the ->search_with_localization did not return it at all. What we need is definitely to add a second condition on the join. For reference: http://search.cpan.org/dist/DBIx-Class/lib/DBIx/Class/Relationship/Base.pm#condition https://blog.afoolishmanifesto.com/posts/dbix-class-parameterized-relationships/ That sounds hacky but seems to be the DBIx::Class path to follow. Bug 17835: follow-up Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:26:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 10:26:23 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula at jns.fi Status|Patch doesn't apply |Signed Off --- Comment #38 from Lari Taskula --- Rebased on top of master (fixed 3 "use" conflicts, 1 per file in catalogue/detail.pl, opac/opac-detail.pl, opac/opac-user.pl). Switching back to Signed Off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:27:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 10:27:30 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61700|0 |1 is obsolete| | --- Comment #39 from Lari Taskula --- Created attachment 61971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61971&action=edit Bug 17835: Mock language pref value That way if prefs contain other languages, the test will still pass. Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:53:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 10:53:58 +0000 Subject: [Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 --- Comment #3 from Lari Taskula --- Created attachment 61972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61972&action=edit Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes The C4::Koha::getitemtypeinfo subroutine did the almost same job as GetItemTypes. On top of that it returned the imageurl value processed by C4::Koha::getitemtypeimagelocation. This value is only used from the 2 [opac-]shelves.pl scripts. Then it's better not retrieve it only when we need it. Test plan: Play with the different scripts touched by this patch and focus on item types. The same description as prior to this patch must be displayed. Note that sometimes it is not the translated description which is displayed, but that should be fixed on another bug report. Indeed we do not expect this patch to change any behaviors. Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:54:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 10:54:12 +0000 Subject: [Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58584|0 |1 is obsolete| | --- Comment #4 from Lari Taskula --- Created attachment 61973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61973&action=edit Bug 17843: Remove C4::Koha::getitemtypeinfo At this point there should not be any calls to this subroutine. Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:54:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 10:54:30 +0000 Subject: [Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula at jns.fi Attachment #58583|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:54:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 10:54:40 +0000 Subject: [Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:56:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 10:56:41 +0000 Subject: [Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 --- Comment #5 from Lari Taskula --- Rebased on top of master, fixed a minor conflict and typo in patch title. Tested scripts touched by first patch. Switching to Signed Off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:14:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 11:14:42 +0000 Subject: [Koha-bugs] [Bug 18397] Sent notices for...: Display email addresses (sender / recipient) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18397 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61963|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Comment on attachment 61963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61963 Bug 18397 - Sent notices for...: Display email addresses (sender / recipient) Does not work on top of 12802 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:22:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 11:22:36 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #63 from Marc V?ron --- With patch applied, I run into an endless loop filling plack error log: Global symbol "$to_address" requires explicit package name at /home/marc/koha/C4/Letters.pm line 1356. prove t/Letters.t t/Letters.t .. 2/6 # Failed test 'use C4::Letters;' # at t/Letters.t line 52. # Tried to use 'C4::Letters'. # Error: Global symbol "$to_address" requires explicit package name at /home/marc/koha/C4/Letters.pm line 1356. # Compilation failed in require at t/Letters.t line 52. Seems to be similar to Comment #23 Am i missing something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:10:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 12:10:52 +0000 Subject: [Koha-bugs] [Bug 18369] Broken title link in UNIMARC catalog search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #3 from Paul Poulain --- I tried to reproduce this error, and couldn't. I'm running UNIMARC, default XSLT, and the links are working fine (master branch) There's probably another specific parameter to see the bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:20:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 12:20:26 +0000 Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #36 from Koha Team Lyon 3 --- Resolved by all the patchs dealing with GST in acquisitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:23:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 12:23:30 +0000 Subject: [Koha-bugs] [Bug 3069] Koha Z39.50 client process discussion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3069 --- Comment #10 from Owen Leonard --- Dave J, this issue sounds more like a support request than a bug report. Support requests can be made on the Koha mailing list, on IRC, or by contracting with a support vendor. All these options are linked to here: https://koha-community.org//support/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:29:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 12:29:15 +0000 Subject: [Koha-bugs] [Bug 14932] serials/ serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:29:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 12:29:18 +0000 Subject: [Koha-bugs] [Bug 14932] serials/ serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43007|0 |1 is obsolete| | --- Comment #2 from Paul Poulain --- Created attachment 61974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61974&action=edit Bug 14932 - serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! Currently we have subscriptions with 300+ serials received. It takes a lot of time to show serials-collection.pl (~20s). This is especially troublesome when receiving serials, since after receival we get redirected to that page. We no longer can receive daily serials in the allotted timeframe. This quick and dirty fix prevents checking the subscription editing for each serial, but instead checks it for the first serial only. This reduced page load time by ~18s TEST PLAN: 1. Receive ~300 serials (or just a bunch :) ) 2. Observe the gradual slowing of the receival action. AFTER THIS PATCH: 1. Receive ~300 serials more (or just a bunch) 2. Observe a significant performance improvement. Signed-off-by: Paul POULAIN -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:38:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 12:38:23 +0000 Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 --- Comment #37 from Katrin Fischer --- Yay! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:41:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 12:41:30 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:41:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 12:41:35 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61153|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 61975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61975&action=edit Bug 18278: C4::Items - Remove GetItemLocation This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Test plan: git grep GetItemLocation Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:41:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 12:41:58 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 --- Comment #7 from Jonathan Druart --- Applied ok for me, reattached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:51:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 12:51:06 +0000 Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413 --- Comment #13 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #12) > (In reply to Jonathan Druart from comment #7) > > Test plan: > > Make sure this change does not introduce regressions on bug 15581 and bug > > 16344. > > Test plan? Could you be more verbose please, I do not understand the question. Yes the test plan is to test that the patches from bugs 15581 and 16344 are still ok. At the moment of writing, none was pushed and so the goal was to test it on top of them and QA them at the same time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:08:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 13:08:13 +0000 Subject: [Koha-bugs] [Bug 18398] CHECKIN/CHECKOUT/RENEWAL don' t use AutoEmailPrimaryAddress but first valid e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12802 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:08:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 13:08:04 +0000 Subject: [Koha-bugs] [Bug 18398] New: CHECKIN/CHECKOUT/RENEWAL don' t use AutoEmailPrimaryAddress but first valid e-mail Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Bug ID: 18398 Summary: CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If the system preference AutoEmailPrimaryAddress is set to alternate or work this e-mail addresses should be used to send out all emails. This works for most notices, but sadly not for CHECKIN, CHECKOUT and RENEWAL notices. http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Message.pm;hb=7d35bdf58a0bcebab20df47b50b249cafe12ddb6#l178 sub _to_address is hardcoded to use the first e-mail field that is set in the patron record. It should follow the AutoEmailPrimaryAddress setting instead. Bug 12802 fixed it, but it's a new feature. Woudl still be good to fix this especially for stable releases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:08:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 13:08:13 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18398 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:12:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 13:12:55 +0000 Subject: [Koha-bugs] [Bug 18369] Broken title link in UNIMARC catalog search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 --- Comment #4 from Oleg Vasilenko --- This bug will reveal itself if record has empty 001, or 001 is not biblionumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:20:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 13:20:39 +0000 Subject: [Koha-bugs] [Bug 18399] New: Reason is missing in suggestion management part Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399 Bug ID: 18399 Summary: Reason is missing in suggestion management part Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org When we want to deal a suggestion by editing it (suggestion.pl?suggestionid=XX&op=edit), we can change the status but we can't add a reason. It's a pitty because changing the status would trigger the workflow and mail sending and in email we provide the reason if the suggestion is rejected... So patron will not have the reason if we change the status here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:39:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 13:39:33 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #64 from Jonathan Druart --- _update_message_to_address has been removed, please double check! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:46:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 13:46:26 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #19 from Jonathan Druart --- I'd like to get users' opinions before removing features. I have no idea if these permissions are used or not. I agree that it is not very clear, but we can still make the interface more easier to use/understand instead of remove features. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:56:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 13:56:09 +0000 Subject: [Koha-bugs] [Bug 18378] Author name cannot add In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18378 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |INVALID --- Comment #5 from Owen Leonard --- This issue sounds more like a support request than a bug report. Support requests can be made on the Koha mailing list, on IRC, or by contracting with a support vendor. All these options are linked to here: https://koha-community.org//support/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 16:01:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 14:01:21 +0000 Subject: [Koha-bugs] [Bug 18369] Broken title link in UNIMARC catalog search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 --- Comment #5 from Paul Poulain --- In my setup, the biblionumber is in 001, this explain that (can't sign-off this patch, but OTOH, won't failed QA it either ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 16:12:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 14:12:31 +0000 Subject: [Koha-bugs] [Bug 18391] Error: You do not have permission to access this page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18391 --- Comment #1 from Owen Leonard --- It looks like the login page knows (based on browser cookies?) when you have been previously logged in successfully. If I start with a clean session I get no message at all. If I log in, log out, and then return to "[domain]/index.html" I get "Error: Session timed out. Please log in again." However, I was not able to reproduce the permissions error you cite above. Tested using kohadevbox running master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 16:20:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 14:20:28 +0000 Subject: [Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #1 from Nick Clemens --- Looks like a 304 and others can trigger this as well -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 16:54:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 14:54:46 +0000 Subject: [Koha-bugs] [Bug 18396] UK format dates not sorting correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18396 --- Comment #1 from Owen Leonard --- My favorite method of avoiding date parsing nightmares when sorting is to use the "title-string" option for DataTables. \koha-tmpl\intranet-tmpl\prog\en\modules\admin\currency.tt: 30 "columnDefs": [ 31 { "aTargets": [ -1 ], "bSortable": false, "bSearchable": false }, 32: { "sType": "title-string", "aTargets" : [ "title-string" ] } 33 ], 34 }, columns_settings ); .. 208 Symbol 209 ISO code 210: Last updated 211 Active 212 Archived .. 223 [% currency.timestamp | $KohaDates %] I don't know if that solution would work with the checkouts table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 16:54:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 14:54:58 +0000 Subject: [Koha-bugs] [Bug 18396] UK format dates not sorting correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18396 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 18:30:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 16:30:03 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #65 from Marc V?ron --- (In reply to Jonathan Druart from comment #64) > _update_message_to_address has been removed, please double check! With patches applied: $ git grep '_update_message_to_address' C4/Letters.pm: _update_message_to_address( $message_id, undef ) if $rv && C4/Letters.pm: _update_message_to_address($message->{'message_id'},$to_address) unless $message->{to_address}; #if initial message address was empty, coming here means that a to address was found and queue should be updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 18:51:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 16:51:08 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #66 from Jonathan Druart --- Yes Marc, I was talking to the assignee. Switching the status accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 18:51:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 16:51:42 +0000 Subject: [Koha-bugs] [Bug 18400] New: Noisy warns in opac-search.pl during itemtype sorting Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 Bug ID: 18400 Summary: Noisy warns in opac-search.pl during itemtype sorting Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Cannot reliably recreate, but seeing in 3.22 - 16.11 when searching in opac we get lots of: opac-search.pl: Use of uninitialized value in string comparison (cmp) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl Tracing the error it seems $itemtype can be corrupted and has keys added like this (when dumped): $VAR1 = 'MICROFORM'; $VAR2 = '1VOLTREAT'; $VAR3 = 'HASH(0x954d948)'; $VAR4 = 'HASH(0x9083428)'; etc. This filled a disk on one of our servers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 18:53:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 16:53:11 +0000 Subject: [Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 --- Comment #1 from Nick Clemens --- Created attachment 61976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61976&action=edit Bug 18400 - Noisy warns in opac-search.pl during itemtype sorting To fix the warns we use a copy of itemtypes which is not touched by other code To test: Apply patches Ensure search still works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 18:53:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 16:53:08 +0000 Subject: [Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 18:56:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 16:56:16 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #28 from Julian Maurice --- Created attachment 61977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61977&action=edit Bug 15395: Fix output of msgcat By default, msgcat tries to merge translations when two or more files have the same msgid, even for the header (msgid ""). This resulted in an invalid PO file ("#-#-#-#-#" markers in header). This patch tells msgcat to use the first available translation instead. Also, this patch set correctly the Project-Id-Version field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:32:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 18:32:50 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- Step 5 and Step 7 don't work for me. I expect the browser to start the download of a text file, but the page reloads without any prompt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 21:13:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 19:13:52 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 21:19:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 19:19:11 +0000 Subject: [Koha-bugs] [Bug 14140] Reversed payments don't generate entry in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14140 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 21:39:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 19:39:31 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5216 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 21:39:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 19:39:31 +0000 Subject: [Koha-bugs] [Bug 5216] Returning lost material with Forgive Fines does not forgive overdue charges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5216 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15675 --- Comment #2 from Barton Chittenden --- The problem described by Ian Walls was impossible to fix prior to bug 15675 'Add issue_id column to accountlines and use it for updating fines'. I don't know off hand if that bug fixed this issue. If not, at least it's a tractable problem now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 21:44:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 19:44:58 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #31 from Marc V?ron --- Sorry, QA tools complain: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt FAIL tt_valid lines 368, 369, 370, 371, 372, 373 FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt FAIL tt_valid lines 151, 152, 153, 154, 155 Suppose it is because of: https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:00:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:00:16 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #1 from Christopher Brannon --- Created attachment 61978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61978&action=edit Bug 18355: Modifies location on detail pages. TEST PLAN 1) Make sure ReturnToShelvingCart is set to Move. 2) Check in an item. 3) View the item in detail.pl and opac-detail.pl and see that only the cart location shows. 4) Apply patch and view the item aga -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:01:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:01:04 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #46 from Agnes Rivers-Moore --- Hanover has started using Bywater's Coce server. :-) It did not work for us at first but is working this week. It certainly does provide a wider range of jacket images than Amazon, especially for older titles and non-book media. Considerations: 1) The first ever call for a particular jacket prompts the Coce server to search for it, but it is not returned to the Koha search until the page is refreshed or search done again or details page opened. That is easy for staff to work with but not so good on the OPAC where so many entries load with no images until Coce has retrieved them at least once. 2) Coce is only set up to work for OPAC, not staff interface. If we had the choice, two options the same as for Amazon jackets, to turn it on for either or both would be nice. Then staff could judge when Coce returns enough images to turn on for our users. We have decided to run with both Amazon and Coce for now, so that in time the image links we need will be generated. Two jacket images looks untidy but until the server has most of the links, two jackets sometimes is better than no jacket frequently. The more libraries use the server, the sooner it will be able to provide a comprehensive resource for jacket images. Thank you to everyone who worked on this and Bywater for providing the server service. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:05:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:05:59 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #2 from Christopher Brannon --- Sorry, the attach turned out wonky. TEST PLAN 1) Make sure ReturnToShelvingCart is set to Move. 2) Check in an item. 3) View the item in detail.pl and opac-detail.pl and see that only the cart location shows. 4) Apply patch and view the item again in check detail.pl and opac-detail.pl. You should now see the permanent location, and the cart location in parenthesis. 5) Check another item that was not checked in. You should see the permanent location and not a secondary location. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:11:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:11:08 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #3 from Christopher Brannon --- I'm not sure how to fix the subject in the attachment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:15:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:15:07 +0000 Subject: [Koha-bugs] [Bug 18401] New: Add the Koha::Checkout->patron method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18401 Bug ID: 18401 Summary: Add the Koha::Checkout->patron method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:15:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:15:23 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61978|Bug 18355: Modifies |Bug 18355: Modifies description|location on detail pages. |location on detail pages. |TEST PLAN 1) Make sure | |ReturnToShelvingCart is set | |to Move. 2) Check in an | |item. 3) View the item in | |detail.pl and | |opac-detail.pl and see that | |only the cart location | |shows. 4) Apply patch and | |view the item aga | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:15:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:15:55 +0000 Subject: [Koha-bugs] [Bug 18402] New: Add the Koha::Item->checkout method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 Bug ID: 18402 Summary: Add the Koha::Item->checkout method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:18:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:18:24 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:18:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:18:47 +0000 Subject: [Koha-bugs] [Bug 18401] Add the Koha::Checkout->patron method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18401 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:18:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:18:46 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |cbrannon at cdalibrary.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:18:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:18:52 +0000 Subject: [Koha-bugs] [Bug 18401] Add the Koha::Checkout->patron method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18401 --- Comment #1 from Jonathan Druart --- Created attachment 61979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61979&action=edit Bug 18401: Add new method Koha::Checkout->patron Return the patron related to a given checkout Test plan: prove t/db_dependent/Koha/Checkouts.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:21:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:21:17 +0000 Subject: [Koha-bugs] [Bug 18402] Add the Koha::Item->checkout method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:21:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:21:21 +0000 Subject: [Koha-bugs] [Bug 18402] Add the Koha::Item->checkout method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 --- Comment #1 from Jonathan Druart --- Created attachment 61980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61980&action=edit Bug 18402: Add the Koha::Item->checkout method Return the current checkout for a given item. Note it may not exist. Test plan: prove t/db_dependent/Koha/Items.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:21:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:21:28 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #4 from Christopher Brannon --- Never mind. I fixed it. :) I am only addressing the detail pages in the patch. I looked over the search results, and the item information is being pulled in differently, so I am not sure how to add the information there. It looks like it is being pulled in via marc records, which seems a little odd. Anyway, I consider this the extent of the patch. If there are other locations that would benefit from this added information, we can address it in another patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:28:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:28:49 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61978|0 |1 is obsolete| | --- Comment #5 from Christopher Brannon --- Created attachment 61981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61981&action=edit Attachment to Bug 18355 - Permanent location should show with cart location Bug 18355: Modifies location on detail pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:40:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2017 21:40:52 +0000 Subject: [Koha-bugs] [Bug 18403] New: Hide patron information if not part of the logged in user library group Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Bug ID: 18403 Summary: Hide patron information if not part of the logged in user library group Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: new feature Priority: P5 - low Component: Patrons Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Add the ability to hide patron record information from any other library (outside the group). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 05:16:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 03:16:49 +0000 Subject: [Koha-bugs] [Bug 18318] Unicode support for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18318 --- Comment #1 from Nick Clemens --- Created attachment 61982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61982&action=edit Bug 18318 - Unicode support for Elasticsearch You must install the icu plugin for elasticsearch https://www.elastic.co/guide/en/elasticsearch/plugins/current/analysis-icu.html Once installed, apply this patch Reindex your data, deleting the existing indexes perl /home/vagrant/kohaclone/misc/search_tools/rebuild_elastic_search.pl -d Find (or add) some titles with accented characters Verify that a search for the exact character or the unaccented version works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 05:44:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 03:44:37 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61955|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 61983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61983&action=edit Bug 18374 - Respect QueryAutoTruncate syspref in Elasticsearch This patchset adds a subroutine '_truncate_terms' to the ES QueryParser. If QueryAutoTruncate is enabled this function will be called for any search to add wildcard '*' to all terms To test: 1 - Enable Elasticsearch and have some records indexed 2 - Search for partial terms 3 - Note they fail unless '*' is appended 4 - Apply patch, leave QueryAutoTruncate disabled 5 - Note partial term searches still fail 6 - Enable QueryAutoTruncate 7 - Note partial term searches succeed 8 - Do some regular and advanced searches to make sure results are as expected https://bugs.koha-community.org/show_bug.cgi?id=18347 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 06:59:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 04:59:53 +0000 Subject: [Koha-bugs] [Bug 4440] Adding feature to print fines/fees receipts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4440 Litty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amalalib09 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 07:00:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 05:00:55 +0000 Subject: [Koha-bugs] [Bug 18404] New: Allow check in receipts through slip Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18404 Bug ID: 18404 Summary: Allow check in receipts through slip Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: amalalib09 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Allow check in receipts through slip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 07:03:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 05:03:18 +0000 Subject: [Koha-bugs] [Bug 18404] Allow check in receipts through slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18404 Litty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amalalib09 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 10:17:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 08:17:16 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #6 from Marc V?ron --- Created attachment 61984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61984&action=edit Bug 18355: Permanent location should show with cart location Followed test plan from Comment #2, tested on current Master, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 10:18:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 08:18:13 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #61981|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 10:19:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 08:19:00 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|3.22 |master --- Comment #7 from Marc V?ron --- Setting version to master (tested on master) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 10:22:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 08:22:24 +0000 Subject: [Koha-bugs] [Bug 18401] Add the Koha::Checkout->patron method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18401 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61979|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 61985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61985&action=edit Bug 18401: Add new method Koha::Checkout->patron Return the patron related to a given checkout Test plan: prove t/db_dependent/Koha/Checkouts.t should return green Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 10:23:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 08:23:21 +0000 Subject: [Koha-bugs] [Bug 18401] Add the Koha::Checkout->patron method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18401 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |veron at veron.ch Status|Needs Signoff |Signed Off --- Comment #3 from Marc V?ron --- Tested on master, setting Version from unspecified to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 10:23:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 08:23:37 +0000 Subject: [Koha-bugs] [Bug 18401] Add the Koha::Checkout->patron method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18401 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 10:26:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 08:26:44 +0000 Subject: [Koha-bugs] [Bug 18402] Add the Koha::Item->checkout method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Marc V?ron --- Wanted to test, can not apply fatal: sha1 information is lacking or useless (Koha/Item.pm) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 14:54:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 12:54:02 +0000 Subject: [Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61668|0 |1 is obsolete| | --- Comment #170 from Marc V?ron --- Created attachment 61986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61986&action=edit Bug 17855 - Reverted back to original step 3 in the web installer so there is no basic and advanced setup mode and consequently no need for SQL files to be moved to a 'default' directory for all languages. Onboarding tool and the rest of the web installer still exists in this commit How I tested in my VM (Current master): - Dropped database - Recreated database - Went through installer - Language en, Marc21 - Installed mandatory data only - Went through Onboarding tool - After finishing, logged in as superlibrarian that was created by onboarding tool Everything worked fine. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 14:59:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 12:59:18 +0000 Subject: [Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off --- Comment #171 from Marc V?ron --- Note: Signed off after test on current master. I did not test on top of 18039; this dependency seems not to be necessary. It would be fine to have some text in 'Text to go to the release notes'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 16:20:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 14:20:29 +0000 Subject: [Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC framework don' t work correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527 --- Comment #24 from M. Tompsett --- (In reply to Marcel de Rooy from comment #23) > (In reply to M. Tompsett from comment #22) > > And 'In Discussion' is a wasteland. > > Sometimes used as an euphemism (nice alias) for Failed QA ? Sometimes, yes. Which explains what the Failed QA (255) and In Discussion (219) queues are roughly the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 16:20:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 14:20:28 +0000 Subject: [Koha-bugs] [Bug 9251] Add option to print checkin and renewal quick slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9251 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 16:22:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 14:22:23 +0000 Subject: [Koha-bugs] [Bug 18404] Allow check in receipts through slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18404 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9251 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 16:22:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 14:22:23 +0000 Subject: [Koha-bugs] [Bug 9251] Add option to print checkin and renewal quick slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9251 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18404 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 16:23:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 14:23:34 +0000 Subject: [Koha-bugs] [Bug 18404] Allow check in receipts through slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18404 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12224 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 16:23:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 14:23:34 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18404 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 16:24:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 14:24:33 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9251 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 16:24:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 14:24:33 +0000 Subject: [Koha-bugs] [Bug 9251] Add option to print checkin and renewal quick slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9251 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12224 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:02:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 21:02:29 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #19 from Christopher Brannon --- vagrant at kohadevbox:kohaclone(bug_14385)$ git bz apply 14385 Bug 14385 - Extend OpacHiddenItems to allow specifying exempt borrower categories 53506 - Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories 53507 - Bug 14385 Followup: C4::Borrowers not found 55593 - Bug 14385: Followup: changes to sysprefs.sql and atomicupdate Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Using index info to reconstruct a base tree... M C4/Items.pm M C4/Search.pm M catalogue/search.pl M cataloguing/addbooks.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref M opac/opac-ISBDdetail.pl M opac/opac-MARCdetail.pl M opac/opac-detail.pl M opac/opac-search.pl M t/db_dependent/Items.t M t/db_dependent/Search.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Search.t Auto-merging t/db_dependent/Items.t Auto-merging opac/opac-search.pl Auto-merging opac/opac-detail.pl Auto-merging opac/opac-MARCdetail.pl Auto-merging opac/opac-ISBDdetail.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging cataloguing/addbooks.pl Auto-merging catalogue/search.pl Auto-merging C4/Search.pm Auto-merging C4/Items.pm Applying: Bug 14385 Followup: C4::Borrowers not found Using index info to reconstruct a base tree... M opac/opac-search.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl Applying: Bug 14385: Followup: changes to sysprefs.sql and atomicupdate Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:21:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 21:21:31 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Christopher Brannon --- Not sure if the above means that the apply failed, but I did see changed files. Tried this out, but the exception is not working. Item is still hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:29:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 21:29:31 +0000 Subject: [Koha-bugs] [Bug 18366] On shelf holds allowed > "If all unavailable" ignores library of the rule and considers all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18366 --- Comment #6 from Claudio --- Katrin, it would be nice if we could count on with this behaviour, i.e., that Koha respects the issuing rule branch as the main option, but also to have a second one (via syspref?) that allows us to change the way Koha should consider reserve's branches. So the options to make a reserve would be: 1) Koha should respect the issuing rule branch (branches that are not close to each other) 2) Koha should consider all branches (branches that are close to each other) It would be nice too if you were in charge of this enhancement :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:58:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2017 21:58:44 +0000 Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and overdue level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #5 from Christopher Brannon --- Looking at the test plan, it seems like it would be odd for B2 to send out a notice regarding B1 items. 1) What is the logic behind the notice coming from B2? 2) If there are multiple items overdue from multiple branches, should there be an option for notices to come from a neutral branch or maybe the patron's home branch? If you are going to make the notices more efficient (which I think we should), it might be a good place to introduce some new logic to the notices. Perhaps have the notice come from the patron's home branch, and have the items grouped by item.homebranch with branch heading? I don't think either of these would take a lot to do, and would make this a cleaner outcome of reducing the number of notices. Just a thought. The grouping is not absolutely necessary, but I do think a single notice should come from the patron's branch, or it should be a preference setting (overdueNoticeSender). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 03:47:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2017 01:47:40 +0000 Subject: [Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Eugene Espinoza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eugenegf at yahoo.com --- Comment #2 from Eugene Espinoza --- Hi! We're experiencing this too in one of our Koha installation, 16.11.05. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 10:28:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2017 08:28:02 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 --- Comment #34 from Marc V?ron --- (In reply to Marc V?ron from comment #33) > Please refer to the following wiki page for setup and usage instructions: > http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently For the records: Wiki page updated after testing for Koha 16.11 an Firefox 52.02 with new example JavaScript: ----------------------------- $( window ).load(function() { try { //Try to print using jsPrintSetup Plug-In in Firefox //If it is not installed fall back to default printing jsPrintSetup.clearSilentPrint(); jsPrintSetup.setOption('printSilent', 1); //Choose printer using one or more of the following functions //jsPrintSetup.getPrintersList... jsPrintSetup.setPrinter("PUT HERE YOUR PRINTER NAME"); //Set Header and footer... jsPrintSetup.setOption('headerStrLeft', ''); jsPrintSetup.setOption('headerStrCenter', ''); jsPrintSetup.setOption('headerStrRight', ''); jsPrintSetup.setOption('footerStrLeft', ''); jsPrintSetup.setOption('footerStrCenter', ''); jsPrintSetup.setOption('footerStrRight', ''); jsPrintSetup.print(); window.close(); } catch(err) { //Default printing if jsPrintsetup is not available window.print(); window.close(); } }); ----------------------------- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:05:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2017 12:05:34 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #27 from Alex Buckley --- Created attachment 61987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61987&action=edit Bug 18002 - Implemented currency creation form which is the first file to be displayed if the user did not install sample currencies during installation. Implemented new colour scheme to match the blue/grey Koha staff interface colours. Implemented text about what is happening in all forms, in addition to a hidden 'Next steps' help text on the acqui-home.tt page which will appear when the user hits the button clearly visible on the same page. This Next steps text tells the user how to create a vendor (link supplied), basket and order I have defaulted the budget active checkbox and currency active checkboxes to be ticked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:05:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2017 12:05:59 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #28 from Alex Buckley --- Created attachment 61988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61988&action=edit Bug 18002 - Reduced the widths (and removed set heights) of the acquisition onboarding includes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:46:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2017 12:46:09 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #29 from Alex Buckley --- Test plan: 1. Restart memcached: sudo service memcached restart 2. Drop and recreate the database 3. Go through the web installer selecting all data values (except the basic currencies) 4. After the web installer is finished log into the staff interface using database admin credentials 5. Create a patron and assign superlibrarian permissions to them 6. Log out of staff interface and log back in as the new user you just created 7. Go to More->Acquisitions 8. Notice yellow/orange warning message telling you to create a budget 9. Apply the patches attached to this bug report 10. Repeat steps 1,2,3,4,5,6,7 11. Notice instead of warning messages a currency creation form appears along with explanation of what a currency is and why the user is being asked to fill this form out. Fill out and submit this form. Notice active checkbox is ticked by default 12. A budget creation form is displayed along with an explanation of budgets above it. Fill this form out and submit it. Notice active checkbox is ticked by default. 13. A fund creation form appears (again with explanation text above it), fill it out and submit it 14. The coloured acquisition onboard box disappears and a table of created funds is displayed and should show the fund you just created 15. On the left of the screen below the text 'Administration' click on 'Funds' and delete the fund you just created 16. Click on More->Acquisitions and observe how the funds form is displayed rather than the currency or budget forms (because we already have a currency and budget in the database). Fill out the fund form and submit it. 17. Again you'll notice the fund table is displayed 18. On the left of the screen click on 'Budget' and delete your budget 19. Navigate to More->Acquisitions and observe how this time the budget form is displayed. Fill out this form and submit it. You should be redirected to the Budget Information page (aqbudgetperiods.pl) where you can click Actions->Add fund to add a fund. 20. Repeat steps 1,2,3,4,5,6,7 but making sure to install all sample data in the web installer including the basic currencies 21. Notice this time because you have installed basic currencies the first form to appear is the budget creation form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 16:55:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2017 14:55:35 +0000 Subject: [Koha-bugs] [Bug 18405] New: Self checkout: Fix broken silent printing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18405 Bug ID: 18405 Summary: Self checkout: Fix broken silent printing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Fix broken 'silent printing' (without printer dialog) in self checkout. To reproduce: Set up silent printing to slip printers as described in: https://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently Verify that it works for check-outs in staff client. Verify that it does not work in Self checkout. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 16:56:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2017 14:56:52 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18405 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 16:56:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2017 14:56:52 +0000 Subject: [Koha-bugs] [Bug 18405] Self checkout: Fix broken silent printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18405 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7563 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 17:01:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2017 15:01:08 +0000 Subject: [Koha-bugs] [Bug 18405] Self checkout: Fix broken silent printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18405 --- Comment #1 from Marc V?ron --- Created attachment 61989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61989&action=edit Bug 18405: Self checkout: Fix broken silent printing Fix broken 'silent printing' (without printer dialog) in self checkout. To reproduce: Set up silent printing to slip printers as described in: https://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently Verify that it works for check-outs in staff client. Verify that it does not work in Self checkout. To test: Apply patch Verify that silent printing works on SCO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 17:02:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2017 15:02:03 +0000 Subject: [Koha-bugs] [Bug 18405] Self checkout: Fix broken silent printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18405 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 17:18:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2017 15:18:46 +0000 Subject: [Koha-bugs] [Bug 11176] Purchase suggestions should respect the 'active' switch on budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 06:50:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 04:50:24 +0000 Subject: [Koha-bugs] [Bug 11176] Purchase suggestions should respect the 'active' switch on budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 --- Comment #4 from Amit Gupta --- Hi In this we have to show only active budget or we have to give option to select inactive also. I m interested to work on this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 06:50:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 04:50:50 +0000 Subject: [Koha-bugs] [Bug 11176] Purchase suggestions should respect the 'active' switch on budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 08:51:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 06:51:51 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 --- Comment #4 from Julian Maurice --- Hi Owen, do you have any JS errors in the console ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 09:01:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 07:01:37 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #10 from David Cook --- (In reply to Chris from comment #9) > I like the idea of storing history with timestamp and author. But storing > whole record seems like overkill to me. Especially for huge libraries. > > So instead of whole history, just a "delta" of data changed (somewhat git > does) and as mentioned - not JSON but TABLE. I like the idea of storing deltas, although I wonder what that looks like in practice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 09:53:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 07:53:02 +0000 Subject: [Koha-bugs] [Bug 18406] New: Linking items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18406 Bug ID: 18406 Summary: Linking items Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: p.imperatori at aarome.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 61990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61990&action=edit Host plus secondary records Hi, i don't know if this issue has been treated previously (doesn't look like). When a record has an item linked to an host item, both in Staff mode and in OPAC is visible in the item to which record is linked to, but this is not true the other way around, in the "mother" record you don't see in the items if there are records linked to that specific item(s)(The only option is the "show analytics" feature). I think it woold be helpfull to have this. Thanks Paolo Imperatori -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 10:56:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 08:56:00 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #20 from Martin Renvoize --- This all looks solid to me, and is another move in the right direction in my opinion. Was about to add my Passed QA mark when I realised I'd need to rebase as the project moved whilst I was testing. Could you rebase Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 11:28:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 09:28:19 +0000 Subject: [Koha-bugs] [Bug 18407] New: REST API: Include renewability information on checkouts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18407 Bug ID: 18407 Summary: REST API: Include renewability information on checkouts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at jns.fi QA Contact: testopia at bugs.koha-community.org It would be useful to have renewability information directly in the /checkouts endpoint to avoid making additional requests. However, this could be optional. Create /api/v1/checkouts/expanded endpoint to include additional data on checkouts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 11:31:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 09:31:42 +0000 Subject: [Koha-bugs] [Bug 18407] REST API: Include renewability information on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18407 --- Comment #1 from Lari Taskula --- Created attachment 61991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61991&action=edit Bug 18407: REST API: Add expanded checkout information GET /api/v1/checkouts/expanded?borrowernumber=1337 This endpoint includes basic checkout information as well as additionally information on renewability. To test: 1. prove t/db_dependent/api/v1/checkoutsexpanded.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 11:34:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 09:34:02 +0000 Subject: [Koha-bugs] [Bug 18407] REST API: Include renewability information on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18407 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED --- Comment #2 from Lari Taskula --- This patch does not yet apply and is dependent on Mojolicious::Plugin::OpenAPI migration and /api/v1/checkouts endpoint (Bug 13895). I just dumped the patch here if anyone is interested in similar feature. Rebase when those move on. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 11:43:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 09:43:14 +0000 Subject: [Koha-bugs] [Bug 18405] Self checkout: Fix broken silent printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18405 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 12:35:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 10:35:55 +0000 Subject: [Koha-bugs] [Bug 17821] due date in intranet search results should use TT date plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 --- Comment #6 from Fridolin SOMERS --- Some of our instances have sometimes an invalid date in items.onload (like 000-00-00). We don't know why but without this patch the page failes on error : "Can't locate object method \"ymd\" via package \"dateonly\" (perh"...) called at /home/koha/src/Koha/DateUtils.pm line 223 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 13:05:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 11:05:17 +0000 Subject: [Koha-bugs] [Bug 18407] REST API: Include renewability information on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18407 --- Comment #3 from Lari Taskula --- Created attachment 61992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61992&action=edit Bug 18407: (follow-up) Add renewability error information -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 13:05:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 11:05:29 +0000 Subject: [Koha-bugs] [Bug 18407] REST API: Include renewability information on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18407 --- Comment #4 from Lari Taskula --- Created attachment 61993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61993&action=edit Bug 18407: (follow-up) Add test for librarian access -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:09:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 12:09:20 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57950|0 |1 is obsolete| | Attachment #57951|0 |1 is obsolete| | Attachment #57952|0 |1 is obsolete| | Attachment #57953|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 61994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61994&action=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:09:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 12:09:24 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #22 from Jonathan Druart --- Created attachment 61995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61995&action=edit Bug 17600: Remove useless extra spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:09:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 12:09:28 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #23 from Jonathan Druart --- Created attachment 61996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61996&action=edit Bug 17600: continue replace of EXPORT with EXPORT_OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:09:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 12:09:38 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #25 from Jonathan Druart --- Created attachment 61998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61998&action=edit Bug 17600: Rerun the script to update use statements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:09:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 12:09:33 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #24 from Jonathan Druart --- Created attachment 61997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61997&action=edit Bug 17600: Explicitly export the subroutines used This patch is generated using the export.pl script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:12:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 12:12:35 +0000 Subject: [Koha-bugs] [Bug 18401] Add the Koha::Checkout->patron method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18401 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 [Bug 18402] Add the Koha::Item->checkout method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:12:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 12:12:35 +0000 Subject: [Koha-bugs] [Bug 18402] Add the Koha::Item->checkout method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18401 Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Jonathan Druart --- Indeed you needs bug 18401. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18401 [Bug 18401] Add the Koha::Checkout->patron method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:31:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 12:31:54 +0000 Subject: [Koha-bugs] [Bug 18408] New: Remainder of title (245$b) in Koha::Biblio Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18408 Bug ID: 18408 Summary: Remainder of title (245$b) in Koha::Biblio Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: lari.taskula at jns.fi QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:36:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 12:36:00 +0000 Subject: [Koha-bugs] [Bug 18408] Remainder of title (245$b) in Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18408 --- Comment #1 from Lari Taskula --- Created attachment 61999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61999&action=edit Bug 18408: Get remainder of title (245$b) from Koha::Biblio To test: 1. prove t/db_dependet/Koha/Biblios.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:36:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 12:36:14 +0000 Subject: [Koha-bugs] [Bug 18408] Remainder of title (245$b) in Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18408 --- Comment #2 from Lari Taskula --- Created attachment 62000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62000&action=edit Bug 18408: Store $record in Koha::Biblio and invalidate it when ->store -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:37:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 12:37:58 +0000 Subject: [Koha-bugs] [Bug 18408] Remainder of title (245$b) in Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18408 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED --- Comment #3 from Lari Taskula --- Needs rebase, current patches apply on top of Bug 18072. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 15:40:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 13:40:59 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59161|0 |1 is obsolete| | --- Comment #61 from Alex Arnaud --- Created attachment 62001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62001&action=edit Bug 12063: Change date calculation for reserve expiration to skip all holiday This patch makes koha automatically set expiration date when reserves become waitting. Also it adds a new syspref "ExcludeHolidaysFromMaxPickUpDelay" that allows to take holidays into account while calculating expiration date. Test plan: - Install this patch and run updatedatabase.pl script, - allow ExpireReservesMaxPickUpDelay in system preferences, - set ReservesMaxPickUpDelay to 5. - Place an hold on a checked out item and check in this item: The hold's expiration date should be today + 5. - Allow ExcludeHolidaysFromMaxPickUpDelay in system preferences, - add holiday during this pickup delay period, - Create a new hold and make it comes waitting: The hold's expiration date should be today + 5 + number of closed day(s). Also: - Check that ExpireReservesOnHolidays syspref works again without ExcludeHolidaysFromMaxPickUpDelay. - Check that cancel fees apply again if wanted. Signed-off-by: sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 15:41:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 13:41:10 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59162|0 |1 is obsolete| | --- Comment #62 from Alex Arnaud --- Created attachment 62002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62002&action=edit Bug 12063 - Remove Koha::Hold::waiting_expires_on since dateexpiration is set on database Signed-off-by: sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 15:41:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 13:41:21 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61401|0 |1 is obsolete| | --- Comment #63 from Alex Arnaud --- Created attachment 62003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62003&action=edit Bug 12063 - Keep patron's requested expiration date if it is prior to the calculated one Signed-off-by: Andreas Hedstr?m Mace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 15:41:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 13:41:31 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61461|0 |1 is obsolete| | --- Comment #64 from Alex Arnaud --- Created attachment 62004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62004&action=edit Bug 12063 - Fix unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 15:41:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 13:41:41 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61735|0 |1 is obsolete| | --- Comment #65 from Alex Arnaud --- Created attachment 62005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62005&action=edit Bug 12063 - Fix QA failures - Remove expiration date calculation in C4::Letter since it's done when setting the reserve waiting, - remove expiration date calculation in circ/waitingreserves.pl. Use the one in DB, - add a new atomic update that calculate expiration date for waiting reserves, - add tests for days_foward function and fix the infinite loop. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 15:42:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 13:42:54 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 15:54:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 13:54:57 +0000 Subject: [Koha-bugs] [Bug 18409] New: Error when updating pickup library on patron pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18409 Bug ID: 18409 Summary: Error when updating pickup library on patron pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com On the "Check out" and "Details" pages, attempting to update a pickup library from the holds tab results in this alert: "There was an error:error Internal Server Error". This appears to be an issue with the holds rest api not functioning correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 16:29:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 14:29:16 +0000 Subject: [Koha-bugs] [Bug 18410] New: Koha should use cool URIs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18410 Bug ID: 18410 Summary: Koha should use cool URIs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org Right now Koha use a very volatile URI scheme. If we seek having not ephemeral URIs they should be completely different. Take a look to this article from 1998 of a guy called Tim Berners-Lee: "Cool URIs don't change" https://www.w3.org/Provider/Style/URI A normal Koha URI looks like this: https://catalog.bywatersolutions.com/cgi-bin/koha/opac-detail.pl?biblionumber=117351 This URI is doomed to die in the short term, is not designed thinking in long-term. We have a lot of information about the tools and technical things used to put it there, like "cgi-bin", "koha" and "pl". Is not even consistent about using always en_US (american English): "/cgi-bin/koha/cataloguing/addbooks.pl" (cataloguing != cataloging). As the article say we shouldn't forget about domain name. We could encourage the use of more permanent words like "catalog" for the host part of the FQDN. PS: This may be related to the robust RESTful URI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 16:32:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 14:32:21 +0000 Subject: [Koha-bugs] [Bug 18366] On shelf holds allowed > "If all unavailable" ignores library of the rule and considers all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18366 --- Comment #7 from Andreas Hedstr?m Mace --- I agree with Cladio that the behaviour described here should be the default for "If all unavailable". I.e. Koha should respect the circulation rule of the branch in question when a hold is placed, not look at all libraries. The other behaviour, where some branches are close together and holds should take several (or all) branches into account, can instead be handled by the proposed enhancement: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15708. This feature would allow the grouping of libraries for holds, and allow more flexibility than as syspref only allowing one branch/all branches. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:12:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 15:12:56 +0000 Subject: [Koha-bugs] [Bug 18402] Add the Koha::Item->checkout method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 --- Comment #4 from Marc V?ron --- (In reply to Jonathan Druart from comment #3) > Indeed you needs bug 18401. Re-tested, made sure that 18401 was applied. $ git bz apply 18402 Bug 18402 - Add the Koha::Item->checkout method 61980 - Bug 18402: Add the Koha::Item->checkout method Apply? [(y)es, (n)o, (i)nteractive] y Wende an: Bug 18402: Add the Koha::Item->checkout method fatal: sha1 information is lacking or useless (Koha/Item.pm). Dem Repository fehlen notwendige Blobs um auf einen 3-Wege-Merge zur?ckzufallen. Kann nicht zu 3-Wege-Merge zur?ckfallen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:33:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 15:33:14 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Owen Leonard --- Sorry, it must have been a problem with my setup. It looks like it's working now. I'll continue testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:47:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 15:47:15 +0000 Subject: [Koha-bugs] [Bug 18410] Koha should use cool URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18410 --- Comment #1 from Owen Leonard --- I have always been bothered by the fact that I can't go to a URL like https://intranet.bywatersolutions.com/cgi-bin/koha/circ/ ...and get to the home page for that module. I agree that even better would be https://intranet.bywatersolutions.com/circ/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:52:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 15:52:51 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61937|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 62006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62006&action=edit [SIGNED-OFF] Bug 18394: Remove useless code from item search The item search was originally designed to work even with JS disabled. Since bug 15111, the staff interface does not work at all without JS, so some parts of this code are useless and should be removed Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:52:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 15:52:54 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 --- Comment #7 from Owen Leonard --- Created attachment 62007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62007&action=edit [SIGNED-OFF] Bug 18394: Add an option to item search to export a barcodes file Test plan: 1. Go to item search (/cgi-bin/koha/catalogue/itemsearch.pl) 2. Fill the form with whatever you want 3. Leave the 'Output' option to 'Screen' and click 'Search' 4. Verify that the search still works 5. Click on 'Edit search' and set 'Output' to 'Barcodes file', click 'Search' 6. You should be able to download a 'barcodes.txt' file, open it and compare it to the previous search results 7. Now click on the 'Export results to barcodes file' button above the results, you should have the same result as in step 5 8. Verify that the CSV export still works Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:53:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 15:53:24 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61938|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:53:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 15:53:36 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:00:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 16:00:33 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #11 from Nick Clemens --- To be done: Move business/logic to a module Add unit tests Remove MySQLisms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:41:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 16:41:18 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #20 from Owen Leonard --- >From my perspective this simplification will make things easier and doesn't take away any functionality we use. What is the purpose of the "Allow changes to contents from - Nobody" option? Why is it useful to create a list which you cannot add to, only delete altogether? The combination of "Category - Private" and "Allow changes to contents from: -- Anyone seeing this list" is confusing since the staff client lacks the "share" feature. Without knowing that you *could* share the list from the OPAC, allowing others to change a private list doesn't make sense. It would be nice to get sharing working in the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:51:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 16:51:36 +0000 Subject: [Koha-bugs] [Bug 15857] Add test mode to process_message_queue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from Owen Leonard --- Kyle does Srdjan's comment require a follow-up, or is this still 'Needs Signoff?' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:53:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 16:53:02 +0000 Subject: [Koha-bugs] [Bug 16954] Add the diff view to authorities in staged MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16954 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:54:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 16:54:45 +0000 Subject: [Koha-bugs] [Bug 15567] Update API to allow multiple holds for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Owen Leonard --- This looks like it should be marked "Signed off." Please change it if I'm wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:59:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 16:59:56 +0000 Subject: [Koha-bugs] [Bug 8426] Diacritics not being mapped for searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard --- Is this patch still relevant? Comments here are contradictory. If this should still be tested please provide a detailed test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:10:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 17:10:30 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #29 from Julian Maurice --- Created attachment 62008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62008&action=edit Bug 15395: Make Koha::I18N work with Plack + add tests Language detection was done in a BEGIN block so it was not working correctly with Plack. This is now done when the first translation is requested. This patch also fixes a bug when set_locale(LC_ALL, ...) fails for some reasons (locale is not installed system-wide for example). And finally, add some unit tests Test plan: 1. prove t/Koha/I18N.t 2. Replay the previous test plans with plack enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:52:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 17:52:25 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #52 from Owen Leonard --- Everything was working up until just after adding a list of barcodes to a rota. When I try to go back to 'manage items' I get an error: Proxy Error The proxy server received an invalid response from an upstream server. The proxy server could not handle the request GET /cgi-bin/koha/tools/stockrotation.pl. The log says: [Mon Apr 10 17:50:22.708218 2017] [proxy_http:error] [pid 4055] (20014)Internal error: [client 192.168.50.1:54951] AH01102: error reading status line from remote server httpd-UDS:0, referer: http://kohadev-staff.mylocalkoha.org/cgi-bin/koha/tools/stockrotation.pl [Mon Apr 10 17:50:22.710180 2017] [proxy:error] [pid 4055] [client 192.168.50.1:54951] AH00898: Error reading from remote server returned by /cgi-bin/koha/tools/stockrotation.pl, referer: http://kohadev-staff.mylocalkoha.org/cgi-bin/koha/tools/stockrotation.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 20:02:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 18:02:43 +0000 Subject: [Koha-bugs] [Bug 17279] Edifact:: Line quantity should ensure its returning invoiced quantity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17279 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- How should this be tested? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 20:15:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 18:15:19 +0000 Subject: [Koha-bugs] [Bug 17217] Allow to reserve first available item from a group of titles ( OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17217 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- Based on comment 2 I think this should be 'Failed QA' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 21:32:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 19:32:01 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Failed QA --- Comment #102 from Julian Maurice --- QA: I haven't tested it yet, but: 1) koha-qa reports a weird error about Koha::Authority::MergeRequest(s) : $ perl -cw Koha/Authority/MergeRequest.pm Inconsistent hierarchy during C3 merge of class 'Koha::Authority::MergeRequest': current merge results [ Koha::Authority::MergeRequest, ] merging failed on 'Koha::Object' at /usr/share/perl/5.20/parent.pm line 26. BEGIN failed--compilation aborted at /home/koha/env/master/src/Koha/Authority/MergeRequest.pm line 22. Compilation failed in require at /home/koha/env/master/src/Koha/Authority/MergeRequests.pm line 25. BEGIN failed--compilation aborted at /home/koha/env/master/src/Koha/Authority/MergeRequests.pm line 25. Compilation failed in require at Koha/Authority/MergeRequest.pm line 25. BEGIN failed--compilation aborted at Koha/Authority/MergeRequest.pm line 25. It seems to be because of circular dependency between the two modules. If I remove 'use Koha::Authority::MergeRequest;' from Koha::Authority::MergeRequests, there is no error. 2) koha-qa also complains about POD: *** WARNING: empty section in previous paragraph in file Koha/Authority/MergeRequests.pm 3) t/db_dependent/Koha/Authorities.t fails with a UNIMARC setup $ prove t/db_dependent/Koha/Authorities.t [2/8764] t/db_dependent/Koha/Authorities.t .. 1/6 substr outside of string at /usr/share/perl5/MARC/File/XML.pm line 561. Use of uninitialized value $enc in string eq at /usr/share/perl5/MARC/File/XML.pm line 563. Use of uninitialized value $enc in string eq at /usr/share/perl5/MARC/File/XML.pm line 563. Use of uninitialized value $enc in string eq at /usr/share/perl5/MARC/File/XML.pm line 565. Use of uninitialized value $enc in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 568. # Looks like you planned 4 tests but ran 1. # Failed test 'New merge request, method oldmarc' # at t/db_dependent/Koha/Authorities.t line 97. Unsupported UNIMARC character encoding [] for XML output for UNIMARCAUTH; 100$a -> a at /usr/share/perl5/MARC/File/XML.pm line 568. # Looks like your test exited with 255 just after 4. t/db_dependent/Koha/Authorities.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/6 subtests Test Summary Report ------------------- t/db_dependent/Koha/Authorities.t (Wstat: 65280 Tests: 4 Failed: 1) Failed test: 4 Non-zero exit status: 255 Parse errors: Bad plan. You planned 6 tests but ran 4. Files=1, Tests=4, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.84 cusr 0.03 csys = 0.88 CPU) Result: FAIL 4) Koha::Authorities::get_usage_count and Koha::Authorities::linked_biblionumbers look very similar. Is there a real performance gain to use get_usage_count instead of linked_biblionumbers ? C4::Authorities::merge call them both and it looks like we could save one search request by calling only linked_biblionumbers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:08:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:08:16 +0000 Subject: [Koha-bugs] [Bug 18189] Elasticsearch sorting broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18189 --- Comment #16 from Katrin Fischer --- Ok, missed the dependency on bug 17255 earlier - should we still push this to stable? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:13:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:13:24 +0000 Subject: [Koha-bugs] [Bug 18368] DBversion 16.12.00.022 not set by updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17866 CC| |katrin.fischer at bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 [Bug 17866] Change sender for claim and order notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:13:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:13:24 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim and order notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18368 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 [Bug 18368] DBversion 16.12.00.022 not set by updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:18:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:18:30 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim and order notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #37 from Katrin Fischer --- As a behaviour change that is not stricly a bug, this won't be pushed to the stable branch 16.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:18:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:18:30 +0000 Subject: [Koha-bugs] [Bug 18368] DBversion 16.12.00.022 not set by updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 Bug 18368 depends on bug 17866, which changed state. Bug 17866 Summary: Change sender for claim and order notices https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:19:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:19:16 +0000 Subject: [Koha-bugs] [Bug 18402] Add the Koha::Item->checkout method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61980|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 62009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62009&action=edit Bug 18402: Add the Koha::Item->checkout method Return the current checkout for a given item. Note it may not exist. Test plan: prove t/db_dependent/Koha/Items.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:20:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:20:04 +0000 Subject: [Koha-bugs] [Bug 18368] DBversion 16.12.00.022 not set by updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18368 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #6 from Katrin Fischer --- Please don't forget to set dependencies - they make a maintainer's job so much easier :) This isn't relevant for 16.11.x as the depending bug 17866 is not in it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:21:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:21:02 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:21:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:21:02 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18402, 16735, 17829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 [Bug 17829] Move GetMember to Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 [Bug 18402] Add the Koha::Item->checkout method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:21:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:21:02 +0000 Subject: [Koha-bugs] [Bug 18402] Add the Koha::Item->checkout method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:21:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:21:02 +0000 Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:21:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:21:29 +0000 Subject: [Koha-bugs] [Bug 18093] Add the Koha::Objects->get_column method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:21:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:21:29 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 Bug 18295 depends on bug 18093, which changed state. Bug 18093 Summary: Add the Koha::Objects->get_column method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:22:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:22:13 +0000 Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17554 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:22:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:22:13 +0000 Subject: [Koha-bugs] [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 [Bug 17829] Move GetMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:22:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:22:35 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 [Bug 17829] Move GetMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:22:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:22:35 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 [Bug 17829] Move GetMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:22:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:22:35 +0000 Subject: [Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 [Bug 17829] Move GetMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:22:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:22:35 +0000 Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17737, 17738, 17680 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:24:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:24:21 +0000 Subject: [Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Enhancement or bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:32:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:32:21 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:32:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:32:24 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #1 from Jonathan Druart --- Created attachment 62010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62010&action=edit Bug 18403: Hide patron information if not part of the logged in user library group This patchset adds a new feature that will allow libraries inside a single Koha installation to restrict access to information of patrons that The group of libraries feature is introduced by bug 15707, see this bug for more information. Let's imagine that 2 groups G1 and G2 are defined and that they include 2 libraries each G1a, G1b and G2c, G2d: logged in users attached to G1a will only see patron's information from G1a and G1b. To add more flexibility, a new user permission named 'view_borrower_infos_from_any_libraries' will drive this behavior. If set, the patron will be able to see patron's information of any libraries. If the restriction is set, the logged in user will not be able to search, show, edit, delete patron's information of patrons attached to groups of libraries outside his own group. In situations we need to refer to a patron, for holds and checkouts for instance, and his information cannot be viewed, a text "A patron from library G1A" will be displayed. Considered unecessary or outside the scope of this bug report: * The report module is not affected by this feature for obvious reasons * The firstname and surname of guarantors, basket (acq) managers, patrons linked to orders are still displayed. * Log viewer: Can only be staff * patron list: you cannot add patrons from another group of librairies, but can see/delete from list (too much rewrite, or we can test for patron one by one?). * "Patron card creator" tool is not impacted by this feature. * Upload patron images is not impacted by this patch, should it be? * Tools: - Upload patrons - Clean borrowers tool (This can can done easily updating Koha::Patrons->search with Koha::Patrons->search_limited in search_upcoming_membership_expires and search_patrons_to_anonymise but we will need to move GetBorrowersToExpunge to Koha::Patrons first) We can discuss these different points but will be other bug reports not to add more complexity to this first patchset. Test plan: You will find a test plan in the following commit messages. Start by creating different group of libraries and patrons with and without the new permission. Open different browser sessions to ease the tests. Note that all patches have to be applied to test the different test plans. Technical notes: For QAers (and others) a techical note will be added to the commit messages of this patchset. I would recommend you to read them one by one to understand the different steps of this development. + Special attention should be payed to the REST api changes + Should we restrict the logged in user to libraries from his group when he wants to set his library (Home ? Circulation ? Set library)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:32:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:32:28 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #2 from Jonathan Druart --- Created attachment 62011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62011&action=edit Bug 18403: Add new method Koha::Library->library_group This is more a follow-up for bug 15707. It could be moved on its own bug report if necessary. Test plan: prove t/db_dependent/LibraryGroups.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:32:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:32:32 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #3 from Jonathan Druart --- Created attachment 62012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62012&action=edit Bug 18403: Add new method Koha::Library::Group->has_child This is more a follow-up for bug 15707. It could be moved on its own bug report if necessary. IMPORTANT NOTE: At the moment the feature only works for 1 level depth, see bug 15707 comment 166+ for the discussion It means that if we have: root_group + groupA + groupA1 + groupA1_library2 + groupA_library1 + groupA2 + groupB + groupB_library1 groupA1_library2 is not considered a child of groupA1. Note that this can change. Test plan: prove t/db_dependent/LibraryGroups.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:32:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:32:35 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #4 from Jonathan Druart --- Created attachment 62013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62013&action=edit Bug 18403: Send logged_in_user to template from C4::Auth Technical note: To ease future changes we are passing a logged_in_user variable to templates. It contains the Koha::Patron object representing the logged in patron. This will be very useful for this patch and even after (for instance we will be able to replace easily loggedinusername and loggedinusernumber). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:32:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:32:39 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #5 from Jonathan Druart --- Created attachment 62014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62014&action=edit Bug 18403: Add new method Koha::Patron->can_see_patron_info Technical note: This is the method that will be called on the logged_in_user variable sent to the template. Moreover we will check that the logged in user can access patron' information when access to members/* and some circulation scripts will be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:32:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:32:44 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #6 from Jonathan Druart --- Created attachment 62015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62015&action=edit Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' Test plan: Login with a patron that only have the 'edit_borrowers' permission. You should be able to access patron's information of patrons inside of your group. Technical note: Before this patchset the borrowers permission module contains only 1 permission 'edit_borrowers'. That meant borrowers => 1 and borrowers => '*' had the same behavior. Moreover, now that we have 2 permissions, 'CAN_user_borrowers' is set when all permissions of 'borrowers' are set. We need to update the different occurrences of these tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:32:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:32:50 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #7 from Jonathan Druart --- Created attachment 62016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62016&action=edit Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos Test plan: Login with a patron that is not allowed to see patron's information for patrons outside of his group. Try to access patron's information from scripts of the patron module (members/*) and circ/circulation.pl. You should be able to access patron's information of patrons outside of your group and get "You are not allowed to see the information of this patron." If you try and access a patron page with a borrowernumber that does not exist, you should get "This patron does not exist" Technical note: A new C4::Output subroutine is created in this patch: "output_and_exit_if_error" Executed at the beginning of the script it will permit not to copy/paste all the different checks to know if the logged in user is authorised to see patron's information. The design here can be discussed, but I did not find an alternative with as less changes. On the way I refactor what we did with 'unknowuser' previously: it will now work with all patron pages, not only the few that used it. Note that the 'or die "Not logged in";' part should not be needed, but... who trusts C4::Auth? I think it could be used as a safeguard later. I am willing to sed and remove them if required. Changes in discharge.pl are mainly indentation changes. With this patch we should now have a $patron variable that refer to the patron we want to access. That will be very useful to remove plenty of code in members/* and only pass this variable to the template (instead of 1 variable per patron's attribute). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:32:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:32:54 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #8 from Jonathan Druart --- Created attachment 62017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62017&action=edit Bug 18403: Adapt patron search This patch modifies the patron search code to limit the libraries to the ones the logged in user is allowed to access Test plan: Search for patrons You should not see patrons you are not allowed to see. Technical note: I am really glad to have refactored all the patron searches before having to write this patch. It tooks me ~40 l to acchieve this job and affect all patron searches. Thanks refactoring! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:03 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #9 from Jonathan Druart --- Created attachment 62018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62018&action=edit Bug 18403: Only display libraries from group in dropdown lists >From where patrons it's about patrons, we do not want to display the libraries from all the system, but only the ones from the group. Test plan: - See the overdues (circ/overdue.pl) and make sure you can only see overdues from patrons part of your group (do not forget to test the CSV export). - Search for patrons, the 'library' filters (headers and left side) should only display libraries from your group - Search for article request by patron's library: only the libraries from your group should be displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:08 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #10 from Jonathan Druart --- Created attachment 62019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62019&action=edit Bug 18403: Use patron-title.inc when hidepatronname is used There is already a HidePatronName syspref to hide patron's information on bibliographic record detail pages and the hold list. Test plan: With the HidePatronName enabled, make sure the patron's information are hidden from the catalogue and hold list pages. If the logged in user is not allowed to see the patron's info, no link and no cardnumber will be displayed With he HidePatronName disabled, make sure the patron's information are displayed if the logged in user is allowed to see the patron's info. Technical note: This patch improves the existing patron-title.inc include file to display patron's information. Using it everywhere patron's details are displayed will permit to homogenise the way they are displayed. The file takes now a patron object (what should be, in the future, the only way to use it), that way we can call the new method on it to know if patron's information can be shown by the logged in used. NOTE: I am not sure this syspref makes sense anymore. Should not we remove it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:13 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #11 from Jonathan Druart --- Created attachment 62020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62020&action=edit Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] On this page we do not have the patron object sent to the template, let's pass it! Test plan: Go on the checkout history of a bibliographic record (catalogue/issuehistory.pl) You should not see patron's information that are not part of your group if you are not allowed to see them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:17 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #12 from Jonathan Druart --- Created attachment 62021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62021&action=edit Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for view_holdsqueue] Same that the previous patch but for the holds queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:20 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #13 from Jonathan Druart --- Created attachment 62022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62022&action=edit Bug 18403: Batch patron modification tool Do not allow a logged in staff user to modify patrons that are not part of his group if he is not allowed. Test plan: Make sure you are not allowed to modify patrons that are not part of your group from the batch patron modification tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:24 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #14 from Jonathan Druart --- Created attachment 62023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62023&action=edit Bug 18403: output_and_exit_if_error for circulation.pl This is a follow-up for a previous patch, changes have been tested already -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:27 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #15 from Jonathan Druart --- Created attachment 62024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62024&action=edit Bug 18403: Add new methods Koha::Patrons->search_limited and use it where needed Most of the time when we search for patrons we do not want to search for all patrons, but just the ones the logged in user is allowed to see the information. This patch takes care of that by adding a new search_limited method to Koha::Patrons. When called this method only search for patrons that the logged in user is allowed to see. Test plan: Patron autocomplete search should be limited -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:31 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #16 from Jonathan Druart --- Created attachment 62025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62025&action=edit Bug 18403: Refactor and add Koha::Patron->libraries_where_can_see_patrons Technical note: Here we are just refactoring a code that have been copied into 3 different places. libraries_where_can_see_patrons is a terrible method's name, feel free to suggest something better. The method return a list of branchcodes to be more efficient, instead of Koha::Libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:34 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #17 from Jonathan Druart --- Created attachment 62026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62026&action=edit Bug 18403: Add tests for Koha::Patrons A bit late but here are the tests for Koha::Patron->libraries_where_can_see_patrons Koha::Patron->can_see_patron_infos Koha::Patron->search_limited Test plan: prove t/db_dependent/Koha/Patrons.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:38 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #18 from Jonathan Druart --- Created attachment 62027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62027&action=edit Bug 18403: Add new method Koha::Patron->can_see_patrons_from Technical note: Sometimes we do not have the patron object, for instance for the patron modifications we will need to know if the logged in user can modify patron's from a given library. This new subroutine 'can_see_patrons_from' will then be useful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:42 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #19 from Jonathan Druart --- Created attachment 62028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62028&action=edit Bug 18403: Patron modification requests Limit patron's modifications based on logged in patron permissions. Test plan: Create some patron's modification requests at the OPAC Make sure the logged in staff user see (or not) the modification depending his permissions. The number of modification displayed on the mainpage should be correct as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:46 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #20 from Jonathan Druart --- Created attachment 62029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62029&action=edit Bug 18403: Patron reviews This patch adds a new method Koha::Reviews->search_limited to return the reviews a logged in user is allowed to see depending his permissions. Test plan: Create some reviews at the OPAC and make sure a staff user is limited (or not) to approve or decline it. The number of reviews displayed on the mainpage should be correct as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:50 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #21 from Jonathan Druart --- Created attachment 62030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62030&action=edit Bug 18403: Patron discharges This patch deals with patron's discharges. Test plan: Same as previously you will need to request dischages at the OPAC. On the staff interface the logged in user should not be allowed to see discharge from patrons outside his library group. The number of discharges waiting displayed on the mainpage should be correct as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:54 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #22 from Jonathan Druart --- Created attachment 62031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62031&action=edit Bug 18403: Article requests Same as previously but for article requests. Test plan: Test article requests and make sure you do not need the requests for patrons that are attached to a group that is not part of your library's group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:33:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:33:58 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #23 from Jonathan Druart --- Created attachment 62032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62032&action=edit Bug 18403: Guarantors Technically a kid from your library group could have a guarantor attached to another group of library, let's deal with this case. Test plan: - Create a kid from your library group - With a superlibrarian staff user create a guarantor that is outside of the group of libraries of the kid - Login with a limited staff user and confirm that on the patron detail page you do not see the link to the guarantor detail page. Note that you see the firstname and surname of the guarantor Q. should it be hidden? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:34:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:34:02 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #24 from Jonathan Druart --- Created attachment 62033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62033&action=edit Bug 18403: REST API - patrons endpoint There is something wrond here, the userenv is no set and so we cannot user search_limited. Should we set the userenv or filter on the libraries using libraries_where_can_see_patrons? WAITING FOR FEEDBACK HERE. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:35:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:35:43 +0000 Subject: [Koha-bugs] [Bug 17346] Enable the check in option in Columns settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Katrin Fischer --- Tiny change - I have decided to push this to 16.11.x. This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:37:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:37:00 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/joubu/Ko | |ha/commits/bug_18403 --- Comment #25 from Jonathan Druart --- There are too many dependencies on this one, please see the following remote branch for the whole stack: https://github.com/joubu/Koha/commits/bug_18403 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:37:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:37:47 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #20 from Marc V?ron --- First two patches apply cleanly, with 3rd patch (complex calls) I get: fatal: sha1 information is lacking or useless (C4/Circulation.pm). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:41:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:41:06 +0000 Subject: [Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.07. Thx for the follow-up, Jonahtan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:43:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:43:53 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #15 from Katrin Fischer --- Hm, a little torn about pushing this one. Opinions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:45:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:45:43 +0000 Subject: [Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:46:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:46:50 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Nick Clemens --- Basic functionality seems to be working right now, a couple issues: 1 - We should be able to get results without being signed in - this would mirror functionality for other sources 2 - The account page should offer a 'logout' option 3 - When no items are checked out or on hold the account tab should not display the headings in the account tab 4 - Image links in OneClick results lead no where, ideally these would point out to the oneclick site for the library 5 - It would be nice to have a few more details on the results page if possible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:48:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:48:53 +0000 Subject: [Koha-bugs] [Bug 18329] Batch record deletion broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:50:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:50:02 +0000 Subject: [Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 --- Comment #3 from Katrin Fischer --- Can someone help me track the problem down here? Colin, can you upload a patch/diff please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:50:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:50:50 +0000 Subject: [Koha-bugs] [Bug 18373] `make upgrade` is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Can we get speedy QA on this please? The bug is present in 16.11.06. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:52:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 21:52:57 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61763|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 62034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62034&action=edit Bug 17680: C4::Circulation - Remove GetItemIssue, complex calls There are a few calls to GetItemIssue where it's not as easy to make sure everything will be fine just replacing the calls with a Koha::Issues->find - In AddReturn the overdue flag is used (that's why this patch depends on bug 17689) - In CanBookBeRenewed, as well as the overdue flag the dates converted to DateTime were used. It's now our job to convert them when we need them. - Same in AddRenewal but we also call _CalculateAndUpdateFine, so we need to update the variables in this subroutine. Note that, prior to this patch, AddReturn returned the GetItemIssue hashref in the $iteminformation. Most of the time this variable is not used, I have found only 1 place where it's used: circ/returns.pl TODO: In this script we should call ->is_overdue instead of the DateTime->compare calls Test plan: All the circulation tests must pass (it's how I have caught the specific cases). Do some checkins/checkouts/renewal and focus on the due date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 00:06:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 22:06:28 +0000 Subject: [Koha-bugs] [Bug 18411] New: t/db_dependent/www/search_utf8.t fails on 16.11.x Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 Bug ID: 18411 Summary: t/db_dependent/www/search_utf8.t fails on 16.11.x Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: katrin.fischer at bsz-bw.de QA Contact: gmcharlt at gmail.com https://jenkins.koha-community.org/job/Koha_16.11.x_D8/lastCompletedBuild/testReport/(root)/t_db_dependent_www_search_utf8_t/Number_of_runned_tests_does_not_match_plan___668_/ perl t/db_dependent/www/history.t 1..2 ok 1 - Latin characters with umlauts show correctly on the history page. ok 2 - Cyrillic characters with umlauts show correctly on the history page. kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ perl t/db_dependent/www/search_utf8.t 1..66 ok 1 - connect to intranet ok 2 - login to staff client ok 3 - load main page ok 4 - open tools module Link not found at t/db_dependent/www/search_utf8.t line 127. # Looks like your test exited with 255 just after 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 00:06:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 22:06:53 +0000 Subject: [Koha-bugs] [Bug 18411] t/db_dependent/www/search_utf8.t fails on 16.11.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 01:09:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2017 23:09:37 +0000 Subject: [Koha-bugs] [Bug 18411] t/db_dependent/www/search_utf8.t fails on 16.11.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #1 from Mason James --- (In reply to Katrin Fischer from comment #0) > https://jenkins.koha-community.org/job/Koha_16.11.x_D8/lastCompletedBuild/ > testReport/(root)/t_db_dependent_www_search_utf8_t/ > Number_of_runned_tests_does_not_match_plan___668_/ > > perl t/db_dependent/www/history.t > 1..2 > ok 1 - Latin characters with umlauts show correctly on the history page. > ok 2 - Cyrillic characters with umlauts show correctly on the history page. > kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ perl > t/db_dependent/www/search_utf8.t > 1..66 > ok 1 - connect to intranet > ok 2 - login to staff client > ok 3 - load main page > ok 4 - open tools module > Link not found at t/db_dependent/www/search_utf8.t line 127. > # Looks like your test exited with 255 just after 4. Hi, this also fails for me on master/7c8610c too mason at xen1:~/g/master$ sudo koha-shell -c 'prove ./t/db_dependent/www/search_utf8.t' mast3 ./t/db_dependent/www/search_utf8.t .. You tried to plan twice at ./t/db_dependent/www/search_utf8.t line 65. # Looks like your test exited with 255 before it could output anything. ./t/db_dependent/www/search_utf8.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 66/66 subtests Test Summary Report ------------------- ./t/db_dependent/www/search_utf8.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 66 tests but ran 0. Files=1, Tests=0, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.79 cusr 0.25 csys = 2.08 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 03:19:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 01:19:16 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #11 from David Cook --- (In reply to Chris from comment #9) > I like the idea of storing history with timestamp and author. But storing > whole record seems like overkill to me. Especially for huge libraries. > > So instead of whole history, just a "delta" of data changed (somewhat git > does) and as mentioned - not JSON but TABLE. After doing some reading, it appears that Git actually does save the whole file during a commit. It will compress it using zlib, but it stores the whole file. However, when it does its garbage collection, it may discard old whole files and replace them with deltas for more efficient storage. Using Compress::Zlib, which is a core Perl module, I compressed a 6.7KB 153 line MARCXML file to 1.3KB. Let's say we have 1,000,000 old versions... that's 976MB or .95GB. Not super huge but not tiny either. If we used GNU diff/patch or even 'git diff --no-index file1 file2', we could get diffs and store those. Using diff, I made a 467B patch for a one line change, and with git diff I got a 474B patch for the same one line change. Presuming 1,000,000 uncompressed patches of the same size, that's 445MB or .434GB. If you compress the patch, you can get it down to 227B, so 216MB or .211GB for 1,000,000 compressed patches. That seems pretty decent to me. So Compress::Zlib is easy to use and it's a core module. Awesome. I think making the deltas may be harder. You can use Git.pm to take advantage of 'git diff --no-index file1 file2', although git diff returns non zero for a diff, so Git.pm actually throws an exception which you have to catch and then you get the diff from there. Not that elegant... plus you'd have to write the records to temporary files (same with using GNU diff). I've seen lots of diff modules on CPAN... and it seems that Text::Diff gets recommended a fair bit (https://metacpan.org/pod/Text::Diff) and shows up in the O'Reilly book it seems (http://docstore.mik.ua/orelly/perl4/cook/ch08_23.htm). I also found it was already installed on my Koha server, although I don't use the Debian packages, so I can't attest to that. It looks like it's required by Test::Differences and that lots of modules use that, so that's probably why it's on my system. I've just tried it out and it's easy to use. Looks like we'd want to use Text::Patch for applying the diff to rebuild a record... although I haven't tried it. Using Text::Diff I got a patch that was 378B uncompressed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 03:25:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 01:25:05 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #12 from David Cook --- Using whole records, it would be easy to recover an older version on a timeline. Per field changes would be harder... but you could always load the older version and then do your own diff algorithm for diffing MARC::Record objects... then choose which differences to apply... but that would be work. Actually, a person could look at XML::Diff as well... as that could make computing the difference a lot easier at the field level. Personally, I like the idea of just using the whole record. It's less granular but it would be easier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 05:50:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 03:50:55 +0000 Subject: [Koha-bugs] [Bug 18373] `make upgrade` is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 07:41:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 05:41:05 +0000 Subject: [Koha-bugs] [Bug 18369] Broken title link in UNIMARC catalog search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I think in the french UNIMARC installer everything is set up for 001 = biblionumber. I am not sure if having the bilbionumber stored elseqhere in a UNIMARC setup won't cause you more trouble overall. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 08:23:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 06:23:02 +0000 Subject: [Koha-bugs] [Bug 5938] Maximum number of issues across a family group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5938 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Lennon, this bug report is pretty old already. Usually the "Assignee" gives a clue if someone is actively working on a bug, but in this case it might be a mistake. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 08:34:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 06:34:53 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #103 from Julian Maurice --- 5) When I merge 2 authorities on the staff interface, I get a UNIMARC-related error: Unsupported UNIMARC character encoding [] for XML output for UNIMARCAUTH; 100$a -> at /usr/share/perl5/MARC/File/XML.pm line 568. It's triggered by MARC::Record::as_xml in Koha::Authority::MergeRequests::reporting_tag_xml. It seems to work correctly when I add the following code before as_xml: # Copied from AddAuthority my $date = POSIX::strftime("%Y%m%d", localtime); my $defaultfield100 = C4::Context->preference('UNIMARCAuthorityField100'); $newrecord->append_fields( MARC::Field->new('100', ' ', ' ' , 'a'=> $date.$defaultfield100) ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:18:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 07:18:21 +0000 Subject: [Koha-bugs] [Bug 18402] Add the Koha::Item->checkout method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62009|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 62035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62035&action=edit Bug 18402: Add the Koha::Item->checkout method Return the current checkout for a given item. Note it may not exist. Test plan: prove t/db_dependent/Koha/Items.t should return green Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:19:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 07:19:10 +0000 Subject: [Koha-bugs] [Bug 18402] Add the Koha::Item->checkout method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18402 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:19:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 07:19:30 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 --- Comment #30 from Julian Maurice --- Why is this bug 'In Discussion' ? Shouldn't it be 'Needs Signoff' ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:33:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 07:33:34 +0000 Subject: [Koha-bugs] [Bug 18412] Show list price in foreign currency in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18412 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:33:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 07:33:26 +0000 Subject: [Koha-bugs] [Bug 18412] New: Show list price in foreign currency in acquisitions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18412 Bug ID: 18412 Summary: Show list price in foreign currency in acquisitions Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org At the moment, the list price as entered in a foreign currency is not shown in acquisitions on the basket or receive forms. Only the converted price is shown. A As exchange rates can change and the libraries need to check invoices etc with the price an item was ordered with, we should also show the list price as it was entered in the foreign currency. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:44:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 07:44:48 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55059|0 |1 is obsolete| | --- Comment #4 from Julian Maurice --- Created attachment 62036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62036&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:44:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 07:44:51 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55060|0 |1 is obsolete| | --- Comment #5 from Julian Maurice --- Created attachment 62037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62037&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:45:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 07:45:08 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Julian Maurice --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:45:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 07:45:55 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Felix Hemme changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |felix.hemme at thulb.uni-jena. | |de --- Comment #4 from Felix Hemme --- With this patch applied, you can not pay or write off the manual credit. Furthermore, information entered the fields 'barcode', 'description' and 'note' is no longer displayed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:47:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 07:47:44 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #7 from Julian Maurice --- (In reply to H?ctor Eduardo Castro Avalos from comment #3) > You should do this one dependent of bug 16246 Why ? They seem to be independent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:52:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 07:52:24 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 --- Comment #31 from Lari Taskula --- (In reply to Julian Maurice from comment #30) > Why is this bug 'In Discussion' ? Shouldn't it be 'Needs Signoff' ? Hi Julian! I left this in discussion to get more feedback on the idea and the patches were attached as an example implementation. But you are right, Needs Signoff is a better status now that there are attached patches implementing this suggestion. We are actually in process of testing this feature together with VuFind via Koha REST API (Bug 16826). So far we received some valuable test feedback, and I have follow-up bugfixes coming that I will squash soon. I shall set this to needs signoff then :) Thanks for the comment! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:58:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 07:58:41 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 --- Comment #32 from Julian Maurice --- Nice! I haven't had a chance to look at the code yet but the idea is great IMO :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:05:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 08:05:03 +0000 Subject: [Koha-bugs] [Bug 5938] Maximum number of issues across a family group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5938 --- Comment #4 from Lennon Mazonde --- Hi Katrin, Thanks a lot for responding. What do you suggest i do? Open a new bug request? I've contacted a couple of support companies directly but have had no response. Lennon -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:11:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 08:11:24 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #30 from Marc V?ron --- Hi Julian I tried again with the tt example from patch 'Bug 15395: Example usage of I18N Template::Toolkit plugin' Followed the test plan (with fr-FR and de-DE), the translations for item/items showed up as expected (exemplaire/exemplaires and Exemplar/Exemplare). Great! However it seems that the second part of line 630 in results.tt is no longer picked for translation or does not translate properly (n available rsp. None available). I have the impression that the rest of the line after the plural stuff is skipped. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:31:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 08:31:35 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #31 from Julian Maurice --- (In reply to Marc V?ron from comment #30) > However it seems that the second part of line 630 in results.tt is no longer > picked for translation or does not translate properly (n available rsp. None > available). I have the impression that the rest of the line after the plural > stuff is skipped. This is expected, quite annoying, but expected. Due to the way the template strings extractor works (not the new one brought by this bug but the current one), almost every change in a template will result in a change in the PO file. For instance, msgid "%s %s %sitems%sitem%s%s, %s available:%s, None available%s %s " will be changed to msgid "%s %s %s%s, %s available:%s, None available%s %s " and will be marked as "fuzzy" so it will not be used. But you can fix the translation, remove the fuzzy flag, and run ./translate install. Text will be translated again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:06:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 09:06:23 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #32 from Marc V?ron --- Ah, got it, thanks for the explanation :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:57:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 09:57:10 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com Attachment #61069|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:58:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 09:58:31 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 delaye changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye at biblibre.co | |m --- Comment #8 from delaye --- The number of exported barcodes remains unchanged despite the use of filters in the result table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:21:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 10:21:02 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:21:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 10:21:09 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61069|0 |1 is obsolete| | --- Comment #191 from Paul Poulain --- Created attachment 62038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62038&action=edit Bug 6473: just a test https://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Julian Maurice Signed-off-by: Julian Maurice Signed-off-by: Julian Maurice Signed-off-by: Paul POULAIN -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:21:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 10:21:24 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:22:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 10:22:22 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #33 from Marc V?ron --- Hmm, I can not make js files translate. What I did: Change staff-global.js as suggested in comment #9 function openHelp(){ alert(__nx("There is one thing", "There are {count} things", 3, {count: 3})); The alert shows up fine in English version (Hit the 'Help' link) However after translate update, I find nothing in Koha.po (only the strings from the tt example) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:51:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 11:51:10 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #34 from Julian Maurice --- Ah, you found a bug! :-) Actually the string extractor only search in koha-tmpl/**/en/ to avoid picking strings from already translated files (when I wrote the test plan, staff-global.js was inside /en/ I think). I guess I need to refine the file search to also search in koha-tmpl/intranet-tmpl/prog/js and koha-tmpl/opac-tmpl/bootstrap/js (anything else ?). Anyway, to test it right now you could modify a .js file in the /en/ directory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:54:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 11:54:53 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #104 from Marcel de Rooy --- Thanks, Julian. Will come back to these points very soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:56:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 11:56:41 +0000 Subject: [Koha-bugs] [Bug 18413] New: Fix Letters.t (follow-up of 17866) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413 Bug ID: 18413 Summary: Fix Letters.t (follow-up of 17866) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: gmcharlt at gmail.com t/db_dependent/Letters.t .. 1/80 Can't call method "branchemail" on an undefined value at /home/vagrant/kohaclone/C4/Letters.pm line 576. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:57:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 11:57:04 +0000 Subject: [Koha-bugs] [Bug 18413] Fix Letters.t (follow-up of 17866) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17866 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 [Bug 17866] Change sender for claim and order notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:57:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 11:57:04 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for claim and order notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18413 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413 [Bug 18413] Fix Letters.t (follow-up of 17866) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:18:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 12:18:15 +0000 Subject: [Koha-bugs] [Bug 18413] Fix Letters.t (follow-up of 17866) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413 --- Comment #1 from Marcel de Rooy --- Created attachment 62039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62039&action=edit Bug 18413: Fix Letters.t (following bug 17866) SendAlert now needs a userenv to find branch email and the fallback of KohaAdminEmailAddress if the branch mail is not filled. Test plan: Run t/db_dependent/Letters.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:18:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 12:18:12 +0000 Subject: [Koha-bugs] [Bug 18413] Fix Letters.t (follow-up of 17866) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:18:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 12:18:58 +0000 Subject: [Koha-bugs] [Bug 18413] Fix Letters.t (follow-up of 17866) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- Jonathan: please QA this one. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:19:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 12:19:21 +0000 Subject: [Koha-bugs] [Bug 18413] Fix Letters.t (follow-up of 17866) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:22:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 12:22:02 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:32:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 12:32:56 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:32:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 12:32:59 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44704|0 |1 is obsolete| | --- Comment #14 from Lari Taskula --- Created attachment 62040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62040&action=edit Bug 14590: Validate messaging preferences Messaging preferences should be only available if a valid contact information is stored for the patron for that transport type. Otherwise, it should not be possible to select preferences for that transport type. For example, when attempting to set messages to be delivered via sms, we should automatically check patron's smsalertnumber before allowing this type of modification. If patron does not have a valid smsalertnumber and is not passing it along with the messaging preference change, we should not store those given messaging transport types. This patch implements exactly this. It uses Koha::Validation from Bug 14620 to validate contact informations and attaches it into patron modification logic - whenever messaging preferences are processed by Koha, preferences that link to an invalid or non-existent contact information will be removed. Client-side JavaScript checks are also implemented. When modifying patron information, messaging preferences for a certain transport type will be either enabled and/or disabled on the fly depending on validity of the contact info linked to that transport type (transport type "sms" => borrower "smsalertnumber"). TESTING: This feature requires tests both in OPAC and staff client. Requirements: 1. Apply patch(es) in Bug 14620 before this patch 2. Make sure EnhancedMessagingPreferences is enabled 3. Make sure EnhancedMessagingPreferencesOPAC is enabled 4. Make sure TalkingTechItivaPhoneNotification is enabled (activates transport type "phone") 5. Make sure SMSSendDriver is enabled (for simple testing purposes you can use the value "test") 6. Preference "ValidatePhoneNumber" needs a regular expression for validating phone numbers. An example regular expression is provided below the input field. You can use that while testing this feature. Copy-paste it into the input box and save preferences. (regex also provided below) ^((\+)?[1-9]{1,2})?([-\s\.])?((\(\d{1,4}\))|\d{1,4})(([-\s\.])?[0-9]{1,12}){1,2}$ TEST PLAN: 1. Login to staff client 2. Go to modification view of any patron 3. Scroll down all the way and you should see "Patron messaging preferences" table including checkboxes for transport types "SMS", "Phone" and "Email". 4. If the patron you are modifying has any contact information of the following "Primary email", "Primary phone", "SMS number", please clear those fields. 5. Scroll down. All checkboxes for the given transport types should now be disabled. 6. Modify field "Primary email" and insert "test". A warning of invalid email should appear. 7. Scroll down. Checkboxes for transport type "Email" should still be disabled. 8. Modify field "Primary email" and insert "nobody at example.com". 9. Scroll down. Checkboxes for transport type "Email" should now be enabled. 10. Select email as transport type for each message type and click "Save". 11. Go back to modification screen. The messaging preferences should still appear as you stored them. 12. Repeat steps 6-11 also for both "Phone" and "SMS number". When inserting text into phone number fields, they should appear as invalid, so test like that. 13. After successful testing, test also other patron modification screens. Go to patron's Details tab and you should see multiple "Edit" links on that page. The point is to make sure transport type selections are correctly removed from the patron if the modification screen lets you modify for example primary email, but does not present the messaging preferences at the bottom of the page. So, as an example, first insert patron a valid email and select all email transport types. Then, go to the "Edit" link right above "Patron messaging preferences" title on patron's details page. This page lets you modify "Primary email" but not messaging preferences. Clear the "Primary email" field and save, and observe that all previously selected email transport types are now removed. 14. Give your patron a valid email and go to Details tab -> "Edit" link below "Patron messaging preferences title" on the left. You should still be able to select email as transport types. 15. Go remove patron's primary email and repeat step 14. You will observe that it is no longer possible to select email as a transport type. 16. Try steps 13-15 with other transport types as well After this test plan you should have a pretty good idea of the feature. As mentioned earlier, this feature requires tests on the OPAC side as well. So attempt this also via OPAC and make sure preferences are validated when the librarian approves patron's modifications. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:33:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 12:33:20 +0000 Subject: [Koha-bugs] [Bug 14590] Validate messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Checkboxes should be |Validate messaging |disabled without valid |preferences |contact information in | |messaging preferences | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:56:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 12:56:29 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #35 from Julian Maurice --- Created attachment 62041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62041&action=edit Bug 15395: Search .js files in more directories Specifically, koha-tmpl/intranet-tmpl/prog/js and koha-tmpl/opac-tmpl/bootstrap/js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:27:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 13:27:00 +0000 Subject: [Koha-bugs] [Bug 18373] `make upgrade` is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18373 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #5 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > Can we get speedy QA on this please? The bug is present in 16.11.06. Upping severity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:31:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 13:31:43 +0000 Subject: [Koha-bugs] [Bug 17693] Add option to export deleted bibs in export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17693 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- If the only option for retrieving deleted records is to get a text file with one biblionumber per line I don't think it should save a file with the ".mrc" extension. That makes it look like it's a MARC file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:32:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 13:32:58 +0000 Subject: [Koha-bugs] [Bug 18414] New: Allow to use other select criteria with delete_patrons.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414 Bug ID: 18414 Summary: Allow to use other select criteria with delete_patrons.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz It would be nice if the delete_patrons.pl script could be enhanced to also allow to delete patrons using a list of borrowernumbers from a file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:33:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 13:33:09 +0000 Subject: [Koha-bugs] [Bug 18413] Fix Letters.t (follow-up of 17866) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:33:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 13:33:12 +0000 Subject: [Koha-bugs] [Bug 18413] Fix Letters.t (follow-up of 17866) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62039|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 62042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62042&action=edit Bug 18413: Fix Letters.t (following bug 17866) SendAlert now needs a userenv to find branch email and the fallback of KohaAdminEmailAddress if the branch mail is not filled. Test plan: Run t/db_dependent/Letters.t Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:35:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 13:35:18 +0000 Subject: [Koha-bugs] [Bug 14590] Validate messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62040|0 |1 is obsolete| | --- Comment #15 from Lari Taskula --- Created attachment 62043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62043&action=edit Bug 14590: Validate messaging preferences Messaging preferences should be only available if a valid contact information is stored for the patron for that transport type. Otherwise, it should not be possible to select preferences for that transport type. For example, when attempting to set messages to be delivered via sms, we should automatically check patron's smsalertnumber before allowing this type of modification. If patron does not have a valid smsalertnumber and is not passing it along with the messaging preference change, we should not store those given messaging transport types. This patch implements exactly this. It uses Koha::Validation from Bug 14620 to validate contact informations and attaches it into patron modification logic - whenever messaging preferences are processed by Koha, preferences that link to an invalid or non-existent contact information will be removed. Client-side JavaScript checks are also implemented. When modifying patron information, messaging preferences for a certain transport type will be either enabled and/or disabled on the fly depending on validity of the contact info linked to that transport type (transport type "sms" => borrower "smsalertnumber"). TESTING: This feature requires tests both in OPAC and staff client. Requirements: 1. Apply patch(es) in Bug 14620 before this patch 2. Make sure EnhancedMessagingPreferences is enabled 3. Make sure EnhancedMessagingPreferencesOPAC is enabled 4. Make sure TalkingTechItivaPhoneNotification is enabled (activates transport type "phone") 5. Make sure SMSSendDriver is enabled (for simple testing purposes you can use the value "test") 6. Preference "ValidatePhoneNumber" needs a regular expression for validating phone numbers. An example regular expression is provided below the input field. You can use that while testing this feature. Copy-paste it into the input box and save preferences. (regex also provided below) ^((\+)?[1-9]{1,2})?([-\s\.])?((\(\d{1,4}\))|\d{1,4})(([-\s\.])?[0-9]{1,12}){1,2}$ TEST PLAN: 1. Login to staff client 2. Go to modification view of any patron 3. Scroll down all the way and you should see "Patron messaging preferences" table including checkboxes for transport types "SMS", "Phone" and "Email". 4. If the patron you are modifying has any contact information of the following "Primary email", "Primary phone", "SMS number", please clear those fields. 5. Scroll down. All checkboxes for the given transport types should now be disabled. 6. Modify field "Primary email" and insert "test". A warning of invalid email should appear. 7. Scroll down. Checkboxes for transport type "Email" should still be disabled. 8. Modify field "Primary email" and insert "nobody at example.com". 9. Scroll down. Checkboxes for transport type "Email" should now be enabled. 10. Select email as transport type for each message type and click "Save". 11. Go back to modification screen. The messaging preferences should still appear as you stored them. 12. Repeat steps 6-11 also for both "Phone" and "SMS number". When inserting text into phone number fields, they should appear as invalid, so test like that. 13. After successful testing, test also other patron modification screens. Go to patron's Details tab and you should see multiple "Edit" links on that page. The point is to make sure transport type selections are correctly removed from the patron if the modification screen lets you modify for example primary email, but does not present the messaging preferences at the bottom of the page. So, as an example, first insert patron a valid email and select all email transport types. Then, go to the "Edit" link right above "Patron messaging preferences" title on patron's details page. This page lets you modify "Primary email" but not messaging preferences. Clear the "Primary email" field and save, and observe that all previously selected email transport types are now removed. 14. Give your patron a valid email and go to Details tab -> "Edit" link below "Patron messaging preferences title" on the left. You should still be able to select email as transport types. 15. Go remove patron's primary email and repeat step 14. You will observe that it is no longer possible to select email as a transport type. 16. Try steps 13-15 with other transport types as well After this test plan you should have a pretty good idea of the feature. As mentioned earlier, this feature requires tests on the OPAC side as well. So attempt this also via OPAC and make sure preferences are validated when the librarian approves patron's modifications. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:41:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 13:41:09 +0000 Subject: [Koha-bugs] [Bug 14606] Donate to the Koha International Fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606 Pablo AB changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi at gmail.com --- Comment #15 from Pablo AB --- Right now I get an error using donate button: "Error Detected: PayPal cannot process this transaction because of a problem with the seller's website. Please contact the seller directly to resolve this problem." I'd be less shy about this subject, like Wikipedia or Canonical. Why not a Donate button in the black menu top bar? BTW, why not also offer some other alternatives? - A donation site better than Paypal: donorbox.org, bountysource.com?, liberapay.com, patreon.com. - QR code to donate to a Bitcoin wallet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:42:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 13:42:32 +0000 Subject: [Koha-bugs] [Bug 18411] t/db_dependent/www/search_utf8.t fails on 16.11.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #2 from Jonathan Druart --- (In reply to Mason James from comment #1) > ./t/db_dependent/www/search_utf8.t .. You tried to plan twice at You did not specify KOHA_INTRANET_URL and KOHA_OPAC_URL % KOHA_INTRANET_URL=http://pro.kohadev.vm KOHA_OPAC_URL=http://catalogue.kohadev.vm prove t/db_dependent/www/search_utf8.t t/db_dependent/www/search_utf8.t .. ok All tests successful. Files=1, Tests=66, 67 wallclock secs ( 0.03 usr 0.00 sys + 1.44 cusr 0.76 csys = 2.23 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:49:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 13:49:25 +0000 Subject: [Koha-bugs] [Bug 14590] Validate messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 --- Comment #16 from Lari Taskula --- Rebased on master & rewrote much of the patch and added a more detailed test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:52:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 13:52:05 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #39 from Jonathan Druart --- I really would like to see them backported, it will greatly simplify setup of installation based on stable releases and so backporting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:54:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 13:54:09 +0000 Subject: [Koha-bugs] [Bug 14590] Validate messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62043|0 |1 is obsolete| | --- Comment #17 from Lari Taskula --- Created attachment 62044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62044&action=edit Bug 14590: Validate messaging preferences Messaging preferences should be only available if a valid contact information is stored for the patron for that transport type. Otherwise, it should not be possible to select preferences for that transport type. For example, when attempting to set messages to be delivered via sms, we should automatically check patron's smsalertnumber before allowing this type of modification. If patron does not have a valid smsalertnumber and is not passing it along with the messaging preference change, we should not store those given messaging transport types. This patch implements exactly this. It uses Koha::Validation from Bug 14620 to validate contact informations and attaches it into patron modification logic - whenever messaging preferences are processed by Koha, preferences that link to an invalid or non-existent contact information will be removed. Client-side JavaScript checks are also implemented. When modifying patron information, messaging preferences for a certain transport type will be either enabled and/or disabled on the fly depending on validity of the contact info linked to that transport type (transport type "sms" => borrower "smsalertnumber"). TESTING: This feature requires tests both in OPAC and staff client. Requirements: 1. Apply patch(es) in Bug 14620 before this patch 2. Make sure EnhancedMessagingPreferences is enabled 3. Make sure EnhancedMessagingPreferencesOPAC is enabled 4. Make sure TalkingTechItivaPhoneNotification is enabled (activates transport type "phone") 5. Make sure SMSSendDriver is enabled (for simple testing purposes you can use the value "test") 6. Preference "ValidatePhoneNumber" needs a regular expression for validating phone numbers. An example regular expression is provided below the input field. You can use that while testing this feature. Copy-paste it into the input box and save preferences. (regex also provided below) ^((\+)?[1-9]{1,2})?([-\s\.])?((\(\d{1,4}\))|\d{1,4})(([-\s\.])?[0-9]{1,12}){1,2}$ TEST PLAN: 1. Login to staff client 2. Go to modification view of any patron 3. Scroll down all the way and you should see "Patron messaging preferences" table including checkboxes for transport types "SMS", "Phone" and "Email". 4. If the patron you are modifying has any contact information of the following "Primary email", "Primary phone", "SMS number", please clear those fields. 5. Scroll down. All checkboxes for the given transport types should now be disabled. 6. Modify field "Primary email" and insert "test". A warning of invalid email should appear. 7. Scroll down. Checkboxes for transport type "Email" should still be disabled. 8. Modify field "Primary email" and insert "nobody at example.com". 9. Scroll down. Checkboxes for transport type "Email" should now be enabled. 10. Select email as transport type for each message type and click "Save". 11. Go back to modification screen. The messaging preferences should still appear as you stored them. 12. Repeat steps 6-11 also for both "Phone" and "SMS number". When inserting text into phone number fields, they should appear as invalid, so test like that. 13. After successful testing, test also other patron modification screens. Go to patron's Details tab and you should see multiple "Edit" links on that page. The point is to make sure transport type selections are correctly removed from the patron if the modification screen lets you modify for example primary email, but does not present the messaging preferences at the bottom of the page. So, as an example, first insert patron a valid email and select all email transport types. Then, go to the "Edit" link right above "Patron messaging preferences" title on patron's details page. This page lets you modify "Primary email" but not messaging preferences. Clear the "Primary email" field and save, and observe that all previously selected email transport types are now removed. 14. Give your patron a valid email and go to Details tab -> "Edit" link below "Patron messaging preferences title" on the left. You should still be able to select email as transport types. 15. Go remove patron's primary email and repeat step 14. You will observe that it is no longer possible to select email as a transport type. 16. Try steps 13-15 with other transport types as well After this test plan you should have a pretty good idea of the feature. As mentioned earlier, this feature requires tests on the OPAC side as well. So attempt this also via OPAC and make sure preferences are validated when the librarian approves patron's modifications. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:57:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 13:57:40 +0000 Subject: [Koha-bugs] [Bug 18411] t/db_dependent/www/search_utf8.t fails on 16.11.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #3 from Katrin Fischer --- Hm, ok, but how would we do this for Jenkins? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:08:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:08:16 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #105 from Marcel de Rooy --- (In reply to Julian Maurice from comment #103) > 5) When I merge 2 authorities on the staff interface, I get a > UNIMARC-related error: > > Unsupported UNIMARC character encoding [] for XML output for UNIMARCAUTH; > 100$a -> at /usr/share/perl5/MARC/File/XML.pm line 568. > > It's triggered by MARC::Record::as_xml in > Koha::Authority::MergeRequests::reporting_tag_xml. > > It seems to work correctly when I add the following code before as_xml: > > # Copied from AddAuthority > my $date = POSIX::strftime("%Y%m%d", localtime); > my $defaultfield100 = > C4::Context->preference('UNIMARCAuthorityField100'); > $newrecord->append_fields( > MARC::Field->new('100', ' ', ' ' , 'a'=> $date.$defaultfield100) > ); Thanks. This error actually is the same as point 3 of the previous comment. I will add an absolute minimum 100 with encoding only for UNIMARC to resolve the problem in MARC::File::XML. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:08:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:08:06 +0000 Subject: [Koha-bugs] [Bug 18411] t/db_dependent/www/search_utf8.t fails on 16.11.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #4 from Jonathan Druart --- I get much more errors that Jenkins's ones. Someone else to take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:13:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:13:36 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56175|0 |1 is obsolete| | Attachment #56176|0 |1 is obsolete| | Attachment #56177|0 |1 is obsolete| | Attachment #56178|0 |1 is obsolete| | Attachment #56179|0 |1 is obsolete| | Attachment #56180|0 |1 is obsolete| | Attachment #56181|0 |1 is obsolete| | Attachment #59728|0 |1 is obsolete| | Attachment #59931|0 |1 is obsolete| | Attachment #61905|0 |1 is obsolete| | --- Comment #25 from Baptiste --- Created attachment 62045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62045&action=edit Bug 17047 add mana syspref Add the system preference to enable or disable mana webservice on koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:13:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:13:46 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #26 from Baptiste --- Created attachment 62046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62046&action=edit Bug 17047 add frequencies and numberpattern in subscription class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:13:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:13:54 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #27 from Baptiste --- Created attachment 62047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62047&action=edit Bug 17047 ability to search subscription model on mana - add a class SharedContent.pm to communicate with mana server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for mana - create datatable in mana-subscription-search-result.inc to show results from a research on mana - modify serials-search.pl to manage research on mana -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:14:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:14:02 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #28 from Baptiste --- Created attachment 62048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62048&action=edit Bug 17047 ability to share a subscription to mana - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a mana subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to mana -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:14:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:14:09 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #29 from Baptiste --- Created attachment 62049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62049&action=edit Bug 17047 ability to import a subscription model from mana - modify subscription-add.tt and subscription.pl to manage a import from mana during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with mana server during a asubscription creation - add a function in Subscription.pm to have all the info for a mana research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from mana server and not already created on the koha database, and modify the tests of the said functions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:14:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:14:17 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #30 from Baptiste --- Created attachment 62050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62050&action=edit Bug 17047 Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:14:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:14:24 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #31 from Baptiste --- Created attachment 62051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62051&action=edit Bug 17047 - Use Koha::Libraries instead of GetBranches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:14:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:14:31 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #32 from Baptiste --- Created attachment 62052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62052&action=edit Bug 17047 - Don't create numberpattern if the same exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:14:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:14:40 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #33 from Baptiste --- Created attachment 62053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62053&action=edit Bug 17047 - Don't show action column (use link) on mana search page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:14:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:14:48 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #34 from Baptiste --- Created attachment 62054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62054&action=edit Bug 17047: Add report, factorize code, add a comment feature Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redisigned to improve the user experience - New Feature : report a record. - peoples can now report a weird report - if a record is reported a lot of time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - Added the syspref "AutoShareWithMana", which enables to select which fields you want to share automatically with mana API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) - Factorize a lot of code in order to improve the speed of next developments SytemPreferences: Mana Activation: - add a field "no, let me think" at the syspref "Mana" - as long as this field is selected, messages ask if user want to activate it messages in pages: - Administration - Add-subscription(page 2) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with mana (automatically not set) Report Share - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana - New feature: search report in Mana Knowledge Base with keywords - New feature: load reports from Mana Comment Resources - The comments can now be manually added - On a resource mana datatable, you can now see comments, add comment and vote for comments you think pertinent - Comments are NOT dynamically generated on the table you need to reload the page when you vote Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => mana shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other". - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:21:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:21:18 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #106 from Marcel de Rooy --- (In reply to Julian Maurice from comment #102) > 4) Koha::Authorities::get_usage_count and > Koha::Authorities::linked_biblionumbers look very similar. Is there a real > performance gain to use get_usage_count instead of linked_biblionumbers ? > C4::Authorities::merge call them both and it looks like we could save one > search request by calling only linked_biblionumbers Yes, there is a performance gain depending on the number of linked records. A significant difference between both subs is the second and third parameter of the simple_search_compat call. And the biblionumber extraction of course. I first worked with one sub doing both, but in the end I felt that separating them resulted in cleaner code. I would prefer not to change them on this report anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:27:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:27:11 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #107 from Marcel de Rooy --- Created attachment 62055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62055&action=edit Bug 9988: [QA Follow-up] Satisfy QA issues [1] See comment102. Moved sub reporting_tag_xml to MergeRequest.pm. Adjusted t/db_dependent/Koha/Authorities.t accordingly. This resolves the C3 inconsistent hierarchy errors. [2] Removed empty POD section Instance Methods from MergeRequests. This resolves the POD error in comment102 point 2. [3] Include a tag 100 for UNIMARC in reporting_tag_xml to resolve an error on encoding in MARC::File::XML. Subtest for oldmarc and subtest for reporting_tag_xml adjusted accordingly. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:36:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:36:25 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #21 from Marcel de Rooy --- (In reply to Owen Leonard from comment #20) > From my perspective this simplification will make things easier and doesn't > take away any functionality we use. > > What is the purpose of the "Allow changes to contents from - Nobody" option? > Why is it useful to create a list which you cannot add to, only delete > altogether? > > The combination of "Category - Private" and "Allow changes to contents from: > -- Anyone seeing this list" is confusing since the staff client lacks the > "share" feature. Without knowing that you *could* share the list from the > OPAC, allowing others to change a private list doesn't make sense. > > It would be nice to get sharing working in the staff client. Thanks for responding. Good to read that the simplification is not interpreted as feature loss. The "Allow changes from Nobody" locks a list: you cannot add, but you cannot delete too. (A contents change is an add or a delete.) Some people may find it comfortable that the list is protected from accidental/incidental changes. The combination of Private and "Anyone seeing" is indeed a bit confusing (altough still true). Might add a follow-up or a new report for it. Sharing in the staff client certainly is a new report. I can at least open one to get some more feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:55:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:55:41 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #35 from Paul Poulain --- Verified that, with mana OFF, nothing changes & Koha still working : * SQL => everything is OK * subscriptions => ERROR On the logs I see: Use of uninitialized value $loggedinuser in string ne at /home/koha/src/Koha/SharedContent.pm line 89. Can't call method "email" on an undefined value at /home/koha/src/Koha/SharedContent.pm line 91. Some QA comments: * patch description : "2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml" => not very clear. Better "copy in your koha-conf.xml the 3 lines about mana configuration the 3 lines you'll find in $KOHA_SRC/etc/koha-conf.xml" * some "+# Copyright ByWater Solutions 2015" => Yikes, it's Biblibre 2017, not ByWater 2015 ;-) * Not sure we should use Koha/Reports.pm & Report.pm. Why not something related to Mana (ie: Koha/Mana/Reports.pm, Koha/Mana/Reports.pm) [this is a question] * Some "+# Copyright 2016 BibLibre Morgane Alonso" => you're Baptiste, not Morgane (and we're now 2017) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:55:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:55:50 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:58:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 14:58:33 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #22 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #19) > I'd like to get users' opinions before removing features. I have no idea if > these permissions are used or not. > I agree that it is not very clear, but we can still make the interface more > easier to use/understand instead of remove features. In response to comment17 and comment19 I wrote the Koha mailing list and asked for feedback on this report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:22:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 15:22:08 +0000 Subject: [Koha-bugs] [Bug 18415] New: Advanced Editor - Rancor - return focus to editor after successful macro Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415 Bug ID: 18415 Summary: Advanced Editor - Rancor - return focus to editor after successful macro Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:24:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 15:24:26 +0000 Subject: [Koha-bugs] [Bug 18416] New: Allow local uploading of audio files Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18416 Bug ID: 18416 Summary: Allow local uploading of audio files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: bibliwho at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Staff can currently use the AudioAlerts preference to control which sounds are played based on particular triggers (for example, a bad barcode scan). At present there is a limited number of built-in sounds to choose from. It would be great if libraries could upload their own sound files so that customized messages could be used. Think of the possibilities -- Warnings in Darth Vader's voice. Reminders in a soothing British accent. Etc. Koha already allows for local book cover files to be uploaded, so I don't believe there would be any major technical obstacles. Thank you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:25:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 15:25:15 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #36 from Marc V?ron --- OK, I tested with 3 files: koha-tmpl/intranet-tmpl/prog/en/js/categories.js koha-tmpl/intranet-tmpl/prog/js/staff-global.js koha-tmpl/opac-tmpl/bootstrap/js/global.js All files were picked up in Koha.po I translated them and did a translate install Example for JavaScript used (added as line 1 of koha-tmpl/intranet-tmpl/prog/en/js/categories.js): alert(__nx("There is one category", "There are {count} categories", 4, {count: 4})); Translation in misc/translator/po/de_DE/LC_MESSAGES/Koha.po: #: koha-tmpl/intranet-tmpl/prog/en/js/categories.js:1 msgid "There is one category" msgid_plural "There are {count} categories" msgstr[0] "Es gibt {count} Kategorien" msgstr[1] "Es gibt nur eine Kategorie..." English page displays "There are 4 categories" (OK) German page displays "Es gibt nur eine Kategorie..." (WRONG) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:25:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 15:25:13 +0000 Subject: [Koha-bugs] [Bug 18415] Advanced Editor - Rancor - return focus to editor after successful macro In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:25:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 15:25:16 +0000 Subject: [Koha-bugs] [Bug 18415] Advanced Editor - Rancor - return focus to editor after successful macro In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415 --- Comment #1 from Nick Clemens --- Created attachment 62056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62056&action=edit Bug 18415 - Advanced Editor - Rancor - return focus to editor after successful macro After running a macro we should return focus to the editor screen so editing can continue from keyboard To test: 1 - Create a macro 007=vd cvaizq 2 - Run it and note focus is not on editor 3 - Apply patch 4 - Reload page 5 - Run macro 6 - Note focus is returned to editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:25:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 15:25:34 +0000 Subject: [Koha-bugs] [Bug 18415] Advanced Editor - Rancor - return focus to editor after successful macro In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18415 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:27:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 15:27:54 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_18417=5D_New=3A__Advanced_Editor_-_R?= =?utf-8?q?ancor_-_add_shortcuts_for_copyright_symbols_=C2=A9_=E2=84=97?= Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 Bug ID: 18417 Summary: Advanced Editor - Rancor - add shortcuts for copyright symbols ? ? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:28:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 15:28:05 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_18417=5D__Advanced_Editor_-_Rancor_-?= =?utf-8?q?_add_shortcuts_for_copyright_symbols_=C2=A9_=E2=84=97?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:31:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 15:31:06 +0000 Subject: [Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Advanced Editor - Rancor - |Advanced Editor - Rancor - |add shortcuts for copyright |add shortcuts for copyright |symbols ? ? |symbols (C) (P) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:31:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 15:31:22 +0000 Subject: [Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:31:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 15:31:24 +0000 Subject: [Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 --- Comment #1 from Nick Clemens --- Created attachment 62057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62057&action=edit Bug 18417 - Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) To test: 1 - Apply patch 2 - Open advanced cataloging editor 3 - Try using Alt+P and Alt+C and note symbols are added 4 - Save record and ensure symbols are saved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:47:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 15:47:51 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #37 from Julian Maurice --- (In reply to Marc V?ron from comment #36) > German page displays "Es gibt nur eine Kategorie..." (WRONG) It depends on how you configured the Plural-Forms header, but by convention, msgstr[0] is the singular form and msgstr[1] is the plural form, so it looks ok to me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 18:49:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 16:49:07 +0000 Subject: [Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309 --- Comment #9 from David Kuhn --- (In reply to Katrin Fischer from comment #8) > Enhancement or bug? This patch is to fix a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:05:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 17:05:33 +0000 Subject: [Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:05:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 17:05:36 +0000 Subject: [Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 --- Comment #4 from Owen Leonard --- Created attachment 62058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62058&action=edit Bug 18372 - transits are not created at check in despite user responsing Yes to the prompt If the AutomaticItemReturn system preference is set to "Don't" and you check in an item which belongs to another library, a dialog will ask you if you want to transfer. This patch corrects a bug to enable the "Yes" buttons to work, triggering the transfer. To test, apply the patch and check in an item which belongs to another library. In the dialog, click the 'Yes' button and confirm that the item has been made 'in transit' to the correct library. Perform the same test with the 'Yes, print slip' and 'No' buttons and confirm they are working correctly. Since this patch changes the behavior of many other popups triggered from this template, test other operations which trigger a 'print slip' option like: - Checking in an item which is part of a rotating collection - Checking in an item which is on hold for a patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:05:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 17:05:54 +0000 Subject: [Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:19:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 17:19:40 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #27 from Owen Leonard --- Sorry, patch doesn't apply. I'll test ASAP after rebased patches are attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:24:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 17:24:09 +0000 Subject: [Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309 --- Comment #10 from Katrin Fischer --- I am asking, because it is marked as enh - please switch to the appropriate severity! (Second input after Importance) Enh are usually not backported to stable releases, so it's important to set the right status :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:29:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 18:29:30 +0000 Subject: [Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57703|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 62059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62059&action=edit Bug 17665 - SIP2 Item Information Response returns incorrect circulation status of '08' ( waiting on hold shelf ) if record has any holds If a record has any holds on it, the SIP2 item information response will return a value of 08 "waiting on hold shelf" even if the item is not actually a waiting hold. This is clearly a bug. Test Plan: 1) Find an item that is not a waiting hold, but whose record has one or more holds. 2) Issue a SIP2 item information request 3) Note in the response, the circulation status field is '08' 4) Apply this patch 5) Repeat the item informationr request 6) Note the code is now '03' ( available ) 7) Check the item in to fill the hold 8) Repeat the item information request 9) Verify the circulation status is now '08' Followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:29:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 18:29:49 +0000 Subject: [Koha-bugs] [Bug 17665] SIP2 Item Information Response returns incorrect circulation status of ' 08' ( waiting on hold shelf ) if record has any holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17665 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:52:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 18:52:41 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61640|0 |1 is obsolete| | --- Comment #17 from Marc V?ron --- Created attachment 62060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62060&action=edit Bug 12021 - SIP2 checkin should alert on transfer and use CT for return branch This small patch corrects the SIP2 checkin response if branch transfer is needed. It depends on bug 7981 and also removes an obsolete alert check in SIP2. Test plan: - apply bug 7981 - make sure syspref AutomaticItemReturn is false - check 'Return policy' in 'Default checkout, hold and return policy' - make a SIP2 checkout and checkin from a branch different than item's home branch. - verify that SIP2 response gives alert CV04 (=send to different branch) - also verify that response field CT gives correct branch according to 'Return policy' Signed-off-by: Kyle M Hall Followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:03:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 19:03:07 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:04:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 19:04:22 +0000 Subject: [Koha-bugs] [Bug 18418] New: Advanced Editor - Rancor - Add a control number widget Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18418 Bug ID: 18418 Summary: Advanced Editor - Rancor - Add a control number widget Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:04:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 19:04:37 +0000 Subject: [Koha-bugs] [Bug 18418] Advanced Editor - Rancor - Add a control number widget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18418 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:13:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 19:13:48 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #36 from Jonathan Druart --- (In reply to Paul Poulain from comment #35) > * Not sure we should use Koha/Reports.pm & Report.pm. Why not something > related to Mana (ie: Koha/Mana/Reports.pm, Koha/Mana/Reports.pm) [this is a > question] They make sense to me, they are related to the (badly named) table saved_sql > * Some "+# Copyright 2016 BibLibre Morgane Alonso" => you're Baptiste, not > Morgane (and we're now 2017) After a very quick look at the code it seems that it is some code written by Morgane and moved by Baptiste, sounds right to keep it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:25:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 19:25:37 +0000 Subject: [Koha-bugs] [Bug 17956] Provide additional functionality in the onboarding tool through configuring z-targets , and providing information on setting up SIP and LDAP services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17956 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60000|0 |1 is obsolete| | --- Comment #12 from Marc V?ron --- Created attachment 62061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62061&action=edit Bug 17956 - Fixed the indentation of onboardingstep6.tt. Ensured SIP2 was written in the joint SIP and LDAP information screen Followed test plan from comment #9, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:26:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 19:26:18 +0000 Subject: [Koha-bugs] [Bug 17956] Provide additional functionality in the onboarding tool through configuring z-targets , and providing information on setting up SIP and LDAP services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17956 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:27:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 19:27:53 +0000 Subject: [Koha-bugs] [Bug 18264] Course reserves - use itemnumber for editing existing reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #16 from Nick Clemens --- The 'bug' part is reproducible on 16.11, I filed as a bug because it can cause issues in those limited cases where barcodes are removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:28:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 19:28:21 +0000 Subject: [Koha-bugs] [Bug 18419] New: Broken patron-blank image in viewlog.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 Bug ID: 18419 Summary: Broken patron-blank image in viewlog.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: ephetteplace at cca.edu QA Contact: testopia at bugs.koha-community.org Created attachment 62062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62062&action=edit screenshot The theme's patron-blank.png image is incorrectly referenced from the viewlog.tt template, resulting in a broken image. One can see this by going to the logs tool, selecting the "Patrons" module, and filling in a borrowernumber under "object" which matches a patron who does not have a custom image. Screenshot attached. I believe this is due to the interaction between line #13 of circ-menu.inc and lines #58-66 of viewlog.tt. The circ menu include expects a value like "/intranet-tmpl" for the "interface" variable (this is what's used on circulation.tt, for instance) while viewlog.tt has a switch statement that assigns the value "Intranet" to the variable, causing the link to break. I'd offer a patch except I'm not sure how the interface value is used throughout viewlog.tt and its includes, or why it appears to refer to the same interface (the intranet) in two different forms for two different templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:29:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 19:29:16 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #23 from Jonathan Druart --- Basically with this patch we are going to remove the "Let people adds stuffs to this list but do not let them remove stuffs from this list (unless added by themself)" option. If nobody uses it, this patch makes code and interface much more easy to read/understand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:43:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 19:43:13 +0000 Subject: [Koha-bugs] [Bug 18418] Advanced Editor - Rancor - Add a control number widget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18418 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:43:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 19:43:17 +0000 Subject: [Koha-bugs] [Bug 18418] Advanced Editor - Rancor - Add a control number widget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18418 --- Comment #1 from Nick Clemens --- Created attachment 62063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62063&action=edit Bug 18418 - Advanced Editor - Rancor - Add a control number widget This patchset adds a control number widget - numbers are generated using an authorised value in the CONTROL_NUM_SEQUENCES category Test plan: 1 - Apply patch 2 - Enable helpers for fixed and coded fields in advanced cataloging editor 3 - Add or view 001 field 4 - You should see a 'Manually assign button 5 - Click and add control number 6 - Note the title when hovering over the button 7 - Add an authorised value in the CONTROL_NUM_SEQUENCES category with initial value as 'authorised_value' and Description as you choose 8 - Reload the editor or load a new record 9 - note you now have an 'Assign next' button or an Override button - test both -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:46:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 19:46:39 +0000 Subject: [Koha-bugs] [Bug 14590] Validate messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:05:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 20:05:28 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Jonathan Druart --- # Failed test at t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 112. # got: 'donald duck' # expected: 'donald* duck*' # Failed test at t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 114. # got: 'donald or duck and mickey not mouse' # expected: 'donald* or duck* and mickey* not mouse*' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:05:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 20:05:33 +0000 Subject: [Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58723|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 62064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62064&action=edit Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls In aqbudgetperiods.pl a commented line is removed that contains a wrong userenv hash key. Should be branch instead of branchcode. In aqbudgets GetBudgetHierarchy is called with the same wrong userenv hash key. Should be userenv->{branch}. This made another bug visible: if you call GetBudgetHierarchy with a branch and without owner, the where clause should take into account that the branchcode can be empty (not null). Test plan: [1] Run Budgets.t [2] Run aqbudgets.pl from Administration [3] Add the show_mine=1 parameter in the URL [4] Change owner of one of the funds and repeat step 2 and 3. t/Budgets.t returns green. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:05:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 20:05:49 +0000 Subject: [Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:10:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 20:10:34 +0000 Subject: [Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #3 from Jonathan Druart --- I would not consider this as a bug, you hyst need to fix the url ...right? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:10:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 20:10:52 +0000 Subject: [Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #4 from Jonathan Druart --- I would not consider this as a bug, you just need to fix the url ...right? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:13:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 20:13:14 +0000 Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #5 from Jonathan Druart --- I have worked for several days on bug 18403, on top of these patches, and did not find any errors. I am quite confident with these patches, even if the changes are important. Please do not let them wait too long. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:13:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 20:13:22 +0000 Subject: [Koha-bugs] [Bug 18367] Fix untranslatable string from Bug 18264 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:13:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 20:13:25 +0000 Subject: [Koha-bugs] [Bug 18367] Fix untranslatable string from Bug 18264 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367 --- Comment #1 from Nick Clemens --- Created attachment 62065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62065&action=edit Bug 18367 - Fix untranslatable string from Bug 18264 Restore display of message when no barcode found To test: 1 - Go to course reserves 2 - Add an item to a course 3 - Try adding an invalid barcode - should get an alert 4 - Try force adding an item with itemnumber: http://localhost:8081/cgi-bin/koha/course_reserves/add_items.pl?op=lookpup&course_id=11&itemnumber=1234523546 5 - Should recieve an error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:16:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 20:16:30 +0000 Subject: [Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #5 from Nick Clemens --- (In reply to Jonathan Druart from comment #4) > I would not consider this as a bug, you just need to fix the url ...right? Technically yes, but no visible error is thrown to the user, you are just silently signed out. Why fetch the 404 error template if we aren't displaying it? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:54:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 20:54:19 +0000 Subject: [Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #172 from Marc V?ron --- Hi Alex, Just found a small problem while testing around with an installation that was configured using the onboarding tool. The problem was a test failing: t/dbdependent/Budgets.t I figured out that while onboarding, step 'Create a new patron category', I had put a Categorycode that was not 'S' (something like 'STAFF'). The test assumes that a category 'S' exists and fails without it. I can imagine that other tests and other scripts could fail as well. I went again through installation / onboarding and set the category code to 'S'. Now the test passed. Maybe it is a good idea to have in the Onboarding tool a fix value 'S' for the new patron category. What do you think about? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:08:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 21:08:10 +0000 Subject: [Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #173 from Katrin Fischer --- Hm, should we not fix the test instead? Not sure I understood correctly, but having a category of 'S' should not be mandatory for the tests to pass in a normal environment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:16:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 21:16:10 +0000 Subject: [Koha-bugs] [Bug 18411] t/db_dependent/www/search_utf8.t fails on 16.11.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > I get much more errors that Jenkins's ones. > Someone else to take a look? Ok pass for me locally finally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:24:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 21:24:53 +0000 Subject: [Koha-bugs] [Bug 18411] t/db_dependent/www/search_utf8.t fails on 16.11.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #6 from Jonathan Druart --- Tomas, I get the following if I launch the tests manually on jenkins t/db_dependent/www/search_utf8.t .. 9/66 Error GETing http://koha_16_11:8080/cgi-bin/koha/tools/background-job-progress.pl?jobID=741d649f9d4472fe75f30761ba2488c0: Bad Request at t/db_dependent/www/search_utf8.t line 170. But nothing in the logs to debug. Any ideas? I just see the apache access log which indeed returns a 400 koha_16_05:8080 127.0.0.1 - - [11/Apr/2017:20:54:24 +0000] "GET /cgi-bin/koha/tools/background-job-progress.pl?jobID=741d649f9d4472fe75f30761ba2488c0 HTTP/1.1" 400 0 "http://koha_16_11:8080/cgi-bin/koha/tools/stage-marc-import.pl" "Test-WWW-Mechanize/1.42" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:39:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 21:39:03 +0000 Subject: [Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:39:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 21:39:09 +0000 Subject: [Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62064|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 62066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62066&action=edit Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls In aqbudgetperiods.pl a commented line is removed that contains a wrong userenv hash key. Should be branch instead of branchcode. In aqbudgets GetBudgetHierarchy is called with the same wrong userenv hash key. Should be userenv->{branch}. This made another bug visible: if you call GetBudgetHierarchy with a branch and without owner, the where clause should take into account that the branchcode can be empty (not null). Test plan: [1] Run Budgets.t [2] Run aqbudgets.pl from Administration [3] Add the show_mine=1 parameter in the URL [4] Change owner of one of the funds and repeat step 2 and 3. t/Budgets.t returns green. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:46:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 21:46:54 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Felix, if there is a problem like the ones you describe, it's totally ok to set 'failed qa' - 'in discussion' is more when more opinions are needed or when there is disagreement about the implementation. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:51:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 21:51:37 +0000 Subject: [Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309 David Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:53:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 21:53:17 +0000 Subject: [Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309 --- Comment #11 from Katrin Fischer --- Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:04:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:04:15 +0000 Subject: [Koha-bugs] [Bug 18375] Better readability of patron category table for zero ages and fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18375 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:04:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:04:20 +0000 Subject: [Koha-bugs] [Bug 18375] Better readability of patron category table for zero ages and fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18375 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61867|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 62067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62067&action=edit Bug 18375: Better readability of patron category table for zero ages and fees In patron category table, this patch displays zero / empty values for ages and fees with '-' for better readability To test: - Go to Home > Administration > Patron categories - Verify that you have 0 years and/or only years in Age required and Uper age limit colums - Verify that you have Enrollment and Hold fees of 0.00 - Apply patch - Verify that such values are replaced by - to enhance table readability Signed-off-by: Luke Honiss Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:12:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:12:31 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- (In reply to delaye from comment #8) > The number of exported barcodes remains unchanged despite the use of filters > in the result table Yes right, but this behavior already existed when exporting as CSV. Julian, any chances to see you fix that on another bug report? :) Passing QA this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:14:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:14:17 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:14:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:14:23 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62006|0 |1 is obsolete| | Attachment #62007|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 62068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62068&action=edit Bug 18394: Remove useless code from item search The item search was originally designed to work even with JS disabled. Since bug 15111, the staff interface does not work at all without JS, so some parts of this code are useless and should be removed Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:14:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:14:28 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 --- Comment #11 from Jonathan Druart --- Created attachment 62069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62069&action=edit Bug 18394: Add an option to item search to export a barcodes file Test plan: 1. Go to item search (/cgi-bin/koha/catalogue/itemsearch.pl) 2. Fill the form with whatever you want 3. Leave the 'Output' option to 'Screen' and click 'Search' 4. Verify that the search still works 5. Click on 'Edit search' and set 'Output' to 'Barcodes file', click 'Search' 6. You should be able to download a 'barcodes.txt' file, open it and compare it to the previous search results 7. Now click on the 'Export results to barcodes file' button above the results, you should have the same result as in step 5 8. Verify that the CSV export still works Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:17:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:17:20 +0000 Subject: [Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #174 from Liz Rea --- Agree with Cait, this is a problem with the test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:18:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:18:10 +0000 Subject: [Koha-bugs] [Bug 14606] Donate to the Koha International Fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606 --- Comment #16 from Liz Rea --- This button really ought to be removed, as no one has given me information about the foundation and as far as I know it is dysfunctional. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:25:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:25:06 +0000 Subject: [Koha-bugs] [Bug 12930] Web installer does not show login errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Alex, it seems that the only changes you made are: + if ($info{'invalid_username_or_password'} == 1) { + $template->param( 'invalid_username_or_password' => $info{'invalid_username_or_password'}); + } If it is right I would prefer a single patch with only the needed changes instead of indentation changes and modification of the return value of checkpw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:29:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:29:13 +0000 Subject: [Koha-bugs] [Bug 14606] Donate to the Koha International Fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606 --- Comment #17 from Pablo AB --- That's really a pity. Meanwhile maybe at least a bitcoin wallet? Created by someone reliable of the community. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:32:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:32:26 +0000 Subject: [Koha-bugs] [Bug 17821] due date in intranet search results should use TT date plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 --- Comment #7 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #6) > Some of our instances have sometimes an invalid date in items.onload (like > 000-00-00). We don't know why but without this patch the page failes on > error : > "Can't locate object method \"ymd\" via package \"dateonly\" (perh"...) > called at /home/koha/src/Koha/DateUtils.pm line 223 Ok but you are not fixing anything with this patch, just hide other problems: course_reserves/course-details.tt: [% IF cr.item.onloan %] reserve/request.tt: [% IF ( itemloo.onloan ) %] catalogue/detail.tt: [% UNLESS ( item.itemnotforloan || item.notforloan_per_itemtype || item.onloan || item.itemlost || item.withdrawn || item.damaged || item.transfertwhen || item.reservedate ) %] In all of these tests, onloan will be true when you are expecting it to be false. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:38:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:38:02 +0000 Subject: [Koha-bugs] [Bug 18420] New: t/dbdependent/Budgets.t fails without patron category 'S' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Bug ID: 18420 Summary: t/dbdependent/Budgets.t fails without patron category 'S' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: veron at veron.ch QA Contact: gmcharlt at gmail.com If no patron category 'S' is defined, t/dbdependent/Budgets.t fails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:39:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:39:00 +0000 Subject: [Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18420 --- Comment #175 from Marc V?ron --- (In reply to Katrin Fischer from comment #173) > Hm, should we not fix the test instead? Not sure I understood correctly, but > having a category of 'S' should not be mandatory for the tests to pass in a > normal environment. No problem for me. I filed a bug: Bug 18420 - t/dbdependent/Budgets.t fails without patron category 'S' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:39:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:39:00 +0000 Subject: [Koha-bugs] [Bug 18420] t/dbdependent/Budgets.t fails without patron category 'S' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17855 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:40:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:40:14 +0000 Subject: [Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17855 | Depends on| |17855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 00:40:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2017 22:40:14 +0000 Subject: [Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18039 Depends on|18039 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039 [Bug 18039] Move the mandatory and optional files for non-english languages into 'default' directory so bug 17855 permits use of other languages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 03:14:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 01:14:40 +0000 Subject: [Koha-bugs] [Bug 18421] New: Make Coce cover images available for staff search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Bug ID: 18421 Summary: Make Coce cover images available for staff search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: arm at hanover.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When turned on, Coce cover images appear in the OPAC only, not staff interface. (Coce Cover images - settings in enhanced content.) Desired setting would be like Amazon cover settings - the ability to turn on Coce images for the OPAC and/or the staff interface separately. Coce server needs Koha searches to populate it with cover image links. While it is collecting them, images do not display on the first time search results. To make them display would need a refresh or a programmed time delay and re-query to the Coce server. This is not useful for public OPAC. While the Coce server is being populated with links it is desirable to have only the staff interface using Coce. After a time, when the Coce server has accumulated a large collection of links, it would then be turned on for public OPAC and used by both. I have Koha 3.22.07, and am testing with the Bywater Coce server. If this is under way or in more recent versions already, please comment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 03:46:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 01:46:07 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16138 CC| |barton at bywatersolutions.com --- Comment #12 from Barton Chittenden --- Note: this seems to be the same compilation error that was tripping up plack in Bug 16138 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 03:46:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 01:46:07 +0000 Subject: [Koha-bugs] [Bug 16138] Restart plack when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17717 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 08:17:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 06:17:29 +0000 Subject: [Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com | |, | |simith.doliveira at inlibro.co | |m --- Comment #5 from Katrin Fischer --- I think if we can't fix this pre-release, we should consider removing the button altogether - at the moment I would hide it if I had a choice as a library, as the feature behind it is broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 08:20:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 06:20:15 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #84 from Katrin Fischer --- Is there documentation about this new feature available somewhere? Is it possible to choose if you want to add a new user and update existing users like it is with LDAP? Do the attributes have to match exactly to what Koha expects (branchcode, categorycode specifically) or is there a way to do a mapping? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 08:22:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 06:22:15 +0000 Subject: [Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187 --- Comment #15 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #11) > Should we send a notification if we cancel a hold? > Can remember to have seen such a report, but cannot find it now. There is bug 12656, but no patch yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 08:48:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 06:48:15 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #85 from Zeno Tajoli --- Hi Katrin, the setup info are inside C4/Auth_with_shibboleth.pm in POD format: Map shibboleth attributes to koha fields, and configure authentication match point in koha-conf.xml. userid Note: The minimum you need here is a block, containing a valid column name from the koha borrowers table, and a block containing a relation between the chosen matchpoint and the shibboleth attribute name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 09:29:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 07:29:54 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #86 from Katrin Fischer --- Thx Zeno - I looked at the patches, but didn't spot it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 09:32:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 07:32:20 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #87 from Katrin Fischer --- Actually, after looking at the POD, I am still not sure what is the answer to my questions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 09:37:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 07:37:02 +0000 Subject: [Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 --- Comment #12 from Julian Maurice --- (In reply to Jonathan Druart from comment #9) > (In reply to delaye from comment #8) > > The number of exported barcodes remains unchanged despite the use of filters > > in the result table > > Yes right, but this behavior already existed when exporting as CSV. > > Julian, any chances to see you fix that on another bug report? :) > > Passing QA this one. Thanks. That's probably what I'll do -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 09:42:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 07:42:54 +0000 Subject: [Koha-bugs] [Bug 18422] New: Add Select2 to authority editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18422 Bug ID: 18422 Summary: Add Select2 to authority editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: synapse.ova at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Overview: Repeat tag fails if authority field has select subfield (for example, UNIMARC 700$8, 800$a) Steps to Reproduce: In authority editor repeat field that has select subfield Actual Results: Field does not repeat (copy is not created). Console shows a js TypeError in cataloging.js: ?$(...).select2 is not a function? Expected Results: Field will repeat (copy is created) Additional Information: Error happens in version 16.11+ after adding Select2 js functions. The easiest way to fix is to add Select2 to authority editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 09:49:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 07:49:33 +0000 Subject: [Koha-bugs] [Bug 18422] Add Select2 to authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18422 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |synapse.ova at gmail.com --- Comment #1 from Oleg Vasilenko --- Created attachment 62070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62070&action=edit Bug 18422 - Add Select2 to authority editor This patch add Select2 to authority editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 09:52:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 07:52:06 +0000 Subject: [Koha-bugs] [Bug 18422] Add Select2 to authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18422 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Depends on| |13501 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 [Bug 13501] Allow autocompletion on drop-down lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 09:52:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 07:52:06 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18422 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18422 [Bug 18422] Add Select2 to authority editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 10:14:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 08:14:43 +0000 Subject: [Koha-bugs] [Bug 18420] Some tests fail without patron category 'S' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|t/dbdependent/Budgets.t |Some tests fail without |fails without patron |patron category 'S' |category 'S' | --- Comment #1 from Marc V?ron --- To reproduce make sure you have no category type 'S' defined but for example 'ST' instead. Failing: t/db_dependent/Budgets.t *) line 583 t/db_dependent/Passwordrecovery.t *) line 55 t/db_dependent/Members.t *) line 53 *) Test scipts with line"my $categorycode = 'S'; Passing: t/db_dependent/Suggestions.t lines 70 and following create a category 'S' if it does not exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 10:26:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 08:26:02 +0000 Subject: [Koha-bugs] [Bug 14590] Validate messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62044|0 |1 is obsolete| | --- Comment #18 from Lari Taskula --- Created attachment 62071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62071&action=edit Bug 14590: Validate messaging preferences Messaging preferences should be only available if a valid contact information is stored for the patron for that transport type. Otherwise, it should not be possible to select preferences for that transport type. For example, when attempting to set messages to be delivered via sms, we should automatically check patron's smsalertnumber before allowing this type of modification. If patron does not have a valid smsalertnumber and is not passing it along with the messaging preference change, we should not store those given messaging transport types. This patch implements exactly this. It uses Koha::Validation from Bug 14620 to validate contact informations and attaches it into patron modification logic - whenever messaging preferences are processed by Koha, preferences that link to an invalid or non-existent contact information will be removed. Client-side JavaScript checks are also implemented. When modifying patron information, messaging preferences for a certain transport type will be either enabled and/or disabled on the fly depending on validity of the contact info linked to that transport type (transport type "sms" => borrower "smsalertnumber"). TESTING: This feature requires tests both in OPAC and staff client. Requirements: 1. Apply patch(es) in Bug 14620 before this patch 2. Make sure EnhancedMessagingPreferences is enabled 3. Make sure EnhancedMessagingPreferencesOPAC is enabled 4. Make sure TalkingTechItivaPhoneNotification is enabled (activates transport type "phone") 5. Make sure SMSSendDriver is enabled (for simple testing purposes you can use the value "test") 6. Preference "ValidatePhoneNumber" needs a regular expression for validating phone numbers. An example regular expression is provided below the input field. You can use that while testing this feature. Copy-paste it into the input box and save preferences. (regex also provided below) ^((\+)?[1-9]{1,2})?([-\s\.])?((\(\d{1,4}\))|\d{1,4})(([-\s\.])?[0-9]{1,12}){1,2}$ TEST PLAN: 1. Login to staff client 2. Go to modification view of any patron 3. Scroll down all the way and you should see "Patron messaging preferences" table including checkboxes for transport types "SMS", "Phone" and "Email". 4. If the patron you are modifying has any contact information of the following "Primary email", "Primary phone", "SMS number", please clear those fields. 5. Scroll down. All checkboxes for the given transport types should now be disabled. 6. Modify field "Primary email" and insert "test". A warning of invalid email should appear. 7. Scroll down. Checkboxes for transport type "Email" should still be disabled. 8. Modify field "Primary email" and insert "nobody at example.com". 9. Scroll down. Checkboxes for transport type "Email" should now be enabled. 10. Select email as transport type for each message type and click "Save". 11. Go back to modification screen. The messaging preferences should still appear as you stored them. 12. Repeat steps 6-11 also for both "Phone" and "SMS number". When inserting text into phone number fields, they should appear as invalid, so test like that. 13. After successful testing, test also other patron modification screens. Go to patron's Details tab and you should see multiple "Edit" links on that page. The point is to make sure transport type selections are correctly removed from the patron if the modification screen lets you modify for example primary email, but does not present the messaging preferences at the bottom of the page. So, as an example, first insert patron a valid email and select all email transport types. Then, go to the "Edit" link right above "Patron messaging preferences" title on patron's details page. This page lets you modify "Primary email" but not messaging preferences. Clear the "Primary email" field and save, and observe that all previously selected email transport types are now removed. 14. Give your patron a valid email and go to Details tab -> "Edit" link below "Patron messaging preferences title" on the left. You should still be able to select email as transport types. 15. Go remove patron's primary email and repeat step 14. You will observe that it is no longer possible to select email as a transport type. 16. Try steps 13-15 with other transport types as well After this test plan you should have a pretty good idea of the feature. As mentioned earlier, this feature requires tests on the OPAC side as well. So attempt this also via OPAC and make sure preferences are validated when the librarian approves patron's modifications. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 10:52:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 08:52:25 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61739|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize --- Created attachment 62072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62072&action=edit Bug 15705: Reset the last error when an auto renew successes The auto_renew_error has to be reset when an auto renew successes, otherwise the patron is not going to receive the correct notice. Test plan; - Checkin an item and mark it as auto renewal (specify a due date in the past to allow auto renewals) - Set OPACFineNoRenewalsBlockAutoRenew to 'Block' and 'OPACFineNoRenewals' to '1' - Execute the script => Auto renewed, column auto_renew_error is null - Add a fine of '2' to the patron - Execute the script => Not auto renewed, column auto_renew_error is 'auto_too_much_oweing' => On the interface youo see the correct message "Automatic renewal failed, patron has unpaid fines" - Pay the fine - Execute the script Without this patch the auto_renew_error is not reset and the patron is going to receive a letter telling him he own too much money to the library With this patch the patron will receive a letter to inform him the renew has been done! Signed-off-by: Jonathan Field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 10:52:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 08:52:42 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 10:52:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 08:52:59 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #58 from Martin Renvoize --- Signed off on final patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:47:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 09:47:41 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #88 from Zeno Tajoli --- Hi Katrin, in fact to answer your question you need to read also the code. I do some answers: >Is there documentation about this new feature available somewhere? The documentation is inside C4/Auth_with_shibboleth.pm in POD format. To see it: perldoc C4/Auth_with_shibboleth.pm >Is it possible to choose if you want to add a new user and update existing users like it is with LDAP? No. The system only adds a new user, it does not update an existing user. And it adds a new user only when, inside login process, it finds that there isn't an existing user with userid = the shibboleth attribure defined with this XML in koha-conf.xml: userid >Do the attributes have to match exactly to what Koha expects (branchcode, categorycode specifically) or is there a way to do a mapping? You can mapping using koha-conf.xml. This is an example: userid The ... and the connected attribute are clearly mandatory. Also attributes for categorycode and branchcode are mandatory, I think. Ohters are optional. Bye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:47:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 09:47:58 +0000 Subject: [Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62058|0 |1 is obsolete| | CC| |colin.campbell at ptfs-europe. | |com --- Comment #5 from Colin Campbell --- Created attachment 62073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62073&action=edit signed off patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:53:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 09:53:54 +0000 Subject: [Koha-bugs] [Bug 17279] Edifact:: Line quantity should ensure its returning invoiced quantity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17279 --- Comment #3 from Colin Campbell --- (In reply to Owen Leonard from comment #2) > How should this be tested? The unit tests check that the two fields are now being returned separately as expected. Previously they were not distinguished. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:56:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 09:56:36 +0000 Subject: [Koha-bugs] [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 --- Comment #6 from Katrin Fischer --- Is this only for 16.11? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:15:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 10:15:07 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Daphne Hoolahan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch at interleaf.ie --- Comment #22 from Daphne Hoolahan --- It all went pretty good and worked fine. We just found a couple of things that are worth pointing out: 6.1.1 ? Why is the biblio number empty on this screen? Actually one of them has the value zero now that we went through the whole process. 6.1.2 ? we noticed that we could request the same title more than once. Maybe not an issue but worth mentioning. 6.1.9 ? we received the email fine but it does not say who it is from, ther than it has the from email address. Should it have the from organisation above the status or is the staff member expected to customise the email text to indicate their organisation? Dear Sir/Madam, We would like to request an interlibrary loan for a title matching the following description: - Status: New - Author: A.N. Other - ID: 5678 - Title: Interlibrary loans in Koha Please let us know if you are able to supply this to us. Kind Regards 6.2 ? We found it difficult to find any matching titles. What is keywords for? (especially as title has a separate entry field) image attached Also we got an error when we tried this search ? didn?t seem to like the book filter: Error performing operation image attached When trying to confirm a request from the BL Software error: The API responded with an error: 500 Internal Server Error Detail: 2017-03-28 13:15:56.941 BST8Authentication failed: Exception occurred processing authentication, please contact BL Customer Services at /usr/share/koha-interleaf/Koha/Illbackends/BLDSS/Base.pm line 481. For help, please send mail to the webmaster (alex.sassmannshausen at ptfs-europe.com), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:19:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 10:19:56 +0000 Subject: [Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61758|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 62074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62074&action=edit Bug 18364: Do not LOCK/UNLOCK tables from tests >From the MySQL doc: "LOCK TABLES is not transaction-safe and implicitly commits any active transaction before attempting to lock the tables." If the LOCK/UNLOCK statements are executed from tests, the current transaction will be committed. To avoid that we need to guess if this code is execute from testsa or not (yes it is a bit hacky) Better ideas are welcome! Another fix would have been to revert commit be156d9ad9e5bcfadab34d44f90e04fd61e256ad Bug 15854: Use a READ and WRITE LOCK on message_queue but theorically a race is still possible. Existing tests seem to be safe, to test this patch you will need new tests from bug 17964. Test plan: prove t/db_dependent/Letters/TemplateToolkit.t twice, and notice that changes have been comitted. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:19:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 10:19:54 +0000 Subject: [Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:37:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 10:37:55 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62054|0 |1 is obsolete| | --- Comment #37 from Baptiste --- Created attachment 62075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62075&action=edit Bug 17047: Add report, factorize code, add a comment feature Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redisigned to improve the user experience - New Feature : report a record. - peoples can now report a weird report - if a record is reported a lot of time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - Added the syspref "AutoShareWithMana", which enables to select which fields you want to share automatically with mana API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) - Factorize a lot of code in order to improve the speed of next developments SytemPreferences: Mana Activation: - add a field "no, let me think" at the syspref "Mana" - as long as this field is selected, messages ask if user want to activate it messages in pages: - Administration - Add-subscription(page 2) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with mana (automatically not set) Report Share - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana - New feature: search report in Mana Knowledge Base with keywords - New feature: load reports from Mana Comment Resources - The comments can now be manually added - On a resource mana datatable, you can now see comments, add comment and vote for comments you think pertinent - Comments are NOT dynamically generated on the table you need to reload the page when you vote Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => mana shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other". - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:58:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 10:58:15 +0000 Subject: [Koha-bugs] [Bug 18321] One more checkouts possible than allowed by rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:58:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 10:58:18 +0000 Subject: [Koha-bugs] [Bug 18321] One more checkouts possible than allowed by rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61770|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 62076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62076&action=edit Bug 18321: Add tests Clean a bit existing tests by adding default values and add a test to highlight the issue. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:58:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 10:58:24 +0000 Subject: [Koha-bugs] [Bug 18321] One more checkouts possible than allowed by rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61771|0 |1 is obsolete| | --- Comment #20 from Nick Clemens --- Created attachment 62077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62077&action=edit Bug 18321: Correctly calculate switch_onsite_checkout Silly error here, the $switch_onsite_checkout is not correctly calculated, it should not only be set to the value of the syspref, but meet all the conditions. Test plan: Set a circ rule with number of on-site checkout = 2 and number of checkouts = 2. Switch on both ConsiderOnSiteCheckoutsAsNormalCheckouts and SwitchOnSiteCheckouts Do a regular checkout Do another regular checkout At this point you have reach the maximum number of checkouts allowed. Not try another one. => Without this patch you will not get the warning => With this patch you will see it Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:04:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 11:04:49 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #53 from Alex Sassmannshausen --- Hi Owen, I've been trying to reproduce this, but cannot. (In reply to Owen Leonard from comment #52) > Everything was working up until just after adding a list of barcodes to a > rota. When I try to go back to 'manage items' I get an error: > > Proxy Error > > The proxy server received an invalid response from an upstream server. > The proxy server could not handle the request GET > /cgi-bin/koha/tools/stockrotation.pl. Is this a persistent error? When you say you try to go back to 'manage items' does this mean you succesfully get to the rotas overview screen, but when you click on 'manage' for the rota you just added the items to, and then 'items', that's when the error appears? There should be no proxying going on here? What testing environment are you using? Is it a devbox? If so, is it with Plack switched on? Would you be able to retest this particular operation with Plack switched off? Thanks for testing so far! Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:15:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 11:15:49 +0000 Subject: [Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364 --- Comment #8 from Marcel de Rooy --- $ENV{_} =~ m|prove|; I'd still rather see a specific environment variable. As mentioned on irc earlier, we could set some kind of lock variable in the environment via a shared apache file or cron file. A test would not see that var and not lock the table. Another option (with some more impact on the code) would be to switch from table locking to some kind of intelligent file locking here. (We use file locking in rebuild zebra, but it should be more refined.) Advantage would be that we do not differentiate between calls from a unit test and from other scripts. And the current test does not include running a separate test file from the command line without prove (which I normally do). Could we test on a .t suffix too? In conclusion, I would not favor pushing this in its current from. Other opinions are welcome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:17:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 11:17:57 +0000 Subject: [Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 --- Comment #7 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #6) > Signed-off-by: Marc V?ron > Signed-off-by: Jonathan Druart Thanks, Marc and Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:18:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 11:18:26 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:18:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 11:18:30 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61877|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 62078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62078&action=edit Bug 17853 - Don't remove () from link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Felix Hemme Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:18:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 11:18:36 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #9 from Nick Clemens --- Created attachment 62079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62079&action=edit Bug 17853 - Don't remove () from field 785 link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:19:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 11:19:12 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #10 from Nick Clemens --- Fixed commit messages - added new patch for 785 field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:23:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 11:23:07 +0000 Subject: [Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364 --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #6) > The correct way to use LOCK TABLES and UNLOCK TABLES with transactional > tables, such as InnoDB tables, is to begin a transaction with SET autocommit > = 0 (not START TRANSACTION) followed by LOCK TABLES, and to not call UNLOCK > TABLES until you commit the transaction explicitly. Did you consider record locking instead of table locks here? Not sure if it would resolve the problem.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:39:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 11:39:03 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #89 from Martin Renvoize --- You're totally right Katrin, I should expand the documentation a bit here. This patch was only ever intended to 'add new' user record (i.e to 'provision') and not to 'sync'. To be honest, I'd love to also submit a 'sync' patch and include an option to only sync certain fields but I'd likely need a bit of sponsorship to get that through. I'm happy to code it up, but it's a nightmare to get these patches through signoff and qa ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:45:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 11:45:21 +0000 Subject: [Koha-bugs] [Bug 18420] Some tests fail without patron category 'S' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- We should use TestBuilder here to create the categories we need. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:47:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 11:47:55 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #108 from Marcel de Rooy --- Back to SO queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:24:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 12:24:43 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #54 from Owen Leonard --- Testing again I can't reproduce the error. I will continue to look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:34:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 12:34:45 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 --- Comment #22 from Marc V?ron --- Typo in 3rd patch, circ/returns.pl , line 314: my $date_due_dt = dt_strom_string( $issue->date_due, 'sql' ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:51:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 12:51:40 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #12 from Marc V?ron --- Merge conflicts in 1st patch: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt course_reserves/add_items.pl Maybe a merge conflict in 3rd patch as well (other patches applied when i skipped 1st and 3rd patch) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:02:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:02:47 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #47 from Marc V?ron --- WAnted to test, but does not apply: Bug 11999: Check for age restriction in CanBookBeReserved fatal: sha1 information is lacking or useless (C4/Reserves.pm). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:09:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:09:57 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:09:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:09:59 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42669|0 |1 is obsolete| | Attachment #44413|0 |1 is obsolete| | --- Comment #22 from Lari Taskula --- Created attachment 62080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62080&action=edit Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:10:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:10:38 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7174, 14698 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 [Bug 7174] Authentication rewriting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:10:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:10:38 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14723 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 [Bug 14723] Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:10:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:10:38 +0000 Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14723 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 [Bug 14723] Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:11:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:11:43 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #23 from Lari Taskula --- (In reply to Fr?d?ric Demians from comment #21) > Get this: > > fatal: sha1 information is lacking or useless (C4/Letters.pm). > error: could not build fake ancestor I removed some dependencies and rebased this on master. Should now apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:23:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:23:58 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #14 from Jonathan Druart --- Created attachment 62082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62082&action=edit Bug 18276: Remove GetBiblioFromItemNumber - ILSDI Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=51&show_holds=1 The results should be the same before and after this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:23:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:23:54 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61177|0 |1 is obsolete| | Attachment #61178|0 |1 is obsolete| | Attachment #61179|0 |1 is obsolete| | Attachment #61180|0 |1 is obsolete| | Attachment #61181|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 62081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62081&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Values from the items, biblio and biblioitems tables are used in the template, so we need to pass all of them to the template, but separately. That way we easily see which field from which table we are displaying. Test plan: Create a course reserve and add items. Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:24:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:24:03 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #15 from Jonathan Druart --- Created attachment 62083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62083&action=edit Bug 18276: Remove GetBiblioFromItemNumber - circulation pages Test plan: 1. Checkout items in a batch The information displayed should be ok (title, subtitles, author, itemnotes, barcode) 2. Checkout an item using the standard checkout page You should correctly see the information of the item that has been checked out (title and author) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:24:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:24:08 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #16 from Jonathan Druart --- Created attachment 62084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62084&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Easy ones The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:24:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:24:12 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #17 from Jonathan Druart --- Created attachment 62085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62085&action=edit Bug 18276: Remove the C4::Biblio::GetBiblioFromItemNumber subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:26:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:26:52 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62034|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 62086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62086&action=edit Bug 17680: C4::Circulation - Remove GetItemIssue, complex calls There are a few calls to GetItemIssue where it's not as easy to make sure everything will be fine just replacing the calls with a Koha::Issues->find - In AddReturn the overdue flag is used (that's why this patch depends on bug 17689) - In CanBookBeRenewed, as well as the overdue flag the dates converted to DateTime were used. It's now our job to convert them when we need them. - Same in AddRenewal but we also call _CalculateAndUpdateFine, so we need to update the variables in this subroutine. Note that, prior to this patch, AddReturn returned the GetItemIssue hashref in the $iteminformation. Most of the time this variable is not used, I have found only 1 place where it's used: circ/returns.pl TODO: In this script we should call ->is_overdue instead of the DateTime->compare calls Test plan: All the circulation tests must pass (it's how I have caught the specific cases). Do some checkins/checkouts/renewal and focus on the due date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:27:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:27:01 +0000 Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131 --- Comment #7 from Nick Clemens --- testing again, this does remove the fields error from authorities, but things are not fixed on authority side: Matching rules can only use a small set of indexes in build_authorities_query_compat: Options are: mainmainentry, mainentry, match, match-heading, see-from, and thesaurus. Tag in Matchpoint components seems to be useless? Sorting is also broken and I had to force no sorting to get match results, and then they didn't match anything Options are: mainmainentry, mainentry, match, match-heading, see-from, and 373 thesaurus. As Joubu said in comment #3 this is all outside the scope of this bug report. Signing off on patches as they offer great improvement and fix matching for biblios - authorities issues should be filed as a new ticket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:28:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:28:17 +0000 Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60716|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 62087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62087&action=edit Bug 18131: ES - Fix matching staged records The code in C4::Matches::get_matches is terrible and a bug has been introduced by bug 12478 because of its way to handle uniqueness. If search engine is elastic, simple_search_compat returns array ref of MARC::Record, used as a string for the key of the matches hashref we get things like "MARC::Record=HASH(0x8f76ab0)". Yes, terrible... The file is never staged and we get an internal server error: stage-marc-import.pl: Can't locate object method "fields" via package "MARC::Record=HASH(0x8f76ab0)" (perhaps you forgot to load "MARC::Record=HASH(0x8f76ab0)"?) at /home/vagrant/kohaclone/C4/Biblio.pm line 2691 To recreate the issue: - Set SearchEngine == Elastic - Create a matching rule on 999$c (you need to edit the existing one and specify 'Local-number' as search index, not 'local-number') - Import a file with bibliographic records and use the matching rule you defined. Test plan: Import authority and bibliographic records with Zebra and Elastic using a matching rule. Everything should work correctly. Note: I found a bug when importing authorities using Elastic, see bug 17255 comment 38. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:28:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:28:22 +0000 Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61586|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 62088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62088&action=edit Bug 18131: ES - Fix matching staged records - Authority Occurrences of C4::AuthoritiesMarc::SearchAuthorities must be replaced by search_auth_compat. You need to define the search index of matching rule with one of the values defined in %koha_to_index_name (from Koha::SearchEngine::Elasticsearch::QueryBuilder::build_authorities_query_compat) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:33:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:33:51 +0000 Subject: [Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364 --- Comment #10 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #9) > (In reply to Jonathan Druart from comment #6) > > > The correct way to use LOCK TABLES and UNLOCK TABLES with transactional > > tables, such as InnoDB tables, is to begin a transaction with SET autocommit > > = 0 (not START TRANSACTION) followed by LOCK TABLES, and to not call UNLOCK > > TABLES until you commit the transaction explicitly. > > Did you consider record locking instead of table locks here? Not sure if it > would resolve the problem.. Do you mean 'SELECT FOR UPDATE'? I tried it yes, see commit message for bug 15854. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:38:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:38:34 +0000 Subject: [Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61933|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 62089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62089&action=edit Bug 18388 - Standardize serials volume information displaying OPAC: Home > Details for (serial) Compared information in tab 'Holdings' col 'Vol info' with same information in staff client. With patch it's the same. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:39:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:39:17 +0000 Subject: [Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Passed QA --- Comment #5 from Nick Clemens --- I like it and like that is in a span with clas so can be hidden for those who don't :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:57:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 13:57:01 +0000 Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty subfield tag [follow-up ] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Version|master |3.22 CC| |julian.maurice at biblibre.com Status|RESOLVED |REOPENED --- Comment #9 from Julian Maurice --- Reopened as it is still a bug on 3.22.19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:04:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:04:24 +0000 Subject: [Koha-bugs] [Bug 18420] Some tests fail without patron category 'S' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:04:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:04:28 +0000 Subject: [Koha-bugs] [Bug 18420] Some tests fail without patron category 'S' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #3 from Jonathan Druart --- Created attachment 62090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62090&action=edit Bug 18420: Fix Budgets.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Budgets.t should return green, even if no categories.categorycode 'S' exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:08:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:08:09 +0000 Subject: [Koha-bugs] [Bug 18420] Some tests fail without patron category 'S' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #4 from Jonathan Druart --- Created attachment 62091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62091&action=edit Bug 18420: Fix Passwordrecovery.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Passwordrecovery.t should return green, even if no categories.categorycode 'S' exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:12:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:12:22 +0000 Subject: [Koha-bugs] [Bug 18420] Some tests fail without patron category 'S' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #5 from Jonathan Druart --- Created attachment 62092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62092&action=edit Bug 18420: Fix Members.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Members.t should return green, even if no categories.categorycode 'S' exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:15:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:15:28 +0000 Subject: [Koha-bugs] [Bug 18420] Some tests fail without patron category 'S' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #6 from Jonathan Druart --- Created attachment 62093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62093&action=edit Bug 18420: Use TestBuilder to create a patron category in Suggestions.t No need to do it that way, let's use TestBuilder. Test plan: prove t/db_dependent/Suggestions.t should still return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:15:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:15:45 +0000 Subject: [Koha-bugs] [Bug 18420] Some tests fail without patron category 'S' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|chris at bigballofwax.co.nz |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:16:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:16:24 +0000 Subject: [Koha-bugs] [Bug 18420] Some tests fail without patron category 'S' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from Jonathan Druart --- There are much more left. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:26:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:26:55 +0000 Subject: [Koha-bugs] [Bug 18423] New: Add child button not always appearing - problem in template variable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18423 Bug ID: 18423 Summary: Add child button not always appearing - problem in template variable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We are seeing on some sites that the 'Add child' button is not appearing on moremember.pl In these cases it seems the line: activeBorrowerRelationship => (C4::Context->preference('borrowerRelationship') ne ''), Fails to pass through the correct value -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:27:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:27:07 +0000 Subject: [Koha-bugs] [Bug 18423] Add child button not always appearing - problem in template variable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18423 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:27:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:27:54 +0000 Subject: [Koha-bugs] [Bug 18424] New: Implement different password strength settings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18424 Bug ID: 18424 Summary: Implement different password strength settings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Implement different password strenght settings as a followup to Bug 18298 - Enforce password complexity See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298#c26 Maybe we could just have different strength settings? Instead of "RequireStrongPassword" we could name this PasswordStrength and then have the current and alphanumeric+digits as first two options. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:28:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:28:20 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18424 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18424 [Bug 18424] Implement different password strength settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:28:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:28:20 +0000 Subject: [Koha-bugs] [Bug 18424] Implement different password strength settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18424 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18298 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 [Bug 18298] Enforce password complexity -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:28:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:28:51 +0000 Subject: [Koha-bugs] [Bug 16282] Usernames should be case sensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16282 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #11 from Marc V?ron --- (In reply to M. Tompsett from comment #10) > (In reply to Owen Leonard from comment #9) > > (In reply to M. Tompsett from comment #8) > > > > > WHERE BINARY? This is a MySQL-ism, is it not? > > > > Is it? Anyone able to point to documentation? > > https://dev.mysql.com/doc/refman/5.7/en/cast-functions.html > I can't find such a casting name for postgres sqlite or other SQLs. Though, > I could be wrong. Which is why I was asking for confirmation. WHERE BINARY does not exist e.g. for Oracle: http://stackoverflow.com/questions/14819724/where-binary-in-oracle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:29:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:29:39 +0000 Subject: [Koha-bugs] [Bug 18423] Add child button not always appearing - problem in template variable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18423 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:29:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:29:41 +0000 Subject: [Koha-bugs] [Bug 18423] Add child button not always appearing - problem in template variable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18423 --- Comment #1 from Nick Clemens --- Created attachment 62094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62094&action=edit Bug 18423 - Add child button not always appearing - problem in template variable This patch removes the retrieval of the syspref borrowerRelationship from the scripts and moves it to a check using the Template Toolkit plugin To test: 1 - Apply patch 2 - Ensure 'Add child' button displays appropriately on all member pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:30:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:30:01 +0000 Subject: [Koha-bugs] [Bug 18424] Implement different password strength settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18424 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16282 --- Comment #1 from Marc V?ron --- Case sensitivity could be an issue, see Bug 16282 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:30:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:30:01 +0000 Subject: [Koha-bugs] [Bug 16282] Usernames should be case sensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16282 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18424 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:50:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:50:30 +0000 Subject: [Koha-bugs] [Bug 16282] Usernames should be case sensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16282 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Owen Leonard --- > WHERE BINARY does not exist e.g. for Oracle: > http://stackoverflow.com/questions/14819724/where-binary-in-oracle So this should be Failed QA? Please correct the status if not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:50:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:50:43 +0000 Subject: [Koha-bugs] [Bug 18420] Some tests fail without patron category 'S' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #8 from Jonathan Druart --- Created attachment 62095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62095&action=edit Bug 18420: Do not use 'S' as patron category code in other tests Test plan: prove all these tests, they must all pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:50:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:50:57 +0000 Subject: [Koha-bugs] [Bug 18420] Some tests fail without patron category 'S' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:53:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:53:10 +0000 Subject: [Koha-bugs] [Bug 16282] Usernames should be case sensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16282 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17829 --- Comment #13 from Jonathan Druart --- Note that I am going to remove GetMember on bug 17829. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:53:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 14:53:10 +0000 Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16282 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:00:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 15:00:52 +0000 Subject: [Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #9 from Marcel de Rooy --- Created attachment 62096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62096&action=edit Bug 14399: Prevent display of double zero notforloan status On bug 12913 a zero status is added on the inventory form. This prevents a lot of false warnings for a wrong notforloan status. The zero status is not included in the default setup. But if you would add one, the status will display here twice now. This patch checks if the status already exists. Test plan: [1] Add a zero NOTFORLOAN status if it does not yet exist in Authorized values. [2] Check that you do not see two "For loan" statuses on inventory form. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:01:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 15:01:01 +0000 Subject: [Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #11 from Marcel de Rooy --- Created attachment 62098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62098&action=edit Bug 14399: Interface changes A part of the confusion around the inventory script may arise from the fact that the form offers several options that are only used under certain conditions. This patch hopefully rearranges a few options more logically and only offers options when appropriate. The barcode fieldset now also contains Compare barcodes and Do not check in checkboxes. These are meaningful when a barcode file is uploaded. The fieldset Item location filters (new name) contains fields that are always used. Same for tne only control left under Additional options, Export to CSV. The fieldset Optional filters depends on the status of the barcode file and the Compare checkbox. It is now shown or hidden depending on what you select: if you do not upload a file, it is shown; or if you upload a file and check Compare, it is shown. Otherwise we hide it, since the script will not look at these values. Under this fieldset last inventory date and Skip items on loan are added, since their behavior is the same as the various item statuses. Test plan: In this test plan we test both the script changes from the previous patch and the interface changes here. We follow the three main scenario's as mentioned in the previous patch. [1] First we prepare a few test items. Pick two biblios A, B and create five items say A1,A2,B1,B2,B3. Pick a not-existing callnumber range you want to test and move these five items there. Add barcodes too (say A1..B3). Edit one item A1 to a not-existing notforloan status (doing this on the mysql command line is fastest). Like: update items set notforloan = '9' where barcode='A1'; Scenario 1 (no barcodes uploaded) [2] Enter the callnumber range on inventory form. Verify that "Set inventory date", Compare barcodes and "Do not check in" are disabled on the form. Check that you see the Optional filters box. Submit the form. Verify that you see all five items. Do the same. Check Export to CSV. Check result file contents. Scenario 2 (upload barcodes, do not compare) [3] Create a barcode file with the barcodes of A1, A2 and B1. Add another existing barcode outside the test callnumber range. After uploading this file, verify that "Set inventory date", Compare and "Do not check in" are enabled. The Optional filters should be hidden. Leave "Set inventory date" to today. Enter the callnumber range again. Submit the form. What do we expect? Four items should have been updated (alert). We should see barcode A1 with problem Unknown status. We should see also the barcode from the other range (Found in wrong place). Repeat this step with the same file. But now export to CSV. Verify that you see two barcodes with problems again in the csv file. Scenario 3 (upload barcodes, compare) [4] Create another barcode file with barcodes of B2 and one existing barcode outside the test callnumber range. After uploading this file, check the Compare checkbox. Verify now that the Optional filters box is displayed again. Leave "Set inventory date" to today. Enter the callnumber range again. Also set "Last inventory date" to today (important!). Submit the form. What do we expect now? Two items should be updated (see alert). We should see barcode B3 with problem Missing. We should also see the barcode from the other range (wrong place). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:00:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 15:00:57 +0000 Subject: [Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #10 from Marcel de Rooy --- Created attachment 62097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62097&action=edit Bug 14399: Numerous small refinements to the inventory script This patch contains the following changes: [01] Label "Inventory date" reworded to "Last inventory date", adding a small explanation for its purpose. [02] Restructured the results: it was an array with items and possible error messages. Multiple messages duplicated individual items. Now the results are in a hash, pulling all error messages for one item together. At the end of the script they are copied to an array. (A helper sub additemtoresults is added in this regard.) We no longer use array @items_with_problems. [03] Both datepickers are no longer connected to the same class. This prevents changing the set date by filling the last inventory date. [04] Input markseen in the template and $markseen in the script are no longer needed. [05] The paragraph before the detail link in the results table in the Title column has been removed. Same for problems column. This makes vertical spacing consistent. [06] Problem status 'missingitem' is no longer used; the missing items are marked as 'not_scanned'. Two additional statuses are: no_barcode and checkedout. [07] Removed unused $itemtype, $totalrecords and $count. We use variable $moddatecount to report a count to the template. [08] The script updated scanned items twice. The first time with ModItem and the second time with ModDateLastSeen. The second call is removed. [09] If a book is checked in, we do no longer return an error message when the checkin is successful (ERR_ONLOAN_RET). The updated datelastseen is passed to the results. [10] $wrongplacelist is renamed to $rightplacelist. It is only built when we need it. (Same for inventorylist now.) [11] Datelastseen (last inventory date) is always used for building the inventory list. It allows you to process partial barcode lists or make a list of items not seen after some date. We do no longer use variable $paramdatelastseen. [12] The section where items.datelastseen was compared with the inventory date has been removed. Scanned items were already updated; to get items seen before some date, you can now use last inventory date without passing barcodes. The form can mainly be used for the following three cases: [1] Prepare an inventory list or csv file; we do not upload barcodes. [2] Update items for uploaded barcodes without comparing to inventory. Last inventory date is useless in this case. Errors wrongplace, checkedout and changestatus are reported. Use this scenario for partial scanned barcode lists (all but last). [3] Update items for uploaded barcodes and compare to inventory, filtered by an optional last inventory date. Apart from the errors mentioned under [2], this also reports not_scanned ("missing") and no_barcode. Use this scenario too for the last partial barcode file (together with inventory date). Test plan: See next patch ("Interface changes"). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:01:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 15:01:06 +0000 Subject: [Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 --- Comment #12 from Marcel de Rooy --- Created attachment 62099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62099&action=edit Bug 14399: Results form also needs a few interface changes Currently, the value of compareinv2barcd is used to determine if the Seen column, the Select/Clear all buttons and the Mark seen buttons are displayed. But if we scanned barcodes, we already marked items as seen. So we should only display these buttons when we did not upload barcodes. Test plan: [1] Upload a barcode file. Check that the result form does not show the buttons. [2] Generate an inventory list, so do not upload a barcode file. Verify that you still see the buttons. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:25:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 15:25:59 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Summary|"missingitem" code from |Fix inventory.pl part two |inventory.pl doesn't work |(following 12913) |properly | --- Comment #13 from Marcel de Rooy --- This is not a complete refactoring. I tried to resolve a lot of smaller issues within the current code. Rearranged the interface a bit too. The test plan of the third patch is the crux. It may look impressive, but you should be able to finish it in say 10-15 minutes (or faster). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:26:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 15:26:10 +0000 Subject: [Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:28:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2017 15:28:11 +0000 Subject: [Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #176 from Jonathan Druart --- - On installer/step3.tt: I'd remove the