[Koha-bugs] [Bug 12930] Web installer does not show login errors

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Apr 2 02:54:42 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
The patch I have attached displays an error message if the user writes in an
invalid username and/or password. 

The InstallAuth.pm module does not contain subroutines to check for
permissions, session timeout, or if the ip address is different even though the
markup checking for these in the auth.tt has been implemented. 

Regarding the nopermission check, as I understand it the only password that is
valid to be written into this installer login is the database admin credentials
and so I don't see why we need the nopermission check in the markup (as is
required for the staff interface login).


Test plan:
1. Restart memcached: sudo service memcached restart

2. Drop and recreate the database

3. Login with these pretend credentials: 
username: fred 
password: password

4. Notice the page refreshes and you get no "invalid username or password"
error displayed

5. Apply the patch attached to this bug

6. Try logging in with the same username and password specified in step 3

7. Notice the page refreshes and a "invalid username or password' error message
is displayed 

8. Now login with the Koha database administrator account and notice you are
logged in successfully

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list