[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Apr 4 15:38:22 CEST 2017
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361
--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #4)
> Comment on attachment 61754 [details] [review]
> Bug 18361: Koha::Objects->find should accept composite primary keys
>
> > sub find {
> >- my ( $self, $id ) = @_;
> >+ my ( $self, @id ) = @_;
>
> While I agree with the general idea, I'd prefer that we keep in mind that
> this is a passthrough to DBIC ->find method. In that sense, please look at
> ResultSet.pm:
>
> sub find {
> my $self = shift;
> my $attrs = (@_ > 1 && ref $_[$#_] eq 'HASH' ? pop(@_) : {});
>
> IMHO we should implement exactly that, probably accept whatever is passed to
> K:O->find and just pass it to RS->find.
my $result = $self->_resultset()->find(@id);
So we pass them to RS. What is exactly your point ?
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list