[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Apr 5 22:10:11 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz <ablewicz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61899|0                           |1
        is obsolete|                            |

--- Comment #94 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 61920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61920&action=edit
Bug 9988: Check the merge limit in sub merge

At this point, we are replacing dontmerge functionality by the new
AuthorityMergeLimit logic. Instead of doing this check before calling
merge, we just call merge and check it there. In order to let the cron
job do the larger (postponed) merges, we add a parameter override_limit.

A subtest is added in Merge.t to test the 'postponed merge' feature. Since
merge now also calls get_usage_count, an additional mock is added. All
references to dontmerge are removed.

In merge two lines, initializing $dbh and $counteditbiblios, are moved.
The dontmerge test in DelAuthority and ModAuthority is removed. Since this
did not leave much in ModAuthority, I fixed the whitespace on the remaining
lines rightaway (yes, I know).
A minimal set of changes is applied to the cron script; it will get further
attention on a next patch.

Test plan:
[1] Run t/db_dependent/Authorities/Merge.t
[2] Set AuthorityMergeLimit to 2. Modify an authority with two linked
    biblios. Check that the merge was done immediately.
[3] Now modify an authority with more than 2 linked records.
    Verify that the merge was postponed; a record must be inserted in
    the need_merge_authorities table.
[4] Testing of the merge cron job is *postponed* to a next patch.
    Note: I tested a modification, but the script just needs more
    attention.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list